20256 2008-08-01 12:34:09 -0700 Array.push and other standard methods disappeared. 2008-10-14 09:23:30 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 david.hansen ap ap louis oldest_to_newest 87606 0 david.hansen 2008-08-01 12:34:09 -0700 Just run the attached test case: ** (jsarray:27866): DEBUG: TypeError: Result of expression 'a.push' [undefined] is not a function. Note that the eval in the context of the WebView does not produce any console messages. By changing the order of evaluation it is possible to let the error happen in the context of the WebView and the context created with the JSC API is working fine. This does affect a lot of other standard methods from at least `Array' and `String'. 87607 1 22608 david.hansen 2008-08-01 12:34:54 -0700 Created attachment 22608 Test case 87677 2 ap 2008-08-02 01:51:27 -0700 This doesn't look gtk-related, but as mentioned in bug 20107, I tried and could not reproduce this on Mac OS X, so at least part of debugging this should be done on a system where this does happen. 94857 3 louis 2008-10-09 23:39:16 -0700 Alexey, this issue doesn't look like gtk-related. I faced same problem and checked several differences between mac and gtk. And finally I turned JSC_MULTIPLE_THREADS on, and this issue was not happend. Would you turn this flag off in mac? 94862 4 louis 2008-10-10 00:13:23 -0700 I investigated more and found that if I allocated private hash tables in JSGlobalData(JavaScriptCore/kjs/JSGlobalData.cpp), this issue wouldn't happen. But I don't know why this code could affect the problem. 95282 5 ap 2008-10-14 04:18:25 -0700 Thank you for your analysis - I can now see the problem. When JSC_MULTIPLE_THREADS is not enabled, we are using static hash tables, but per-GlobalData identifier table. Since the hash tables reference identifiers, this makes no sense. 95283 6 24341 ap 2008-10-14 04:23:44 -0700 Created attachment 24341 proposed fix I don't remember why I made this conditional - probably there was no good reason. 95295 7 24341 darin 2008-10-14 09:04:02 -0700 Comment on attachment 24341 proposed fix r=me 95298 8 ap 2008-10-14 09:23:30 -0700 Fixed in <http://trac.webkit.org/changeset/37586>. 22608 2008-08-01 12:34:54 -0700 2008-08-01 12:34:54 -0700 Test case jsarray.c text/plain 1410 david.hansen I2luY2x1ZGUgPGd0ay9ndGsuaD4KI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHQu aD4KI2luY2x1ZGUgPHdlYmtpdC93ZWJraXQuaD4KCnN0YXRpYyBnY2hhciAqCmpzX3N0cmluZ190 b19jc3RyaW5nIChKU1N0cmluZ1JlZiBqc1N0cikKewogIGdzaXplICBsZW4gPSBKU1N0cmluZ0dl dE1heGltdW1VVEY4Q1N0cmluZ1NpemUgKGpzU3RyKTsKICBnY2hhciAqc3RyID0gZ19tYWxsb2Mg KGxlbik7CgogIEpTU3RyaW5nR2V0VVRGOENTdHJpbmcgKGpzU3RyLCBzdHIsIGxlbik7CgogIHJl dHVybiBzdHI7Cn0KCnN0YXRpYyBnY2hhciAqCmpzX3ZhbHVlX3RvX2NzdHJpbmcgKEpTQ29udGV4 dFJlZiBqc0N0eCwgSlNWYWx1ZVJlZiBqc1ZhbCwgSlNWYWx1ZVJlZiAqanNFeG4pCnsKICBKU1N0 cmluZ1JlZiAganNTdHIgPSBKU1ZhbHVlVG9TdHJpbmdDb3B5IChqc0N0eCwganNWYWwsIGpzRXhu KTsKICBnY2hhciAgICAgICAqc3RyOwoKICBpZiAoTlVMTCA9PSBqc1N0cikKICAgIHJldHVybiBO VUxMOwoKICBzdHIgPSBqc19zdHJpbmdfdG9fY3N0cmluZyAoanNTdHIpOwogIEpTU3RyaW5nUmVs ZWFzZSAoanNTdHIpOwoKICByZXR1cm4gc3RyOwp9CgppbnQKbWFpbiAoaW50IGFyZ2MsIGNoYXIg Kiphcmd2KQp7CiAgSlNTdHJpbmdSZWYgIGpzU3RyOwogIEpTQ29udGV4dFJlZiBqc0N0eCAgICAg ICAgPSBKU0dsb2JhbENvbnRleHRDcmVhdGUgKE5VTEwpOwogIEpTVmFsdWVSZWYgICBqc1ZhbCwg anNFeG4gPSBOVUxMOwoKICBXZWJLaXRXZWJWaWV3ICp3ZWJ2aWV3OwoKICBnY2hhciAqc3RyOwoK ICBndGtfaW5pdCAoJmFyZ2MsICZhcmd2KTsKCiAgd2VidmlldyAgPSBXRUJLSVRfV0VCX1ZJRVcg KHdlYmtpdF93ZWJfdmlld19uZXcgKCkpOwogIHdlYmtpdF93ZWJfdmlld19leGVjdXRlX3Njcmlw dCAod2VidmlldywgImEgPSBbXTsgYS5wdXNoKDQyKTsiKTsKICBndGtfd2lkZ2V0X2Rlc3Ryb3kg KEdUS19XSURHRVQgKHdlYnZpZXcpKTsKCiAganNTdHIgPSBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4 Q1N0cmluZyAoImEgPSBbXTsgYS5wdXNoKDQyKTsiKTsKICBqc1ZhbCA9IEpTRXZhbHVhdGVTY3Jp cHQgKGpzQ3R4LCBqc1N0ciwgTlVMTCwgTlVMTCwgMCwgJmpzRXhuKTsKCiAgaWYgKE5VTEwgPT0g anNWYWwpCiAgICBqc1ZhbCA9IGpzRXhuOwoKICBzdHIgPSBqc192YWx1ZV90b19jc3RyaW5nIChq c0N0eCwganNWYWwsIE5VTEwpOwogIGdfZGVidWcgKCIlcyIsIHN0cik7CgogIHJldHVybiAwOwp9 CgovKgogIExvY2FsIFZhcmlhYmxlczoKICBjb21waWxlLWNvbW1hbmQ6ICJnY2MgLWcgLWdnZGIg LU8wIC1XIC1XYWxsIFwKICAgIGBwa2ctY29uZmlnIC0tY2ZsYWdzIC0tbGlicyB3ZWJraXQtMS4w YCAgIFwKICAgIGpzYXJyYXkuYyAtbyBqc2FycmF5IgogIEVuZDoKKi8K 24341 2008-10-14 04:23:44 -0700 2008-10-14 09:04:02 -0700 proposed fix 20256r1_patch.txt text/plain 2490 ap SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM3NTg0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMTAtMTQgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDI1NgorICAgICAgICBBcnJheS5wdXNoIGFuZCBvdGhlciBzdGFuZGFyZCBtZXRob2Rz IGRpc2FwcGVhcgorCisgICAgICAgICoga2pzL0pTR2xvYmFsRGF0YS5jcHA6CisgICAgICAgIChK U0M6OkpTR2xvYmFsRGF0YTo6SlNHbG9iYWxEYXRhKToKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxE YXRhOjp+SlNHbG9iYWxEYXRhKToKKyAgICAgICAgRG9uJ3QgdXNlIHN0YXRpYyBoYXNoIHRhYmxl cyBldmVuIG9uIHBsYXRmb3JtcyB0aGF0IGRvbid0IGVuYWJsZSBKU0NfTVVMVElQTEVfVEhSRUFE UyAtCisgICAgICAgIHRoZXNlIHRhYmxlcyByZWZlcmVuY2UgSWRlbnRpZmllclRhYmxlLCB3aGlj aCBpcyBhbHdheXMgcGVyLUdsb2JhbERhdGEuCisKIDIwMDgtMTAtMTQgIE1hY2llaiBTdGFjaG93 aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBDYW1lcm9uIFp3YXJp Y2guCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMvSlNHbG9iYWxEYXRhLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvSlNHbG9iYWxEYXRhLmNwcAkocmV2aXNpb24gMzc1NzUp CisrKyBKYXZhU2NyaXB0Q29yZS9ranMvSlNHbG9iYWxEYXRhLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNjEsNyArNjEsNiBAQCBleHRlcm4gY29uc3QgSGFzaFRhYmxlIHN0cmluZ1RhYmxlOwogSlNH bG9iYWxEYXRhOjpKU0dsb2JhbERhdGEoYm9vbCBpc1NoYXJlZCkKICAgICA6IG1hY2hpbmUobmV3 IE1hY2hpbmUpCiAgICAgLCBleGNlcHRpb24oMCkKLSNpZiBFTkFCTEUoSlNDX01VTFRJUExFX1RI UkVBRFMpCiAgICAgLCBhcnJheVRhYmxlKG5ldyBIYXNoVGFibGUoSlNDOjphcnJheVRhYmxlKSkK ICAgICAsIGRhdGVUYWJsZShuZXcgSGFzaFRhYmxlKEpTQzo6ZGF0ZVRhYmxlKSkKICAgICAsIG1h dGhUYWJsZShuZXcgSGFzaFRhYmxlKEpTQzo6bWF0aFRhYmxlKSkKQEAgLTY5LDE1ICs2OCw2IEBA IEpTR2xvYmFsRGF0YTo6SlNHbG9iYWxEYXRhKGJvb2wgaXNTaGFyZWQKICAgICAsIHJlZ0V4cFRh YmxlKG5ldyBIYXNoVGFibGUoSlNDOjpyZWdFeHBUYWJsZSkpCiAgICAgLCByZWdFeHBDb25zdHJ1 Y3RvclRhYmxlKG5ldyBIYXNoVGFibGUoSlNDOjpyZWdFeHBDb25zdHJ1Y3RvclRhYmxlKSkKICAg ICAsIHN0cmluZ1RhYmxlKG5ldyBIYXNoVGFibGUoSlNDOjpzdHJpbmdUYWJsZSkpCi0jZWxzZQot ICAgICwgYXJyYXlUYWJsZSgmSlNDOjphcnJheVRhYmxlKQotICAgICwgZGF0ZVRhYmxlKCZKU0M6 OmRhdGVUYWJsZSkKLSAgICAsIG1hdGhUYWJsZSgmSlNDOjptYXRoVGFibGUpCi0gICAgLCBudW1i ZXJUYWJsZSgmSlNDOjpudW1iZXJUYWJsZSkKLSAgICAsIHJlZ0V4cFRhYmxlKCZKU0M6OnJlZ0V4 cFRhYmxlKQotICAgICwgcmVnRXhwQ29uc3RydWN0b3JUYWJsZSgmSlNDOjpyZWdFeHBDb25zdHJ1 Y3RvclRhYmxlKQotICAgICwgc3RyaW5nVGFibGUoJkpTQzo6c3RyaW5nVGFibGUpCi0jZW5kaWYK ICAgICAsIG51bGxQcm90b1N0cnVjdHVyZUlEKEpTT2JqZWN0OjpjcmVhdGVTdHJ1Y3R1cmVJRChq c051bGwoKSkpCiAgICAgLCBhY3RpdmF0aW9uU3RydWN0dXJlSUQoSlNBY3RpdmF0aW9uOjpjcmVh dGVTdHJ1Y3R1cmVJRChqc051bGwoKSkpCiAgICAgLCBzdGF0aWNTY29wZVN0cnVjdHVyZUlEKEpT U3RhdGljU2NvcGVPYmplY3Q6OmNyZWF0ZVN0cnVjdHVyZUlEKGpzTnVsbCgpKSkKQEAgLTEwOCw3 ICs5OCw2IEBAIEpTR2xvYmFsRGF0YTo6fkpTR2xvYmFsRGF0YSgpCiAgICAgbWFjaGluZSA9IDA7 CiAjZW5kaWYKIAotI2lmIEVOQUJMRShKU0NfTVVMVElQTEVfVEhSRUFEUykKICAgICBhcnJheVRh YmxlLT5kZWxldGVUYWJsZSgpOwogICAgIGRhdGVUYWJsZS0+ZGVsZXRlVGFibGUoKTsKICAgICBt YXRoVGFibGUtPmRlbGV0ZVRhYmxlKCk7CkBAIC0xMjMsNyArMTEyLDYgQEAgSlNHbG9iYWxEYXRh Ojp+SlNHbG9iYWxEYXRhKCkKICAgICBkZWxldGUgcmVnRXhwVGFibGU7CiAgICAgZGVsZXRlIHJl Z0V4cENvbnN0cnVjdG9yVGFibGU7CiAgICAgZGVsZXRlIHN0cmluZ1RhYmxlOwotI2VuZGlmCiAK ICAgICBkZWxldGUgcGFyc2VyOwogICAgIGRlbGV0ZSBsZXhlcjsK