202554 2019-10-03 17:55:49 -0700 Fix testmasm failure on ASan builds. 2019-10-03 18:27:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1576664 0 mark.lam 2019-10-03 17:55:49 -0700 Gigacage is disabled on ASan builds. So testmasm is sad. Make the relevant test bail gracefully if Gigacage should be disabled. 1576666 1 380173 mark.lam 2019-10-03 18:01:54 -0700 Created attachment 380173 proposed patch. 1576667 2 380174 mark.lam 2019-10-03 18:03:04 -0700 Created attachment 380174 proposed patch. 1576669 3 380174 ysuzuki 2019-10-03 18:06:24 -0700 Comment on attachment 380174 proposed patch. r=me 1576673 4 380174 commit-queue 2019-10-03 18:26:33 -0700 Comment on attachment 380174 proposed patch. Clearing flags on attachment: 380174 Committed r250695: <https://trac.webkit.org/changeset/250695> 1576674 5 commit-queue 2019-10-03 18:26:34 -0700 All reviewed patches have been landed. Closing bug. 1576675 6 webkit-bug-importer 2019-10-03 18:27:18 -0700 <rdar://problem/55969676> 380173 2019-10-03 18:01:54 -0700 2019-10-03 18:03:04 -0700 proposed patch. bug-202554.patch text/plain 2487 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUwNjkzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE5LTEwLTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggdGVzdG1hc20gZmFpbHVyZSBvbiBBU2FuIGJ1aWxkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjU1NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsc28gY29udmVydGVkIHNvbWUgQVNTRVJUcyBp bnRvIFJFTEVBU0VfQVNTRVJUcy4gIFRoaXMgaXMgYSB0ZXN0LiAgTm8gcmVhc29uIHRvCisgICAg ICAgIG5vdCBhc3NlcnQgYWx3YXlzLgorCisgICAgICAgICogYXNzZW1ibGVyL3Rlc3RtYXNtLmNw cDoKKyAgICAgICAgKEpTQzo6dGVzdENhZ2VQcmVzZXJ2ZXNQQUNGYWlsdXJlQml0KToKKwogMjAx OS0xMC0wMyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAg ICAgU29ja2V0IFJXSSBjbGllbnQgc2hvdWxkIGFjcXVpcmUgYmFja2VuZCBjb21tYW5kcyBmcm9t IHNlcnZlcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci90ZXN0bWFzbS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci90ZXN0bWFz bS5jcHAJKHJldmlzaW9uIDI1MDY5MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvdGVzdG1hc20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENv cHlyaWdodCAoQykgMjAxNy0yMDE4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAxNy0yMDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMTIxMCw3ICsxMjEwLDExIEBAIHZv aWQgdGVzdE1vdmVEb3VibGVDb25kaXRpb25hbGx5NjQoKQogc3RhdGljIHZvaWQgdGVzdENhZ2VQ cmVzZXJ2ZXNQQUNGYWlsdXJlQml0KCkKIHsKICNpZiBHSUdBQ0FHRV9FTkFCTEVECi0gICAgQVNT RVJUKCFHaWdhY2FnZTo6aXNEaXNhYmxpbmdQcmltaXRpdmVHaWdhY2FnZUZvcmJpZGRlbigpKTsK KyAgICAvLyBQbGFjYXRlIEFTYW4gYnVpbGRzIGFuZCBhbnkgZW52aXJvbm1lbnRzIHRoYXQgZGlz YWJsZXMgdGhlIEdpZ2FjYWdlLgorICAgIGlmICghR2lnYWNhZ2U6OnNob3VsZEJlRW5hYmxlZCgp KQorICAgICAgICByZXR1cm47CisKKyAgICBSRUxFQVNFX0FTU0VSVCghR2lnYWNhZ2U6OmlzRGlz YWJsaW5nUHJpbWl0aXZlR2lnYWNhZ2VGb3JiaWRkZW4oKSk7CiAgICAgYXV0byBjYWdlID0gY29t cGlsZShbXSAoQ0NhbGxIZWxwZXJzJiBqaXQpIHsKICAgICAgICAgZW1pdEZ1bmN0aW9uUHJvbG9n dWUoaml0KTsKICAgICAgICAgaml0LmNhZ2VDb25kaXRpb25hbGx5KEdpZ2FjYWdlOjpQcmltaXRp dmUsIEdQUkluZm86OmFyZ3VtZW50R1BSMCwgR1BSSW5mbzo6YXJndW1lbnRHUFIxLCBHUFJJbmZv Ojphcmd1bWVudEdQUjIpOwpAQCAtMTIyMSw3ICsxMjI1LDcgQEAgc3RhdGljIHZvaWQgdGVzdENh Z2VQcmVzZXJ2ZXNQQUNGYWlsdXJlQgogCiAgICAgdm9pZCogcHRyID0gR2lnYWNhZ2U6OnRyeU1h bGxvYyhHaWdhY2FnZTo6UHJpbWl0aXZlLCAxKTsKICAgICB2b2lkKiB0YWdnZWRQdHIgPSB0YWdB cnJheVB0cihwdHIsIDEpOwotICAgIEFTU0VSVChoYXNPbmVCaXRTZXQoR2lnYWNhZ2U6OnNpemUo R2lnYWNhZ2U6OlByaW1pdGl2ZSkgPDwgMikpOworICAgIFJFTEVBU0VfQVNTRVJUKGhhc09uZUJp dFNldChHaWdhY2FnZTo6c2l6ZShHaWdhY2FnZTo6UHJpbWl0aXZlKSA8PCAyKSk7CiAgICAgdm9p ZCogbm90Q2FnZWRQdHIgPSByZWludGVycHJldF9jYXN0PHZvaWQqPihyZWludGVycHJldF9jYXN0 PHVpbnRwdHJfdD4ocHRyKSArIChHaWdhY2FnZTo6c2l6ZShHaWdhY2FnZTo6UHJpbWl0aXZlKSA8 PCAyKSk7CiAgICAgQ0hFQ0tfTk9UX0VRKEdpZ2FjYWdlOjpjYWdlZChHaWdhY2FnZTo6UHJpbWl0 aXZlLCBub3RDYWdlZFB0ciksIG5vdENhZ2VkUHRyKTsKICAgICB2b2lkKiB0YWdnZWROb3RDYWdl ZFB0ciA9IHRhZ0FycmF5UHRyKG5vdENhZ2VkUHRyLCAxKTsK 380174 2019-10-03 18:03:04 -0700 2019-10-03 18:26:33 -0700 proposed patch. bug-202554.patch text/plain 2637 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUwNjkzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE5LTEwLTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggdGVzdG1hc20gZmFpbHVyZSBvbiBBU2FuIGJ1aWxkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjU1NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdpZ2FjYWdlIGlzIGRpc2FibGVkIG9uIEFTYW4g YnVpbGRzLiAgU28gdGVzdG1hc20gaXMgc2FkLiAgTWFrZSB0aGUgcmVsZXZhbnQgdGVzdAorICAg ICAgICBiYWlsIGdyYWNlZnVsbHkgaWYgR2lnYWNhZ2Ugc2hvdWxkIGJlIGRpc2FibGVkLgorCisg ICAgICAgIEFsc28gY29udmVydGVkIHNvbWUgQVNTRVJUcyBpbnRvIFJFTEVBU0VfQVNTRVJUcy4g IFRoaXMgaXMgYSB0ZXN0LiAgTm8gcmVhc29uIHRvCisgICAgICAgIG5vdCBhc3NlcnQgYWx3YXlz LgorCisgICAgICAgICogYXNzZW1ibGVyL3Rlc3RtYXNtLmNwcDoKKyAgICAgICAgKEpTQzo6dGVz dENhZ2VQcmVzZXJ2ZXNQQUNGYWlsdXJlQml0KToKKwogMjAxOS0xMC0wMyAgUm9zcyBLaXJzbGlu ZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgU29ja2V0IFJXSSBjbGllbnQg c2hvdWxkIGFjcXVpcmUgYmFja2VuZCBjb21tYW5kcyBmcm9tIHNlcnZlcgpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci90ZXN0bWFzbS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci90ZXN0bWFzbS5jcHAJKHJldmlzaW9uIDI1MDY5 MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvdGVzdG1hc20uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxNy0yMDE4 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxNy0y MDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlv biBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAq IG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcg Y29uZGl0aW9ucwpAQCAtMTIxMCw3ICsxMjEwLDExIEBAIHZvaWQgdGVzdE1vdmVEb3VibGVDb25k aXRpb25hbGx5NjQoKQogc3RhdGljIHZvaWQgdGVzdENhZ2VQcmVzZXJ2ZXNQQUNGYWlsdXJlQml0 KCkKIHsKICNpZiBHSUdBQ0FHRV9FTkFCTEVECi0gICAgQVNTRVJUKCFHaWdhY2FnZTo6aXNEaXNh YmxpbmdQcmltaXRpdmVHaWdhY2FnZUZvcmJpZGRlbigpKTsKKyAgICAvLyBQbGFjYXRlIEFTYW4g YnVpbGRzIGFuZCBhbnkgZW52aXJvbm1lbnRzIHRoYXQgZGlzYWJsZXMgdGhlIEdpZ2FjYWdlLgor ICAgIGlmICghR2lnYWNhZ2U6OnNob3VsZEJlRW5hYmxlZCgpKQorICAgICAgICByZXR1cm47CisK KyAgICBSRUxFQVNFX0FTU0VSVCghR2lnYWNhZ2U6OmlzRGlzYWJsaW5nUHJpbWl0aXZlR2lnYWNh Z2VGb3JiaWRkZW4oKSk7CiAgICAgYXV0byBjYWdlID0gY29tcGlsZShbXSAoQ0NhbGxIZWxwZXJz JiBqaXQpIHsKICAgICAgICAgZW1pdEZ1bmN0aW9uUHJvbG9ndWUoaml0KTsKICAgICAgICAgaml0 LmNhZ2VDb25kaXRpb25hbGx5KEdpZ2FjYWdlOjpQcmltaXRpdmUsIEdQUkluZm86OmFyZ3VtZW50 R1BSMCwgR1BSSW5mbzo6YXJndW1lbnRHUFIxLCBHUFJJbmZvOjphcmd1bWVudEdQUjIpOwpAQCAt MTIyMSw3ICsxMjI1LDcgQEAgc3RhdGljIHZvaWQgdGVzdENhZ2VQcmVzZXJ2ZXNQQUNGYWlsdXJl QgogCiAgICAgdm9pZCogcHRyID0gR2lnYWNhZ2U6OnRyeU1hbGxvYyhHaWdhY2FnZTo6UHJpbWl0 aXZlLCAxKTsKICAgICB2b2lkKiB0YWdnZWRQdHIgPSB0YWdBcnJheVB0cihwdHIsIDEpOwotICAg IEFTU0VSVChoYXNPbmVCaXRTZXQoR2lnYWNhZ2U6OnNpemUoR2lnYWNhZ2U6OlByaW1pdGl2ZSkg PDwgMikpOworICAgIFJFTEVBU0VfQVNTRVJUKGhhc09uZUJpdFNldChHaWdhY2FnZTo6c2l6ZShH aWdhY2FnZTo6UHJpbWl0aXZlKSA8PCAyKSk7CiAgICAgdm9pZCogbm90Q2FnZWRQdHIgPSByZWlu dGVycHJldF9jYXN0PHZvaWQqPihyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4ocHRyKSArIChH aWdhY2FnZTo6c2l6ZShHaWdhY2FnZTo6UHJpbWl0aXZlKSA8PCAyKSk7CiAgICAgQ0hFQ0tfTk9U X0VRKEdpZ2FjYWdlOjpjYWdlZChHaWdhY2FnZTo6UHJpbWl0aXZlLCBub3RDYWdlZFB0ciksIG5v dENhZ2VkUHRyKTsKICAgICB2b2lkKiB0YWdnZWROb3RDYWdlZFB0ciA9IHRhZ0FycmF5UHRyKG5v dENhZ2VkUHRyLCAxKTsK