202546 2019-10-03 15:18:03 -0700 [WinCairo] Remote Inspector doesn't gracefully shutdown 2019-10-03 22:06:15 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned basuke commit-queue ews-watchlist fujii hi joepeck keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1576624 0 chris.reid 2019-10-03 15:18:03 -0700 Windows sockets need to call shutdown before closesocket. https://docs.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-closesocket This causes some issues when the client closed then immediately initiated a new connection. The close isn't being seen by the server until much later causing the accept call to fail. 1576630 1 380165 chris.reid 2019-10-03 15:33:32 -0700 Created attachment 380165 patch 1576631 2 380166 chris.reid 2019-10-03 15:41:39 -0700 Created attachment 380166 Rebased patch 1576710 3 380166 commit-queue 2019-10-03 22:05:07 -0700 Comment on attachment 380166 Rebased patch Clearing flags on attachment: 380166 Committed r250699: <https://trac.webkit.org/changeset/250699> 1576711 4 commit-queue 2019-10-03 22:05:08 -0700 All reviewed patches have been landed. Closing bug. 1576714 5 webkit-bug-importer 2019-10-03 22:06:15 -0700 <rdar://problem/55973313> 380165 2019-10-03 15:33:32 -0700 2019-10-03 15:41:39 -0700 patch 202546.diff text/plain 3361 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBkNDBhNGRhMjEyLi5kOTcwNTU1NTAyYSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMTAtMDMgIENocmlz dG9waGVyIFJlaWQgIDxjaHJpcy5yZWlkQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10g UmVtb3RlIEluc3BlY3RvciBkb2Vzbid0IGdyYWNlZnVsbHkgc2h1dGRvd24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjU0NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGwgc2h1dGRvd24gYmVmb3Jl IGNsb3Nlc29ja2V0IGluIHdpbmRvd3MgdG8gY2xvc2UgdGhlIGNvbm5lY3Rpb24gZ3JhY2VmdWxs eS4KKworICAgICAgICBUaGlzIGFsc28gZml4ZXMgc29tZSBwb3RlbnRpYWwgdGhyZWFkaW5nIGlz c3VlcyB3aGVyZSBtX2NsaWVudENvbm5lY3Rpb24gCisgICAgICAgIGlzIHNldCBvbiBhIHdvcmtl ciB0aHJlYWQgYnV0IGNsZWFyZWQgb24gdGhlIG1haW4gdGhyZWFkLgorICAgICAgICBSZW1vdmUg Y2FsbE9uTWFpblRocmVhZCBpbiB0aGUgc2VydmVyIHRvbyBzaW5jZSBleGVjdXRpb24gZ2V0cyBw YXVzZWQgZHVyaW5nIEpTIGJyZWFrcG9pbnRzLgorCisgICAgICAgICogaW5zcGVjdG9yL3JlbW90 ZS9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcDoKKyAgICAgICAgKiBpbnNwZWN0b3Iv cmVtb3RlL3NvY2tldC93aW4vUmVtb3RlSW5zcGVjdG9yU29ja2V0V2luLmNwcDoKKwogMjAxOS0x MC0wMiAgUGF1bG8gTWF0b3MgIDxwbWF0b3NAaWdhbGlhLmNvbT4KIAogICAgICAgICBHYXJkZW5p bmcgYnVpbGQgZml4OiBIaWRlIHN0b3JlNjQvbG9hZDY0IGZ1bmN0aW9ucyBmcm9tIDMyYml0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQv UmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwCmluZGV4IDdiZTBiYmE5 OGVkLi43NTMxYzU1ZmVlYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9yZW1vdGUvc29ja2V0L1JlbW90ZUluc3BlY3RvclNlcnZlci5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvc29ja2V0L1JlbW90ZUluc3BlY3RvclNl cnZlci5jcHAKQEAgLTMyLDYgKzMyLDcgQEAKIAogI2luY2x1ZGUgPHd0Zi9KU09OVmFsdWVzLmg+ CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KKyNpbmNsdWRlIDx3dGYvUnVuTG9vcC5oPgog CiBuYW1lc3BhY2UgSW5zcGVjdG9yIHsKIApAQCAtODgsMTQgKzg5LDEyIEBAIHZvaWQgUmVtb3Rl SW5zcGVjdG9yU2VydmVyOjpkaWRDbG9zZShDb25uZWN0aW9uSUQgaWQpCiAKICAgICBpZiAoaWQg PT0gbV9jbGllbnRDb25uZWN0aW9uKSB7CiAgICAgICAgIC8vIENvbm5lY3Rpb24gZnJvbSB0aGUg cmVtb3RlIGNsaWVudCBjbG9zZWQuCi0gICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXNdIHsK LSAgICAgICAgICAgIGNsaWVudENvbm5lY3Rpb25DbG9zZWQoKTsKLSAgICAgICAgfSk7CisgICAg ICAgIGNsaWVudENvbm5lY3Rpb25DbG9zZWQoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAog ICAgIC8vIENvbm5lY3Rpb24gZnJvbSBXZWJQcm9jZXNzIGNsb3NlZC4KLSAgICBjYWxsT25NYWlu VGhyZWFkKFt0aGlzLCBpZF0geworICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbdGhpcywg aWRdIHsKICAgICAgICAgY29ubmVjdGlvbkNsb3NlZChpZCk7CiAgICAgfSk7CiB9CkBAIC0xOTMs MTMgKzE5MiwxNiBAQCB2b2lkIFJlbW90ZUluc3BlY3RvclNlcnZlcjo6Y2xvc2UoY29uc3QgRXZl bnQmIGV2ZW50KQogCiB2b2lkIFJlbW90ZUluc3BlY3RvclNlcnZlcjo6Y2xpZW50Q29ubmVjdGlv bkNsb3NlZCgpCiB7Ci0gICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKLQotICAgIGZvciAoYXV0 byBjb25uZWN0aW9uVGFyZ2V0UGFpciA6IG1faW5zcGVjdGlvblRhcmdldHMpCi0gICAgICAgIHNl bmRDbG9zZUV2ZW50KGNvbm5lY3Rpb25UYXJnZXRQYWlyLmZpcnN0LCBjb25uZWN0aW9uVGFyZ2V0 UGFpci5zZWNvbmQpOworICAgIEFTU0VSVCghaXNNYWluVGhyZWFkKCkpOwogCi0gICAgbV9pbnNw ZWN0aW9uVGFyZ2V0cy5jbGVhcigpOwogICAgIG1fY2xpZW50Q29ubmVjdGlvbiA9IFdURjo6bnVs bG9wdDsKKworICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbdGhpc10geworICAgICAgICBM b2NrSG9sZGVyIGxvY2sobV9jb25uZWN0aW9uc0xvY2spOworICAgICAgICBmb3IgKGF1dG8gY29u bmVjdGlvblRhcmdldFBhaXIgOiBtX2luc3BlY3Rpb25UYXJnZXRzKQorICAgICAgICAgICAgc2Vu ZENsb3NlRXZlbnQoY29ubmVjdGlvblRhcmdldFBhaXIuZmlyc3QsIGNvbm5lY3Rpb25UYXJnZXRQ YWlyLnNlY29uZCk7CisgICAgICAgIG1faW5zcGVjdGlvblRhcmdldHMuY2xlYXIoKTsKKyAgICB9 KTsKIH0KIAogdm9pZCBSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6OmNvbm5lY3Rpb25DbG9zZWQoQ29u bmVjdGlvbklEIGNsaWVudElEKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu c3BlY3Rvci9yZW1vdGUvc29ja2V0L3dpbi9SZW1vdGVJbnNwZWN0b3JTb2NrZXRXaW4uY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvc29ja2V0L3dpbi9SZW1vdGVJ bnNwZWN0b3JTb2NrZXRXaW4uY3BwCmluZGV4IDA2ZjczZTQ1MjRlLi41OTNkZWVlOTE2OCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvc29ja2V0L3dp bi9SZW1vdGVJbnNwZWN0b3JTb2NrZXRXaW4uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC93aW4vUmVtb3RlSW5zcGVjdG9yU29ja2V0V2luLmNw cApAQCAtNjcsNiArNjcsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBjbG9zZSgpCiAgICAgewogICAg ICAgICBpZiAoaXNWYWxpZChtX3NvY2tldCkpIHsKKyAgICAgICAgICAgIDo6c2h1dGRvd24obV9z b2NrZXQsIFNEX0JPVEgpOwogICAgICAgICAgICAgOjpjbG9zZXNvY2tldChtX3NvY2tldCk7CiAg ICAgICAgICAgICBtX3NvY2tldCA9IElOVkFMSURfU09DS0VUX1ZBTFVFOwogICAgICAgICB9Cg== 380166 2019-10-03 15:41:39 -0700 2019-10-03 22:05:07 -0700 Rebased patch 202546.diff text/plain 3423 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGRjMGU1ZTJlNjE3Li42ZGUxZDkzYTAzOCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMTAtMDMgIENocmlz dG9waGVyIFJlaWQgIDxjaHJpcy5yZWlkQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10g UmVtb3RlIEluc3BlY3RvciBkb2Vzbid0IGdyYWNlZnVsbHkgc2h1dGRvd24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjU0NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGwgc2h1dGRvd24gYmVmb3Jl IGNsb3Nlc29ja2V0IGluIHdpbmRvd3MgdG8gY2xvc2UgdGhlIGNvbm5lY3Rpb24gZ3JhY2VmdWxs eS4KKworICAgICAgICBUaGlzIGFsc28gZml4ZXMgc29tZSBwb3RlbnRpYWwgdGhyZWFkaW5nIGlz c3VlcyB3aGVyZSBtX2NsaWVudENvbm5lY3Rpb24gCisgICAgICAgIGlzIHNldCBvbiBhIHdvcmtl ciB0aHJlYWQgYnV0IGNsZWFyZWQgb24gdGhlIG1haW4gdGhyZWFkLgorICAgICAgICBSZW1vdmUg Y2FsbE9uTWFpblRocmVhZCBpbiB0aGUgc2VydmVyIHRvbyBzaW5jZSBleGVjdXRpb24gZ2V0cyBw YXVzZWQgZHVyaW5nIEpTIGJyZWFrcG9pbnRzLgorCisgICAgICAgICogaW5zcGVjdG9yL3JlbW90 ZS9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcDoKKyAgICAgICAgKiBpbnNwZWN0b3Iv cmVtb3RlL3NvY2tldC93aW4vUmVtb3RlSW5zcGVjdG9yU29ja2V0V2luLmNwcDoKKwogMjAxOS0x MC0wMyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAg U29ja2V0IFJXSSBjbGllbnQgc2hvdWxkIGFjcXVpcmUgYmFja2VuZCBjb21tYW5kcyBmcm9tIHNl cnZlcgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUv c29ja2V0L1JlbW90ZUluc3BlY3RvclNlcnZlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcAppbmRleCA1 ZGZlOTRiNzNlYy4uMTliODU5Y2FlNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNw ZWN0b3JTZXJ2ZXIuY3BwCkBAIC0zMiw2ICszMiw3IEBACiAjaW5jbHVkZSA8d3RmL0ZpbGVTeXN0 ZW0uaD4KICNpbmNsdWRlIDx3dGYvSlNPTlZhbHVlcy5oPgogI2luY2x1ZGUgPHd0Zi9NYWluVGhy ZWFkLmg+CisjaW5jbHVkZSA8d3RmL1J1bkxvb3AuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9CYXNl NjQuaD4KIAogbmFtZXNwYWNlIEluc3BlY3RvciB7CkBAIC04OSwxNCArOTAsMTIgQEAgdm9pZCBS ZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6OmRpZENsb3NlKENvbm5lY3Rpb25JRCBpZCkKIAogICAgIGlm IChpZCA9PSBtX2NsaWVudENvbm5lY3Rpb24pIHsKICAgICAgICAgLy8gQ29ubmVjdGlvbiBmcm9t IHRoZSByZW1vdGUgY2xpZW50IGNsb3NlZC4KLSAgICAgICAgY2FsbE9uTWFpblRocmVhZChbdGhp c10gewotICAgICAgICAgICAgY2xpZW50Q29ubmVjdGlvbkNsb3NlZCgpOwotICAgICAgICB9KTsK KyAgICAgICAgY2xpZW50Q29ubmVjdGlvbkNsb3NlZCgpOwogICAgICAgICByZXR1cm47CiAgICAg fQogCiAgICAgLy8gQ29ubmVjdGlvbiBmcm9tIFdlYlByb2Nlc3MgY2xvc2VkLgotICAgIGNhbGxP bk1haW5UaHJlYWQoW3RoaXMsIGlkXSB7CisgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFt0 aGlzLCBpZF0gewogICAgICAgICBjb25uZWN0aW9uQ2xvc2VkKGlkKTsKICAgICB9KTsKIH0KQEAg LTE5OSwxMyArMTk4LDE2IEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yU2VydmVyOjpjbG9zZShjb25z dCBFdmVudCYgZXZlbnQpCiAKIHZvaWQgUmVtb3RlSW5zcGVjdG9yU2VydmVyOjpjbGllbnRDb25u ZWN0aW9uQ2xvc2VkKCkKIHsKLSAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwotCi0gICAgZm9y IChhdXRvIGNvbm5lY3Rpb25UYXJnZXRQYWlyIDogbV9pbnNwZWN0aW9uVGFyZ2V0cykKLSAgICAg ICAgc2VuZENsb3NlRXZlbnQoY29ubmVjdGlvblRhcmdldFBhaXIuZmlyc3QsIGNvbm5lY3Rpb25U YXJnZXRQYWlyLnNlY29uZCk7CisgICAgQVNTRVJUKCFpc01haW5UaHJlYWQoKSk7CiAKLSAgICBt X2luc3BlY3Rpb25UYXJnZXRzLmNsZWFyKCk7CiAgICAgbV9jbGllbnRDb25uZWN0aW9uID0gV1RG OjpudWxsb3B0OworCisgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFt0aGlzXSB7CisgICAg ICAgIExvY2tIb2xkZXIgbG9jayhtX2Nvbm5lY3Rpb25zTG9jayk7CisgICAgICAgIGZvciAoYXV0 byBjb25uZWN0aW9uVGFyZ2V0UGFpciA6IG1faW5zcGVjdGlvblRhcmdldHMpCisgICAgICAgICAg ICBzZW5kQ2xvc2VFdmVudChjb25uZWN0aW9uVGFyZ2V0UGFpci5maXJzdCwgY29ubmVjdGlvblRh cmdldFBhaXIuc2Vjb25kKTsKKyAgICAgICAgbV9pbnNwZWN0aW9uVGFyZ2V0cy5jbGVhcigpOwor ICAgIH0pOwogfQogCiB2b2lkIFJlbW90ZUluc3BlY3RvclNlcnZlcjo6Y29ubmVjdGlvbkNsb3Nl ZChDb25uZWN0aW9uSUQgY2xpZW50SUQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQvd2luL1JlbW90ZUluc3BlY3RvclNvY2tldFdpbi5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQvd2luL1Jl bW90ZUluc3BlY3RvclNvY2tldFdpbi5jcHAKaW5kZXggMDZmNzNlNDUyNGUuLjU5M2RlZWU5MTY4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9zb2Nr ZXQvd2luL1JlbW90ZUluc3BlY3RvclNvY2tldFdpbi5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvc29ja2V0L3dpbi9SZW1vdGVJbnNwZWN0b3JTb2NrZXRX aW4uY3BwCkBAIC02Nyw2ICs2Nyw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGNsb3NlKCkKICAgICB7 CiAgICAgICAgIGlmIChpc1ZhbGlkKG1fc29ja2V0KSkgeworICAgICAgICAgICAgOjpzaHV0ZG93 bihtX3NvY2tldCwgU0RfQk9USCk7CiAgICAgICAgICAgICA6OmNsb3Nlc29ja2V0KG1fc29ja2V0 KTsKICAgICAgICAgICAgIG1fc29ja2V0ID0gSU5WQUxJRF9TT0NLRVRfVkFMVUU7CiAgICAgICAg IH0K