202545 2019-10-03 15:17:23 -0700 Fix WebGL 1 conformance regressions when USE_ANGLE=1 2020-03-11 17:12:13 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198948 1 jdarpinian jdarpinian achristensen cdumez commit-queue darin dino esprehn+autocc ews-watchlist graouts gyuyoung.kim kbr kondapallykalyan webkit-bug-importer oldest_to_newest 1576623 0 jdarpinian 2019-10-03 15:17:23 -0700 Fix WebGL 1 conformance regressions when USE_ANGLE=1 1576626 1 380163 jdarpinian 2019-10-03 15:19:52 -0700 Created attachment 380163 Fix WebGL 1 conformance regressions when USE_ANGLE=1 1576627 2 jdarpinian 2019-10-03 15:23:33 -0700 After this patch plus a couple of upstream changes I'm working on in ANGLE, setting USE_ANGLE=1 on Mac fixes a bunch of WebGL conformance tests and causes no new test regressions. 1576697 3 380163 commit-queue 2019-10-03 20:48:18 -0700 Comment on attachment 380163 Fix WebGL 1 conformance regressions when USE_ANGLE=1 Clearing flags on attachment: 380163 Committed r250697: <https://trac.webkit.org/changeset/250697> 1576698 4 commit-queue 2019-10-03 20:48:19 -0700 All reviewed patches have been landed. Closing bug. 1576699 5 webkit-bug-importer 2019-10-03 20:49:16 -0700 <rdar://problem/55972310> 1577794 6 380163 darin 2019-10-08 09:32:04 -0700 Comment on attachment 380163 Fix WebGL 1 conformance regressions when USE_ANGLE=1 View in context: https://bugs.webkit.org/attachment.cgi?id=380163&action=review > Source/WebCore/html/canvas/WebGLDebugShaders.cpp:54 > if (m_context.isContextLost()) > return String(); Since this function can no longer return null, it doesn’t make sense to return a null string here. Before the change to the bindings, this would turn into a JavaScript null, so this line of code may have had a valuable effect. We should consider returning an empty string here. Or perhaps removing this code entirely as long as the validateWebGLObject function is guaranteed to return false when the context is lost. 380163 2019-10-03 15:19:52 -0700 2019-10-03 20:48:18 -0700 Fix WebGL 1 conformance regressions when USE_ANGLE=1 bug-202545-20191003151951.patch text/plain 7097 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMwZTgzMWIwNGNlZjQ2 MWY2MmE3ODc5MjY5MGM1MzY5YjMyMGQ5Ny4uNDhkMTRlMTBiNDExOWMyYWQ2M2FmZWZmNjY4NzMx NGY4MDUwYTY4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE5LTEwLTAzICBKYW1l cyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggV2Vi R0wgMSBjb25mb3JtYW5jZSByZWdyZXNzaW9ucyB3aGVuIFVTRV9BTkdMRT0xCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI1NDUKKworICAgICAgICBQ cmV2ZW50IEFOR0xFIGZyb20gYXV0b21hdGljYWxseSB1c2luZyBFUzMgd2hlbiBFUzIgaXMgcmVx dWVzdGVkLgorCisgICAgICAgIFdFQkdMX2RlYnVnX3NoYWRlcnMgZXh0ZW5zaW9uIHNob3VsZCBu b3QgYWNjZXB0IG9yIHJldHVybiBudWxsLgorCisgICAgICAgIEVuYWJsZSBBTkdMRSdzIG5ldyBz dXBwb3J0IGZvciBlbXVsYXRpbmcgUkdCIG9uIFJHQkEgSU9TdXJmYWNlcy4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdM RGVidWdTaGFkZXJzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMRGVidWdTaGFkZXJzOjpn ZXRUcmFuc2xhdGVkU2hhZGVyU291cmNlKToKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTERl YnVnU2hhZGVycy5oOgorICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMRGVidWdTaGFkZXJzLmlk bDoKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U6OnZhbGlkYXRlVmVy dGV4QXR0cmlidXRlcyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUvRXh0ZW5z aW9uczNEQU5HTEUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uczNEQU5HTEU6Omdl dFRyYW5zbGF0ZWRTaGFkZXJTb3VyY2VBTkdMRSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY29jb2EvR3JhcGhpY3NDb250ZXh0M0RDb2NvYS5tbToKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzQ29udGV4dDNEOjpHcmFwaGljc0NvbnRleHQzRCk6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5tbToKKyAgICAgICAgKC1bV2ViR0xMYXllciBhbGxv Y2F0ZUlPU3VyZmFjZUJhY2tpbmdTdG9yZVdpdGhTaXplOnVzaW5nQWxwaGE6XSk6CisKIDIwMTkt MTAtMDMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBYTUxIdHRw UmVxdWVzdCBzb21ldGltZXMgcHJldmVudHMgcGFnZXMgZnJvbSBlbnRlcmluZyB0aGUgYmFjay9m b3J3YXJkIGNhY2hlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH TERlYnVnU2hhZGVycy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTERlYnVn U2hhZGVycy5jcHAKaW5kZXggODBjZGQ1YzUyMWQ1YWU5YWE4MTc5ODBjMjJjMmU3M2Q3NDVlNDQ3 My4uYjhhODIxYmI3ZWU3ZTU3MjRmMzZhMzgxN2FjZjAwNGVlNGY0NWVlNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xEZWJ1Z1NoYWRlcnMuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMRGVidWdTaGFkZXJzLmNwcApAQCAtNDgsMTMg KzQ4LDEzIEBAIFdlYkdMRXh0ZW5zaW9uOjpFeHRlbnNpb25OYW1lIFdlYkdMRGVidWdTaGFkZXJz OjpnZXROYW1lKCkgY29uc3QKICAgICByZXR1cm4gV2ViR0xEZWJ1Z1NoYWRlcnNOYW1lOwogfQog Ci1TdHJpbmcgV2ViR0xEZWJ1Z1NoYWRlcnM6OmdldFRyYW5zbGF0ZWRTaGFkZXJTb3VyY2UoV2Vi R0xTaGFkZXIqIHNoYWRlcikKK1N0cmluZyBXZWJHTERlYnVnU2hhZGVyczo6Z2V0VHJhbnNsYXRl ZFNoYWRlclNvdXJjZShXZWJHTFNoYWRlciYgc2hhZGVyKQogewogICAgIGlmIChtX2NvbnRleHQu aXNDb250ZXh0TG9zdCgpKQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7Ci0gICAgaWYgKCFtX2Nv bnRleHQudmFsaWRhdGVXZWJHTE9iamVjdCgiZ2V0VHJhbnNsYXRlZFNoYWRlclNvdXJjZSIsIHNo YWRlcikpCisgICAgaWYgKCFtX2NvbnRleHQudmFsaWRhdGVXZWJHTE9iamVjdCgiZ2V0VHJhbnNs YXRlZFNoYWRlclNvdXJjZSIsICZzaGFkZXIpKQogICAgICAgICByZXR1cm4gZW1wdHlTdHJpbmco KTsKLSAgICByZXR1cm4gbV9jb250ZXh0LmdyYXBoaWNzQ29udGV4dDNEKCktPmdldEV4dGVuc2lv bnMoKS5nZXRUcmFuc2xhdGVkU2hhZGVyU291cmNlQU5HTEUoc2hhZGVyLT5vYmplY3QoKSk7Cisg ICAgcmV0dXJuIG1fY29udGV4dC5ncmFwaGljc0NvbnRleHQzRCgpLT5nZXRFeHRlbnNpb25zKCku Z2V0VHJhbnNsYXRlZFNoYWRlclNvdXJjZUFOR0xFKHNoYWRlci5vYmplY3QoKSk7CiB9CiAKIH0g Ly8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdMRGVidWdTaGFkZXJzLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH TERlYnVnU2hhZGVycy5oCmluZGV4IDBkMTgwZmFhZTRiYWNhMjExN2UyYzRkOWMwODIxMWI1OGQx NjQwZDguLjQ1NjBlMjJjZDkxMzEyMDEzZmM1OTU2MjBhMDUzYTdjODU2MGVhY2UgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMRGVidWdTaGFkZXJzLmgKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xEZWJ1Z1NoYWRlcnMuaApAQCAtNDAsNyAr NDAsNyBAQCBwdWJsaWM6CiAKICAgICBFeHRlbnNpb25OYW1lIGdldE5hbWUoKSBjb25zdCBvdmVy cmlkZTsKIAotICAgIFN0cmluZyBnZXRUcmFuc2xhdGVkU2hhZGVyU291cmNlKFdlYkdMU2hhZGVy Kik7CisgICAgU3RyaW5nIGdldFRyYW5zbGF0ZWRTaGFkZXJTb3VyY2UoV2ViR0xTaGFkZXImKTsK IH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMRGVidWdTaGFkZXJzLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL1dlYkdMRGVidWdTaGFkZXJzLmlkbAppbmRleCA5N2M1ZTM2YmU2NmM5NmRkZTljYzVk YWRjZTRlNGM2MmNjM2UxMGUzLi45MzVhNmYxYTE0MTRlMTQ2NGExYjNlNjJlMjhjM2U3MzFlMmE2 YzZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTERlYnVnU2hh ZGVycy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xEZWJ1Z1NoYWRl cnMuaWRsCkBAIC0yOCw1ICsyOCw1IEBACiAgICAgR2VuZXJhdGVJc1JlYWNoYWJsZT1JbXBsV2Vi R0xSZW5kZXJpbmdDb250ZXh0LAogICAgIE5vSW50ZXJmYWNlT2JqZWN0LAogXSBpbnRlcmZhY2Ug V2ViR0xEZWJ1Z1NoYWRlcnMgewotICAgIERPTVN0cmluZz8gZ2V0VHJhbnNsYXRlZFNoYWRlclNv dXJjZShXZWJHTFNoYWRlcj8gc2hhZGVyKTsgLy8gRklYTUU6IFRoZSByZXR1cm4gdmFsdWUgYW5k IHRoZSBwYXJhbWV0ZXIgc2hvdWxkIG5vdCBiZSBudWxsYWJsZS4KKyAgICBET01TdHJpbmcgZ2V0 VHJhbnNsYXRlZFNoYWRlclNvdXJjZShXZWJHTFNoYWRlciBzaGFkZXIpOwogfTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFz ZS5jcHAKaW5kZXggMmQxNTBjNzExYzJkZmQ4ZTg3M2YzYjBjM2YwYjYxOTcwN2FlZmNiNC4uM2Ew MWQzNzRjY2ExODUyOTA1MjU3MTBkY2YzNDRjMGI0NTQxN2U2YiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAK QEAgLTIxMjAsNiArMjEyMCw5IEBAIGJvb2wgV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZTo6dmFs aWRhdGVWZXJ0ZXhBdHRyaWJ1dGVzKHVuc2lnbmVkIGVsZW1lbnRDb3VudCwKICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKICAgICAgICAgfQogICAgIH0KKyNlbHNlCisgICAgVU5VU0VEX1BBUkFN KGVsZW1lbnRDb3VudCk7CisgICAgVU5VU0VEX1BBUkFNKHByaW1pdGl2ZUNvdW50KTsKICNlbmRp ZgogICAgIAogICAgIHJldHVybiB0cnVlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYW5nbGUvRXh0ZW5zaW9uczNEQU5HTEUuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUvRXh0ZW5zaW9uczNEQU5HTEUuY3BwCmluZGV4IGFh MTQzZDA5MTE3M2E2YWEwN2E5Y2UyNjdjODg3OTExOTRkNWUwMzMuLjJkYmYzY2NiZWI3ZGUxNTc2 MDVmNzIxM2NhZjM0N2YyY2Q0MTY1YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2FuZ2xlL0V4dGVuc2lvbnMzREFOR0xFLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9FeHRlbnNpb25zM0RBTkdMRS5jcHAKQEAgLTEx MSw3ICsxMTEsOCBAQCBTdHJpbmcgRXh0ZW5zaW9uczNEQU5HTEU6OmdldFRyYW5zbGF0ZWRTaGFk ZXJTb3VyY2VBTkdMRShQbGF0Zm9ybTNET2JqZWN0IHNoYWRlcgogICAgIGdsOjpHZXRUcmFuc2xh dGVkU2hhZGVyU291cmNlQU5HTEUoc2hhZGVyLCBzb3VyY2VMZW5ndGgsICZyZXR1cm5lZExlbmd0 aCwgbmFtZS5kYXRhKCkpOwogICAgIGlmICghcmV0dXJuZWRMZW5ndGgpCiAgICAgICAgIHJldHVy biBlbXB0eVN0cmluZygpOwotICAgIEFTU0VSVChyZXR1cm5lZExlbmd0aCA9PSBzb3VyY2VMZW5n dGgpOworICAgIC8vIHJldHVybmVkTGVuZ3RoIGRvZXMgbm90IGluY2x1ZGUgdGhlIG51bGwgdGVy bWluYXRvci4KKyAgICBBU1NFUlQocmV0dXJuZWRMZW5ndGggPT0gc291cmNlTGVuZ3RoIC0gMSk7 CiAgICAgcmV0dXJuIFN0cmluZyhuYW1lLmRhdGEoKSwgcmV0dXJuZWRMZW5ndGgpOwogfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGlj c0NvbnRleHQzRENvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29j b2EvR3JhcGhpY3NDb250ZXh0M0RDb2NvYS5tbQppbmRleCBlYzk4MDUxNDU1YjcwZDA4NWU3Y2Zl NmUzNWJjMTNiMmE5MjNmNzgxLi5hZTI0Yzc4ZjBmMmVjZDdhYmVmZDAxMGVkYzAxYTgxYWNmMWQy M2ZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9H cmFwaGljc0NvbnRleHQzRENvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NvY29hL0dyYXBoaWNzQ29udGV4dDNEQ29jb2EubW0KQEAgLTMyNyw2ICszMjcsOSBA QCBHcmFwaGljc0NvbnRleHQzRDo6R3JhcGhpY3NDb250ZXh0M0QoR3JhcGhpY3NDb250ZXh0M0RB dHRyaWJ1dGVzIGF0dHJzLCBIb3N0V2luZAogICAgIHN0ZDo6dmVjdG9yPEVHTGludD4gY29udGV4 dEF0dHJpYnV0ZXM7CiAgICAgY29udGV4dEF0dHJpYnV0ZXMucHVzaF9iYWNrKEVHTF9DT05URVhU X0NMSUVOVF9WRVJTSU9OKTsKICAgICBjb250ZXh0QXR0cmlidXRlcy5wdXNoX2JhY2soMik7Cisg ICAgLy8gQU5HTEUgd2lsbCB1cGdyYWRlIHRoZSBjb250ZXh0IHRvIEVTMyBhdXRvbWF0aWNhbGx5 IHVubGVzcyB0aGlzIGlzIHNwZWNpZmllZC4KKyAgICBjb250ZXh0QXR0cmlidXRlcy5wdXNoX2Jh Y2soRUdMX0NPTlRFWFRfT1BFTkdMX0JBQ0tXQVJEU19DT01QQVRJQkxFX0FOR0xFKTsKKyAgICBj b250ZXh0QXR0cmlidXRlcy5wdXNoX2JhY2soRUdMX0ZBTFNFKTsKICAgICBjb250ZXh0QXR0cmli dXRlcy5wdXNoX2JhY2soRUdMX0NPTlRFWFRfV0VCR0xfQ09NUEFUSUJJTElUWV9BTkdMRSk7CiAg ICAgY29udGV4dEF0dHJpYnV0ZXMucHVzaF9iYWNrKEVHTF9UUlVFKTsKICAgICBpZiAoc3Ryc3Ry KGRpc3BsYXlFeHRlbnNpb25zLCAiRUdMX0FOR0xFX3Bvd2VyX3ByZWZlcmVuY2UiKSkgewpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXll ci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1dlYkdMTGF5ZXIu bW0KaW5kZXggN2RlYzllYzU2YWJlOTJhMjg1YjNhMzExNGFhZTQ5YmI2ZGMyN2MzNC4uODc4MDg2 MDI3MDI1ZjMwOTA4ODNhYmVjNDdkYmVjYWQ1NmEyNTBkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5tbQorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExheWVyLm1tCkBAIC0yMjAsNyAr MjIwLDcgQEAgLSAodm9pZClhbGxvY2F0ZUlPU3VyZmFjZUJhY2tpbmdTdG9yZVdpdGhTaXplOihX ZWJDb3JlOjpJbnRTaXplKXNpemUgdXNpbmdBbHBoYToKICAgICAgICAgRUdMX0hFSUdIVCwgc2l6 ZS5oZWlnaHQoKSwKICAgICAgICAgRUdMX0lPU1VSRkFDRV9QTEFORV9BTkdMRSwgMCwKICAgICAg ICAgRUdMX1RFWFRVUkVfVEFSR0VULCBFR0xfVEVYVFVSRV9SRUNUQU5HTEVfQU5HTEUsCi0gICAg ICAgIEVHTF9URVhUVVJFX0lOVEVSTkFMX0ZPUk1BVF9BTkdMRSwgR0xfQkdSQV9FWFQsCisgICAg ICAgIEVHTF9URVhUVVJFX0lOVEVSTkFMX0ZPUk1BVF9BTkdMRSwgdXNpbmdBbHBoYSA/IEdMX0JH UkFfRVhUIDogR0xfUkdCLAogICAgICAgICBFR0xfVEVYVFVSRV9GT1JNQVQsIEVHTF9URVhUVVJF X1JHQkEsCiAgICAgICAgIEVHTF9URVhUVVJFX1RZUEVfQU5HTEUsIEdMX1VOU0lHTkVEX0JZVEUs CiAgICAgICAgIEVHTF9OT05FLCBFR0xfTk9ORQo=