202544 2019-10-03 13:23:28 -0700 Replace _WKProcessPoolConfiguration.suppressesConnectionTerminationOnSystemChange with SPI on _WKWebsiteDataStoreConfiguration 2019-10-04 10:25:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen mitz sam thorton webkit-bug-importer oldest_to_newest 1576567 0 achristensen 2019-10-03 13:23:28 -0700 Replace _WKProcessPoolConfiguration.suppressesConnectionTerminationOnSystemChange with SPI on _WKWebsiteDataStoreConfiguration 1576568 1 380156 achristensen 2019-10-03 13:24:31 -0700 Created attachment 380156 Patch 1576597 2 achristensen 2019-10-03 14:17:01 -0700 http://trac.webkit.org/r250677 1576598 3 webkit-bug-importer 2019-10-03 14:17:19 -0700 <rdar://problem/55960800> 1576599 4 380156 mitz 2019-10-03 14:19:58 -0700 Comment on attachment 380156 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380156&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:71 > +@property (nonatomic) BOOL suppressesConnectionTerminationOnSystemChange WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); How does this relate to website data? 1576610 5 achristensen 2019-10-03 14:43:11 -0700 It goes in the NSURLSessionConfiguration, which is associated with a data store. 1576611 6 mitz 2019-10-03 14:47:48 -0700 (In reply to Alex Christensen from comment #5) > It goes in the NSURLSessionConfiguration, which is associated with a data > store. Unless I’m missing something, the NSURLSessionConfiguration association is an implementation detail and not part of the API, so that’s not a good motivator for introducing this property on _WKWebsiteDataStoreConfiguration. 1576615 7 achristensen 2019-10-03 14:51:21 -0700 _WKWebsiteDataStoreConfiguration is currently the best place in the API/SPI for the properties that apply to all WKWebViews that share the same networking session. I've considered adding a network parameters object to the _WKWebsiteDataStoreConfiguration 1576617 8 mitz 2019-10-03 15:01:05 -0700 (In reply to Alex Christensen from comment #7) > _WKWebsiteDataStoreConfiguration is currently the best place in the API/SPI > for the properties that apply to all WKWebViews that share the same > networking session. It’s not immediately clear why. Does the concept of networking session exist in the API? Is it conceptually related to website data and/or persistence? 1576618 9 achristensen 2019-10-03 15:06:29 -0700 (In reply to mitz from comment #8) > (In reply to Alex Christensen from comment #7) > > _WKWebsiteDataStoreConfiguration is currently the best place in the API/SPI > > for the properties that apply to all WKWebViews that share the same > > networking session. > > It’s not immediately clear why. Does the concept of networking session exist > in the API? Is it conceptually related to website data and/or persistence? A networking session *is* conceptually related to website data because of cookies and the HTTP cache. 1576905 10 sam 2019-10-04 10:25:20 -0700 I agree with Mitz here. It doesn't seem like this makes sense as a property of the WebsiteDataStore. For now, it probably makes the most sense on WKWebView itself. Separately, this name is very opaque. What exactly is "SystemChange" in this context? 380156 2019-10-03 13:24:31 -0700 2019-10-03 13:36:51 -0700 Patch bug-202544-20191003132429.patch text/plain 10987 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTA2NzMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDE5LTEwLTAzICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVwbGFjZSBfV0tQ cm9jZXNzUG9vbENvbmZpZ3VyYXRpb24uc3VwcHJlc3Nlc0Nvbm5lY3Rpb25UZXJtaW5hdGlvbk9u U3lzdGVtQ2hhbmdlIHdpdGggU1BJIG9uIF9XS1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI1NDQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgX1dL UHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uIFNQSSB3YXMgb3JpZ2luYWxseSBpbnRyb2R1Y2VkIGlu IHJkYXI6Ly9wcm9ibGVtLzQwNjUwMjQ0CisgICAgICAgIEtlZXAgYm90aCB3b3JraW5nIGR1cmlu ZyB0aGUgdHJhbnNpdGlvbiBwZXJpb2QsIGJ1dCB3ZSBuZWVkIGl0IHRvIG5vdCBiZSBvbiB0aGUg cHJvY2VzcyBwb29sLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Nlc3Npb25D cmVhdGlvblBhcmFtZXRlcnMuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrU2Vzc2lvbkNy ZWF0aW9uUGFyYW1ldGVyczo6ZW5jb2RlIGNvbnN0KToKKyAgICAgICAgKFdlYktpdDo6TmV0d29y a1Nlc3Npb25DcmVhdGlvblBhcmFtZXRlcnM6OmRlY29kZSk6CisgICAgICAgICogTmV0d29ya1By b2Nlc3MvTmV0d29ya1Nlc3Npb25DcmVhdGlvblBhcmFtZXRlcnMuaDoKKyAgICAgICAgKiBOZXR3 b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tOgorICAgICAgICAoV2ViS2l0 OjpOZXR3b3JrU2Vzc2lvbkNvY29hOjpOZXR3b3JrU2Vzc2lvbkNvY29hKToKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL0NvY29hL19XS1Byb2Nlc3NQb29sQ29uZmlndXJhdGlvbi5oOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24u aDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS1dlYnNpdGVEYXRhU3RvcmVDb25m aWd1cmF0aW9uLm1tOgorICAgICAgICAoLVtfV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlv biBzdXBwcmVzc2VzQ29ubmVjdGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2VdKToKKyAgICAg ICAgKC1bX1dLV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24gc2V0U3VwcHJlc3Nlc0Nvbm5l Y3Rpb25UZXJtaW5hdGlvbk9uU3lzdGVtQ2hhbmdlOl0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJzaXRlRGF0YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW06CisgICAgICAgIChXZWJL aXQ6OldlYnNpdGVEYXRhU3RvcmU6OnBhcmFtZXRlcnMpOgorICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uOjpjb3B5KToKKyAgICAgICAgKiBV SVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24uaDoKKyAg ICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb246OnN1cHByZXNzZXND b25uZWN0aW9uVGVybWluYXRpb25PblN5c3RlbUNoYW5nZSBjb25zdCk6CisgICAgICAgIChXZWJL aXQ6OldlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uOjpzZXRTdXBwcmVzc2VzQ29ubmVjdGlv blRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2UpOgorCiAyMDE5LTEwLTAzICBQZXIgQXJuZSBWb2xs YW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKDI0OTY0OSk6IFVu YWJsZSB0byBvcGVuIGxvY2FsIGZpbGVzIGluIE1pbmlCcm93c2VyIG9uIG1hY09TCkluZGV4OiBT b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtTZXNzaW9uQ3JlYXRpb25QYXJhbWV0 ZXJzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdv cmtTZXNzaW9uQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcAkocmV2aXNpb24gMjUwNjY1KQorKysgU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrU2Vzc2lvbkNyZWF0aW9uUGFyYW1ldGVy cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc5LDYgKzc5LDcgQEAgdm9pZCBOZXR3b3JrU2Vzc2lv bkNyZWF0aW9uUGFyYW1ldGVyczo6ZQogICAgIGVuY29kZXIgPDwgbmV0d29ya0NhY2hlU3BlY3Vs YXRpdmVWYWxpZGF0aW9uRW5hYmxlZDsKICAgICBlbmNvZGVyIDw8IHNob3VsZFVzZVRlc3RpbmdO ZXR3b3JrU2Vzc2lvbjsKICAgICBlbmNvZGVyIDw8IHRlc3RTcGVlZE11bHRpcGxpZXI7CisgICAg ZW5jb2RlciA8PCBzdXBwcmVzc2VzQ29ubmVjdGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2U7 CiB9CiAKIE9wdGlvbmFsPE5ldHdvcmtTZXNzaW9uQ3JlYXRpb25QYXJhbWV0ZXJzPiBOZXR3b3Jr U2Vzc2lvbkNyZWF0aW9uUGFyYW1ldGVyczo6ZGVjb2RlKElQQzo6RGVjb2RlciYgZGVjb2RlcikK QEAgLTI0OCw2ICsyNDksMTEgQEAgT3B0aW9uYWw8TmV0d29ya1Nlc3Npb25DcmVhdGlvblBhcmFt ZXRlcgogICAgIGlmICghdGVzdFNwZWVkTXVsdGlwbGllcikKICAgICAgICAgcmV0dXJuIFdURjo6 bnVsbG9wdDsKICAgICAKKyAgICBPcHRpb25hbDxib29sPiBzdXBwcmVzc2VzQ29ubmVjdGlvblRl cm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2U7CisgICAgZGVjb2RlciA+PiBzdXBwcmVzc2VzQ29ubmVj dGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2U7CisgICAgaWYgKCFzdXBwcmVzc2VzQ29ubmVj dGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2UpCisgICAgICAgIHJldHVybiBXVEY6Om51bGxv cHQ7CisKICAgICByZXR1cm4ge3sKICAgICAgICAgKnNlc3Npb25JRAogICAgICAgICAsIFdURk1v dmUoKmJvdW5kSW50ZXJmYWNlSWRlbnRpZmllcikKQEAgLTI4Nyw2ICsyOTMsNyBAQCBPcHRpb25h bDxOZXR3b3JrU2Vzc2lvbkNyZWF0aW9uUGFyYW1ldGVyCiAgICAgICAgICwgV1RGTW92ZSgqbmV0 d29ya0NhY2hlU3BlY3VsYXRpdmVWYWxpZGF0aW9uRW5hYmxlZCkKICAgICAgICAgLCBXVEZNb3Zl KCpzaG91bGRVc2VUZXN0aW5nTmV0d29ya1Nlc3Npb24pCiAgICAgICAgICwgV1RGTW92ZSgqdGVz dFNwZWVkTXVsdGlwbGllcikKKyAgICAgICAgLCBXVEZNb3ZlKCpzdXBwcmVzc2VzQ29ubmVjdGlv blRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2UpCiAgICAgfX07CiB9CiAKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Nlc3Npb25DcmVhdGlvblBhcmFtZXRlcnMuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtTZXNzaW9u Q3JlYXRpb25QYXJhbWV0ZXJzLmgJKHJldmlzaW9uIDI1MDY2NSkKKysrIFNvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvTmV0d29ya1Nlc3Npb25DcmVhdGlvblBhcmFtZXRlcnMuaAkod29ya2lu ZyBjb3B5KQpAQCAtOTcsNiArOTcsNyBAQCBzdHJ1Y3QgTmV0d29ya1Nlc3Npb25DcmVhdGlvblBh cmFtZXRlcnMgCiAgICAgYm9vbCBuZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZVZhbGlkYXRpb25FbmFi bGVkIHsgZmFsc2UgfTsKICAgICBib29sIHNob3VsZFVzZVRlc3RpbmdOZXR3b3JrU2Vzc2lvbiB7 IGZhbHNlIH07CiAgICAgdW5zaWduZWQgdGVzdFNwZWVkTXVsdGlwbGllciB7IDEgfTsKKyAgICBi b29sIHN1cHByZXNzZXNDb25uZWN0aW9uVGVybWluYXRpb25PblN5c3RlbUNoYW5nZSB7IGZhbHNl IH07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0J KHJldmlzaW9uIDI1MDY2NSkKKysrIFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2Ev TmV0d29ya1Nlc3Npb25Db2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtOTgzLDcgKzk4Myw3IEBA IE5ldHdvcmtTZXNzaW9uQ29jb2E6Ok5ldHdvcmtTZXNzaW9uQ29jb2EKIAogI2lmIChQTEFURk9S TShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNDAwKSB8fCBQ TEFURk9STShJT1NfRkFNSUxZKQogICAgIC8vIEZJWE1FOiBSZXBsYWNlIEAia0NGU3RyZWFtUHJv cGVydHlBdXRvRXJyb3JPblN5c3RlbUNoYW5nZSIgd2l0aCBhIGNvbnN0YW50IGZyb20gdGhlIFNE SyBvbmNlIHJkYXI6Ly9wcm9ibGVtLzQwNjUwMjQ0IGlzIGluIGEgYnVpbGQuCi0gICAgaWYgKG5l dHdvcmtQcm9jZXNzLnN1cHByZXNzZXNDb25uZWN0aW9uVGVybWluYXRpb25PblN5c3RlbUNoYW5n ZSgpKQorICAgIGlmIChuZXR3b3JrUHJvY2Vzcy5zdXBwcmVzc2VzQ29ubmVjdGlvblRlcm1pbmF0 aW9uT25TeXN0ZW1DaGFuZ2UoKSB8fCBwYXJhbWV0ZXJzLnN1cHByZXNzZXNDb25uZWN0aW9uVGVy bWluYXRpb25PblN5c3RlbUNoYW5nZSkKICAgICAgICAgY29uZmlndXJhdGlvbi5fc29ja2V0U3Ry ZWFtUHJvcGVydGllcyA9IEB7IEAia0NGU3RyZWFtUHJvcGVydHlBdXRvRXJyb3JPblN5c3RlbUNo YW5nZSIgOiBATk8gfTsKICNlbmRpZgogCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQ29jb2EvX1dLUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1Byb2Nlc3NQb29sQ29uZmlndXJhdGlv bi5oCShyZXZpc2lvbiAyNTA2NjUpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvX1dLUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTY4LDcg KzY4LDcgQEAgV0tfQ0xBU1NfQVZBSUxBQkxFKG1hY29zKDEwLjEwKSwgaW9zKDguMAogQHByb3Bl cnR5IChub25hdG9taWMpIEJPT0wgcHJld2FybXNQcm9jZXNzZXNBdXRvbWF0aWNhbGx5IFdLX0FQ SV9BVkFJTEFCTEUobWFjb3MoMTAuMTQuNCksIGlvcygxMi4yKSk7CiBAcHJvcGVydHkgKG5vbmF0 b21pYykgQk9PTCB1c2VzV2ViUHJvY2Vzc0NhY2hlIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAu MTQuNCksIGlvcygxMi4yKSk7CiBAcHJvcGVydHkgKG5vbmF0b21pYykgQk9PTCBwYWdlQ2FjaGVF bmFibGVkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAuMTQpLCBpb3MoMTIuMCkpOwotQHByb3Bl cnR5IChub25hdG9taWMpIEJPT0wgc3VwcHJlc3Nlc0Nvbm5lY3Rpb25UZXJtaW5hdGlvbk9uU3lz dGVtQ2hhbmdlIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAuMTQpLCBpb3MoMTIuMCkpOworQHBy b3BlcnR5IChub25hdG9taWMpIEJPT0wgc3VwcHJlc3Nlc0Nvbm5lY3Rpb25UZXJtaW5hdGlvbk9u U3lzdGVtQ2hhbmdlIFdLX0FQSV9ERVBSRUNBVEVEX1dJVEhfUkVQTEFDRU1FTlQoIl9XS1dlYnNp dGVEYXRhU3RvcmVDb25maWd1cmF0aW9uLnN1cHByZXNzZXNDb25uZWN0aW9uVGVybWluYXRpb25P blN5c3RlbUNoYW5nZSIsIG1hY29zKDEwLjE0LCBXS19NQUNfVEJBKSwgaW9zKDEyLjAsIFdLX0lP U19UQkEpKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBnZXR0ZXI9aXNKSVRFbmFibGVkKSBCT09M IEpJVEVuYWJsZWQgV0tfQVBJX0FWQUlMQUJMRShtYWNvcygxMC4xNC40KSwgaW9zKDEyLjIpKTsK IEBwcm9wZXJ0eSAobm9uYXRvbWljLCBudWxsYWJsZSwgY29weSwgc2V0dGVyPXNldEhTVFNTdG9y YWdlRGlyZWN0b3J5OikgTlNVUkwgKmhzdHNTdG9yYWdlRGlyZWN0b3J5IFdLX0FQSV9BVkFJTEFC TEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CiAKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlv bi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tX ZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5oCShyZXZpc2lvbiAyNTA2NjUpCisrKyBTb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3Vy YXRpb24uaAkod29ya2luZyBjb3B5KQpAQCAtNjgsNiArNjgsNyBAQCBXS19DTEFTU19BVkFJTEFC TEUobWFjb3MoMTAuMTMpLCBpb3MoMTEuCiBAcHJvcGVydHkgKG5vbmF0b21pYywgbnVsbGFibGUs IGNvcHkpIE5TVVJMICptZWRpYUNhY2hlRGlyZWN0b3J5IFdLX0FQSV9BVkFJTEFCTEUobWFjb3Mo V0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgbnVs bGFibGUsIGNvcHkpIE5TVVJMICptZWRpYUtleXNTdG9yYWdlRGlyZWN0b3J5IFdLX0FQSV9BVkFJ TEFCTEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CiBAcHJvcGVydHkgKG5v bmF0b21pYykgTlNVSW50ZWdlciB0ZXN0U3BlZWRNdWx0aXBsaWVyIFdLX0FQSV9BVkFJTEFCTEUo bWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CitAcHJvcGVydHkgKG5vbmF0b21p YykgQk9PTCBzdXBwcmVzc2VzQ29ubmVjdGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2UgV0tf QVBJX0FWQUlMQUJMRShtYWNvcyhXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKIAogLy8g VGVzdGluZyBvbmx5LgogQHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgYWxsTG9hZHNCbG9ja2Vk QnlEZXZpY2VNYW5hZ2VtZW50UmVzdHJpY3Rpb25zRm9yVGVzdGluZyBXS19BUElfQVZBSUxBQkxF KG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwpJbmRleDogU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tXZWJz aXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5tbQkocmV2aXNpb24gMjUwNjY1KQorKysgU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0 aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zNDAsNiArMzQwLDE2IEBAIC0gKHZvaWQpc2V0VGVz dFNwZWVkTXVsdGlwbGllcjooTlNVSW50ZWcKICAgICBfY29uZmlndXJhdGlvbi0+c2V0VGVzdFNw ZWVkTXVsdGlwbGllcihxdW90YSk7CiB9CiAKKy0gKEJPT0wpc3VwcHJlc3Nlc0Nvbm5lY3Rpb25U ZXJtaW5hdGlvbk9uU3lzdGVtQ2hhbmdlCit7CisgICAgcmV0dXJuIF9jb25maWd1cmF0aW9uLT5z dXBwcmVzc2VzQ29ubmVjdGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2UoKTsKK30KKworLSAo dm9pZClzZXRTdXBwcmVzc2VzQ29ubmVjdGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2U6KEJP T0wpc3VwcHJlc3NlcworeworICAgIF9jb25maWd1cmF0aW9uLT5zZXRTdXBwcmVzc2VzQ29ubmVj dGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2Uoc3VwcHJlc3Nlcyk7Cit9CisKIC0gKE5TU3Ry aW5nICopYm91bmRJbnRlcmZhY2VJZGVudGlmaWVyCiB7CiAgICAgcmV0dXJuIF9jb25maWd1cmF0 aW9uLT5ib3VuZEludGVyZmFjZUlkZW50aWZpZXIoKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0 YVN0b3JlQ29uZmlndXJhdGlvbi5jcHAJKHJldmlzaW9uIDI1MDY2NSkKKysrIFNvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uLmNw cAkod29ya2luZyBjb3B5KQpAQCAtODUsNiArODUsNyBAQCBSZWY8V2Vic2l0ZURhdGFTdG9yZUNv bmZpZ3VyYXRpb24+IFdlYnNpCiAgICAgY29weS0+bV9kYXRhQ29ubmVjdGlvblNlcnZpY2VUeXBl ID0gdGhpcy0+bV9kYXRhQ29ubmVjdGlvblNlcnZpY2VUeXBlOwogICAgIGNvcHktPm1fdGVzdGlu Z1Nlc3Npb25FbmFibGVkID0gdGhpcy0+bV90ZXN0aW5nU2Vzc2lvbkVuYWJsZWQ7CiAgICAgY29w eS0+bV90ZXN0U3BlZWRNdWx0aXBsaWVyID0gdGhpcy0+bV90ZXN0U3BlZWRNdWx0aXBsaWVyOwor ICAgIGNvcHktPm1fc3VwcHJlc3Nlc0Nvbm5lY3Rpb25UZXJtaW5hdGlvbk9uU3lzdGVtQ2hhbmdl ID0gdGhpcy0+bV9zdXBwcmVzc2VzQ29ubmVjdGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2U7 CiAjaWYgUExBVEZPUk0oQ09DT0EpCiAgICAgaWYgKG1fcHJveHlDb25maWd1cmF0aW9uKQogICAg ICAgICBjb3B5LT5tX3Byb3h5Q29uZmlndXJhdGlvbiA9IGFkb3B0Q0YoQ0ZEaWN0aW9uYXJ5Q3Jl YXRlQ29weShudWxscHRyLCB0aGlzLT5tX3Byb3h5Q29uZmlndXJhdGlvbi5nZXQoKSkpOwpJbmRl eDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZUNv bmZpZ3VyYXRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJz aXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5oCShyZXZpc2lvbiAyNTA2NjUp CisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3Jl Q29uZmlndXJhdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzgsNiArMTM4LDkgQEAgcHVibGlj OgogICAgIGNvbnN0IFN0cmluZyYgZGF0YUNvbm5lY3Rpb25TZXJ2aWNlVHlwZSgpIGNvbnN0IHsg cmV0dXJuIG1fZGF0YUNvbm5lY3Rpb25TZXJ2aWNlVHlwZTsgfQogICAgIHZvaWQgc2V0RGF0YUNv bm5lY3Rpb25TZXJ2aWNlVHlwZShTdHJpbmcmJiB0eXBlKSB7IG1fZGF0YUNvbm5lY3Rpb25TZXJ2 aWNlVHlwZSA9IFdURk1vdmUodHlwZSk7IH0KICAgICAKKyAgICBib29sIHN1cHByZXNzZXNDb25u ZWN0aW9uVGVybWluYXRpb25PblN5c3RlbUNoYW5nZSgpIGNvbnN0IHsgcmV0dXJuIG1fc3VwcHJl c3Nlc0Nvbm5lY3Rpb25UZXJtaW5hdGlvbk9uU3lzdGVtQ2hhbmdlOyB9CisgICAgdm9pZCBzZXRT dXBwcmVzc2VzQ29ubmVjdGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFuZ2UoYm9vbCBzdXBwcmVz c2VzKSB7IG1fc3VwcHJlc3Nlc0Nvbm5lY3Rpb25UZXJtaW5hdGlvbk9uU3lzdGVtQ2hhbmdlID0g c3VwcHJlc3NlczsgfQorCiBwcml2YXRlOgogICAgIElzUGVyc2lzdGVudCBtX2lzUGVyc2lzdGVu dCB7IElzUGVyc2lzdGVudDo6Tm8gfTsKIApAQCAtMTc0LDYgKzE3Nyw3IEBAIHByaXZhdGU6CiAg ICAgYm9vbCBtX2Zhc3RTZXJ2ZXJUcnVzdEV2YWx1YXRpb25FbmFibGVkIHsgZmFsc2UgfTsKICAg ICBib29sIG1fc2VydmljZVdvcmtlclByb2Nlc3NUZXJtaW5hdGlvbkRlbGF5RW5hYmxlZCB7IHRy dWUgfTsKICAgICBib29sIG1fdGVzdGluZ1Nlc3Npb25FbmFibGVkIHsgZmFsc2UgfTsKKyAgICBi b29sIG1fc3VwcHJlc3Nlc0Nvbm5lY3Rpb25UZXJtaW5hdGlvbk9uU3lzdGVtQ2hhbmdlIHsgZmFs c2UgfTsKICAgICB1bnNpZ25lZCBtX3Rlc3RTcGVlZE11bHRpcGxpZXIgeyAxIH07CiAjaWYgUExB VEZPUk0oQ09DT0EpCiAgICAgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gbV9wcm94eUNvbmZp Z3VyYXRpb247CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9Db2Nv YS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1tCShyZXZp c2lvbiAyNTA2NjUpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9Db2Nv YS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTE0Nyw2ICsxNDcs NyBAQCBXZWJzaXRlRGF0YVN0b3JlUGFyYW1ldGVycyBXZWJzaXRlRGF0YVN0CiAgICAgICAgIG1f Y29uZmlndXJhdGlvbi0+bmV0d29ya0NhY2hlU3BlY3VsYXRpdmVWYWxpZGF0aW9uRW5hYmxlZCgp LAogICAgICAgICBtX2NvbmZpZ3VyYXRpb24tPnRlc3RpbmdTZXNzaW9uRW5hYmxlZCgpLAogICAg ICAgICBtX2NvbmZpZ3VyYXRpb24tPnRlc3RTcGVlZE11bHRpcGxpZXIoKSwKKyAgICAgICAgbV9j b25maWd1cmF0aW9uLT5zdXBwcmVzc2VzQ29ubmVjdGlvblRlcm1pbmF0aW9uT25TeXN0ZW1DaGFu Z2UoKSwKICAgICB9OwogICAgIG5ldHdvcmtpbmdIYXNCZWd1bigpOwogCg==