202530 2019-10-03 09:05:41 -0700 [GTK] WebAutomation: make setWindowRect synchronous 2019-10-03 23:15:50 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 202047 1 cgarcia webkit-unassigned berto bugs-noreply clopez ews-watchlist gustavo oldest_to_newest 1576428 0 cgarcia 2019-10-03 09:05:41 -0700 Move/resize window is asynchronous in GTK, but automation expects it to be synchronous so that get window rect after setting it always returns the value set. 1576429 1 380119 cgarcia 2019-10-03 09:08:15 -0700 Created attachment 380119 Patch 1576431 2 ews-watchlist 2019-10-03 09:09:07 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1576443 3 380119 clopez 2019-10-03 09:26:38 -0700 Comment on attachment 380119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380119&action=review > Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp:156 > + if (geometry.x >= 0 && geometry.y >= 0) { curly braces are not needed around this if. > Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp:159 > + if (geometry.width > 0 && geometry.height > 0) { Same here. 1576736 4 cgarcia 2019-10-03 23:15:50 -0700 Committed r250707: <https://trac.webkit.org/changeset/250707> 380119 2019-10-03 09:08:15 -0700 2019-10-03 09:26:38 -0700 Patch wk2-set-window-frame-sync.diff text/plain 3898 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNTJjNWMwNmVjOTIuLjQxNGU3MzgwYzI1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDE5LTEwLTAzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBXZWJBdXRvbWF0aW9uOiBtYWtlIHNldFdpbmRvd1JlY3Qg c3luY2hyb25vdXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwMjUzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1vdmUvcmVzaXplIHdpbmRvdyBpcyBhc3luY2hyb25vdXMgaW4gR1RLLCBidXQgYXV0b21h dGlvbiBleHBlY3RzIGl0IHRvIGJlIHN5bmNocm9ub3VzIHNvIHRoYXQgZ2V0IHdpbmRvdyByZWN0 CisgICAgICAgIGFmdGVyIHNldHRpbmcgaXQgYWx3YXlzIHJldHVybnMgdGhlIHZhbHVlIHNldC4g VXNlIGEgbmVzdGVkIHJ1biBsb29wIHRvIHdhaXQgZm9yIHRoZSBjb25maWd1cmUgZXZlbnRzIGFm dGVyIHRoZQorICAgICAgICBtb3ZlL3Jlc2l6ZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv Z2xpYi9XZWJLaXRVSUNsaWVudC5jcHA6CisgICAgICAgIChVSUNsaWVudDo6d2luZG93Q29uZmln dXJlRXZlbnRDYWxsYmFjayk6CisgICAgICAgIChVSUNsaWVudDo6c2V0V2luZG93RnJhbWVUaW1l ckZpcmVkKToKKwogMjAxOS0xMC0wMyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS11bV1BFXSBFbmFibGUgYXN5bmMgc2Nyb2xsaW5nCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAKaW5k ZXggODk2ZTEzZGFkOTcuLmMyNmUxNGQ4ZTUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0VUlDbGllbnQuY3BwCkBAIC0zNSw2ICszNSw3IEBACiAj aW5jbHVkZSAiV2ViUHJvY2Vzc1Byb3h5LmgiCiAjaW5jbHVkZSAiV2Vic2l0ZURhdGFTdG9yZS5o IgogI2luY2x1ZGUgPHd0Zi9nbGliL0dSZWZQdHIuaD4KKyNpbmNsdWRlIDx3dGYvZ2xpYi9SdW5M b29wU291cmNlUHJpb3JpdHkuaD4KIAogI2lmIFBMQVRGT1JNKEdUSykKICNpbmNsdWRlIDxXZWJD b3JlL0d0a1V0aWxpdGllcy5oPgpAQCAtMTI4LDE2ICsxMjksNDUgQEAgcHJpdmF0ZToKICAgICAg ICAgd2Via2l0V2luZG93UHJvcGVydGllc1NldFJlc2l6YWJsZSh3ZWJraXRfd2ViX3ZpZXdfZ2V0 X3dpbmRvd19wcm9wZXJ0aWVzKG1fd2ViVmlldyksIHJlc2l6YWJsZSk7CiAgICAgfQogCisgICAg c3RhdGljIHZvaWQgd2luZG93Q29uZmlndXJlRXZlbnRDYWxsYmFjayhHdGtXaW5kb3cqIHdpbmRv dywgR2RrRXZlbnRDb25maWd1cmUqLCBHZGtSZWN0YW5nbGUqIHRhcmdldEdlb21ldHJ5KQorICAg IHsKKyAgICAgICAgR2RrUmVjdGFuZ2xlIGdlb21ldHJ5ID0geyAwLCAwLCAwLCAwIH07CisgICAg ICAgIGd0a193aW5kb3dfZ2V0X3Bvc2l0aW9uKHdpbmRvdywgJmdlb21ldHJ5LngsICZnZW9tZXRy eS55KTsKKyAgICAgICAgZ3RrX3dpbmRvd19nZXRfc2l6ZSh3aW5kb3csICZnZW9tZXRyeS53aWR0 aCwgJmdlb21ldHJ5LmhlaWdodCk7CisgICAgICAgIGlmIChnZW9tZXRyeS54ID09IHRhcmdldEdl b21ldHJ5LT54ICYmIGdlb21ldHJ5LnkgPT0gdGFyZ2V0R2VvbWV0cnktPnkgJiYgZ2VvbWV0cnku d2lkdGggPT0gdGFyZ2V0R2VvbWV0cnktPndpZHRoICYmIGdlb21ldHJ5LmhlaWdodCA9PSB0YXJn ZXRHZW9tZXRyeS0+aGVpZ2h0KQorICAgICAgICAgICAgUnVuTG9vcDo6Y3VycmVudCgpLnN0b3Ao KTsKKyAgICB9CisKKyAgICB2b2lkIHNldFdpbmRvd0ZyYW1lVGltZXJGaXJlZCgpCisgICAgewor ICAgICAgICBSdW5Mb29wOjpjdXJyZW50KCkuc3RvcCgpOworICAgIH0KKwogICAgIHZvaWQgc2V0 V2luZG93RnJhbWUoV2ViUGFnZVByb3h5JiwgY29uc3QgV2ViQ29yZTo6RmxvYXRSZWN0JiBmcmFt ZSkgZmluYWwKICAgICB7CiAjaWYgUExBVEZPUk0oR1RLKQogICAgICAgICBHZGtSZWN0YW5nbGUg Z2VvbWV0cnkgPSBXZWJDb3JlOjpJbnRSZWN0KGZyYW1lKTsKICAgICAgICAgR3RrV2lkZ2V0KiB3 aW5kb3cgPSBndGtfd2lkZ2V0X2dldF90b3BsZXZlbChHVEtfV0lER0VUKG1fd2ViVmlldykpOwog ICAgICAgICBpZiAod2Via2l0X3dlYl92aWV3X2lzX2NvbnRyb2xsZWRfYnlfYXV0b21hdGlvbiht X3dlYlZpZXcpICYmIFdlYkNvcmU6OndpZGdldElzT25zY3JlZW5Ub3BsZXZlbFdpbmRvdyh3aW5k b3cpICYmIGd0a193aWRnZXRfZ2V0X3Zpc2libGUod2luZG93KSkgewotICAgICAgICAgICAgaWYg KGdlb21ldHJ5LnggPj0gMCAmJiBnZW9tZXRyeS55ID49IDApCisgICAgICAgICAgICBpZiAoKGdl b21ldHJ5LnggPCAwIHx8IGdlb21ldHJ5LnkgPCAwKSAmJiAoZ2VvbWV0cnkud2lkdGggPD0gMCB8 fCBnZW9tZXRyeS5oZWlnaHQgPD0gMCkpCisgICAgICAgICAgICAgICAgcmV0dXJuOworCisgICAg ICAgICAgICBhdXRvIHNpZ25hbElEID0gZ19zaWduYWxfY29ubmVjdCh3aW5kb3csICJjb25maWd1 cmUtZXZlbnQiLCBHX0NBTExCQUNLKHdpbmRvd0NvbmZpZ3VyZUV2ZW50Q2FsbGJhY2spLCAmZ2Vv bWV0cnkpOworICAgICAgICAgICAgaWYgKGdlb21ldHJ5LnggPj0gMCAmJiBnZW9tZXRyeS55ID49 IDApIHsKICAgICAgICAgICAgICAgICBndGtfd2luZG93X21vdmUoR1RLX1dJTkRPVyh3aW5kb3cp LCBnZW9tZXRyeS54LCBnZW9tZXRyeS55KTsKLSAgICAgICAgICAgIGlmIChnZW9tZXRyeS53aWR0 aCA+IDAgJiYgZ2VvbWV0cnkuaGVpZ2h0ID4gMCkKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAg IGlmIChnZW9tZXRyeS53aWR0aCA+IDAgJiYgZ2VvbWV0cnkuaGVpZ2h0ID4gMCkgewogICAgICAg ICAgICAgICAgIGd0a193aW5kb3dfcmVzaXplKEdUS19XSU5ET1cod2luZG93KSwgZ2VvbWV0cnku d2lkdGgsIGdlb21ldHJ5LmhlaWdodCk7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIC8v IFdlIG5lZWQgdGhlIG1vdmUvcmVzaXplIHRvIGhhcHBlbiBzeW5jaHJvbm91c2x5IGluIGF1dG9t YXRpb24gbW9kZSwgc28gd2UgdXNlIGEgbmVzdGVkIFJ1bkxvb3AKKyAgICAgICAgICAgIC8vIHRv IHdhaXQsIHVwIHRvcCAxIHNlY29uZCwgZm9yIHRoZSBjb25maWd1cmUgZXZlbnRzLgorICAgICAg ICAgICAgYXV0byB0aW1lciA9IG1ha2VVbmlxdWU8UnVuTG9vcDo6VGltZXI8VUlDbGllbnQ+PihS dW5Mb29wOjptYWluKCksIHRoaXMsICZVSUNsaWVudDo6c2V0V2luZG93RnJhbWVUaW1lckZpcmVk KTsKKyAgICAgICAgICAgIHRpbWVyLT5zZXRQcmlvcml0eShSdW5Mb29wU291cmNlUHJpb3JpdHk6 OlJ1bkxvb3BUaW1lcik7CisgICAgICAgICAgICB0aW1lci0+c3RhcnRPbmVTaG90KDFfcyk7Cisg ICAgICAgICAgICBSdW5Mb29wOjpydW4oKTsKKyAgICAgICAgICAgIHRpbWVyID0gbnVsbHB0cjsK KyAgICAgICAgICAgIGdfc2lnbmFsX2hhbmRsZXJfZGlzY29ubmVjdCh3aW5kb3csIHNpZ25hbElE KTsKICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICB3ZWJraXRXaW5kb3dQcm9wZXJ0aWVzU2V0 R2VvbWV0cnkod2Via2l0X3dlYl92aWV3X2dldF93aW5kb3dfcHJvcGVydGllcyhtX3dlYlZpZXcp LCAmZ2VvbWV0cnkpOwogI2VuZGlmCg==