202508 2019-10-02 22:40:43 -0700 [GTK] WebGL backed by ANGLE flickers when USE_OPENGL_ES is enabled. 2019-12-18 09:38:27 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 199060 1 changseok changseok bugs-noreply cgarcia cmarcelo commit-queue ews-watchlist kondapallykalyan luiz magomez noam zan oldest_to_newest 1576299 0 changseok 2019-10-02 22:40:43 -0700 This is a series of patches to add ANGLE as webgl backend to the GTK port. This fix needs the patch of Bug 199060 as a pre-condition. In 199060, the change brings ANGLE webgl to gtk port that has glx graphics backend. This bug will handle ANGLE webgl support where ENABLE_GLES is activated. 1594142 1 384482 changseok 2019-11-29 00:40:33 -0800 Created attachment 384482 Patch 1599788 2 384482 zan 2019-12-18 07:17:30 -0800 Comment on attachment 384482 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384482&action=review > Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp:115 > - auto texture = BitmapTextureGL::create(TextureMapperContextAttributes::get(), m_context.m_internalColorFormat); > + auto texture = BitmapTextureGL::create(TextureMapperContextAttributes::get(), flags, m_context.m_internalColorFormat); Ooof, good fix. 1599830 3 384482 changseok 2019-12-18 08:48:29 -0800 Comment on attachment 384482 Patch Thanks for your review! 1599845 4 384482 commit-queue 2019-12-18 09:38:25 -0800 Comment on attachment 384482 Patch Clearing flags on attachment: 384482 Committed r253691: <https://trac.webkit.org/changeset/253691> 1599846 5 commit-queue 2019-12-18 09:38:27 -0800 All reviewed patches have been landed. Closing bug. 384482 2019-11-29 00:40:33 -0800 2019-12-18 09:38:25 -0800 Patch bug-202508-20191129174031.patch text/plain 3578 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzU0NjQ4MzhhNGU3ZDU1 NWI1MmI5MzliYTVjN2VmNTRkY2YzYmZhNy4uNWVjODkzNzAxYmY5ZmMxNjczODVhY2EwMGMyMTI4 MjlmYTE4YWRiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTExLTI5ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2tAd2Via2l0Lm9yZz4KKworICAgICAgICBbR1RLXSBXZWJHTCBi YWNrZWQgYnkgQU5HTEUgZmxpY2tlcnMgd2hlbiBVU0VfT1BFTkdMX0VTIGlzIGVuYWJsZWQuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI1MDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29sb3Ig Zm9ybWF0IGFuZCBpbnRlcm5hbCBvbmUgb2YgQml0bWFwVGV4dHVyZUdMIGNhbm5vdCBiZSBtYXRj aGVkCisgICAgICAgIHdoZXJlIFVTRV9BTkdMRV9XRUJHTCBhbmQgVVNFX09QRU5HTF9FUyBhcmUg ZW5hYmxlZCBzaW11bHRhbmVvdXNseS4KKyAgICAgICAgVGhpcyBjYXVzZXMgdGhlIGZsaWNrZXJp bmcgaXNzdWUgb24gV2ViR0wgc2NlbmUgc2luY2UgaXQgcHJldmVudHMgVGV4dHVyZU1hcHBlcgor ICAgICAgICBmcm9tIHJlY3ljbGluZyBhdmFpbGFibGUgbGF5ZXIgYnVmZmVycyBkdWUgdG8gbWlz bWF0Y2hlZCBjb2xvciBmb3JtYXQuCisgICAgICAgIFdoZW4gQU5HTEVfV0VCR0wgaXMgZW5hYmxl ZCwgdGhlIGludGVybmFsIGNvbG9yIGZvcm1hdCBpcyBzZXQgR0xfUkdCQTguCisgICAgICAgIEhv d2V2ZXIsIHRoYXQgaXMgbm90IGNvbXBhdGlibGUgdG8gR0xFUyB0ZXh0dXJlcy4gVG8gYWRkcmVz cyB0aGlzLAorICAgICAgICBXZSBhbHdheXMgbWFrZSB0aGUgY29sb3IgZm9ybWF0IG9mIEJpdG1h cFRleHR1cmVHTCBHTF9SR0JBLAorICAgICAgICBhbmQgb25seSBzZXQgaXRzIGludGVybmFsIGNv bG9yIGZvcm1hdCB3aXRoIGEgZ2l2ZW4gdmFsdWUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNp bmNlIG5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL25pY29zaWEvdGV4bWFwL05pY29zaWFHQzNETGF5ZXIuY3BwOgorICAgICAgICAoTmljb3Np YTo6R0MzRExheWVyOjpzd2FwQnVmZmVyc0lmTmVlZGVkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvQml0bWFwVGV4dHVyZUdMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJp dG1hcFRleHR1cmVHTDo6Qml0bWFwVGV4dHVyZUdMKToKKwogMjAxOS0xMS0yNiAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIERyb3AgQWN0aXZlRE9NT2JqZWN0Ojpz aG91bGRQcmV2ZW50RW50ZXJpbmdCYWNrRm9yd2FyZENhY2hlX0RFUFJFQ0FURUQoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS90ZXhtYXAvTmlj b3NpYUdDM0RMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9uaWNv c2lhL3RleG1hcC9OaWNvc2lhR0MzRExheWVyLmNwcAppbmRleCAyZGM5MTZkMDgyZGU5YzFjODEy NzRlMjJkZmNiNjU2NzJjNWFhODI4Li5iZGE2NTg4YWY5MjA0YTBhYTBlZmY5OGVmMGMxMGMyMDVl NDliMTIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9uaWNv c2lhL3RleG1hcC9OaWNvc2lhR0MzRExheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9uaWNvc2lhL3RleG1hcC9OaWNvc2lhR0MzRExheWVyLmNwcApAQCAtMTEy LDcgKzExMiw3IEBAIHZvaWQgR0MzRExheWVyOjpzd2FwQnVmZmVyc0lmTmVlZGVkKCkKICAgICAg ICAgc3RkOjp1bmlxdWVfcHRyPFRleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyQnVmZmVyPiBsYXll ckJ1ZmZlcjsKICAgICAgICAgbGF5ZXJCdWZmZXIgPSBwcm94eS5nZXRBdmFpbGFibGVCdWZmZXIo dGV4dHVyZVNpemUsIG1fY29udGV4dC5tX2ludGVybmFsQ29sb3JGb3JtYXQpOwogICAgICAgICBp ZiAoIWxheWVyQnVmZmVyKSB7Ci0gICAgICAgICAgICBhdXRvIHRleHR1cmUgPSBCaXRtYXBUZXh0 dXJlR0w6OmNyZWF0ZShUZXh0dXJlTWFwcGVyQ29udGV4dEF0dHJpYnV0ZXM6OmdldCgpLCBtX2Nv bnRleHQubV9pbnRlcm5hbENvbG9yRm9ybWF0KTsKKyAgICAgICAgICAgIGF1dG8gdGV4dHVyZSA9 IEJpdG1hcFRleHR1cmVHTDo6Y3JlYXRlKFRleHR1cmVNYXBwZXJDb250ZXh0QXR0cmlidXRlczo6 Z2V0KCksIGZsYWdzLCBtX2NvbnRleHQubV9pbnRlcm5hbENvbG9yRm9ybWF0KTsKICAgICAgICAg ICAgIHN0YXRpY19jYXN0PEJpdG1hcFRleHR1cmVHTCY+KHRleHR1cmUuZ2V0KCkpLnNldFBlbmRp bmdDb250ZW50cyhXVEZNb3ZlKGltYWdlKSk7CiAgICAgICAgICAgICBsYXllckJ1ZmZlciA9IG1h a2VVbmlxdWU8VGV4dHVyZU1hcHBlclBsYXRmb3JtTGF5ZXJCdWZmZXI+KFdURk1vdmUodGV4dHVy ZSksIGZsYWdzKTsKICAgICAgICAgfSBlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0bWFwVGV4dHVyZUdMLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRtYXBUZXh0dXJlR0wuY3BwCmluZGV4IDBm YjYzZDk3ODFjMzEwNDljYTk0YzVmZmQ4OGEwOGUyMjdiYjcwNGYuLjY0MmJmMGU5NjAxMDliZDM0 NzYzN2M4ZGMwZmZmNDM4ODQ0ZDYxZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9CaXRtYXBUZXh0dXJlR0wuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRtYXBUZXh0dXJlR0wuY3BwCkBAIC02Mywx MyArNjMsMTQgQEAgQml0bWFwVGV4dHVyZUdMKiB0b0JpdG1hcFRleHR1cmVHTChCaXRtYXBUZXh0 dXJlKiB0ZXh0dXJlKQogCiBCaXRtYXBUZXh0dXJlR0w6OkJpdG1hcFRleHR1cmVHTChjb25zdCBU ZXh0dXJlTWFwcGVyQ29udGV4dEF0dHJpYnV0ZXMmIGNvbnRleHRBdHRyaWJ1dGVzLCBjb25zdCBG bGFncywgR0xpbnQgaW50ZXJuYWxGb3JtYXQpCiAgICAgOiBtX2NvbnRleHRBdHRyaWJ1dGVzKGNv bnRleHRBdHRyaWJ1dGVzKQorICAgICwgbV9mb3JtYXQoR0xfUkdCQSkKIHsKICAgICBpZiAoaW50 ZXJuYWxGb3JtYXQgIT0gR0xfRE9OVF9DQVJFKSB7Ci0gICAgICAgIG1faW50ZXJuYWxGb3JtYXQg PSBtX2Zvcm1hdCA9IGludGVybmFsRm9ybWF0OworICAgICAgICBtX2ludGVybmFsRm9ybWF0ID0g aW50ZXJuYWxGb3JtYXQ7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBtX2ludGVybmFs Rm9ybWF0ID0gbV9mb3JtYXQgPSBHTF9SR0JBOworICAgIG1faW50ZXJuYWxGb3JtYXQgPSBHTF9S R0JBOwogfQogCiB2b2lkIEJpdG1hcFRleHR1cmVHTDo6ZGlkUmVzZXQoKQo=