202493 2019-10-02 14:04:47 -0700 FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes 2019-10-02 14:20:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1576173 0 keith_miller 2019-10-02 14:04:47 -0700 FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes 1576175 1 380057 keith_miller 2019-10-02 14:07:16 -0700 Created attachment 380057 Patch 1576176 2 380058 keith_miller 2019-10-02 14:08:12 -0700 Created attachment 380058 Patch 1576179 3 380058 saam 2019-10-02 14:12:10 -0700 Comment on attachment 380058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380058&action=review > Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:256 > + if (instruction->opcodeID() == op_get_by_id) { do you want to do the is<OpGetById> instead? 1576185 4 380058 keith_miller 2019-10-02 14:18:50 -0700 Comment on attachment 380058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380058&action=review >> Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:256 >> + if (instruction->opcodeID() == op_get_by_id) { > > do you want to do the is<OpGetById> instead? Sure, why not. 1576186 5 keith_miller 2019-10-02 14:19:42 -0700 Committed r250629: <https://trac.webkit.org/changeset/250629> 1576187 6 webkit-bug-importer 2019-10-02 14:20:18 -0700 <rdar://problem/55924336> 1576188 7 webkit-bug-importer 2019-10-02 14:20:19 -0700 <rdar://problem/55924337> 380057 2019-10-02 14:07:16 -0700 2019-10-02 14:08:09 -0700 Patch bug-202493-20191002170715.patch text/plain 3108 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZDQwYTRkYTIxMjY0NTU4YzM5MmViODFkZDU5NmRmNzk2MTE5ZTM0Li5kYzM2YmM2ZWY0YjJiZTc0 NmNiY2NiNDNhMDg0NDcwOGUxNGFiNzcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0xMC0wMiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGVEwgT1NSIGV4aXQgc2hvdWxkbid0IGJvdGhlciB1cGRhdGluZyBn ZXRfYnlfaWQgYXJyYXkgcHJvZmlsZXMgdGhhdCBoYXZlIGNoYW5nZWQgbW9kZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjQ5MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkgYWRkZWQgdGhpcyBvcHRp bWl6YXRpb24gZm9yIERGRyBidXQgZm9yZ290IHRvIGRvIGl0IGZvciB0aGUgRlRMCisgICAgICAg IGF0IHRoZSBzYW1lIHRpbWUuIFRoaXMgcGF0Y2ggcmVjdGlmaWVzIHRoYXQuCisKKyAgICAgICAg KiBmdGwvRlRMT1NSRXhpdENvbXBpbGVyLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpjb21waWxl U3R1Yik6CisKIDIwMTktMTAtMDIgIFBhdWxvIE1hdG9zICA8cG1hdG9zQGlnYWxpYS5jb20+CiAK ICAgICAgICAgR2FyZGVuaW5nIGJ1aWxkIGZpeDogSGlkZSBzdG9yZTY0L2xvYWQ2NCBmdW5jdGlv bnMgZnJvbSAzMmJpdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExP U1JFeGl0Q29tcGlsZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExPU1JFeGl0 Q29tcGlsZXIuY3BwCmluZGV4IGNmMjA1Y2Q5ZWMwZjgyNGVlM2UwZjVjOTlkMzRlYTc4NzcyZTA5 YzQuLmJmOTZmZGFjOTQ4MjlhNjM5Mjk5ZDkzMDI1Mjg4OWUwMTkxOWVkMTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT1NSRXhpdENvbXBpbGVyLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9TUkV4aXRDb21waWxlci5jcHAKQEAgLTI4LDYg KzI4LDcgQEAKIAogI2lmIEVOQUJMRShGVExfSklUKQogCisjaW5jbHVkZSAiQnl0ZWNvZGVTdHJ1 Y3RzLmgiCiAjaW5jbHVkZSAiREZHT1NSRXhpdENvbXBpbGVyQ29tbW9uLmgiCiAjaW5jbHVkZSAi REZHT1NSRXhpdFByZXBhcmF0aW9uLmgiCiAjaW5jbHVkZSAiRlRMRXhpdEFyZ3VtZW50Rm9yT3Bl cmFuZC5oIgpAQCAtMjQ4LDcgKzI0OSwxNyBAQCBzdGF0aWMgdm9pZCBjb21waWxlU3R1YigKICAg ICAgICAgCiAgICAgICAgIGlmIChleGl0Lm1fa2luZCA9PSBCYWRDYWNoZSB8fCBleGl0Lm1fa2lu ZCA9PSBCYWRJbmRleGluZ1R5cGUpIHsKICAgICAgICAgICAgIENvZGVPcmlnaW4gY29kZU9yaWdp biA9IGV4aXQubV9jb2RlT3JpZ2luRm9yRXhpdFByb2ZpbGU7Ci0gICAgICAgICAgICBpZiAoQXJy YXlQcm9maWxlKiBhcnJheVByb2ZpbGUgPSBqaXQuYmFzZWxpbmVDb2RlQmxvY2tGb3IoY29kZU9y aWdpbiktPmdldEFycmF5UHJvZmlsZShjb2RlT3JpZ2luLmJ5dGVjb2RlSW5kZXgoKSkpIHsKKyAg ICAgICAgICAgIENvZGVCbG9jayogY29kZUJsb2NrID0gaml0LmJhc2VsaW5lQ29kZUJsb2NrRm9y KGNvZGVPcmlnaW4pOworICAgICAgICAgICAgaWYgKEFycmF5UHJvZmlsZSogYXJyYXlQcm9maWxl ID0gY29kZUJsb2NrLT5nZXRBcnJheVByb2ZpbGUoY29kZU9yaWdpbi5ieXRlY29kZUluZGV4KCkp KSB7CisgICAgICAgICAgICAgICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGluc3RydWN0aW9uID0gY29k ZUJsb2NrLT5pbnN0cnVjdGlvbnMoKS5hdChjb2RlT3JpZ2luLmJ5dGVjb2RlSW5kZXgoKSkucHRy KCk7CisgICAgICAgICAgICAgICAgQ0NhbGxIZWxwZXJzOjpKdW1wIHNraXBQcm9maWxlOworICAg ICAgICAgICAgICAgIGlmIChpbnN0cnVjdGlvbi0+b3Bjb2RlSUQoKSA9PSBvcF9nZXRfYnlfaWQp IHsKKyAgICAgICAgICAgICAgICAgICAgYXV0byYgbWV0YWRhdGEgPSBpbnN0cnVjdGlvbi0+YXM8 T3BHZXRCeUlkPigpLm1ldGFkYXRhKGNvZGVCbG9jayk7CisgICAgICAgICAgICAgICAgICAgIGRh dGFMb2dMbigiaGVyZSIpOworICAgICAgICAgICAgICAgICAgICBVTlVTRURfUEFSQU0obWV0YWRh dGEpOworICAgICAgICAgICAgICAgICAgICBza2lwUHJvZmlsZSA9IGppdC5icmFuY2g4KENDYWxs SGVscGVyczo6Tm90RXF1YWwsIENDYWxsSGVscGVyczo6QWJzb2x1dGVBZGRyZXNzKCZtZXRhZGF0 YS5tX21vZGVNZXRhZGF0YS5tb2RlKSwgQ0NhbGxIZWxwZXJzOjpUcnVzdGVkSW1tMzIoc3RhdGlj X2Nhc3Q8dWludDhfdD4oR2V0QnlJZE1vZGU6OkFycmF5TGVuZ3RoKSkpOworICAgICAgICAgICAg ICAgIH0KKwogICAgICAgICAgICAgICAgIGppdC5sb2FkMzIoTWFjcm9Bc3NlbWJsZXI6OkFkZHJl c3MoR1BSSW5mbzo6cmVnVDAsIEpTQ2VsbDo6c3RydWN0dXJlSURPZmZzZXQoKSksIEdQUkluZm86 OnJlZ1QxKTsKICAgICAgICAgICAgICAgICBqaXQuc3RvcmUzMihHUFJJbmZvOjpyZWdUMSwgYXJy YXlQcm9maWxlLT5hZGRyZXNzT2ZMYXN0U2VlblN0cnVjdHVyZUlEKCkpOwogCkBAIC0yNjYsNiAr Mjc3LDkgQEAgc3RhdGljIHZvaWQgY29tcGlsZVN0dWIoCiAgICAgICAgICAgICAgICAgaml0Lmxz aGlmdDMyKEdQUkluZm86OnJlZ1QxLCBHUFJJbmZvOjpyZWdUMik7CiAgICAgICAgICAgICAgICAg c3RvcmVBcnJheU1vZGVzLmxpbmsoJmppdCk7CiAgICAgICAgICAgICAgICAgaml0Lm9yMzIoR1BS SW5mbzo6cmVnVDIsIE1hY3JvQXNzZW1ibGVyOjpBYnNvbHV0ZUFkZHJlc3MoYXJyYXlQcm9maWxl LT5hZGRyZXNzT2ZBcnJheU1vZGVzKCkpKTsKKworICAgICAgICAgICAgICAgIGlmIChza2lwUHJv ZmlsZS5pc1NldCgpKQorICAgICAgICAgICAgICAgICAgICBza2lwUHJvZmlsZS5saW5rKCZqaXQp OwogICAgICAgICAgICAgfQogICAgICAgICB9CiAK 380058 2019-10-02 14:08:12 -0700 2019-10-02 14:20:04 -0700 Patch bug-202493-20191002170811.patch text/plain 3023 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZDQwYTRkYTIxMjY0NTU4YzM5MmViODFkZDU5NmRmNzk2MTE5ZTM0Li5kYzM2YmM2ZWY0YjJiZTc0 NmNiY2NiNDNhMDg0NDcwOGUxNGFiNzcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0xMC0wMiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGVEwgT1NSIGV4aXQgc2hvdWxkbid0IGJvdGhlciB1cGRhdGluZyBn ZXRfYnlfaWQgYXJyYXkgcHJvZmlsZXMgdGhhdCBoYXZlIGNoYW5nZWQgbW9kZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjQ5MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkgYWRkZWQgdGhpcyBvcHRp bWl6YXRpb24gZm9yIERGRyBidXQgZm9yZ290IHRvIGRvIGl0IGZvciB0aGUgRlRMCisgICAgICAg IGF0IHRoZSBzYW1lIHRpbWUuIFRoaXMgcGF0Y2ggcmVjdGlmaWVzIHRoYXQuCisKKyAgICAgICAg KiBmdGwvRlRMT1NSRXhpdENvbXBpbGVyLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpjb21waWxl U3R1Yik6CisKIDIwMTktMTAtMDIgIFBhdWxvIE1hdG9zICA8cG1hdG9zQGlnYWxpYS5jb20+CiAK ICAgICAgICAgR2FyZGVuaW5nIGJ1aWxkIGZpeDogSGlkZSBzdG9yZTY0L2xvYWQ2NCBmdW5jdGlv bnMgZnJvbSAzMmJpdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExP U1JFeGl0Q29tcGlsZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExPU1JFeGl0 Q29tcGlsZXIuY3BwCmluZGV4IGNmMjA1Y2Q5ZWMwZjgyNGVlM2UwZjVjOTlkMzRlYTc4NzcyZTA5 YzQuLjcxMTJhZGFjMmYyNTdhYmU0Yjg4MTkyODJmMGYzZjIwZjkxYWUyYjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT1NSRXhpdENvbXBpbGVyLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9TUkV4aXRDb21waWxlci5jcHAKQEAgLTI4LDYg KzI4LDcgQEAKIAogI2lmIEVOQUJMRShGVExfSklUKQogCisjaW5jbHVkZSAiQnl0ZWNvZGVTdHJ1 Y3RzLmgiCiAjaW5jbHVkZSAiREZHT1NSRXhpdENvbXBpbGVyQ29tbW9uLmgiCiAjaW5jbHVkZSAi REZHT1NSRXhpdFByZXBhcmF0aW9uLmgiCiAjaW5jbHVkZSAiRlRMRXhpdEFyZ3VtZW50Rm9yT3Bl cmFuZC5oIgpAQCAtMjQ4LDcgKzI0OSwxNSBAQCBzdGF0aWMgdm9pZCBjb21waWxlU3R1YigKICAg ICAgICAgCiAgICAgICAgIGlmIChleGl0Lm1fa2luZCA9PSBCYWRDYWNoZSB8fCBleGl0Lm1fa2lu ZCA9PSBCYWRJbmRleGluZ1R5cGUpIHsKICAgICAgICAgICAgIENvZGVPcmlnaW4gY29kZU9yaWdp biA9IGV4aXQubV9jb2RlT3JpZ2luRm9yRXhpdFByb2ZpbGU7Ci0gICAgICAgICAgICBpZiAoQXJy YXlQcm9maWxlKiBhcnJheVByb2ZpbGUgPSBqaXQuYmFzZWxpbmVDb2RlQmxvY2tGb3IoY29kZU9y aWdpbiktPmdldEFycmF5UHJvZmlsZShjb2RlT3JpZ2luLmJ5dGVjb2RlSW5kZXgoKSkpIHsKKyAg ICAgICAgICAgIENvZGVCbG9jayogY29kZUJsb2NrID0gaml0LmJhc2VsaW5lQ29kZUJsb2NrRm9y KGNvZGVPcmlnaW4pOworICAgICAgICAgICAgaWYgKEFycmF5UHJvZmlsZSogYXJyYXlQcm9maWxl ID0gY29kZUJsb2NrLT5nZXRBcnJheVByb2ZpbGUoY29kZU9yaWdpbi5ieXRlY29kZUluZGV4KCkp KSB7CisgICAgICAgICAgICAgICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGluc3RydWN0aW9uID0gY29k ZUJsb2NrLT5pbnN0cnVjdGlvbnMoKS5hdChjb2RlT3JpZ2luLmJ5dGVjb2RlSW5kZXgoKSkucHRy KCk7CisgICAgICAgICAgICAgICAgQ0NhbGxIZWxwZXJzOjpKdW1wIHNraXBQcm9maWxlOworICAg ICAgICAgICAgICAgIGlmIChpbnN0cnVjdGlvbi0+b3Bjb2RlSUQoKSA9PSBvcF9nZXRfYnlfaWQp IHsKKyAgICAgICAgICAgICAgICAgICAgYXV0byYgbWV0YWRhdGEgPSBpbnN0cnVjdGlvbi0+YXM8 T3BHZXRCeUlkPigpLm1ldGFkYXRhKGNvZGVCbG9jayk7CisgICAgICAgICAgICAgICAgICAgIHNr aXBQcm9maWxlID0gaml0LmJyYW5jaDgoQ0NhbGxIZWxwZXJzOjpOb3RFcXVhbCwgQ0NhbGxIZWxw ZXJzOjpBYnNvbHV0ZUFkZHJlc3MoJm1ldGFkYXRhLm1fbW9kZU1ldGFkYXRhLm1vZGUpLCBDQ2Fs bEhlbHBlcnM6OlRydXN0ZWRJbW0zMihzdGF0aWNfY2FzdDx1aW50OF90PihHZXRCeUlkTW9kZTo6 QXJyYXlMZW5ndGgpKSk7CisgICAgICAgICAgICAgICAgfQorCiAgICAgICAgICAgICAgICAgaml0 LmxvYWQzMihNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhHUFJJbmZvOjpyZWdUMCwgSlNDZWxsOjpz dHJ1Y3R1cmVJRE9mZnNldCgpKSwgR1BSSW5mbzo6cmVnVDEpOwogICAgICAgICAgICAgICAgIGpp dC5zdG9yZTMyKEdQUkluZm86OnJlZ1QxLCBhcnJheVByb2ZpbGUtPmFkZHJlc3NPZkxhc3RTZWVu U3RydWN0dXJlSUQoKSk7CiAKQEAgLTI2Niw2ICsyNzUsOSBAQCBzdGF0aWMgdm9pZCBjb21waWxl U3R1YigKICAgICAgICAgICAgICAgICBqaXQubHNoaWZ0MzIoR1BSSW5mbzo6cmVnVDEsIEdQUklu Zm86OnJlZ1QyKTsKICAgICAgICAgICAgICAgICBzdG9yZUFycmF5TW9kZXMubGluaygmaml0KTsK ICAgICAgICAgICAgICAgICBqaXQub3IzMihHUFJJbmZvOjpyZWdUMiwgTWFjcm9Bc3NlbWJsZXI6 OkFic29sdXRlQWRkcmVzcyhhcnJheVByb2ZpbGUtPmFkZHJlc3NPZkFycmF5TW9kZXMoKSkpOwor CisgICAgICAgICAgICAgICAgaWYgKHNraXBQcm9maWxlLmlzU2V0KCkpCisgICAgICAgICAgICAg ICAgICAgIHNraXBQcm9maWxlLmxpbmsoJmppdCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0K IAo=