202492 2019-10-02 13:53:37 -0700 DoubleToStringConverter::ToExponential() should null terminate its string. 2019-10-02 20:21:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo commit-queue dbates ews-watchlist fpizlo webkit-bug-importer ysuzuki oldest_to_newest 1576165 0 mark.lam 2019-10-02 13:53:37 -0700 <rdar://problem/55907708> 1576172 1 380056 mark.lam 2019-10-02 14:04:03 -0700 Created attachment 380056 proposed patch. 1576217 2 380056 mark.lam 2019-10-02 15:34:59 -0700 Comment on attachment 380056 proposed patch. Thanks for the review. Landing now. 1576236 3 380056 commit-queue 2019-10-02 16:21:04 -0700 Comment on attachment 380056 proposed patch. Clearing flags on attachment: 380056 Committed r250636: <https://trac.webkit.org/changeset/250636> 1576237 4 commit-queue 2019-10-02 16:21:06 -0700 All reviewed patches have been landed. Closing bug. 1576280 5 ysuzuki 2019-10-02 20:21:00 -0700 Is it better to upstream this change to https://github.com/google/double-conversion ? 380056 2019-10-02 14:04:03 -0700 2019-10-02 16:21:04 -0700 proposed patch. bug-202492.patch text/plain 4038 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTA2MjUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTEwLTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBEb3VibGVUb1N0cmluZ0NvbnZlcnRlcjo6VG9FeHBvbmVudGlhbCgpIHNo b3VsZCBudWxsIHRlcm1pbmF0ZSBpdHMgc3RyaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNDkyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81 NTkwNzcwOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHN0cmVzcy9kdG9hLUFkZFN1YnN0cmluZy1zaG91bGQtdXNlcy1zdHJubGVuLWluLWFzc2Vy dGlvbi5qczogQWRkZWQuCisKIDIwMTktMTAtMDEgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBs ZS5jb20+CiAKICAgICAgICAgT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZSBzaG91bGRuJ3Qg aW5zZXJ0IGhpbnRzIGZvciBhbGxvY2F0aW9ucyB3aGljaCBhcmUgbm8gbG9uZ2VyIHZhbGlkCklu ZGV4OiBKU1Rlc3RzL3N0cmVzcy9kdG9hLUFkZFN1YnN0cmluZy1zaG91bGQtdXNlcy1zdHJubGVu LWluLWFzc2VydGlvbi5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kdG9hLUFkZFN1 YnN0cmluZy1zaG91bGQtdXNlcy1zdHJubGVuLWluLWFzc2VydGlvbi5qcwkobm9uZXhpc3RlbnQp CisrKyBKU1Rlc3RzL3N0cmVzcy9kdG9hLUFkZFN1YnN0cmluZy1zaG91bGQtdXNlcy1zdHJubGVu LWluLWFzc2VydGlvbi5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDUgQEAKKy8vQCBydW5E ZWZhdWx0CisKK2Z1bmN0aW9uIGZvbygpIHt9Citmb28oKDApLnRvRXhwb25lbnRpYWwoMCkpOwor KDApLnRvRXhwb25lbnRpYWwoOTUpOwpJbmRleDogU291cmNlL1dURi9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dURi9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MDYxNCkKKysrIFNvdXJj ZS9XVEYvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMTAt MDIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIERvdWJsZVRvU3Ry aW5nQ29udmVydGVyOjpUb0V4cG9uZW50aWFsKCkgc2hvdWxkIG51bGwgdGVybWluYXRlIGl0cyBz dHJpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDI0OTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1OTA3NzA4PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL2R0b2EvZG91YmxlLWNvbnZl cnNpb24uY2M6CisgICAgICAgIC0gRG91YmxlVG9TdHJpbmdDb252ZXJ0ZXI6OkRvdWJsZVRvQXNj aWkoKSBhbHdheXMgcHJvZHVjZXMgYSBudWxsIHRlcm1pbmF0ZWQKKyAgICAgICAgICBzdHJpbmcu ICBGaXhlZCB0aGUgcGFkZGluZyBsb29wIGluIERvdWJsZVRvU3RyaW5nQ29udmVydGVyOjpUb0V4 cG9uZW50aWFsKCkKKyAgICAgICAgICB0aGF0IGZvbGxvd3MgaXQgdG8gYWxzbyBrZWVwIHRoZSBu dWxsIHRlcm1pbmF0b3IuCisKKyAgICAgICAgKiB3dGYvZHRvYS91dGlscy5oOgorICAgICAgICAo V1RGOjpkb3VibGVfY29udmVyc2lvbjo6U3RyaW5nQnVpbGRlcjo6QWRkU3Vic3RyaW5nKToKKyAg ICAgICAgLSBBbiBhc3NlcnRpb24gaW4gaGVyZSB3YXMgdXNpbmcgc3RybGVuKCkgd2hpY2ggaW5k aWNhdGVzIHRoYXQgaXQgZXhwZWN0cyBhIG51bGwKKyAgICAgICAgICB0ZXJtaW5hdG9yIGluIHRo ZSBpbmNvbWluZyBzdHJpbmcuICBIb3dldmVyLCB0aGlzIHJlcXVpcmVtZW50IGlzIHRvbyByZXN0 cmljdGl2ZS4KKyAgICAgICAgICBUaGUgY29kZSBkb2VzIG5vdCBhY3R1YWxseSBkZXBlbmQgb24g dGhlIHN0cmluZyBoYXZpbmcgYSBudWxsIHRlcm1pbmF0b3IsIG9ubHkKKyAgICAgICAgICB0aGF0 IGEgbnVsbCB0ZXJtaW5hdG9yIGRvZXMgbm90IG1hbmlmZXN0IGJlZm9yZSB0aGUgbnRoIGNoYXJh Y3Rlci4gIENoYW5nZWQKKyAgICAgICAgICB0aGUgYXNzZXJ0aW9uIHRvIHVzZSBzdHJubGVuKCkg aW5zdGVhZCB0byByZWZsZWN0IHRoaXMuCisKIDIwMTktMTAtMDIgIFphbiBEb2JlcnNlayAgPHpk b2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtOaWNvc2lhXSBFbmFibGUgYXN5bmMgc2Ny b2xsaW5nIGF0IGJ1aWxkLXRpbWUgZm9yIE5pY29zaWEtdXNpbmcgcG9ydHMKSW5kZXg6IFNvdXJj ZS9XVEYvd3RmL2R0b2EvZG91YmxlLWNvbnZlcnNpb24uY2MKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dURi93dGYvZHRvYS9kb3VibGUtY29udmVyc2lvbi5jYwkocmV2aXNpb24gMjUwNjE0KQorKysg U291cmNlL1dURi93dGYvZHRvYS9kb3VibGUtY29udmVyc2lvbi5jYwkod29ya2luZyBjb3B5KQpA QCAtMjY3LDEwICsyNjcsMTIgQEAgYm9vbCBEb3VibGVUb1N0cmluZ0NvbnZlcnRlcjo6VG9FeHBv bmVudAogICAgICAgICAgICAgICAgICAgJnNpZ24sICZkZWNpbWFsX3JlcF9sZW5ndGgsICZkZWNp bWFsX3BvaW50KTsKICAgICBBU1NFUlQoZGVjaW1hbF9yZXBfbGVuZ3RoIDw9IHJlcXVlc3RlZF9k aWdpdHMgKyAxKTsKIAotICAgIGZvciAoaW50IGkgPSBkZWNpbWFsX3JlcF9sZW5ndGg7IGkgPCBy ZXF1ZXN0ZWRfZGlnaXRzICsgMTsgKytpKSB7Ci0gICAgICBkZWNpbWFsX3JlcFtpXSA9ICcwJzsK KyAgICBpZiAoZGVjaW1hbF9yZXBfbGVuZ3RoIDwgcmVxdWVzdGVkX2RpZ2l0cyArIDEpIHsKKyAg ICAgIGZvciAoaW50IGkgPSBkZWNpbWFsX3JlcF9sZW5ndGg7IGkgPCByZXF1ZXN0ZWRfZGlnaXRz ICsgMTsgKytpKQorICAgICAgICBkZWNpbWFsX3JlcFtpXSA9ICcwJzsKKyAgICAgIGRlY2ltYWxf cmVwX2xlbmd0aCA9IHJlcXVlc3RlZF9kaWdpdHMgKyAxOworICAgICAgZGVjaW1hbF9yZXBbZGVj aW1hbF9yZXBfbGVuZ3RoXSA9ICdcMCc7CiAgICAgfQotICAgIGRlY2ltYWxfcmVwX2xlbmd0aCA9 IHJlcXVlc3RlZF9kaWdpdHMgKyAxOwogICB9CiAKICAgYm9vbCB1bmlxdWVfemVybyA9ICgoZmxh Z3NfICYgVU5JUVVFX1pFUk8pICE9IDApOwpJbmRleDogU291cmNlL1dURi93dGYvZHRvYS91dGls cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL2R0b2EvdXRpbHMuaAkocmV2aXNpb24g MjUwNjE0KQorKysgU291cmNlL1dURi93dGYvZHRvYS91dGlscy5oCSh3b3JraW5nIGNvcHkpCkBA IC0yNzEsNyArMjcxLDcgQEAgY2xhc3MgU3RyaW5nQnVpbGRlciB7CiAgIC8vIGJ1aWxkZXIuIFRo ZSBpbnB1dCBzdHJpbmcgbXVzdCBoYXZlIGVub3VnaCBjaGFyYWN0ZXJzLgogICB2b2lkIEFkZFN1 YnN0cmluZyhjb25zdCBjaGFyKiBzLCBpbnQgbikgewogICAgIEFTU0VSVCghaXNfZmluYWxpemVk KCkgJiYgcG9zaXRpb25fICsgbiA8IGJ1ZmZlcl8ubGVuZ3RoKCkpOwotICAgIEFTU0VSVF9XSVRI X1NFQ1VSSVRZX0lNUExJQ0FUSU9OKHN0YXRpY19jYXN0PHNpemVfdD4obikgPD0gc3RybGVuKHMp KTsKKyAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihzdGF0aWNfY2FzdDxzaXpl X3Q+KG4pIDw9IHN0cm5sZW4ocywgbikpOwogICAgIG1lbW1vdmUoJmJ1ZmZlcl9bcG9zaXRpb25f XSwgcywgbiAqIGtDaGFyU2l6ZSk7CiAgICAgcG9zaXRpb25fICs9IG47CiAgIH0K