20245 2008-07-31 14:24:17 -0700 WinLauncher does not start in WebKit-debug right out of the box. 2008-07-31 15:13:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 stefan.landvogt webkit-unassigned oldest_to_newest 87526 0 stefan.landvogt 2008-07-31 14:24:17 -0700 I build WebKit-debug and to verify that the WebKit.dll is fine, I try to start WinLauncher. This fails at HRESULT hr = CoCreateInstance(CLSID_WebView, 0, CLSCTX_ALL, IID_IWebView, (void**)&gWebView); where hr is returning some error code. With help from aroben I tested the following patch, which worked on my system after a clean build but not after a rebuild of the WinLauncher solution. 87527 1 22587 stefan.landvogt 2008-07-31 14:26:40 -0700 Created attachment 22587 Just following arobens directions for fixing WinLauncher. 87528 2 22587 aroben 2008-07-31 14:29:41 -0700 Comment on attachment 22587 Just following arobens directions for fixing WinLauncher. Thanks for the patch! Two changes are needed before we can land this: 1. The change you made to the project file needs to be made for all configurations. You should choose "All Configurations" from the "Configuration" drop-down in the "Project Properties" dialog, then make the change. 2. You need to write a ChangeLog entry. See <http://webkit.org/coding/contributing.html> for instructions on how to do so. 87529 3 22588 stefan.landvogt 2008-07-31 14:39:08 -0700 Created attachment 22588 Adding the changes to "All Configurations" 87530 4 22589 stefan.landvogt 2008-07-31 14:50:49 -0700 Created attachment 22589 Adding the properties to "all configurations" and add changelog entry 87532 5 22589 aroben 2008-07-31 15:10:00 -0700 Comment on attachment 22589 Adding the properties to "all configurations" and add changelog entry r=me Normally in ChangeLogs we mention the bug that's being fixed, like this: Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of the box <https://bugs.webkit.org/show_bug.cgi?id=20245> Reviewed by NOBODY (OOPS!) I can make this change before landing the patch. Thanks again! 87533 6 aroben 2008-07-31 15:13:11 -0700 Landed in r35500 22587 2008-07-31 14:26:40 -0700 2008-07-31 14:50:49 -0700 Just following arobens directions for fixing WinLauncher. MyExcellentPatch.txt text/plain 730 stefan.landvogt SW5kZXg6IFdlYktpdFRvb2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLnZjcHJvago9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXRUb29scy9XaW5MYXVuY2hlci9XaW5MYXVuY2hlci52Y3Byb2oJKHJldmlz aW9uIDM1NDY3KQorKysgV2ViS2l0VG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIudmNwcm9q CSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNv ZGluZz0iV2luZG93cy0xMjUyIj8+DQogPFZpc3VhbFN0dWRpb1Byb2plY3QNCiAJUHJvamVjdFR5 cGU9IlZpc3VhbCBDKysiDQotCVZlcnNpb249IjguMDAiDQorCVZlcnNpb249IjgsMDAiDQogCU5h bWU9IldpbkxhdW5jaGVyIg0KIAlQcm9qZWN0R1VJRD0iezExNEZDQTExLTIxNkItNEM4Qy05NTdF LTMwQTc1QUU4MDQ0M30iDQogCVJvb3ROYW1lc3BhY2U9IldpbkxhdW5jaGVyIg0KQEAgLTc3LDYg Kzc3LDggQEAKIAkJCS8+DQogCQkJPFRvb2wNCiAJCQkJTmFtZT0iVkNNYW5pZmVzdFRvb2wiDQor CQkJCVR5cGVMaWJyYXJ5RmlsZT0iJChXZWJLaXRPdXRwdXREaXIpXGxpYlxXZWJLaXQudGxiIg0K KwkJCQlDb21wb25lbnRGaWxlTmFtZT0iV2ViS2l0JChXZWJLaXRETExDb25maWdTdWZmaXgpIg0K IAkJCS8+DQogCQkJPFRvb2wNCiAJCQkJTmFtZT0iVkNYRENNYWtlVG9vbCINCg== 22588 2008-07-31 14:39:08 -0700 2008-07-31 14:49:32 -0700 Adding the changes to "All Configurations" MyExcellentPatch.txt text/plain 730 stefan.landvogt SW5kZXg6IFdlYktpdFRvb2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLnZjcHJvago9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXRUb29scy9XaW5MYXVuY2hlci9XaW5MYXVuY2hlci52Y3Byb2oJKHJldmlz aW9uIDM1NDY3KQorKysgV2ViS2l0VG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIudmNwcm9q CSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNv ZGluZz0iV2luZG93cy0xMjUyIj8+DQogPFZpc3VhbFN0dWRpb1Byb2plY3QNCiAJUHJvamVjdFR5 cGU9IlZpc3VhbCBDKysiDQotCVZlcnNpb249IjguMDAiDQorCVZlcnNpb249IjgsMDAiDQogCU5h bWU9IldpbkxhdW5jaGVyIg0KIAlQcm9qZWN0R1VJRD0iezExNEZDQTExLTIxNkItNEM4Qy05NTdF LTMwQTc1QUU4MDQ0M30iDQogCVJvb3ROYW1lc3BhY2U9IldpbkxhdW5jaGVyIg0KQEAgLTc3LDYg Kzc3LDggQEAKIAkJCS8+DQogCQkJPFRvb2wNCiAJCQkJTmFtZT0iVkNNYW5pZmVzdFRvb2wiDQor CQkJCVR5cGVMaWJyYXJ5RmlsZT0iJChXZWJLaXRPdXRwdXREaXIpXGxpYlxXZWJLaXQudGxiIg0K KwkJCQlDb21wb25lbnRGaWxlTmFtZT0iV2ViS2l0JChXZWJLaXRETExDb25maWdTdWZmaXgpIg0K IAkJCS8+DQogCQkJPFRvb2wNCiAJCQkJTmFtZT0iVkNYRENNYWtlVG9vbCINCg== 22589 2008-07-31 14:50:49 -0700 2008-07-31 15:10:00 -0700 Adding the properties to "all configurations" and add changelog entry MyExcellentPatch.txt text/plain 1395 stefan.landvogt SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM1NDk4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKworMjAwOC0wNy0zMSAgU3RlZmFuIExhbmR2b2d0 IDxzdGVmYW4ubGFuZHZvZ3RAZ21haWwuY29tPgorCisgICAgICAgIHJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2luTGF1bmNoZXIvV2luTGF1bmNoZXIudmNwcm9qOiBh ZGRpbmcgdGhlIGZvbGxvd2luZyBwcm9wZXJ0aWVzIHRvCisJV2luTGF1bmNoZXIgPiBQcm9wZXJ0 aWVzID4gTWFuaWZlc3QgVG9vbCA+IElzb2xhdGVkIENPTQorCVR5cGUgTGlicmFyeSBGaWxlOiAk KFdlYktpdE91dHB1dERpcilcbGliXFdlYktpdC50bGIKKwlDb21wb25lbnQgRmlsZSBOYW1lOiBX ZWJLaXQkKFdlYktpdERMTENvbmZpZ1N1ZmZpeCkKKwlEb2luZyB0aGUgY2hhbmdlIG9uICJBbGwg Q29uZmlndXJhdGlvbnMiCisKIDIwMDgtMDctMzEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFdpbmRvd3MgYnVpbGQgYm90IGZpeApJbmRleDogV2ViS2l0VG9vbHMv V2luTGF1bmNoZXIvV2luTGF1bmNoZXIudmNwcm9qCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xz L1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLnZjcHJvagkocmV2aXNpb24gMzU0NjcpCisrKyBXZWJL aXRUb29scy9XaW5MYXVuY2hlci9XaW5MYXVuY2hlci52Y3Byb2oJKHdvcmtpbmcgY29weSkKQEAg LTEsNyArMSw3IEBACiA8P3htbCB2ZXJzaW9uPSIxLjAiIGVuY29kaW5nPSJXaW5kb3dzLTEyNTIi Pz4NCiA8VmlzdWFsU3R1ZGlvUHJvamVjdA0KIAlQcm9qZWN0VHlwZT0iVmlzdWFsIEMrKyINCi0J VmVyc2lvbj0iOC4wMCINCisJVmVyc2lvbj0iOCwwMCINCiAJTmFtZT0iV2luTGF1bmNoZXIiDQog CVByb2plY3RHVUlEPSJ7MTE0RkNBMTEtMjE2Qi00QzhDLTk1N0UtMzBBNzVBRTgwNDQzfSINCiAJ Um9vdE5hbWVzcGFjZT0iV2luTGF1bmNoZXIiDQpAQCAtNzcsNiArNzcsOCBAQAogCQkJLz4NCiAJ CQk8VG9vbA0KIAkJCQlOYW1lPSJWQ01hbmlmZXN0VG9vbCINCisJCQkJVHlwZUxpYnJhcnlGaWxl PSIkKFdlYktpdE91dHB1dERpcilcbGliXFdlYktpdC50bGIiDQorCQkJCUNvbXBvbmVudEZpbGVO YW1lPSJXZWJLaXQkKFdlYktpdERMTENvbmZpZ1N1ZmZpeCkiDQogCQkJLz4NCiAJCQk8VG9vbA0K IAkJCQlOYW1lPSJWQ1hEQ01ha2VUb29sIg0K