202446 2019-10-01 21:44:59 -0700 Web Inspector: REGRESSION(r250149): changing CSS via the Styles details sidebar panel doesn't update the associated resource 2019-10-02 11:50:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 202000 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1575884 0 hi 2019-10-01 21:44:59 -0700 # STEPS TO REPRODUCE: 1. inspect <https://devinrousso.com> 2. select the node matching `body > header > nav > ul > li:nth-child(1) > a` 3. modify the `display: inline-block;` property of the rule with the selector `a.roll` to be something else (e.g. `display: block;`) 4. click on the source code location link next to the selector (e.g. 'common.css:1:638`) => FAIL: the rule with the selector `a.roll` still shows `display: inline-block;` in the text editor 5. go back to the Elements Tab => FAIL: the property changed in step #3 has changed back to `display: inline-block;` 6. repeat steps #3 and #4 => FAIL: the rule with the selector `a.roll` still shows `display: inline-block;` in the text editor 7. go back to the Elements Tab => PASS: the property changed in step #6 still shows `display: block;` 8. go back to the Resources/Sources Tab 9. edit the same property as step #3/#6 (it should show as `display: inline-block;` right now) to a different value (e.g. `display: flex;`) 10. go back to the Elements Tab => PASS: the property now shows `display: flex;` and any further edits (e.g. step #3/#6) correctly propagate to the associated resource 1575885 1 hi 2019-10-01 21:46:27 -0700 I'm guessing that this is related to: - <https://webkit.org/b/202000> Web Inspector: Remove BranchManager in favor of just using currentRevision 1576009 2 380027 hi 2019-10-02 08:53:24 -0700 Created attachment 380027 Patch 1576048 3 380027 joepeck 2019-10-02 10:39:43 -0700 Comment on attachment 380027 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380027&action=review r=me. Layout Test failures don't appear to be caused by this. > Source/WebInspectorUI/UserInterface/Models/SourceCode.js:227 > + if (this._currentRevision === this._originalRevision) > + this.currentRevision = this._originalRevision.copy(); Hmm, should we just do this in the constructor (and LocalResource constructor)? I tried to lazy avoid the copy, but if they share the same string it ins't really a "copy" so we would probably be fine. 1576065 4 380027 hi 2019-10-02 11:05:52 -0700 Comment on attachment 380027 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380027&action=review >> Source/WebInspectorUI/UserInterface/Models/SourceCode.js:227 >> + this.currentRevision = this._originalRevision.copy(); > > Hmm, should we just do this in the constructor (and LocalResource constructor)? I tried to lazy avoid the copy, but if they share the same string it ins't really a "copy" so we would probably be fine. I don't think we would want to do this in the `constructor`, due to issues in all cases other than this bug, as we wouldn't have set the `content` of the `_originalRevision`. This isn't a "problem" right now though, as we don't really make use of `_originalRevision` (which would be through `WI.Revision.prototype.revert()`). This is actually more of a "problem" for style sheets if you follow the same steps as described in this bug, in that the `content` of the `_originalRevision` would never get set (style sheets override `revisionForRequestedContent` to be the `_currentRevision`, so we never even touch the `_originalRevision`). 1576090 5 380027 commit-queue 2019-10-02 11:49:59 -0700 Comment on attachment 380027 Patch Clearing flags on attachment: 380027 Committed r250618: <https://trac.webkit.org/changeset/250618> 1576091 6 commit-queue 2019-10-02 11:50:00 -0700 All reviewed patches have been landed. Closing bug. 1576092 7 webkit-bug-importer 2019-10-02 11:50:16 -0700 <rdar://problem/55918288> 380027 2019-10-02 08:53:24 -0700 2019-10-02 11:49:59 -0700 Patch bug-202446-20191002115323.patch text/plain 3910 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ1OTJhMzJlZDA4ODBkZDRiMDdhODI5NGVlZDA2 YTQ5Yzg3NGIzMjEuLjJlY2U0YjhkZDQzYTRkZmE3YjE4ZjVjMWY1YTQyZGFjM2JhZjc4NDYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE5LTEwLTAyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNTAxNDkpOiBjaGFuZ2luZyBDU1MgdmlhIHRoZSBTdHlsZXMgZGV0YWlscyBz aWRlYmFyIHBhbmVsIGRvZXNuJ3QgdXBkYXRlIHRoZSBhc3NvY2lhdGVkIHJlc291cmNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI0NDYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHVwZGF0aW5n IHRoZSB0ZXh0IG9mIGEgYFdJLkNTU1Byb3BlcnR5YCAob3IgdGhlIHNlbGVjdG9yIG9mIGEgYFdJ LkNTU1J1bGVgKSBpcyB1cGRhdGVkLAorICAgICAgICBXZWIgSW5zcGVjdG9yIHdpbGwgdXBkYXRl IHRoZSBiYWNrZW5kIHN0eWxlIHNoZWV0LCB3aGljaCB3aWxsIG5vdGlmeSB0aGUgYFdJLkNTU01h bmFnZXJgIG9mCisgICAgICAgIHRoZSBjaGFuZ2UsIHdpdGhvdXQgZXZlciBnb2luZyB0aHJvdWdo IHRoZSBhc3NvY2lhdGVkIGBXSS5Tb3VyY2VDb2RlYC4gYFdJLkNTU01hbmFnZXJgIHRoZW4KKyAg ICAgICAgdXBkYXRlcyB0aGUgY29udGVudCBvZiB0aGUgYFdJLlNvdXJjZUNvZGVgIHRvIHJlZmxl Y3QgdGhlc2UgY2hhbmdlcywgYnV0IGF0IHRoYXQgcG9pbnQgdGhlCisgICAgICAgIGBXSS5Tb3Vy Y2VDb2RlYCBoYWRuJ3QgeWV0ICJtb3ZlZCIgaXQncyBgY3VycmVudFJldmlzaW9uYCBmb3J3YXJk IG9mIGl0J3MgYG9yaWdpbmFsUmV2aXNpb25gCisgICAgICAgIHdoaWNoIG1lYW5zIGl0IHdvdWxk IGdldCBvdmVycmlkZGVuIHRoZSBmaXJzdCB0aW1lIHRoZSBgV0kuU291cmNlQ29kZWAgdXBkYXRl cyBpdHNlbGYuCisKKyAgICAgICAgTW9kaWZ5IGBXSS5Tb3VyY2VDb2RlYCBzdWNoIHRoYXQgZXZl cnkgcGF0aCB0byBnZXQgdGhlIGBjdXJyZW50UmV2aXNpb25gIGVuc3VyZXMgdGhhdCBpdCBpcwor ICAgICAgICAibW92ZWQiIGZvcndhcmQgYmVmb3JlIHRoZSBgV0kuU291cmNlQ29kZVJldmlzaW9u YCB2YWx1ZSBpcyByZXR1cm5lZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1Nv dXJjZUNvZGUuanM6CisgICAgICAgIChXSS5Tb3VyY2VDb2RlLnByb3RvdHlwZS5nZXQgY3VycmVu dFJldmlzaW9uKToKKyAgICAgICAgKFdJLlNvdXJjZUNvZGUucHJvdG90eXBlLmdldCBjb250ZW50 KToKKyAgICAgICAgKFdJLlNvdXJjZUNvZGUucHJvdG90eXBlLnJldmlzaW9uQ29udGVudERpZENo YW5nZSk6CisgICAgICAgIChXSS5Tb3VyY2VDb2RlLnByb3RvdHlwZS5faW5pdGlhbGl6ZUN1cnJl bnRSZXZpc2lvbklmTmVlZGVkKTogQWRkZWQuCisgICAgICAgIChXSS5Tb3VyY2VDb2RlLnByb3Rv dHlwZS5fcHJvY2Vzc0NvbnRlbnQpOgorCiAyMDE5LTEwLTAxICBEZXZpbiBSb3Vzc28gIDxkcm91 c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTb3VyY2VzOiBjbGlja2lu ZyBvbiBhIGJyZWFrcG9pbnQgY2hhbmdlcyB0aGUgcGF0aCBjb21wb25lbnRzIHRvIG5vdCBtYXRj aCB0aGUgc2NyaXB0J3MgcGF0aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZUNvZGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Nb2RlbHMvU291cmNlQ29kZS5qcwppbmRleCAzYmRiNWY4ODJlNWJkZGY4 ZmJkNzc5YTZjYWI0NWU0MWE1MTBkN2Y5Li42MDI3OGJlZjg3NmU2ZTJmZDI2NTA5N2IxYTY1N2Mw ZDgwM2ZmMjA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Nb2RlbHMvU291cmNlQ29kZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Nb2RlbHMvU291cmNlQ29kZS5qcwpAQCAtNjYsNiArNjYsNyBAQCBXSS5Tb3VyY2VD b2RlID0gY2xhc3MgU291cmNlQ29kZSBleHRlbmRzIFdJLk9iamVjdAogCiAgICAgZ2V0IGN1cnJl bnRSZXZpc2lvbigpCiAgICAgeworICAgICAgICB0aGlzLl9pbml0aWFsaXplQ3VycmVudFJldmlz aW9uSWZOZWVkZWQoKTsKICAgICAgICAgcmV0dXJuIHRoaXMuX2N1cnJlbnRSZXZpc2lvbjsKICAg ICB9CiAKQEAgLTg2LDcgKzg3LDcgQEAgV0kuU291cmNlQ29kZSA9IGNsYXNzIFNvdXJjZUNvZGUg ZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgIGdldCBjb250ZW50KCkKICAgICB7Ci0gICAgICAgIHJl dHVybiB0aGlzLl9jdXJyZW50UmV2aXNpb24uY29udGVudDsKKyAgICAgICAgcmV0dXJuIHRoaXMu Y3VycmVudFJldmlzaW9uLmNvbnRlbnQ7CiAgICAgfQogCiAgICAgZ2V0IHVybCgpCkBAIC0xODAs NyArMTgxLDcgQEAgV0kuU291cmNlQ29kZSA9IGNsYXNzIFNvdXJjZUNvZGUgZXh0ZW5kcyBXSS5P YmplY3QKICAgICAgICAgaWYgKHRoaXMuX2lnbm9yZVJldmlzaW9uQ29udGVudERpZENoYW5nZUV2 ZW50KQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGlmIChyZXZpc2lvbiAhPT0gdGhp cy5fY3VycmVudFJldmlzaW9uKQorICAgICAgICBpZiAocmV2aXNpb24gIT09IHRoaXMuY3VycmVu dFJldmlzaW9uKQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIHRoaXMuaGFuZGxlQ3Vy cmVudFJldmlzaW9uQ29udGVudENoYW5nZSgpOwpAQCAtMjIwLDYgKzIyMSwxMiBAQCBXSS5Tb3Vy Y2VDb2RlID0gY2xhc3MgU291cmNlQ29kZSBleHRlbmRzIFdJLk9iamVjdAogCiAgICAgLy8gUHJp dmF0ZQogCisgICAgX2luaXRpYWxpemVDdXJyZW50UmV2aXNpb25JZk5lZWRlZCgpCisgICAgewor ICAgICAgICBpZiAodGhpcy5fY3VycmVudFJldmlzaW9uID09PSB0aGlzLl9vcmlnaW5hbFJldmlz aW9uKQorICAgICAgICAgICAgdGhpcy5jdXJyZW50UmV2aXNpb24gPSB0aGlzLl9vcmlnaW5hbFJl dmlzaW9uLmNvcHkoKTsKKyAgICB9CisKICAgICBfcHJvY2Vzc0NvbnRlbnQocGFyYW1ldGVycykK ICAgICB7CiAgICAgICAgIC8vIERpZmZlcmVudCBiYWNrZW5kIEFQSXMgcmV0dXJuIG9uZSBvZiBg Y29udGVudCwgYGJvZHlgLCBgdGV4dGAsIG9yIGBzY3JpcHRTb3VyY2VgLgpAQCAtMjM3LDggKzI0 NCw3IEBAIFdJLlNvdXJjZUNvZGUgPSBjbGFzcyBTb3VyY2VDb2RlIGV4dGVuZHMgV0kuT2JqZWN0 CiAgICAgICAgIHJldmlzaW9uLmNvbnRlbnQgPSBjb250ZW50IHx8IG51bGw7CiAgICAgICAgIHRo aXMuX2lnbm9yZVJldmlzaW9uQ29udGVudERpZENoYW5nZUV2ZW50ID0gZmFsc2U7CiAKLSAgICAg ICAgaWYgKHRoaXMuX2N1cnJlbnRSZXZpc2lvbiA9PT0gdGhpcy5fb3JpZ2luYWxSZXZpc2lvbikK LSAgICAgICAgICAgIHRoaXMuY3VycmVudFJldmlzaW9uID0gdGhpcy5fb3JpZ2luYWxSZXZpc2lv bi5jb3B5KCk7CisgICAgICAgIHRoaXMuX2luaXRpYWxpemVDdXJyZW50UmV2aXNpb25JZk5lZWRl ZCgpOwogCiAgICAgICAgIC8vIEZJWE1FOiBSZXR1cm5pbmcgdGhlIGNvbnRlbnQgaW4gdGhpcyBw cm9taXNlIGlzIG1pc2xlYWRpbmcuIEl0IG1heSBub3QgYmUgY3VycmVudCBjb250ZW50CiAgICAg ICAgIC8vIG5vdywgYW5kIGl0IG1heSBiZWNvbWUgb3V0LWRhdGVkIGxhdGVyIG9uLiBXZSBzaG91 bGQgZHJvcCBjb250ZW50IGZyb20gdGhpcyBwcm9taXNlCg==