202434 2019-10-01 14:37:12 -0700 XMLHttpRequest sometimes prevents pages from entering the back/forward cache 2019-10-03 14:29:51 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 202293 1 cdumez cdumez achristensen beidson commit-queue ggaren thorton webkit-bug-importer youennf oldest_to_newest 1575747 0 cdumez 2019-10-01 14:37:12 -0700 XMLHttpRequest sometimes prevents pages from entering the back/forward cache. 1575748 1 webkit-bug-importer 2019-10-01 14:37:38 -0700 <rdar://problem/55890340> 1575777 2 379958 cdumez 2019-10-01 15:44:32 -0700 Created attachment 379958 Patch 1576577 3 379958 ggaren 2019-10-03 13:44:29 -0700 Comment on attachment 379958 Patch r=me Isn't it also the case that the document refuses to cache if it has not fired the load event yet? It seems like tight coupling for an XHR object to maintain invariants on behalf of the document. 1576578 4 cdumez 2019-10-03 13:46:02 -0700 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 379958 [details] > Patch > > r=me > > Isn't it also the case that the document refuses to cache if it has not > fired the load event yet? It seems like tight coupling for an XHR object to > maintain invariants on behalf of the document. It is true for the main frame but not necessarily true for subframes (that were added later on, after the load event had fired in the main frame). 1576582 5 ggaren 2019-10-03 13:48:49 -0700 > > Isn't it also the case that the document refuses to cache if it has not > > fired the load event yet? It seems like tight coupling for an XHR object to > > maintain invariants on behalf of the document. > > It is true for the main frame but not necessarily true for subframes (that > were added later on, after the load event had fired in the main frame). If a subframe has not loaded yet, and we cancel its loads in order to enter the page cache, doesn't that present the same concern -- that the subframe document will fire its load event while in the page cache? 1576585 6 cdumez 2019-10-03 13:51:37 -0700 (In reply to Geoffrey Garen from comment #5) > > > Isn't it also the case that the document refuses to cache if it has not > > > fired the load event yet? It seems like tight coupling for an XHR object to > > > maintain invariants on behalf of the document. > > > > It is true for the main frame but not necessarily true for subframes (that > > were added later on, after the load event had fired in the main frame). > > If a subframe has not loaded yet, and we cancel its loads in order to enter > the page cache, doesn't that present the same concern -- that the subframe > document will fire its load event while in the page cache? No, the load event would fire before entering PageCache, which is when we stop the loads. The issue here is that XMLHttpRequest stops its load in the "suspend" function (where script is not allowed to run). This can be refactored further so that XMLHttpRequest no longer stops its loads in suspend though. I can look into it in a follow-up. 1576590 7 ggaren 2019-10-03 13:57:58 -0700 Sounds good. 1576602 8 379958 commit-queue 2019-10-03 14:29:50 -0700 Comment on attachment 379958 Patch Clearing flags on attachment: 379958 Committed r250678: <https://trac.webkit.org/changeset/250678> 1576604 9 commit-queue 2019-10-03 14:29:51 -0700 All reviewed patches have been landed. Closing bug. 379958 2019-10-01 15:44:32 -0700 2019-10-03 14:29:50 -0700 Patch bug-202434-20191001154432.patch text/plain 6114 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQ1NDc0OTIyMmI2MzVm ZGJmNzJlMDA0YTA3MWZjOTE5ZjBkMjE5YS4uNjBiM2Y2OWUwNTFlOTE1NDc1ZmFkY2Q3MGM4Mjg4 YzQyNzlmYjFlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTEwLTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWE1MSHR0cFJlcXVlc3Qgc29t ZXRpbWVzIHByZXZlbnRzIHBhZ2VzIGZyb20gZW50ZXJpbmcgdGhlIGJhY2svZm9yd2FyZCBjYWNo ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNDM0 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTg5MDM0MD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBYTUxIdHRwUmVxdWVzdDo6Y2FuU3VzcGVuZEZv ckRvY3VtZW50U3VzcGVuc2lvbigpIHdhcyByZXR1cm5pbmcgZmFsc2UgaWYgdGhlIGRvY3VtZW50 IGhhcyBub3QgZmlyZWQKKyAgICAgICAgdGhlIHdpbmRvdydzIGxvYWQgZXZlbnQsIHdpdGggYSBj b21tZW50IGV4cGxhaW5pbmcgdGhhdCBjYW5jZWxsaW5nIHRoZSBYSFIgaW4gdGhlIHVwb24gc3Vz cGVuc2lvbgorICAgICAgICBtYXkgY2F1c2UgdGhlIGxvYWQgZXZlbnQgdG8gZ2V0IGZpcmVkIGFu ZCB0aHVzIHJ1biBzY3JpcHQgd2hlbiBmb3JiaWRkZW4uIEhvd2V2ZXIsIHdlIHNob3VsZCBvbmx5 CisgICAgICAgIHJldHVybiBmYWxzZSBpZiB0aGUgWE1MSHR0cFJlcXVlc3QgaXMgYWN0dWFsbHkg bG9hZGluZyAobV9sb2FkZXIgaXMgbm90IG51bGwpLiBYSFJzIHRoYXQgYXJlIG5vdAorICAgICAg ICBsb2FkaW5nIHNob3VsZCBuZXZlciBwcmV2ZW50IHBhZ2UgY2FjaGluZy4KKworICAgICAgICBJ IHNhdyBmYWlsdXJlcyB0byBlbnRlciB0aGUgYmFjay9mb3J3YXJkIGNhY2hlIG9uIHlhbmRleC5y dSBhbmQgdGFvYmFvLmNvbSBiZWNhdXNlIG9mIHRoaXMuCisKKyAgICAgICAgVGVzdDogaHR0cC90 ZXN0cy9uYXZpZ2F0aW9uL3BhZ2UtY2FjaGUtZmFpbGVkLXhoci5odG1sCisKKyAgICAgICAgKiB4 bWwvWE1MSHR0cFJlcXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6 OmNhblN1c3BlbmRGb3JEb2N1bWVudFN1c3BlbnNpb24gY29uc3QpOgorCiAyMDE5LTEwLTAxICBD aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQWxsb3cgcGFnZXMgdXNp bmcgRXZlbnRTb3VyY2UgdG8gZW50ZXIgdGhlIGJhY2svZm9yd2FyZCBjYWNoZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKaW5kZXggMTExN2JjZGE1ODRhOWRkNzU2NWNlN2UzMDNi MTAxODBmNjQwM2U0Ny4uN2YwZTAzNWM1Zjk1NWU0ZTFhMGY3M2E3OWI3ODg0NzBkZTk2NjJlYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCkBAIC0xMTQ2LDcgKzExNDYsNyBA QCBib29sIFhNTEh0dHBSZXF1ZXN0OjpjYW5TdXNwZW5kRm9yRG9jdW1lbnRTdXNwZW5zaW9uKCkg Y29uc3QKICAgICAvLyBJZiB0aGUgbG9hZCBldmVudCBoYXMgbm90IGZpcmVkIHlldCwgY2FuY2Vs bGluZyB0aGUgbG9hZCBpbiBzdXNwZW5kKCkgbWF5IGNhdXNlCiAgICAgLy8gdGhlIGxvYWQgZXZl bnQgdG8gYmUgZmlyZWQgYW5kIGFyYml0cmFyeSBKUyBleGVjdXRpb24sIHdoaWNoIHdvdWxkIGJl IHVuc2FmZS4KICAgICAvLyBUaGVyZWZvcmUsIHdlIHByZXZlbnQgc3VzcGVuZGluZyBpbiB0aGlz IGNhc2UuCi0gICAgcmV0dXJuIGRvY3VtZW50KCktPmxvYWRFdmVudEZpbmlzaGVkKCk7CisgICAg cmV0dXJuICFtX2xvYWRlciB8fCBkb2N1bWVudCgpLT5sb2FkRXZlbnRGaW5pc2hlZCgpOwogfQog CiBjb25zdCBjaGFyKiBYTUxIdHRwUmVxdWVzdDo6YWN0aXZlRE9NT2JqZWN0TmFtZSgpIGNvbnN0 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggZTc5ZGViMDQ3YzYzZTZmZjAzZjBkY2E3MzUxM2EzNjY3ZWNlMzI4MC4uMWFlOWZh NzU3NTkxOWFlMGZjOTJhMDQ0Yzg2OWU2ODgyMDgwMWQyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDE5LTEwLTAxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAg WE1MSHR0cFJlcXVlc3Qgc29tZXRpbWVzIHByZXZlbnRzIHBhZ2VzIGZyb20gZW50ZXJpbmcgdGhl IGJhY2svZm9yd2FyZCBjYWNoZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAyNDM0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTg5MDM0MD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbGF5b3V0 IHRlc3QgY292ZXJhZ2UuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL25hdmlnYXRpb24vcGFnZS1j YWNoZS1mYWlsZWQteGhyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0 cy9uYXZpZ2F0aW9uL3BhZ2UtY2FjaGUtZmFpbGVkLXhoci5odG1sOiBBZGRlZC4KKyAgICAgICAg KiBodHRwL3Rlc3RzL25hdmlnYXRpb24vcmVzb3VyY2VzL3BhZ2UtY2FjaGUtZmFpbGVkLXhoci1m cmFtZS5odG1sOiBBZGRlZC4KKwogMjAxOS0xMC0wMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIEFsbG93IHBhZ2VzIHVzaW5nIEV2ZW50U291cmNlIHRvIGVudGVy IHRoZSBiYWNrL2ZvcndhcmQgY2FjaGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvbmF2aWdhdGlvbi9wYWdlLWNhY2hlLWZhaWxlZC14aHItZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3BhZ2UtY2FjaGUtZmFpbGVkLXhoci1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uZmJlNTkzMzU2ZDc4ZmY3OWVmZWVlYzEzMTFjN2RmMTczNjU3YTEw ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9w YWdlLWNhY2hlLWZhaWxlZC14aHItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTMgQEAKK1Rlc3Rz IHRoYXQgYSBwYWdlIHdpdGggYSBmYWlsZWQgWE1MSHR0cFJlcXVlc3QgZ29lcyBpbnRvIHRoZSBw YWdlIGNhY2hlLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1Mi IG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworcGFnZXNob3cgLSBu b3QgZnJvbSBjYWNoZQorcGFnZWhpZGUgLSBlbnRlcmluZyBjYWNoZQorcGFnZXNob3cgLSBmcm9t IGNhY2hlCitQQVNTIFBhZ2UgZGlkIGVudGVyIGFuZCB3YXMgcmVzdG9yZWQgZnJvbSB0aGUgcGFn ZSBjYWNoZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRF CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9wYWdlLWNh Y2hlLWZhaWxlZC14aHIuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9w YWdlLWNhY2hlLWZhaWxlZC14aHIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43MmQwYmM5NzZjMDdiNWI0NWE0 MDI3NzBkZDY1MGUxYzdlYzk0ODcxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9uYXZpZ2F0aW9uL3BhZ2UtY2FjaGUtZmFpbGVkLXhoci5odG1sCkBAIC0wLDAgKzEs NDcgQEAKKzwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgZW5hYmxlUGFnZUNhY2hlPXRydWUgXSAt LT4KKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIvanMtdGVz dC1yZXNvdXJjZXMvanMtdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24o J1Rlc3RzIHRoYXQgYSBwYWdlIHdpdGggYSBmYWlsZWQgWE1MSHR0cFJlcXVlc3QgZ29lcyBpbnRv IHRoZSBwYWdlIGNhY2hlLicpOword2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworCitmdW5j dGlvbiBpZnJhbWVJc0xvYWRpbmcoKQoreworICAgIGZyYW1lc1swXS5zdG9wKCk7CisKKyAgICBz ZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgICAgLy8gRm9yY2UgYSBiYWNrIG5hdmlnYXRpb24g YmFjayB0byB0aGlzIHBhZ2UuCisgICAgICB3aW5kb3cubG9jYXRpb24uaHJlZiA9ICJyZXNvdXJj ZXMvcGFnZS1jYWNoZS1oZWxwZXIuaHRtbCI7CisgICAgfSwgMCk7Cit9CisKK3dpbmRvdy5hZGRF dmVudExpc3RlbmVyKCJwYWdlc2hvdyIsIGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgZGVidWcoInBh Z2VzaG93IC0gIiArIChldmVudC5wZXJzaXN0ZWQgPyAiIiA6ICJub3QgIikgKyAiZnJvbSBjYWNo ZSIpOworCisgICAgaWYgKGV2ZW50LnBlcnNpc3RlZCkgeworICAgICAgICB0ZXN0UGFzc2VkKCJQ YWdlIGRpZCBlbnRlciBhbmQgd2FzIHJlc3RvcmVkIGZyb20gdGhlIHBhZ2UgY2FjaGUiKTsKKyAg ICAgICAgc2V0VGltZW91dChmaW5pc2hKU1Rlc3QsIDApOworICAgIH0KK30sIGZhbHNlKTsKKwor d2luZG93LmFkZEV2ZW50TGlzdGVuZXIoInBhZ2VoaWRlIiwgZnVuY3Rpb24oZXZlbnQpIHsKKyAg ICBkZWJ1ZygicGFnZWhpZGUgLSAiICsgKGV2ZW50LnBlcnNpc3RlZCA/ICIiIDogIm5vdCAiKSAr ICJlbnRlcmluZyBjYWNoZSIpOworICAgIGlmICghZXZlbnQucGVyc2lzdGVkKSB7CisgICAgICAg IHRlc3RGYWlsZWQoIlBhZ2UgZGlkIG5vdCBlbnRlciB0aGUgcGFnZSBjYWNoZS4iKTsKKyAgICAg ICAgZmluaXNoSlNUZXN0KCk7CisgICAgfQorfSwgZmFsc2UpOworCit3aW5kb3cuYWRkRXZlbnRM aXN0ZW5lcignbG9hZCcsIGZ1bmN0aW9uKCkgeworICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7 CisgICAgICAgIGxldCBpZnJhbWUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpZnJhbWUiKTsK KyAgICAgICAgaWZyYW1lLnNyYyA9ICJyZXNvdXJjZXMvcGFnZS1jYWNoZS1mYWlsZWQteGhyLWZy YW1lLmh0bWwiOworICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlmcmFtZSk7Cisg ICAgfSwgMCk7Cit9LCBmYWxzZSk7CisKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNlcy9wYWdl LWNhY2hlLWZhaWxlZC14aHItZnJhbWUuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2 aWdhdGlvbi9yZXNvdXJjZXMvcGFnZS1jYWNoZS1mYWlsZWQteGhyLWZyYW1lLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uNzM2MTg2MWFkODY3NjZmYjBiYjliN2QyOThkNDI3YWNhMWY2OTY4YwotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNvdXJjZXMvcGFn ZS1jYWNoZS1mYWlsZWQteGhyLWZyYW1lLmh0bWwKQEAgLTAsMCArMSwxMCBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHNjcmlwdD4KK3hociA9IG5ldyBYTUxIdHRwUmVxdWVz dCgpOworeGhyLm9wZW4oIkdFVCIsICIvcmVzb3VyY2VzL2xvYWQtYW5kLXN0YWxsLmNnaT9uYW1l PWxvYWQtYW5kLXN0YWxsLmNnaSZzdGFsbEZvcj0zJnN0YWxsQXQ9MCZtaW1lVHlwZT10ZXh0L3Bs YWluIiwgdHJ1ZSk7Cit4aHIuc2VuZCgpOworcGFyZW50LmlmcmFtZUlzTG9hZGluZygpOworPC9z Y3JpcHQ+Cis8aHRtbD4K