20243 2008-07-31 11:14:03 -0700 Potential crash with RenderLayer clipRects 2008-07-31 14:11:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser dino oldest_to_newest 87512 0 simon.fraser 2008-07-31 11:14:03 -0700 Bug 20066 changed RenderLayer::calculateClipRects() to not call parent()->calculateClipRects() in some situations. That means that the parent's clipRects are no longer guaranteed to be set up, so the code lower in the method needs to protect against this. 87513 1 simon.fraser 2008-07-31 11:20:25 -0700 I haven't been able to actually crash, but here's a null-check patch. 87514 2 22580 simon.fraser 2008-07-31 11:22:20 -0700 Created attachment 22580 Patch 87518 3 22580 hyatt 2008-07-31 13:09:30 -0700 Comment on attachment 22580 Patch r=me 87524 4 simon.fraser 2008-07-31 14:11:18 -0700 Committed r35496 M WebCore/rendering/RenderLayer.cpp M WebCore/ChangeLog r35496 = aec6a3acb56598eac0ab03de1d44cb8679883d72 (trunk) 22580 2008-07-31 11:22:20 -0700 2008-07-31 13:09:30 -0700 Patch clip_rects_patch.txt text/plain 1378 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDA5Njk1Yy4uNTMzZDJmZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOC0wNy0zMSAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBOdWxsLWNoZWNrIHBhcmVudCBjbGlwIHJlY3RzLCBiZWNhdXNl IHRoZXkgbWF5IG5vdCBoYXZlIGJlZW4KKyAgICAgICAgc2V0IHVwIHlldC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjQzCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6 OmNhbGN1bGF0ZUNsaXBSZWN0cyk6CisKIO+7vzIwMDgtMDctMzEgIEtldmluIE9sbGl2aWVyIDxr ZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBTZWNvbmQgYXR0ZW1wdCBhdCBXaW5k b3dzL3d4IGJ1aWxkIGZpeC4gSW5zdGVhZCBvZiBhdm9pZGluZyBpbmNsdXNpb24gb2Ygd2luZG93 cy5oLApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IDliOGNiOTYuLmU5YjVjN2EgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTE5NjYsNyArMTk2Niw4IEBAIHZvaWQgUmVu ZGVyTGF5ZXI6OmNhbGN1bGF0ZUNsaXBSZWN0cyhjb25zdCBSZW5kZXJMYXllciogcm9vdExheWVy KQogICAgIAogICAgIC8vIElmIG91ciBjbGlwIHJlY3RzIG1hdGNoIG91ciBwYXJlbnQncyBjbGlw LCB0aGVuIHdlIGNhbiBqdXN0IHNoYXJlIGl0cyBkYXRhIHN0cnVjdHVyZSBhbmQKICAgICAvLyBy ZWYgY291bnQuCi0gICAgaWYgKGZpeGVkID09IHBhcmVudCgpLT5jbGlwUmVjdHMoKS0+Zml4ZWQo KSAmJgorICAgIGlmIChwYXJlbnQoKS0+Y2xpcFJlY3RzKCkgJiYKKyAgICAgICAgZml4ZWQgPT0g cGFyZW50KCktPmNsaXBSZWN0cygpLT5maXhlZCgpICYmCiAgICAgICAgIHBvc0NsaXBSZWN0ID09 IHBhcmVudCgpLT5jbGlwUmVjdHMoKS0+cG9zQ2xpcFJlY3QoKSAmJgogICAgICAgICBvdmVyZmxv d0NsaXBSZWN0ID09IHBhcmVudCgpLT5jbGlwUmVjdHMoKS0+b3ZlcmZsb3dDbGlwUmVjdCgpICYm CiAgICAgICAgIGZpeGVkQ2xpcFJlY3QgPT0gcGFyZW50KCktPmNsaXBSZWN0cygpLT5maXhlZENs aXBSZWN0KCkpCg==