202408 2019-10-01 09:13:50 -0700 [ews] Add method to retry a build using Buildbot API 2019-10-01 12:09:45 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196599 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1575560 0 aakash_jain 2019-10-01 09:13:50 -0700 Add method to retry a build using Buildbot API. 1575563 1 379910 aakash_jain 2019-10-01 09:20:51 -0700 Created attachment 379910 Patch 1575584 2 aakash_jain 2019-10-01 10:24:07 -0700 Tested on uat instance. 1575591 3 379910 jbedard 2019-10-01 10:35:07 -0700 Comment on attachment 379910 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379910&action=review > Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:28 > +import requests How are we guaranteeing that this is installed? > Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:104 > + def retry_build(cls, builder_id, build_number): Who is going to call this and what is our plan for testing? 1575608 4 aakash_jain 2019-10-01 11:20:23 -0700 > How are we guaranteeing that this is installed? Through separate ansible configuration. > > > Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:104 > > + def retry_build(cls, builder_id, build_number): > > Who is going to call this and what is our plan for testing? A new API endpoint would be added to retry the (failed builds of) patch, that endpoint would use this method. I am currently testing that, and would post a patch for it soon. 1575633 5 379910 commit-queue 2019-10-01 12:06:37 -0700 Comment on attachment 379910 Patch Clearing flags on attachment: 379910 Committed r250572: <https://trac.webkit.org/changeset/250572> 1575634 6 commit-queue 2019-10-01 12:06:38 -0700 All reviewed patches have been landed. Closing bug. 1575635 7 webkit-bug-importer 2019-10-01 12:09:45 -0700 <rdar://problem/55885172> 379910 2019-10-01 09:20:51 -0700 2019-10-01 12:06:37 -0700 Patch bug-202408-20191001122050.patch text/plain 2556 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MDU1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTEwLTAxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBBZGQgbWV0aG9kIHRvIHJldHJ5IGEgYnVpbGQgdXNpbmcgQnVp bGRib3QgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDI0MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi9idWlsZGJvdC5weToKKyAg ICAgICAgKEJ1aWxkYm90LnJldHJ5X2J1aWxkKTogTWV0aG9kIHRvIHJldHJ5IGdpdmVuIGJ1aWxk IHVzaW5nIEJ1aWxkYm90IEFQSS4KKwogMjAxOS0xMC0wMSAgeW91ZW5uIGZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHJhY2VzIGNvbmRpdGlvbiB3aGVuIHZhbGlk YXRpbmcgY2FwdHVyZSBzYW5kYm94IGV4dGVuc2lvbiByZXZvY2F0aW9uCkluZGV4OiBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVpbGRib3QucHkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvY29tbW9uL2J1aWxkYm90 LnB5CShyZXZpc2lvbiAyNTA1NTYpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBw L2V3cy9jb21tb24vYnVpbGRib3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTI1LDYgKzI1LDcgQEAg ZnJvbSBmdXR1cmUudXRpbHMgaW1wb3J0IGxyYW5nZQogaW1wb3J0IGxvZ2dpbmcKIGltcG9ydCBv cwogaW1wb3J0IHJlCitpbXBvcnQgcmVxdWVzdHMKIGltcG9ydCBzdWJwcm9jZXNzCiAKIGltcG9y dCBld3MuY29tbW9uLnV0aWwgYXMgdXRpbApAQCAtOTgsMyArOTksMjcgQEAgY2xhc3MgQnVpbGRi b3QoKToKICAgICAgICAgICAgIEJ1aWxkYm90Lmljb25zX2Zvcl9xdWV1ZXNfbWFwcGluZ1tzaG9y dG5hbWVdID0gYnVpbGRlci5nZXQoJ2ljb24nKQogCiAgICAgICAgIHJldHVybiBCdWlsZGJvdC5p Y29uc19mb3JfcXVldWVzX21hcHBpbmcKKworICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiByZXRy eV9idWlsZChjbHMsIGJ1aWxkZXJfaWQsIGJ1aWxkX251bWJlcik6CisgICAgICAgIGlmIG5vdCAo dXRpbC5pc192YWxpZF9pZChidWlsZGVyX2lkKSBhbmQgdXRpbC5pc192YWxpZF9pZChidWlsZF9u dW1iZXIpKToKKyAgICAgICAgICAgIHJldHVybiBGYWxzZQorCisgICAgICAgIGJ1aWxkX3VybCA9 ICdodHRwczovL3t9L2FwaS92Mi9idWlsZGVycy97fS9idWlsZHMve30nLmZvcm1hdChjb25maWcu QlVJTERCT1RfU0VSVkVSX0hPU1QsIGJ1aWxkZXJfaWQsIGJ1aWxkX251bWJlcikKKyAgICAgICAg dXNlcm5hbWUgPSBvcy5nZXRlbnYoJ0VXU19BRE1JTl9VU0VSTkFNRScpCisgICAgICAgIHBhc3N3 b3JkID0gb3MuZ2V0ZW52KCdFV1NfQURNSU5fUEFTU1dPUkQxJykKKyAgICAgICAgc2Vzc2lvbiA9 IHJlcXVlc3RzLlNlc3Npb24oKQorICAgICAgICByZXNwb25zZSA9IHNlc3Npb24uaGVhZCgnaHR0 cHM6Ly97fS9hdXRoL2xvZ2luJy5mb3JtYXQoY29uZmlnLkJVSUxEQk9UX1NFUlZFUl9IT1NUKSwg YXV0aD0odXNlcm5hbWUsIHBhc3N3b3JkKSkKKyAgICAgICAgaWYgKG5vdCByZXNwb25zZSkgb3Ig cmVzcG9uc2Uuc3RhdHVzX2NvZGUgbm90IGluICgyMDAsIDMwMik6CisgICAgICAgICAgICBfbG9n LmVycm9yKCdBdXRoZW50aWNhdGlvbiB0byB7fSBmYWlsZWQuIFBsZWFzZSBjaGVjayB1c2VybmFt ZS9wYXNzd29yZC4nLmZvcm1hdChjb25maWcuQlVJTERCT1RfU0VSVkVSX0hPU1QpKQorICAgICAg ICAgICAgcmV0dXJuIEZhbHNlCisKKyAgICAgICAganNvbl9kYXRhID0geydtZXRob2QnOiAncmVi dWlsZCcsICdpZCc6IDEsICdqc29ucnBjJzogJzIuMCcsICdwYXJhbXMnOiB7J3JlYXNvbic6ICdy ZXRyaWVkLWJ5LXVzZXInfX0KKyAgICAgICAgcmVzcG9uc2UgPSBzZXNzaW9uLnBvc3QoYnVpbGRf dXJsLCBqc29uPWpzb25fZGF0YSkKKworICAgICAgICBpZiByZXNwb25zZSBhbmQgcmVzcG9uc2Uu c3RhdHVzX2NvZGUgPT0gMjAwOgorICAgICAgICAgICAgX2xvZy5pbmZvKCdTdWNjZXNzZnVseSBz dWJtaXR0ZWQgcmV0cnkgcmVxdWVzdCBmb3IgYnVpbGQ6IHt9Jy5mb3JtYXQoYnVpbGRfdXJsKSkK KyAgICAgICAgICAgIHJldHVybiBUcnVlCisKKyAgICAgICAgX2xvZy5lcnJvcignRmFpbGVkIHRv IHJldHJ5IGJ1aWxkOiB7fSwgaHR0cCByZXNwb25zZSBjb2RlOiB7fScuZm9ybWF0KGJ1aWxkX3Vy bCwgcmVzcG9uc2Uuc3RhdHVzX2NvZGUpKQorICAgICAgICByZXR1cm4gRmFsc2UK