202389 2019-09-30 20:18:39 -0700 [JSC] HeapSnapshotBuilder m_rootData should be protected with a lock too 2019-09-30 20:24:03 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1575416 0 ysuzuki 2019-09-30 20:18:39 -0700 [JSC] HeapAnalyzer m_rootData should be protected with a lock too 1575417 1 379872 ysuzuki 2019-09-30 20:20:00 -0700 Created attachment 379872 Patch 1575418 2 ysuzuki 2019-09-30 20:20:02 -0700 <rdar://problem/50717564> 1575419 3 379873 ysuzuki 2019-09-30 20:21:01 -0700 Created attachment 379873 Patch 1575420 4 379873 mark.lam 2019-09-30 20:22:23 -0700 Comment on attachment 379873 Patch r=me 1575421 5 ysuzuki 2019-09-30 20:24:03 -0700 Committed r250541: <https://trac.webkit.org/changeset/250541> 379872 2019-09-30 20:20:00 -0700 2019-09-30 20:21:00 -0700 Patch bug-202389-20190930201959.patch text/plain 2841 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx Y2YyYzMzMTNmYWVjMDg2Y2VlMGZmNTllMTQ4YTZhNjc4ZDM5OTRhLi5lY2JhM2FkOThlN2VkNGVh ZjFkZjg4ZTA0ZTc1YjhkNmIyY2U3NGFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wOS0zMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEhlYXBBbmFseXplciBtX3Jvb3REYXRhIHNob3VsZCBiZSBwcm90 ZWN0ZWQgd2l0aCBhIGxvY2sgdG9vCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDIzODkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUwNzE3NTY0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIHdl IGFyZSBwcm90ZWN0aW5nIEhlYXBTbmFwc2hvdEJ1aWxkZXI6Om1fZWRnZXMgd2l0aCBhIGxvY2ss IHdlIGFyZSBub3QgcHJvdGVjdGluZyBtX3Jvb3REYXRhLCB3aGljaCBpcyBhbHNvIGNvbmN1cnJl bnRseSBtb2RpZmllZC4KKyAgICAgICAgVGhpcyBwYXRjaCBwcm90ZWN0cyBpdC4KKworICAgICAg ICAqIGhlYXAvSGVhcFNuYXBzaG90QnVpbGRlci5jcHA6CisgICAgICAgIChKU0M6OkhlYXBTbmFw c2hvdEJ1aWxkZXI6OnNldE9wYXF1ZVJvb3RSZWFjaGFiaWxpdHlSZWFzb25Gb3JDZWxsKToKKwog MjAxOS0wOS0zMCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBJ bmxpbmUgY2FjaGluZyBpcyB3cm9uZyBmb3IgY3VzdG9tIGFjY2Vzc29ycyBhbmQgY3VzdG9tIHZh bHVlcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFNuYXBzaG90 QnVpbGRlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwU25hcHNob3RCdWls ZGVyLmNwcAppbmRleCA2N2FhM2FiZGMyZjI4OTQ5YjFlODQwZGVjOTgzYWY1ZmVmMjEzNWY3Li4w YzU3Y2E5MGM2NWY4NmZlNGVhNzk5MTFhN2JjZGQwMTRlYTE0YmE1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwU25hcHNob3RCdWlsZGVyLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwU25hcHNob3RCdWlsZGVyLmNwcApAQCAtMTUwLDYg KzE1MCw4IEBAIHZvaWQgSGVhcFNuYXBzaG90QnVpbGRlcjo6c2V0T3BhcXVlUm9vdFJlYWNoYWJp bGl0eVJlYXNvbkZvckNlbGwoSlNDZWxsKiBjZWxsLCBjCiAgICAgaWYgKCFyZWFzb24gfHwgISpy ZWFzb24gfHwgbV9zbmFwc2hvdFR5cGUgIT0gU25hcHNob3RUeXBlOjpHQ0RlYnVnZ2luZ1NuYXBz aG90KQogICAgICAgICByZXR1cm47CiAKKyAgICBzdGQ6OmxvY2tfZ3VhcmQ8TG9jaz4gbG9jayht X2J1aWxkaW5nRWRnZU11dGV4KTsKKwogICAgIG1fcm9vdERhdGEuZW5zdXJlKGNlbGwsIFtdICgp IC0+IFJvb3REYXRhIHsKICAgICAgICAgcmV0dXJuIHsgfTsKICAgICB9KS5pdGVyYXRvci0+dmFs dWUucmVhY2hhYmlsaXR5RnJvbU9wYXF1ZVJvb3RSZWFzb25zID0gcmVhc29uOwpkaWZmIC0tZ2l0 IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBkYjM3OWE0ZGFm Yzk3ZDYxMmU2Zjg2Zjg4ZDJhMzExMTkxYWNkZTgxLi43M2M5MmRlMzQyZmI2ZmMzMTA3YjIwOWUw YzFiNWY5MzY1NGM4NDNmIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA5LTMwICBZdXN1a2UgU3V6dWtp ICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW0pTQ10gSGVhcEFuYWx5emVyIG1fcm9v dERhdGEgc2hvdWxkIGJlIHByb3RlY3RlZCB3aXRoIGEgbG9jayB0b28KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjM4OQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTA3MTc1NjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBzdHJlc3MvaGVhcC1hbmFseXplci10YWtpbmctbG9jay5qczogQWRkZWQu CisKIDIwMTktMDktMzAgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAg ICAgSW5saW5lIGNhY2hpbmcgaXMgd3JvbmcgZm9yIGN1c3RvbSBhY2Nlc3NvcnMgYW5kIGN1c3Rv bSB2YWx1ZXMKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2hlYXAtYW5hbHl6ZXItdGFraW5n LWxvY2suanMgYi9KU1Rlc3RzL3N0cmVzcy9oZWFwLWFuYWx5emVyLXRha2luZy1sb2NrLmpzCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjkzNzZmOGQ0OTUzMDE3MTM0NjI1ZmUzMzBlNGZlZDJhMzdhNGZhZmYKLS0tIC9k ZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9oZWFwLWFuYWx5emVyLXRha2luZy1sb2NrLmpz CkBAIC0wLDAgKzEsOCBAQAorLy8gU2hvdWxkIG5vdCBjcmFzaC4KK2xldCBhcnJheSA9IFtdOwor Zm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKSB7CisgICAgYXJyYXlbaV0gPSBuZXcgRGF0 YVZpZXcobmV3IEFycmF5QnVmZmVyKCkpOworfQorZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwOyBp KyspIHt9CisKK2dlbmVyYXRlSGVhcFNuYXBzaG90Rm9yR0NEZWJ1Z2dpbmcoKTsK 379873 2019-09-30 20:21:01 -0700 2019-09-30 20:22:23 -0700 Patch bug-202389-20190930202100.patch text/plain 2855 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx Y2YyYzMzMTNmYWVjMDg2Y2VlMGZmNTllMTQ4YTZhNjc4ZDM5OTRhLi5kZGQ2MzlkMDRhOGQzODZk YjNmMGU4ZDU5MDdhYjNkNjBkMWFlMmY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wOS0zMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEhlYXBTbmFwc2hvdEJ1aWxkZXIgbV9yb290RGF0YSBzaG91bGQg YmUgcHJvdGVjdGVkIHdpdGggYSBsb2NrIHRvbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyMzg5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDcx NzU2ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGlsZSB3ZSBhcmUgcHJvdGVjdGluZyBIZWFwU25hcHNob3RCdWlsZGVyOjptX2VkZ2VzIHdpdGgg YSBsb2NrLCB3ZSBhcmUgbm90IHByb3RlY3RpbmcgbV9yb290RGF0YSwgd2hpY2ggaXMgYWxzbyBj b25jdXJyZW50bHkgbW9kaWZpZWQuCisgICAgICAgIFRoaXMgcGF0Y2ggcHJvdGVjdHMgaXQuCisK KyAgICAgICAgKiBoZWFwL0hlYXBTbmFwc2hvdEJ1aWxkZXIuY3BwOgorICAgICAgICAoSlNDOjpI ZWFwU25hcHNob3RCdWlsZGVyOjpzZXRPcGFxdWVSb290UmVhY2hhYmlsaXR5UmVhc29uRm9yQ2Vs bCk6CisKIDIwMTktMDktMzAgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAg ICAgICAgSW5saW5lIGNhY2hpbmcgaXMgd3JvbmcgZm9yIGN1c3RvbSBhY2Nlc3NvcnMgYW5kIGN1 c3RvbSB2YWx1ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXBT bmFwc2hvdEJ1aWxkZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFNuYXBz aG90QnVpbGRlci5jcHAKaW5kZXggNjdhYTNhYmRjMmYyODk0OWIxZTg0MGRlYzk4M2FmNWZlZjIx MzVmNy4uMGM1N2NhOTBjNjVmODZmZTRlYTc5OTExYTdiY2RkMDE0ZWExNGJhNSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFNuYXBzaG90QnVpbGRlci5jcHAKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFNuYXBzaG90QnVpbGRlci5jcHAKQEAg LTE1MCw2ICsxNTAsOCBAQCB2b2lkIEhlYXBTbmFwc2hvdEJ1aWxkZXI6OnNldE9wYXF1ZVJvb3RS ZWFjaGFiaWxpdHlSZWFzb25Gb3JDZWxsKEpTQ2VsbCogY2VsbCwgYwogICAgIGlmICghcmVhc29u IHx8ICEqcmVhc29uIHx8IG1fc25hcHNob3RUeXBlICE9IFNuYXBzaG90VHlwZTo6R0NEZWJ1Z2dp bmdTbmFwc2hvdCkKICAgICAgICAgcmV0dXJuOwogCisgICAgc3RkOjpsb2NrX2d1YXJkPExvY2s+ IGxvY2sobV9idWlsZGluZ0VkZ2VNdXRleCk7CisKICAgICBtX3Jvb3REYXRhLmVuc3VyZShjZWxs LCBbXSAoKSAtPiBSb290RGF0YSB7CiAgICAgICAgIHJldHVybiB7IH07CiAgICAgfSkuaXRlcmF0 b3ItPnZhbHVlLnJlYWNoYWJpbGl0eUZyb21PcGFxdWVSb290UmVhc29ucyA9IHJlYXNvbjsKZGlm ZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGIz NzlhNGRhZmM5N2Q2MTJlNmY4NmY4OGQyYTMxMTE5MWFjZGU4MS4uZDc2ZGZjZWZmYzI4MTU3YjFm NDU2NWI5YjExYTExYzBiOWQyY2I1YyAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysr IGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0wOS0zMCAgWXVzdWtl IFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgorCisgICAgICAgIFtKU0NdIEhlYXBTbmFwc2hv dEJ1aWxkZXIgbV9yb290RGF0YSBzaG91bGQgYmUgcHJvdGVjdGVkIHdpdGggYSBsb2NrIHRvbwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyMzg5Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDcxNzU2ND4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9oZWFwLWFuYWx5emVyLXRha2luZy1s b2NrLmpzOiBBZGRlZC4KKwogMjAxOS0wOS0zMCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxl LmNvbT4KIAogICAgICAgICBJbmxpbmUgY2FjaGluZyBpcyB3cm9uZyBmb3IgY3VzdG9tIGFjY2Vz c29ycyBhbmQgY3VzdG9tIHZhbHVlcwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvaGVhcC1h bmFseXplci10YWtpbmctbG9jay5qcyBiL0pTVGVzdHMvc3RyZXNzL2hlYXAtYW5hbHl6ZXItdGFr aW5nLWxvY2suanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTM3NmY4ZDQ5NTMwMTcxMzQ2MjVmZTMzMGU0ZmVkMmEz N2E0ZmFmZgotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL2hlYXAtYW5hbHl6ZXIt dGFraW5nLWxvY2suanMKQEAgLTAsMCArMSw4IEBACisvLyBTaG91bGQgbm90IGNyYXNoLgorbGV0 IGFycmF5ID0gW107Citmb3IgKGxldCBpID0gMDsgaSA8IDEwMDAwOyBpKyspIHsKKyAgICBhcnJh eVtpXSA9IG5ldyBEYXRhVmlldyhuZXcgQXJyYXlCdWZmZXIoKSk7Cit9Citmb3IgKGxldCBpID0g MDsgaSA8IDEwMDA7IGkrKykge30KKworZ2VuZXJhdGVIZWFwU25hcHNob3RGb3JHQ0RlYnVnZ2lu ZygpOwo=