<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>202385</bug_id>
          
          <creation_ts>2019-09-30 17:35:49 -0700</creation_ts>
          <short_desc>Rename JSTokenType::EXPORT to EXPORT_ to avoid naming conflict with internal header</short_desc>
          <delta_ts>2019-10-08 10:01:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1575391</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-09-30 17:35:49 -0700</bug_when>
    <thetext>Rename JSTokenType::EXPORT to EXPORT_ to avoid naming conflict with internal header</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1575392</commentid>
    <comment_count>1</comment_count>
      <attachid>379865</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-09-30 17:36:01 -0700</bug_when>
    <thetext>Created attachment 379865
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1575448</commentid>
    <comment_count>2</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-09-30 23:15:17 -0700</bug_when>
    <thetext>http://trac.webkit.org/r250548</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1575449</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-09-30 23:16:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/55867896&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1577808</commentid>
    <comment_count>4</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-10-08 10:01:04 -0700</bug_when>
    <thetext>Maybe these don’t need to be ALL CAPS at all?</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>379865</attachid>
            <date>2019-09-30 17:36:01 -0700</date>
            <delta_ts>2019-09-30 23:15:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-202385-20190930173600.patch</filename>
            <type>text/plain</type>
            <size>2631</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUwNTM4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA
CisyMDE5LTA5LTMwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+
CisKKyAgICAgICAgUmVuYW1lIEpTVG9rZW5UeXBlOjpFWFBPUlQgdG8gRVhQT1JUXyB0byBhdm9p
ZCBuYW1pbmcgY29uZmxpY3Qgd2l0aCBpbnRlcm5hbCBoZWFkZXIKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjM4NQorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFyc2VyL0tleXdvcmRzLnRhYmxlOgor
ICAgICAgICAqIHBhcnNlci9QYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpQYXJzZXI8TGV4ZXJU
eXBlPjo6cGFyc2VNb2R1bGVTb3VyY2VFbGVtZW50cyk6CisgICAgICAgIChKU0M6OlBhcnNlcjxM
ZXhlclR5cGU+OjpwYXJzZUV4cG9ydERlY2xhcmF0aW9uKToKKyAgICAgICAgKiBwYXJzZXIvUGFy
c2VyVG9rZW5zLmg6CisKIDIwMTktMDktMzAgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxl
LmNvbT4KIAogICAgICAgICBbSlNDXSBBSSBmb2xkcyBDb21wYXJlRXEgd3JvbmdseSB3aGVuIGl0
IHNlZXMgcHJvdmVuIEJvb2xlYW4gYW5kIE51bWJlcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD
b3JlL3BhcnNlci9LZXl3b3Jkcy50YWJsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw
dENvcmUvcGFyc2VyL0tleXdvcmRzLnRhYmxlCShyZXZpc2lvbiAyNTA1MjIpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvcGFyc2VyL0tleXdvcmRzLnRhYmxlCSh3b3JraW5nIGNvcHkpCkBAIC00
Myw3ICs0Myw3IEBAIHlpZWxkCVlJRUxECiAKICMgUmVzZXJ2ZWQgZm9yIGZ1dHVyZSB1c2UuCiBl
bnVtICAgICAgICAgICAgUkVTRVJWRUQKLWV4cG9ydCAgICAgICAgICBFWFBPUlQKK2V4cG9ydCAg
ICAgICAgICBFWFBPUlRfCiBpbXBvcnQgICAgICAgICAgSU1QT1JUCiAKICMgUmVzZXJ2ZWQgZm9y
IGZ1dHVyZSB1c2UgaW4gc3RyaWN0IGNvZGUuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
cGFyc2VyL1BhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Bh
cnNlci9QYXJzZXIuY3BwCShyZXZpc2lvbiAyNTA1MjIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvcGFyc2VyL1BhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyNyw3ICs0MjcsNyBAQCB0
ZW1wbGF0ZSA8Y2xhc3MgVHJlZUJ1aWxkZXI+IFRyZWVTb3VyY2VFCiAgICAgd2hpbGUgKHRydWUp
IHsKICAgICAgICAgVHJlZVN0YXRlbWVudCBzdGF0ZW1lbnQgPSAwOwogICAgICAgICBzd2l0Y2gg
KG1fdG9rZW4ubV90eXBlKSB7Ci0gICAgICAgIGNhc2UgRVhQT1JUOgorICAgICAgICBjYXNlIEVY
UE9SVF86CiAgICAgICAgICAgICBzdGF0ZW1lbnQgPSBwYXJzZUV4cG9ydERlY2xhcmF0aW9uKGNv
bnRleHQpOwogICAgICAgICAgICAgaWYgKHN0YXRlbWVudCkKICAgICAgICAgICAgICAgICByZWNv
cmRQYXVzZUxvY2F0aW9uKGNvbnRleHQuYnJlYWtwb2ludExvY2F0aW9uKHN0YXRlbWVudCkpOwpA
QCAtMzM4MCw3ICszMzgwLDcgQEAgdGVtcGxhdGUgPHR5cGVuYW1lIExleGVyVHlwZT4KIHRlbXBs
YXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZVN0YXRlbWVudCBQYXJzZXI8TGV4ZXJUeXBlPjo6
cGFyc2VFeHBvcnREZWNsYXJhdGlvbihUcmVlQnVpbGRlciYgY29udGV4dCkKIHsKICAgICAvLyBo
dHRwOi8vd3d3LmVjbWEtaW50ZXJuYXRpb25hbC5vcmcvZWNtYS0yNjIvNi4wLyNzZWMtZXhwb3J0
cwotICAgIEFTU0VSVChtYXRjaChFWFBPUlQpKTsKKyAgICBBU1NFUlQobWF0Y2goRVhQT1JUXykp
OwogICAgIEpTVG9rZW5Mb2NhdGlvbiBleHBvcnRMb2NhdGlvbih0b2tlbkxvY2F0aW9uKCkpOwog
ICAgIG5leHQoKTsKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXJU
b2tlbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNl
clRva2Vucy5oCShyZXZpc2lvbiAyNTA1MjIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFy
c2VyL1BhcnNlclRva2Vucy5oCSh3b3JraW5nIGNvcHkpCkBAIC04NSw3ICs4NSw3IEBAIGVudW0g
SlNUb2tlblR5cGUgewogICAgIERFQlVHR0VSLAogICAgIEVMU0UsCiAgICAgSU1QT1JULAotICAg
IEVYUE9SVCwKKyAgICBFWFBPUlRfLAogICAgIENMQVNTVE9LRU4sCiAgICAgRVhURU5EUywKICAg
ICBTVVBFUiwK
</data>

          </attachment>
      

    </bug>

</bugzilla>