202369 2019-09-30 13:46:38 -0700 [WinCairo] Move Remote Inspector Server initialization out of WebView 2019-09-30 16:48:26 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned basuke commit-queue fujii ross.kirsling webkit-bug-importer oldest_to_newest 1575311 0 chris.reid 2019-09-30 13:46:38 -0700 We shouldn't be initializing the remote inspector in the WebView since there can be multiple WebViews attempting to bind inspector servers to the same port. 1575331 1 379843 chris.reid 2019-09-30 14:47:26 -0700 Created attachment 379843 patch 1575372 2 379843 commit-queue 2019-09-30 16:47:12 -0700 Comment on attachment 379843 patch Clearing flags on attachment: 379843 Committed r250534: <https://trac.webkit.org/changeset/250534> 1575373 3 commit-queue 2019-09-30 16:47:14 -0700 All reviewed patches have been landed. Closing bug. 1575376 4 webkit-bug-importer 2019-09-30 16:48:26 -0700 <rdar://problem/55860804> 379843 2019-09-30 14:47:26 -0700 2019-09-30 16:47:12 -0700 patch 202369.diff text/plain 4147 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzAzYTBmMDU4ZTkuLjJhYjlmYTEwNGQxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE5LTA5LTMwICBDaHJpc3RvcGhlciBSZWlkICA8Y2hyaXMucmVpZEBzb255LmNv bT4KKworICAgICAgICBbV2luQ2Fpcm9dIE1vdmUgUmVtb3RlIEluc3BlY3RvciBTZXJ2ZXIgaW5p dGlhbGl6YXRpb24gb3V0IG9mIFdlYlZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMjM2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorICAgICAgICAKKyAgICAgICAgTW92ZSBSZW1vdGUgSW5zcGVjdG9yIFNlcnZlciBp bml0aWFsaXphdGlvbiB0byBXaW5kb3dzIFdlYlByb2Nlc3NQb29sIGluaXRpYWxpemF0aW9uLgor CisgICAgICAgICogVUlQcm9jZXNzL3dpbi9XZWJQcm9jZXNzUG9vbFdpbi5jcHA6CisgICAgICAg ICogVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcDoKKwogMjAxOS0wOS0yNiAgV2Vuc29uIEhzaWVo ICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TIDEzXSBUYXBwaW5nIG9u IGEgbm9uLWVkaXRhYmxlIHRleHQgc2VsZWN0aW9uIHNob3VsZCB0b2dnbGUgY2FsbG91dCBiYXIg dmlzaWJpbGl0eSBpbnN0ZWFkIG9mIGNsZWFyaW5nIHNlbGVjdGlvbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3Mvd2luL1dlYlByb2Nlc3NQb29sV2luLmNwcCBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL3dpbi9XZWJQcm9jZXNzUG9vbFdpbi5jcHAKaW5kZXggOTJiOGQzZDQz OGEuLjJlNjA0NDc4YjJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy93aW4v V2ViUHJvY2Vzc1Bvb2xXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL3dpbi9X ZWJQcm9jZXNzUG9vbFdpbi5jcHAKQEAgLTMxLDExICszMSw0MCBAQAogI2luY2x1ZGUgPFdlYkNv cmUvTm90SW1wbGVtZW50ZWQuaD4KICNpbmNsdWRlIDx3dGYvRmlsZVN5c3RlbS5oPgogCisjaWYg RU5BQkxFKFJFTU9URV9JTlNQRUNUT1IpCisjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvUmVtb3Rl SW5zcGVjdG9yU2VydmVyLmg+CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYktpdCB7CiAKKyNpZiBF TkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikKK3N0YXRpYyB2b2lkIGluaXRpYWxpemVSZW1vdGVJbnNw ZWN0b3JTZXJ2ZXIoU3RyaW5nVmlldyBhZGRyZXNzKQoreworICAgIGlmIChJbnNwZWN0b3I6OlJl bW90ZUluc3BlY3RvclNlcnZlcjo6c2luZ2xldG9uKCkuaXNSdW5uaW5nKCkpCisgICAgICAgIHJl dHVybjsKKworICAgIGF1dG8gcG9zID0gYWRkcmVzcy5maW5kKCc6Jyk7CisgICAgaWYgKHBvcyA9 PSBub3RGb3VuZCkKKyAgICAgICAgcmV0dXJuOworICAgIGF1dG8gaG9zdCA9IGFkZHJlc3Muc3Vi c3RyaW5nKDAsIHBvcyk7CisgICAgYXV0byBwb3J0ID0gYWRkcmVzcy5zdWJzdHJpbmcocG9zICsg MSkudG9VSW50NjRTdHJpY3QoKTsKKworICAgIGlmICghcG9ydCkKKyAgICAgICAgcmV0dXJuOwor CisgICAgSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6OnNpbmdsZXRvbigpLnN0YXJ0 KGhvc3QudXRmOCgpLmRhdGEoKSwgcG9ydC52YWx1ZSgpKTsKK30KKyNlbmRpZgorCiB2b2lkIFdl YlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemUoKQogewotICAgIG5vdEltcGxlbWVudGVk KCk7CisjaWYgRU5BQkxFKFJFTU9URV9JTlNQRUNUT1IpCisgICAgaWYgKGNvbnN0IGNoYXIqIGFk ZHJlc3MgPSBnZXRlbnYoIldFQktJVF9JTlNQRUNUT1JfU0VSVkVSIikpIHsKKyAgICAgICAgaW5p dGlhbGl6ZVJlbW90ZUluc3BlY3RvclNlcnZlcihhZGRyZXNzKTsKKyAgICAgICAgYXV0byBwb3J0 ID0gSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6OnNpbmdsZXRvbigpLmxpc3RlbkZv clRhcmdldHMoKTsKKyAgICAgICAgSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3I6OnNldFNlcnZl clBvcnQocG9ydC52YWx1ZU9yKDApKTsKKyAgICB9CisjZW5kaWYKIH0KIAogdm9pZCBXZWJQcm9j ZXNzUG9vbDo6cGxhdGZvcm1Jbml0aWFsaXplTmV0d29ya1Byb2Nlc3MoTmV0d29ya1Byb2Nlc3ND cmVhdGlvblBhcmFtZXRlcnMmKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv d2luL1dlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3Bw CmluZGV4IDE1Mzk1NGU4OGI1Li45YjkyMjYxN2I4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L3dpbi9XZWJWaWV3LmNwcApAQCAtNjAsNyArNjAsNiBAQAogCiAjaWYgRU5BQkxFKFJFTU9URV9J TlNQRUNUT1IpCiAjaW5jbHVkZSAiUmVtb3RlSW5zcGVjdG9yUHJvdG9jb2xIYW5kbGVyLmgiCi0j aW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmg+CiAjZW5kaWYK IAogI2lmIFVTRShDQUlSTykKQEAgLTg3LDI1ICs4Niw2IEBAIGVudW0gewogICAgIFVwZGF0ZUFj dGl2ZVN0YXRlVGltZXIgPSAxLAogfTsKIAotI2lmIEVOQUJMRShSRU1PVEVfSU5TUEVDVE9SKQot c3RhdGljIHZvaWQgaW5pdGlhbGl6ZVJlbW90ZUluc3BlY3RvclNlcnZlcihTdHJpbmdWaWV3IGFk ZHJlc3MpCi17Ci0gICAgaWYgKEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yU2VydmVyOjpzaW5n bGV0b24oKS5pc1J1bm5pbmcoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgYXV0byBwb3MgPSBh ZGRyZXNzLmZpbmQoJzonKTsKLSAgICBpZiAocG9zID09IG5vdEZvdW5kKQotICAgICAgICByZXR1 cm47Ci0gICAgYXV0byBob3N0ID0gYWRkcmVzcy5zdWJzdHJpbmcoMCwgcG9zKTsKLSAgICBhdXRv IHBvcnQgPSBhZGRyZXNzLnN1YnN0cmluZyhwb3MgKyAxKS50b1VJbnQ2NFN0cmljdCgpOwotCi0g ICAgaWYgKCFwb3J0KQotICAgICAgICByZXR1cm47Ci0KLSAgICBJbnNwZWN0b3I6OlJlbW90ZUlu c3BlY3RvclNlcnZlcjo6c2luZ2xldG9uKCkuc3RhcnQoaG9zdC51dGY4KCkuZGF0YSgpLCBwb3J0 LnZhbHVlKCkpOwotfQotI2VuZGlmCi0KIExSRVNVTFQgQ0FMTEJBQ0sgV2ViVmlldzo6V2ViVmll d1duZFByb2MoSFdORCBoV25kLCBVSU5UIG1lc3NhZ2UsIFdQQVJBTSB3UGFyYW0sIExQQVJBTSBs UGFyYW0pCiB7CiAgICAgTE9OR19QVFIgbG9uZ1B0ciA9IDo6R2V0V2luZG93TG9uZ1B0cihoV25k LCAwKTsKQEAgLTI0NSwxMyArMjI1LDYgQEAgV2ViVmlldzo6V2ViVmlldyhSRUNUIHJlY3QsIGNv bnN0IEFQSTo6UGFnZUNvbmZpZ3VyYXRpb24mIGNvbmZpZ3VyYXRpb24sIEhXTkQgcGEKIHsKICAg ICByZWdpc3RlcldlYlZpZXdXaW5kb3dDbGFzcygpOwogCi0jaWYgRU5BQkxFKFJFTU9URV9JTlNQ RUNUT1IpCi0gICAgaWYgKGNvbnN0IGNoYXIqIGFkZHJlc3MgPSBnZXRlbnYoIldFQktJVF9JTlNQ RUNUT1JfU0VSVkVSIikpIHsKLSAgICAgICAgaW5pdGlhbGl6ZVJlbW90ZUluc3BlY3RvclNlcnZl cihhZGRyZXNzKTsKLSAgICAgICAgYXV0byBwb3J0ID0gSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0 b3JTZXJ2ZXI6OnNpbmdsZXRvbigpLmxpc3RlbkZvclRhcmdldHMoKTsKLSAgICAgICAgSW5zcGVj dG9yOjpSZW1vdGVJbnNwZWN0b3I6OnNldFNlcnZlclBvcnQocG9ydC52YWx1ZU9yKDApKTsKLSAg ICB9Ci0jZW5kaWYKICAgICBtX3dpbmRvdyA9IDo6Q3JlYXRlV2luZG93RXhXKDAsIGtXZWJLaXQy V2ViVmlld1dpbmRvd0NsYXNzTmFtZSwgMCwgV1NfQ0hJTEQgfCBXU19DTElQU0lCTElOR1MgfCBX U19DTElQQ0hJTERSRU4gfCBXU19WSVNJQkxFLAogICAgICAgICByZWN0LmxlZnQsIHJlY3QudG9w LCByZWN0LnJpZ2h0IC0gcmVjdC5sZWZ0LCByZWN0LmJvdHRvbSAtIHJlY3QudG9wLCBwYXJlbnRX aW5kb3cgPyBwYXJlbnRXaW5kb3cgOiBIV05EX01FU1NBR0UsIDAsIGluc3RhbmNlSGFuZGxlKCks IHRoaXMpOwogICAgIEFTU0VSVCg6OklzV2luZG93KG1fd2luZG93KSk7Cg==