<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>202349</bug_id>
          
          <creation_ts>2019-09-28 12:30:39 -0700</creation_ts>
          <short_desc>[GTK][WPE] Fix non-unified build issue caused by r250440</short_desc>
          <delta_ts>2019-09-28 17:49:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrian Perez">aperez</reporter>
          <assigned_to name="Adrian Perez">aperez</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1575068</commentid>
    <comment_count>0</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2019-09-28 12:30:39 -0700</bug_when>
    <thetext>This one was introduced by r250440:

../Source/JavaScriptCore/dfg/DFGOSRExit.cpp:524:47: error: use of undeclared identifier &apos;OpGetById&apos;; did you mean &apos;GetById&apos;?
            bool doProfile = !instruction-&gt;is&lt;OpGetById&gt;() || instruction-&gt;as&lt;OpGetById&gt;().metadata(profiledCodeBlock).m_modeMetadata.mode == GetByIdMode::ArrayLength;
                                              ^~~~~~~~~
                                              GetById</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1575069</commentid>
    <comment_count>1</comment_count>
      <attachid>379791</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2019-09-28 12:32:08 -0700</bug_when>
    <thetext>Created attachment 379791
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1575104</commentid>
    <comment_count>2</comment_count>
      <attachid>379791</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2019-09-28 17:25:39 -0700</bug_when>
    <thetext>Comment on attachment 379791
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1575108</commentid>
    <comment_count>3</comment_count>
      <attachid>379791</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-28 17:48:33 -0700</bug_when>
    <thetext>Comment on attachment 379791
Patch

Clearing flags on attachment: 379791

Committed r250486: &lt;https://trac.webkit.org/changeset/250486&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1575109</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-28 17:48:34 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1575110</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-09-28 17:49:18 -0700</bug_when>
    <thetext>&lt;rdar://problem/55812379&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>379791</attachid>
            <date>2019-09-28 12:32:08 -0700</date>
            <delta_ts>2019-09-28 17:48:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-202349-20190928223207.patch</filename>
            <type>text/plain</type>
            <size>1214</size>
            <attacher name="Adrian Perez">aperez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5
NjA3MzJhODE5MjE4OGY0MTM0NWJiZjc5MzgyYzVkOTRjNzBkNTMxLi5hM2Q5MzVlOTZlY2ViMmM1
NTQ3NjQyOGU0ZjNkNzFkMzViMjU1MDMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxMiBAQAorMjAxOS0wOS0yOCAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBp
Z2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gRml4IG5vbi11bmlmaWVkIGJ1aWxkIGlz
c3VlIGNhdXNlZCBieSByMjUwNDQwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0yMDIzNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICAqIGRmZy9ERkdPU1JFeGl0LmNwcDogQWRkIG1pc3NpbmcgaW5jbHVzaW9u
IG9mIHRoZSBCeXRlY29kZVVzZURlZi5oIGhlYWRlci4KKwogMjAxOS0wOS0yNyAgWXVzdWtlIFN1
enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIEtlZXAgSlNTdHJpbmc6
OnZhbHVlKEV4ZWNTdGF0ZSopJ3MgcmVzdWx0IGFzIFN0cmluZyBpbnN0ZWFkIG9mIGBjb25zdCBT
dHJpbmcmYApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0
LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAKaW5kZXggYWVh
OWU4ZmE1NzJhNjI2YmExYzkxNjg5MzY2Y2Q4OTY5MDQ1NmJhZS4uNTU4N2ZjNjJjMGQ3MDVmYjI4
ZGYwN2VjYjNhZjY3NTBkOWU2YjUyMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl
L2RmZy9ERkdPU1JFeGl0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09T
UkV4aXQuY3BwCkBAIC0yOSw2ICsyOSw3IEBACiAjaWYgRU5BQkxFKERGR19KSVQpCiAKICNpbmNs
dWRlICJBc3NlbWJseUhlbHBlcnMuaCIKKyNpbmNsdWRlICJCeXRlY29kZVVzZURlZi5oIgogI2lu
Y2x1ZGUgIkNsb25lZEFyZ3VtZW50cy5oIgogI2luY2x1ZGUgIkRGR0dyYXBoLmgiCiAjaW5jbHVk
ZSAiREZHTWF5RXhpdC5oIgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>