202348 2019-09-28 11:23:51 -0700 [LFC][IFC] Line::InitialConstraints's heightAndBaseline should be optional 2019-09-28 16:58:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1575059 0 zalan 2019-09-28 11:23:51 -0700 it's undefined while computing the preferred width 1575060 1 379790 zalan 2019-09-28 11:34:58 -0700 Created attachment 379790 Patch 1575091 2 webkit-bug-importer 2019-09-28 14:14:42 -0700 <rdar://problem/55810712> 1575101 3 379790 commit-queue 2019-09-28 16:58:16 -0700 Comment on attachment 379790 Patch Clearing flags on attachment: 379790 Committed r250484: <https://trac.webkit.org/changeset/250484> 1575102 4 commit-queue 2019-09-28 16:58:17 -0700 All reviewed patches have been landed. Closing bug. 379790 2019-09-28 11:34:58 -0700 2019-09-28 16:58:16 -0700 Patch bug-202348-20190928113454.patch text/plain 6678 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzZiYmEzNmMxOWU4MmMw ZWJkNTI4MGE3YTNmZDNjMzA5MGM1MGU3NS4uOGY4NTcwODViN2ZlMjM2ODBjZWJjMzgxYzUwYzQw ZGU4NDU5YTJhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA5LTI4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBMaW5lOjpJ bml0aWFsQ29uc3RyYWludHMncyBoZWlnaHRBbmRCYXNlbGluZSBzaG91bGQgYmUgb3B0aW9uYWwK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjM0OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFZlcnRpY2Fs IHByb3BlcnRpZXMgYXJlIHVuZGVmaW5lZCB3aGlsZSBjb21wdXRpbmcgdGhlIHByZWZlcnJlZCB3 aWR0aC4KKworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRp bmdDb250ZXh0TGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVJ bnB1dDo6TGluZUlucHV0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6SW5saW5lRm9ybWF0 dGluZ0NvbnRleHQ6OklubGluZUxheW91dDo6Y29tcHV0ZWRJbnRyaW5zaWNXaWR0aCBjb25zdCk6 CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OkxpbmUpOgorICAgICAgICAqIGxheW91dC9pbmxp bmVmb3JtYXR0aW5nL0lubGluZUxpbmUuaDoKKwogMjAxOS0wOS0yNyAgWmFsYW4gQnVqdGFzICA8 emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gTGluZTo6Qm94IHNob3VsZCBo YXZlIGEgY29uc3QgcHVibGljIGludGVyZmFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5b3V0 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1h dHRpbmdDb250ZXh0TGluZUxheW91dC5jcHAKaW5kZXggOTU3ZTkwMWMwMGI4M2E5Y2EwNGFhYWU0 YzQxYWEyYWNkMjU1M2EyNi4uNGQ0N2MyNzA0NDU4YjgzMDlmMTBmNDc3ZjM2M2M3Y2Y0NmFhYjk3 YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5s aW5lRm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dExpbmVMYXlvdXQu Y3BwCkBAIC05MSw2ICs5MSwxNCBAQCBzdHJ1Y3QgTGluZUlucHV0IHsKICAgICBPcHRpb25hbDxM YXlvdXRVbml0PiBmbG9hdE1pbmltdW1Mb2dpY2FsQm90dG9tOwogfTsKIAorTGluZUlucHV0OjpM aW5lSW5wdXQoY29uc3QgTGluZTo6SW5pdGlhbENvbnN0cmFpbnRzJiBpbml0aWFsTGluZUNvbnN0 cmFpbnRzLCBMaW5lOjpTa2lwVmVydGljYWxBbGlnbWVudCBza2lwVmVydGljYWxBbGlnbWVudCwg SW5kZXhBbmRSYW5nZSBmaXJzdFRvUHJvY2VzcywgY29uc3QgSW5saW5lSXRlbXMmIGlubGluZUl0 ZW1zKQorICAgIDogaW5pdGlhbENvbnN0cmFpbnRzKGluaXRpYWxMaW5lQ29uc3RyYWludHMpCisg ICAgLCBza2lwVmVydGljYWxBbGlnbWVudChza2lwVmVydGljYWxBbGlnbWVudCkKKyAgICAsIGZp cnN0SW5saW5lSXRlbShmaXJzdFRvUHJvY2VzcykKKyAgICAsIGlubGluZUl0ZW1zKGlubGluZUl0 ZW1zKQoreworfQorCiBzdHJ1Y3QgTGluZUNvbnRlbnQgewogICAgIE9wdGlvbmFsPEluZGV4QW5k UmFuZ2U+IGxhc3RDb21taXR0ZWQ7CiAgICAgVmVjdG9yPFdlYWtQdHI8SW5saW5lSXRlbT4+IGZs b2F0czsKQEAgLTI2MiwxNCArMjcwLDYgQEAgTGluZUNvbnRlbnQgTGluZUxheW91dDo6bGF5b3V0 KCkKICAgICByZXR1cm4gY2xvc2UoKTsKIH0KIAotTGluZUlucHV0OjpMaW5lSW5wdXQoY29uc3Qg TGluZTo6SW5pdGlhbENvbnN0cmFpbnRzJiBpbml0aWFsTGluZUNvbnN0cmFpbnRzLCBMaW5lOjpT a2lwVmVydGljYWxBbGlnbWVudCBza2lwVmVydGljYWxBbGlnbWVudCwgSW5kZXhBbmRSYW5nZSBm aXJzdFRvUHJvY2VzcywgY29uc3QgSW5saW5lSXRlbXMmIGlubGluZUl0ZW1zKQotICAgIDogaW5p dGlhbENvbnN0cmFpbnRzKGluaXRpYWxMaW5lQ29uc3RyYWludHMpCi0gICAgLCBza2lwVmVydGlj YWxBbGlnbWVudChza2lwVmVydGljYWxBbGlnbWVudCkKLSAgICAsIGZpcnN0SW5saW5lSXRlbShm aXJzdFRvUHJvY2VzcykKLSAgICAsIGlubGluZUl0ZW1zKGlubGluZUl0ZW1zKQotewotfQotCiBJ bmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6SW5saW5lTGF5b3V0OjpJbmxpbmVMYXlvdXQoSW5saW5l Rm9ybWF0dGluZ0NvbnRleHQmIGlubGluZUZvcm1hdHRpbmdDb250ZXh0LCBVc2VkSG9yaXpvbnRh bFZhbHVlcyB1c2VkSG9yaXpvbnRhbFZhbHVlcykKICAgICA6IG1faW5saW5lRm9ybWF0dGluZ0Nv bnRleHQoaW5saW5lRm9ybWF0dGluZ0NvbnRleHQpCiAgICAgLCBtX3VzZWRIb3Jpem9udGFsVmFs dWVzKHVzZWRIb3Jpem9udGFsVmFsdWVzKQpAQCAtMzQ2LDEwICszNDYsMTQgQEAgTGF5b3V0VW5p dCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6SW5saW5lTGF5b3V0Ojpjb21wdXRlZEludHJpbnNp Y1dpZHRoKGNvbnN0IEkKICAgICBhdXRvJiBmb3JtYXR0aW5nQ29udGV4dCA9IHRoaXMtPmZvcm1h dHRpbmdDb250ZXh0KCk7CiAgICAgTGF5b3V0VW5pdCBtYXhpbXVtTGluZVdpZHRoOwogICAgIElu ZGV4QW5kUmFuZ2UgY3VycmVudElubGluZUl0ZW07Ci0gICAgYXV0byBxdWlya3MgPSBmb3JtYXR0 aW5nQ29udGV4dC5xdWlya3MoKTsKICAgICB3aGlsZSAoY3VycmVudElubGluZUl0ZW0uaW5kZXgg PCBpbmxpbmVJdGVtcy5zaXplKCkpIHsKLSAgICAgICAgYXV0byBsaW5lQ29udGVudCA9IExpbmVM YXlvdXQoZm9ybWF0dGluZ0NvbnRleHQsIHsgeyB7IH0sIHdpZHRoQ29uc3RyYWludCgpLCBmYWxz ZSwgcXVpcmtzLmxpbmVIZWlnaHRDb25zdHJhaW50cyhmb3JtYXR0aW5nUm9vdCgpKSB9LCBMaW5l OjpTa2lwVmVydGljYWxBbGlnbWVudDo6WWVzLCBjdXJyZW50SW5saW5lSXRlbSwgaW5saW5lSXRl bXMgfSkubGF5b3V0KCk7Ci0gICAgICAgIGN1cnJlbnRJbmxpbmVJdGVtID0geyBsaW5lQ29udGVu dC5sYXN0Q29tbWl0dGVkLT5pbmRleCArIDEsIFdURjo6bnVsbG9wdCB9OworICAgICAgICAvLyBP bmx5IHRoZSBob3JpenRvbmFsIGF2YWlsYWJsZSB3aWR0aCBpcyBjb25zdHJhaW5lZCB3aGVuIGNv bXB1dGluZyBpbnRyaW5zaWMgd2lkdGguCisgICAgICAgIGF1dG8gaW5pdGlhbExpbmVDb25zdHJh aW50cyA9IExpbmU6OkluaXRpYWxDb25zdHJhaW50cyB7IHsgfSwgd2lkdGhDb25zdHJhaW50KCks IGZhbHNlLCB7IH0gfTsKKyAgICAgICAgYXV0byBsaW5lSW5wdXQgPSBMaW5lSW5wdXQgeyBpbml0 aWFsTGluZUNvbnN0cmFpbnRzLCBMaW5lOjpTa2lwVmVydGljYWxBbGlnbWVudDo6WWVzLCBjdXJy ZW50SW5saW5lSXRlbSwgaW5saW5lSXRlbXMgfTsKKworICAgICAgICBhdXRvIGxpbmVDb250ZW50 ID0gTGluZUxheW91dChmb3JtYXR0aW5nQ29udGV4dCwgbGluZUlucHV0KS5sYXlvdXQoKTsKKwor ICAgICAgICBjdXJyZW50SW5saW5lSXRlbSA9IHsgbGluZUNvbnRlbnQubGFzdENvbW1pdHRlZC0+ aW5kZXggKyAxLCB7IH0gfTsKICAgICAgICAgTGF5b3V0VW5pdCBmbG9hdHNXaWR0aDsKICAgICAg ICAgZm9yIChhdXRvJiBmbG9hdEl0ZW0gOiBsaW5lQ29udGVudC5mbG9hdHMpCiAgICAgICAgICAg ICBmbG9hdHNXaWR0aCArPSBmb3JtYXR0aW5nQ29udGV4dC5nZW9tZXRyeUZvckJveChmbG9hdEl0 ZW0tPmxheW91dEJveCgpKS5tYXJnaW5Cb3hXaWR0aCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcAppbmRleCBmNmFhYzg5 N2ZmM2NlMmYwNDg0NmFiODg3N2U2ZTc2Y2NiMWU1ZjQzLi42NmI3MzJmMmIzNzY2NDIyODJjZTNm M2MyNGNlMzYwY2M4NzBkZDI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5s aW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv aW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcApAQCAtNTksMTIgKzU5LDE1IEBAIGJvb2wg TGluZTo6UnVuOjpjYW5CZUV4dGVuZGVkKCkgY29uc3QKIAogTGluZTo6TGluZShjb25zdCBJbmxp bmVGb3JtYXR0aW5nQ29udGV4dCYgaW5saW5lRm9ybWF0dGluZ0NvbnRleHQsIGNvbnN0IEluaXRp YWxDb25zdHJhaW50cyYgaW5pdGlhbENvbnN0cmFpbnRzLCBTa2lwVmVydGljYWxBbGlnbWVudCBz a2lwVmVydGljYWxBbGlnbWVudCkKICAgICA6IG1faW5saW5lRm9ybWF0dGluZ0NvbnRleHQoaW5s aW5lRm9ybWF0dGluZ0NvbnRleHQpCi0gICAgLCBtX2luaXRpYWxTdHJ1dChpbml0aWFsQ29uc3Ry YWludHMuaGVpZ2h0QW5kQmFzZWxpbmUuc3RydXQpCisgICAgLCBtX2luaXRpYWxTdHJ1dChpbml0 aWFsQ29uc3RyYWludHMuaGVpZ2h0QW5kQmFzZWxpbmUgPyBpbml0aWFsQ29uc3RyYWludHMuaGVp Z2h0QW5kQmFzZWxpbmUtPnN0cnV0IDogV1RGOjpudWxsb3B0KQogICAgICwgbV9saW5lTG9naWNh bFdpZHRoKGluaXRpYWxDb25zdHJhaW50cy5hdmFpbGFibGVMb2dpY2FsV2lkdGgpCiAgICAgLCBt X3NraXBWZXJ0aWNhbEFsaWdtZW50KHNraXBWZXJ0aWNhbEFsaWdtZW50ID09IFNraXBWZXJ0aWNh bEFsaWdtZW50OjpZZXMpCiB7Ci0gICAgYXV0byBsaW5lUmVjdCA9IERpc3BsYXk6OlJlY3QgeyBp bml0aWFsQ29uc3RyYWludHMubG9naWNhbFRvcExlZnQsIHsgfSwgaW5pdGlhbENvbnN0cmFpbnRz LmhlaWdodEFuZEJhc2VsaW5lLmhlaWdodCB9OwotICAgIGF1dG8gYmFzZWxpbmUgPSBMaW5lQm94 OjpCYXNlbGluZSB7IGluaXRpYWxDb25zdHJhaW50cy5oZWlnaHRBbmRCYXNlbGluZS5iYXNlbGlu ZU9mZnNldCwgaW5pdGlhbENvbnN0cmFpbnRzLmhlaWdodEFuZEJhc2VsaW5lLmhlaWdodCAtIGlu aXRpYWxDb25zdHJhaW50cy5oZWlnaHRBbmRCYXNlbGluZS5iYXNlbGluZU9mZnNldCB9OworICAg IEFTU0VSVChtX3NraXBWZXJ0aWNhbEFsaWdtZW50IHx8IGluaXRpYWxDb25zdHJhaW50cy5oZWln aHRBbmRCYXNlbGluZSk7CisgICAgYXV0byBpbml0aWFsTGluZUhlaWdodCA9IGluaXRpYWxDb25z dHJhaW50cy5oZWlnaHRBbmRCYXNlbGluZSA/IGluaXRpYWxDb25zdHJhaW50cy5oZWlnaHRBbmRC YXNlbGluZS0+aGVpZ2h0IDogTGF5b3V0VW5pdCgpOworICAgIGF1dG8gaW5pdGlhbEJhc2VsaW5l T2Zmc2V0ID0gaW5pdGlhbENvbnN0cmFpbnRzLmhlaWdodEFuZEJhc2VsaW5lID8gaW5pdGlhbENv bnN0cmFpbnRzLmhlaWdodEFuZEJhc2VsaW5lLT5iYXNlbGluZU9mZnNldCA6IExheW91dFVuaXQo KTsKKyAgICBhdXRvIGxpbmVSZWN0ID0gRGlzcGxheTo6UmVjdCB7IGluaXRpYWxDb25zdHJhaW50 cy5sb2dpY2FsVG9wTGVmdCwgeyB9LCBpbml0aWFsTGluZUhlaWdodCB9OworICAgIGF1dG8gYmFz ZWxpbmUgPSBMaW5lQm94OjpCYXNlbGluZSB7IGluaXRpYWxCYXNlbGluZU9mZnNldCwgaW5pdGlh bExpbmVIZWlnaHQgLSBpbml0aWFsQmFzZWxpbmVPZmZzZXQgfTsKICAgICBtX2xpbmVCb3ggPSBM aW5lQm94IHsgbGluZVJlY3QsIGJhc2VsaW5lLCB7IH0gfTsKIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5oIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5oCmluZGV4IGQ3NDg2 YWE3MmZhNjRkY2M3MGZkM2ExNDRkYmE2ZWQzMGFlOGRiMWYuLjYzOTFhNjc3MmUwZDEwMTRkMTFj Mzc3ZmE2NzA5MzRiYjQ4MzY3N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv aW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmgKQEAgLTQ5LDcgKzQ5LDcgQEAgcHVibGljOgog ICAgICAgICAgICAgTGF5b3V0VW5pdCBiYXNlbGluZU9mZnNldDsKICAgICAgICAgICAgIE9wdGlv bmFsPExpbmVCb3g6OkJhc2VsaW5lPiBzdHJ1dDsKICAgICAgICAgfTsKLSAgICAgICAgSGVpZ2h0 QW5kQmFzZWxpbmUgaGVpZ2h0QW5kQmFzZWxpbmU7CisgICAgICAgIE9wdGlvbmFsPEhlaWdodEFu ZEJhc2VsaW5lPiBoZWlnaHRBbmRCYXNlbGluZTsKICAgICB9OwogICAgIGVudW0gY2xhc3MgU2tp cFZlcnRpY2FsQWxpZ21lbnQgeyBObywgWWVzIH07CiAgICAgTGluZShjb25zdCBJbmxpbmVGb3Jt YXR0aW5nQ29udGV4dCYsIGNvbnN0IEluaXRpYWxDb25zdHJhaW50cyYsIFNraXBWZXJ0aWNhbEFs aWdtZW50KTsK