202336 2019-09-27 16:20:39 -0700 [LFC][IFC] Line::Box should have a const public interface 2019-09-28 07:30:48 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1575008 0 zalan 2019-09-27 16:20:39 -0700 ssia 1575009 1 webkit-bug-importer 2019-09-27 16:21:01 -0700 <rdar://problem/55798628> 1575011 2 379773 zalan 2019-09-27 16:25:03 -0700 Created attachment 379773 Patch 1575049 3 379773 commit-queue 2019-09-28 07:30:46 -0700 Comment on attachment 379773 Patch Clearing flags on attachment: 379773 Committed r250482: <https://trac.webkit.org/changeset/250482> 1575050 4 commit-queue 2019-09-28 07:30:48 -0700 All reviewed patches have been landed. Closing bug. 379773 2019-09-27 16:25:03 -0700 2019-09-28 07:30:46 -0700 Patch bug-202336-20190927162459.patch text/plain 4223 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVkYzA5MjI2OWUyOTJi ZGUzZDI1MTA5ZTMyYjlmOWJkZjk4NDE1Ny4uNzZiYmEzNmMxOWU4MmMwZWJkNTI4MGE3YTNmZDNj MzA5MGM1MGU3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA5LTI3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBMaW5lOjpC b3ggc2hvdWxkIGhhdmUgYSBjb25zdCBwdWJsaWMgaW50ZXJmYWNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDIzMzYKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzU1Nzk4NjI4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENsZWFuIHVwIExpbmU6OkJveCBpbnRlcmZhY2UuCisKKyAgICAgICAgKiBsYXlv dXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okxh eW91dDo6TGluZTo6Y2xvc2UpOgorICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZUxpbmUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZTo6UnVuOjpkaXNwbGF5 UnVuIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZTo6UnVuOjppc1Zpc3Vh bGx5RW1wdHkgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lOjpSdW46OmV4 cGFuZCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OlJ1bjo6ZGlzcGxheVJ1bik6 IERlbGV0ZWQuCisKIDIwMTktMDktMjcgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFtXaW5dIENyYXNoIHVuZGVyIEZvbnRDYWNoZTo6bGFzdFJlc29ydEZh bGxiYWNrRm9udApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1h dHRpbmcvSW5saW5lTGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0 dGluZy9JbmxpbmVMaW5lLmNwcAppbmRleCAxMmY4MDIxNTVjZjc1MWUwMWJkYmY2MDYzNmUzY2Iy OTU4N2JlZmFmLi5mNmFhYzg5N2ZmM2NlMmYwNDg0NmFiODg3N2U2ZTc2Y2NiMWU1ZjQzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5l LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVM aW5lLmNwcApAQCAtMTc4LDEwICsxNzgsNyBAQCBMaW5lOjpSdW5MaXN0IExpbmU6OmNsb3NlKCkK ICAgICAgICAgLy8gT25seSB0ZXh0IGNvbnRlbnQgY2FuIGJlIGV4dGVuZGVkIGF0bS4KICAgICAg ICAgQVNTRVJUKHByZXZpb3VzUnVuLT5pc1RleHQoKSk7CiAgICAgICAgIEFTU0VSVChjdXJyZW50 UnVuLT5pc1RleHQoKSk7Ci0gICAgICAgIGF1dG8mIHByZXZpb3VzRGlzcGxheVJ1biA9IHByZXZp b3VzUnVuLT5kaXNwbGF5UnVuKCk7Ci0gICAgICAgIGF1dG8mIGN1cnJlbnREaXNwbGF5UnVuID0g Y3VycmVudFJ1bi0+ZGlzcGxheVJ1bigpOwotICAgICAgICBwcmV2aW91c0Rpc3BsYXlSdW4uZXhw YW5kSG9yaXpvbnRhbGx5KGN1cnJlbnREaXNwbGF5UnVuLmxvZ2ljYWxXaWR0aCgpKTsKLSAgICAg ICAgcHJldmlvdXNEaXNwbGF5UnVuLnRleHRDb250ZXh0KCktPmV4cGFuZChjdXJyZW50RGlzcGxh eVJ1bi50ZXh0Q29udGV4dCgpLT5sZW5ndGgoKSk7CisgICAgICAgIHByZXZpb3VzUnVuLT5leHBh bmQoKmN1cnJlbnRSdW4pOwogICAgICAgICBtX3J1bkxpc3QucmVtb3ZlKGluZGV4KTsKICAgICB9 CiAgICAgcmV0dXJuIFdURk1vdmUobV9ydW5MaXN0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuaCBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuaAppbmRleCAxYTZiZWQxNjMzODAy YzlhZjU1ZjJjYWZhYzhkZDBhZGEyNDQ4ZmU4Li5kNzQ4NmFhNzJmYTY0ZGNjNzBmZDNhMTQ0ZGJh NmVkMzBhZThkYjFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9y bWF0dGluZy9JbmxpbmVMaW5lLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZv cm1hdHRpbmcvSW5saW5lTGluZS5oCkBAIC02OSwxMCArNjksMTAgQEAgcHVibGljOgogICAgICAg ICBSdW4oY29uc3QgSW5saW5lSXRlbSYsIGNvbnN0IERpc3BsYXk6OlJ1biYpOwogCiAgICAgICAg IGNvbnN0IERpc3BsYXk6OlJ1biYgZGlzcGxheVJ1bigpIGNvbnN0IHsgcmV0dXJuIG1fZGlzcGxh eVJ1bjsgfQotICAgICAgICBEaXNwbGF5OjpSdW4mIGRpc3BsYXlSdW4oKSB7IHJldHVybiBtX2Rp c3BsYXlSdW47IH0KICAgICAgICAgY29uc3QgQm94JiBsYXlvdXRCb3goKSBjb25zdCB7IHJldHVy biBtX2lubGluZUl0ZW0ubGF5b3V0Qm94KCk7IH0KIAogICAgICAgICBjb25zdCBEaXNwbGF5OjpS ZWN0JiBsb2dpY2FsUmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fZGlzcGxheVJ1bi5sb2dpY2FsUmVj dCgpOyB9CisgICAgICAgIGJvb2wgaXNWaXN1YWxseUVtcHR5KCkgY29uc3QgeyByZXR1cm4gbV9p c1Zpc3VhbGx5RW1wdHk7IH0KIAogICAgICAgICBib29sIGlzVGV4dCgpIGNvbnN0IHsgcmV0dXJu IG1faW5saW5lSXRlbS5pc1RleHQoKTsgfQogICAgICAgICBib29sIGlzQm94KCkgY29uc3QgeyBy ZXR1cm4gbV9pbmxpbmVJdGVtLmlzQm94KCk7IH0KQEAgLTgwLDE3ICs4MCwxOSBAQCBwdWJsaWM6 CiAgICAgICAgIGJvb2wgaXNDb250YWluZXJTdGFydCgpIGNvbnN0IHsgcmV0dXJuIG1faW5saW5l SXRlbS5pc0NvbnRhaW5lclN0YXJ0KCk7IH0KICAgICAgICAgYm9vbCBpc0NvbnRhaW5lckVuZCgp IGNvbnN0IHsgcmV0dXJuIG1faW5saW5lSXRlbS5pc0NvbnRhaW5lckVuZCgpOyB9CiAKLSAgICAg ICAgYm9vbCBpc1Zpc3VhbGx5RW1wdHkoKSBjb25zdCB7IHJldHVybiBtX2lzVmlzdWFsbHlFbXB0 eTsgfQotICAgICAgICBib29sIGlzV2hpdGVzcGFjZSgpIGNvbnN0OwotICAgICAgICBib29sIGNh bkJlRXh0ZW5kZWQoKSBjb25zdDsKLQogICAgIHByaXZhdGU6CiAgICAgICAgIGZyaWVuZCBjbGFz cyBMaW5lOwogICAgICAgICB2b2lkIGFkanVzdExvZ2ljYWxUb3AoTGF5b3V0VW5pdCBsb2dpY2Fs VG9wKSB7IG1fZGlzcGxheVJ1bi5zZXRMb2dpY2FsVG9wKGxvZ2ljYWxUb3ApOyB9CiAgICAgICAg IHZvaWQgbW92ZVZlcnRpY2FsbHkoTGF5b3V0VW5pdCBvZmZzZXQpIHsgbV9kaXNwbGF5UnVuLm1v dmVWZXJ0aWNhbGx5KG9mZnNldCk7IH0KICAgICAgICAgdm9pZCBtb3ZlSG9yaXpvbnRhbGx5KExh eW91dFVuaXQgb2Zmc2V0KSB7IG1fZGlzcGxheVJ1bi5tb3ZlSG9yaXpvbnRhbGx5KG9mZnNldCk7 IH0KKworICAgICAgICB2b2lkIGV4cGFuZChjb25zdCBSdW4mKTsKKwogICAgICAgICB2b2lkIHNl dFZpc3VhbGx5SXNFbXB0eSgpIHsgbV9pc1Zpc3VhbGx5RW1wdHkgPSB0cnVlOyB9CiAKKyAgICAg ICAgYm9vbCBpc1doaXRlc3BhY2UoKSBjb25zdDsKKyAgICAgICAgYm9vbCBjYW5CZUV4dGVuZGVk KCkgY29uc3Q7CisKICAgICAgICAgY29uc3QgSW5saW5lSXRlbSYgbV9pbmxpbmVJdGVtOwogICAg ICAgICBEaXNwbGF5OjpSdW4gbV9kaXNwbGF5UnVuOwogICAgICAgICBib29sIG1faXNWaXN1YWxs eUVtcHR5IHsgZmFsc2UgfTsKQEAgLTE0MSw2ICsxNDMsMTYgQEAgcHJpdmF0ZToKICAgICBMaW5l Qm94IG1fbGluZUJveDsKIH07CiAKK2lubGluZSB2b2lkIExpbmU6OlJ1bjo6ZXhwYW5kKGNvbnN0 IFJ1biYgb3RoZXIpCit7CisgICAgQVNTRVJUKGlzVGV4dCgpKTsKKyAgICBBU1NFUlQob3RoZXIu aXNUZXh0KCkpOworCisgICAgYXV0byYgb3RoZXJEaXNwbGF5UnVuID0gb3RoZXIuZGlzcGxheVJ1 bigpOworICAgIG1fZGlzcGxheVJ1bi5leHBhbmRIb3Jpem9udGFsbHkob3RoZXJEaXNwbGF5UnVu LmxvZ2ljYWxXaWR0aCgpKTsKKyAgICBtX2Rpc3BsYXlSdW4udGV4dENvbnRleHQoKS0+ZXhwYW5k KG90aGVyRGlzcGxheVJ1bi50ZXh0Q29udGV4dCgpLT5sZW5ndGgoKSk7Cit9CisKIH0KIH0KICNl bmRpZgo=