202335 2019-09-27 15:36:55 -0700 [Experiment][iOS] Add temporary HTTP header to distinguish iPads for requests to Google 2019-09-30 12:04:21 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 202367 1 cdumez cdumez achristensen beidson bfulgham commit-queue dbates ews-watchlist ggaren japhet mjs webkit-bug-importer youennf oldest_to_newest 1575000 0 cdumez 2019-09-27 15:36:55 -0700 Add temporary HTTP header to distinguish device types for requests to Google as an experiment. 1575001 1 cdumez 2019-09-27 15:37:10 -0700 <rdar://problem/55790994> 1575010 2 379772 cdumez 2019-09-27 16:23:03 -0700 Created attachment 379772 Patch 1575012 3 379774 cdumez 2019-09-27 16:42:21 -0700 Created attachment 379774 Patch 1575070 4 379774 mjs 2019-09-28 12:35:02 -0700 Comment on attachment 379774 Patch Code change looks good. Though there's still some debate over whether we should do this, I think it would be good to land and then discuss whether to change what we are doing, given the short timeline. 1575093 5 379774 cdumez 2019-09-28 14:32:57 -0700 Comment on attachment 379774 Patch Thanks. 1575094 6 379774 cdumez 2019-09-28 14:38:18 -0700 Comment on attachment 379774 Patch Clearing flags on attachment: 379774 Committed r250483: <https://trac.webkit.org/changeset/250483> 1575095 7 cdumez 2019-09-28 14:38:20 -0700 All reviewed patches have been landed. Closing bug. 379772 2019-09-27 16:23:03 -0700 2019-09-27 16:42:19 -0700 Patch bug-202335-20190927162302.patch text/plain 2822 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNjYTU4MjAxODM4NmJj M2NlNTdiY2I5NDcwYmQ2NjU4ZGM0Y2ZlZi4uZGQ4YWMzYmFkMTBhZWYwODkwMjQ4MzA3OTMxNjc5 OTRhNjcyNjUzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA5LTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0V4cGVyaW1lbnRdW2lPU10g QWRkIHRlbXBvcmFyeSBIVFRQIGhlYWRlciB0byBkaXN0aW5ndWlzaCBpUGFkcyBmb3IgcmVxdWVz dHMgdG8gR29vZ2xlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDIzMzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1NzkwOTk0PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0Nh Y2hlZFJlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNl TG9hZGVyOjpyZXF1ZXN0UmVzb3VyY2UpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvSFRU UEhlYWRlck5hbWVzLmluOgorCiAyMDE5LTA5LTI3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgW2lQYWRPU10gQ2Fu4oCZdCB1c2UgUmFscGhMYXVyZW4uY29tIG9u IGlQYWQgYmVjYXVzZSBob3ZlciBtZW51cyBkb27igJl0IHN0YXkgdXAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwCmluZGV4IDZi NGY0OWZmYWJmZjg0YzY4MDkzMDJkMjVlZjFlYTA0ZmNhZGQ1OTguLjk0YjEyNThiMjgxMjM1YjUw OWNhNmI4NTAwZDFkYmYyMGJkZTJlYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcApAQCAtODgsNiArODgsMTAgQEAKICNp bmNsdWRlICJDYWNoZWRUZXh0VHJhY2suaCIKICNlbmRpZgogCisjaWYgUExBVEZPUk0oSU9TX0ZB TUlMWSkKKyNpbmNsdWRlICJEZXZpY2UuaCIKKyNlbmRpZgorCiAjdW5kZWYgUkVMRUFTRV9MT0df SUZfQUxMT1dFRAogI2RlZmluZSBSRUxFQVNFX0xPR19JRl9BTExPV0VEKGZtdCwgLi4uKSBSRUxF QVNFX0xPR19JRihpc0Fsd2F5c09uTG9nZ2luZ0FsbG93ZWQoKSwgTmV0d29yaywgIiVwIC0gQ2Fj aGVkUmVzb3VyY2VMb2FkZXI6OiIgZm10LCB0aGlzLCAjI19fVkFfQVJHU19fKQogCkBAIC04Njcs NiArODcxLDE2IEBAIFJlc291cmNlRXJyb3JPcjxDYWNoZWRSZXNvdXJjZUhhbmRsZTxDYWNoZWRS ZXNvdXJjZT4+IENhY2hlZFJlc291cmNlTG9hZGVyOjpyZXF1CiAgICAgICAgIH0KICAgICB9CiAK KyAgICAvLyBGSVhNRTogVGhpcyBpcyB0ZW1wb3JhcnkgZm9yIDxyZGFyOi8vcHJvYmxlbS81NTc5 MDk5ND4uCisjaWYgUExBVEZPUk0oSU9TKSAmJiAhUExBVEZPUk0oSU9TTUFDKQorICAgIGlmICgh cGFnZS5zZXNzaW9uSUQoKS5pc0VwaGVtZXJhbCgpICYmIGRldmljZUhhc0lQYWRDYXBhYmlsaXR5 KCkpIHsKKyAgICAgICAgYXV0byBob3N0ID0gcmVxdWVzdC5yZXNvdXJjZVJlcXVlc3QoKS51cmwo KS5ob3N0KCk7CisgICAgICAgIGlmIChyZXF1ZXN0LnJlc291cmNlUmVxdWVzdCgpLnVybCgpLnBy b3RvY29sSXMoImh0dHBzIikKKyAgICAgICAgICAgICYmIChob3N0LnN0YXJ0c1dpdGhJZ25vcmlu Z0FTQ0lJQ2FzZSgiZ29vZ2xlLiIpIHx8IGhvc3Quc3RhcnRzV2l0aElnbm9yaW5nQVNDSUlDYXNl KCJ3d3cuZ29vZ2xlLiIpIHx8IGhvc3Quc3RhcnRzV2l0aElnbm9yaW5nQVNDSUlDYXNlKCJpbWFn ZXMuZ29vZ2xlLiIpKSkKKyAgICAgICAgICAgIHJlcXVlc3QucmVzb3VyY2VSZXF1ZXN0KCkuc2V0 SFRUUEhlYWRlckZpZWxkKEhUVFBIZWFkZXJOYW1lOjpYVGVtcFRhYmxldCwgIjEiX3MpOworICAg IH0KKyNlbmRpZgorCiAgICAgTG9hZFRpbWluZyBsb2FkVGltaW5nOwogICAgIGxvYWRUaW1pbmcu bWFya1N0YXJ0VGltZUFuZEZldGNoU3RhcnQoKTsKICAgICBJbml0aWF0b3JDb250ZXh0IGluaXRp YXRvckNvbnRleHQgPSByZXF1ZXN0Lm9wdGlvbnMoKS5pbml0aWF0b3JDb250ZXh0OwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTmFtZXMuaW4g Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJOYW1lcy5pbgppbmRl eCA2YzY4ZmUxNDhkMWYxZjY5NGMzODFhNWJjYWEzMTNmNDY3ZDc2YjlhLi5kM2Q5NjVlN2MzZTY3 ZWI1OWExZmQxMmNiMzNjYjcxYTg0YTNjZWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJOYW1lcy5pbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJOYW1lcy5pbgpAQCAtMTA0LDYgKzEwNCw3IEBAIFgt U291cmNlTWFwCiBYLVdlYktpdC1DU1AKIFgtV2ViS2l0LUNTUC1SZXBvcnQtT25seQogWC1YU1Mt UHJvdGVjdGlvbgorWC1UZW1wLVRhYmxldAogCiAvLyBUaGVzZSBoZWFkZXJzIGFyZSBzcGVjaWZp YyB0byBHU3RyZWFtZXIuCiBJY3ktTWV0YUludAo= 379774 2019-09-27 16:42:21 -0700 2019-09-28 14:38:18 -0700 Patch bug-202335-20190927164220.patch text/plain 2974 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNjYTU4MjAxODM4NmJj M2NlNTdiY2I5NDcwYmQ2NjU4ZGM0Y2ZlZi4uZGQ4YWMzYmFkMTBhZWYwODkwMjQ4MzA3OTMxNjc5 OTRhNjcyNjUzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA5LTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0V4cGVyaW1lbnRdW2lPU10g QWRkIHRlbXBvcmFyeSBIVFRQIGhlYWRlciB0byBkaXN0aW5ndWlzaCBpUGFkcyBmb3IgcmVxdWVz dHMgdG8gR29vZ2xlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDIzMzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1NzkwOTk0PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0Nh Y2hlZFJlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNl TG9hZGVyOjpyZXF1ZXN0UmVzb3VyY2UpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvSFRU UEhlYWRlck5hbWVzLmluOgorCiAyMDE5LTA5LTI3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgW2lQYWRPU10gQ2Fu4oCZdCB1c2UgUmFscGhMYXVyZW4uY29tIG9u IGlQYWQgYmVjYXVzZSBob3ZlciBtZW51cyBkb27igJl0IHN0YXkgdXAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwCmluZGV4IDZi NGY0OWZmYWJmZjg0YzY4MDkzMDJkMjVlZjFlYTA0ZmNhZGQ1OTguLmVkNGE5OWZlM2U2YjI4Y2Jm M2ZkMDkzNmUyMzE0NGRmNTJiYzJkYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcApAQCAtODgsNiArODgsMTAgQEAKICNp bmNsdWRlICJDYWNoZWRUZXh0VHJhY2suaCIKICNlbmRpZgogCisjaWYgUExBVEZPUk0oSU9TX0ZB TUlMWSkKKyNpbmNsdWRlICJEZXZpY2UuaCIKKyNlbmRpZgorCiAjdW5kZWYgUkVMRUFTRV9MT0df SUZfQUxMT1dFRAogI2RlZmluZSBSRUxFQVNFX0xPR19JRl9BTExPV0VEKGZtdCwgLi4uKSBSRUxF QVNFX0xPR19JRihpc0Fsd2F5c09uTG9nZ2luZ0FsbG93ZWQoKSwgTmV0d29yaywgIiVwIC0gQ2Fj aGVkUmVzb3VyY2VMb2FkZXI6OiIgZm10LCB0aGlzLCAjI19fVkFfQVJHU19fKQogCkBAIC04Njcs NiArODcxLDE4IEBAIFJlc291cmNlRXJyb3JPcjxDYWNoZWRSZXNvdXJjZUhhbmRsZTxDYWNoZWRS ZXNvdXJjZT4+IENhY2hlZFJlc291cmNlTG9hZGVyOjpyZXF1CiAgICAgICAgIH0KICAgICB9CiAK KyAgICAvLyBGSVhNRTogVGhpcyBpcyB0ZW1wb3JhcnkgZm9yIDxyZGFyOi8vcHJvYmxlbS81NTc5 MDk5ND4uCisjaWYgUExBVEZPUk0oSU9TKSAmJiAhUExBVEZPUk0oSU9TTUFDKQorICAgIGlmICgh cGFnZS5zZXNzaW9uSUQoKS5pc0VwaGVtZXJhbCgpICYmIGRldmljZUhhc0lQYWRDYXBhYmlsaXR5 KCkgJiYgcmVxdWVzdC5yZXNvdXJjZVJlcXVlc3QoKS51cmwoKS5wcm90b2NvbElzKCJodHRwcyIp KSB7CisgICAgICAgIFJlZ2lzdHJhYmxlRG9tYWluIHJlZ2lzdHJhYmxlRG9tYWluKHJlcXVlc3Qu cmVzb3VyY2VSZXF1ZXN0KCkudXJsKCkpOworICAgICAgICBpZiAocmVnaXN0cmFibGVEb21haW4u c3RyaW5nKCkuc3RhcnRzV2l0aCgiZ29vZ2xlLiIpKSB7CisgICAgICAgICAgICBhdXRvIGhvc3Qg PSByZXF1ZXN0LnJlc291cmNlUmVxdWVzdCgpLnVybCgpLmhvc3QoKTsKKyAgICAgICAgICAgIGlm IChob3N0LnN0YXJ0c1dpdGhJZ25vcmluZ0FTQ0lJQ2FzZSgiZ29vZ2xlLiIpIHx8IGhvc3Quc3Rh cnRzV2l0aElnbm9yaW5nQVNDSUlDYXNlKCJ3d3cuZ29vZ2xlLiIpIHx8IGhvc3Quc3RhcnRzV2l0 aElnbm9yaW5nQVNDSUlDYXNlKCJpbWFnZXMuZ29vZ2xlLiIpKQorICAgICAgICAgICAgICAgIHJl cXVlc3QucmVzb3VyY2VSZXF1ZXN0KCkuc2V0SFRUUEhlYWRlckZpZWxkKEhUVFBIZWFkZXJOYW1l OjpYVGVtcFRhYmxldCwgIjEiX3MpOworICAgICAgICB9CisgICAgfQorI2VuZGlmCisKICAgICBM b2FkVGltaW5nIGxvYWRUaW1pbmc7CiAgICAgbG9hZFRpbWluZy5tYXJrU3RhcnRUaW1lQW5kRmV0 Y2hTdGFydCgpOwogICAgIEluaXRpYXRvckNvbnRleHQgaW5pdGlhdG9yQ29udGV4dCA9IHJlcXVl c3Qub3B0aW9ucygpLmluaXRpYXRvckNvbnRleHQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJOYW1lcy5pbiBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvSFRUUEhlYWRlck5hbWVzLmluCmluZGV4IDZjNjhmZTE0OGQxZjFmNjk0 YzM4MWE1YmNhYTMxM2Y0NjdkNzZiOWEuLmQzZDk2NWU3YzNlNjdlYjU5YTFmZDEyY2IzM2NiNzFh ODRhM2NlYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRU UEhlYWRlck5hbWVzLmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRU UEhlYWRlck5hbWVzLmluCkBAIC0xMDQsNiArMTA0LDcgQEAgWC1Tb3VyY2VNYXAKIFgtV2ViS2l0 LUNTUAogWC1XZWJLaXQtQ1NQLVJlcG9ydC1Pbmx5CiBYLVhTUy1Qcm90ZWN0aW9uCitYLVRlbXAt VGFibGV0CiAKIC8vIFRoZXNlIGhlYWRlcnMgYXJlIHNwZWNpZmljIHRvIEdTdHJlYW1lci4KIElj eS1NZXRhSW50Cg==