202333 2019-09-27 14:19:25 -0700 Check values of variables before extracting index in perl 2019-10-17 08:16:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pmatos pmatos commit-queue dbates ews-watchlist jbedard webkit-bug-importer oldest_to_newest 1574976 0 pmatos 2019-09-27 14:19:25 -0700 Check values of variables before extracting index in perl 1574978 1 379766 pmatos 2019-09-27 14:21:10 -0700 Created attachment 379766 Patch 1574981 2 pmatos 2019-09-27 14:24:24 -0700 The problem here is that some gcc versions do not have target or host variables set when built. An example, is gcc-8 from Arch Linux, whose version shows: $ gcc-8 -v Using built-in specs. COLLECT_GCC=gcc-8 COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/8.3.0/lto-wrapper Target: x86_64-pc-linux-gnu Configured with: /build/gcc8/src/gcc/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,fortran,lto --enable-shared --enable-threads=posix --enable-libmpx --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --disable-multilib --disable-werror --enable-checking=release --enable-default-pie --enable-default-ssp --enable-cet=auto --program-suffix=-8 --enable-version-specific-runtime-libs Thread model: posix gcc version 8.3.0 (GCC) This was causing a warning in the perl script because @target[0] and @host[0] are not defined if the regexp fails to match. I noticed the warning while doing: CC=gcc-8 CXX=g++-8 Tools/Scripts/build-jsc --jsc-only --debug 1575083 3 379766 ap 2019-09-28 13:24:31 -0700 Comment on attachment 379766 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379766&action=review > Tools/Scripts/webkitdirs.pm:1393 > + if (!@target || !@host) { This seems worth explaining in a comment. It’s not even clear from bug comments why this situation implies cross-compilation, and it will be even more mysterious without the context. 1580940 4 381190 pmatos 2019-10-17 05:39:12 -0700 Created attachment 381190 Patch 1580941 5 pmatos 2019-10-17 05:41:02 -0700 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 379766 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=379766&action=review > > > Tools/Scripts/webkitdirs.pm:1393 > > + if (!@target || !@host) { > > This seems worth explaining in a comment. It’s not even clear from bug > comments why this situation implies cross-compilation, and it will be even > more mysterious without the context. Apologies for the delay on this. You are correct that we should not assume cross-compilation, if there's no information about host or target on the compiler version information we assume no cross-compilation. Have now uploaded new patch. 1580956 6 381190 commit-queue 2019-10-17 08:15:05 -0700 Comment on attachment 381190 Patch Clearing flags on attachment: 381190 Committed r251234: <https://trac.webkit.org/changeset/251234> 1580957 7 commit-queue 2019-10-17 08:15:06 -0700 All reviewed patches have been landed. Closing bug. 1580958 8 webkit-bug-importer 2019-10-17 08:16:19 -0700 <rdar://problem/56370686> 379766 2019-09-27 14:21:10 -0700 2019-10-17 05:39:09 -0700 Patch bug-202333-20190927232048.patch text/plain 1437 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNDIxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDc0NmM2MTgwN2Q1NWQ0YzZmMDRmYTQ5NmI3MDRjNDg5 Y2Y3Nzc3ZC4uMzEyZGM0YTYzOGMxMGYxNzI5OTFjZWEwZGMwZTYyMTkzYWJmYzI1NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTA5LTI3ICBQYXVsbyBNYXRvcyAgPHBtYXRvc0BpZ2FsaWEuY29tPgorCisgICAg ICAgIENoZWNrIHZhbHVlcyBvZiB2YXJpYWJsZXMgYmVmb3JlIGV4dHJhY3RpbmcgaW5kZXggaW4g cGVybAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAy MzMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChpc0Nyb3NzQ29tcGlsYXRpb24pOgorCiAy MDE5LTA5LTI3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmVtb3ZlIHVudXNlZCBBUElQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb246OmRpc2tD YWNoZVNwZWN1bGF0aXZlVmFsaWRhdGlvbkVuYWJsZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBhZTc5 NDJlOWI2MDNiNmZkZGVkNzM0YmEwMWY5YTA0NDU5OTYxYTg1Li4yODlhMmM2MjYxZWI4MWYwZjM3 NThhYWUyNTk4YmQ4ZTYwNWQxYzdiIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xMzkwLDcgKzEzOTAs MTAgQEAgc3ViIGlzQ3Jvc3NDb21waWxhdGlvbigpCiAgICAgICAgIG15ICRjb21waWxlck9wdGlv bnMgPSBgJGNvbXBpbGVyIC12IDI+JjFgOwogICAgICAgICBteSBAaG9zdCA9ICRjb21waWxlck9w dGlvbnMgPX4gbS8tLWhvc3Q9KC4qPylccy87CiAgICAgICAgIG15IEB0YXJnZXQgPSAkY29tcGls ZXJPcHRpb25zID1+IG0vLS10YXJnZXQ9KC4qPylccy87Ci0gICAgICAgIGlmICgkdGFyZ2V0WzBd IG5lICIiICYmICRob3N0WzBdIG5lICIiKSB7CisgICAgICAgIGlmICghQHRhcmdldCB8fCAhQGhv c3QpIHsKKyAgICAgICAgICAgIHJldHVybiAxOworICAgICAgICB9CisgICAgICAgIGVsc2lmICgk dGFyZ2V0WzBdIG5lICIiICYmICRob3N0WzBdIG5lICIiKSB7CiAgICAgICAgICAgICAgICAgcmV0 dXJuICgkaG9zdFswXSBuZSAkdGFyZ2V0WzBdKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAg ICAgICAgICAjICR0ZW1wRGlyIGdldHMgYXV0b21hdGljYWxseSBkZWxldGVkIHdoZW4gZ29lcyBv dXQgb2Ygc2NvcGUK 381190 2019-10-17 05:39:12 -0700 2019-10-17 08:15:05 -0700 Patch bug-202333-20191017143910.patch text/plain 1824 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMjMxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDY5NmVjMzAzNDQyNjI4NGExMjE0OTRkYjc3NDRkNjAz NDc4YTRjZS4uNDgxYzgxMjUzOGVkYjkyN2VhYzZiZDY0NTZjOTM0N2NlMmJlN2MzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTEwLTE3ICBQYXVsbyBNYXRvcyAgPHBtYXRvc0BpZ2FsaWEuY29tPgorCisgICAg ICAgIENoZWNrIHZhbHVlcyBvZiB2YXJpYWJsZXMgYmVmb3JlIGV4dHJhY3RpbmcgaW5kZXggaW4g cGVybAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAy MzMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYg Y29tcGlsZXIgZG9lc24ndCBwcm9wZXJseSByZXBvcnQgdGhlIGhvc3QgYW5kIHRhcmdldCBpdCB3 YXMKKyAgICAgICAgY29tcGlsZWQgZm9yLCBsYWNraW5nIGJldHRlciBpbmZvcm1hdGlvbiB3ZSBq dXN0IGdvIGFoZWFkIGFuZCBhc3N1bWUKKyAgICAgICAgdGhlcmUgaXMgbm8gY3Jvc3MgY29tcGls YXRpb24gaW52b2x2ZWQuCisgICAgICAgIAorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bToKKyAgICAgICAgKGlzQ3Jvc3NDb21waWxhdGlvbik6CisKIDIwMTktMTAtMTYgIEFuZHkgRXN0 ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtRdWljayBMb29rXSBUZXN0IHRoYXQg bGVnYWN5IHdlYiB2aWV3cyBsb2FkIHByZXZpZXdzIGJlZm9yZSBkZWNpZGluZyBjb250ZW50IHBv bGljeQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGFlNzk0MmU5YjYwM2I2ZmRkZWQ3MzRiYTAxZjlhMDQ0 NTk5NjFhODUuLjE1ZGU1ZTM5M2U4MmU3MzcyOWE5ZGJkOTdiNjE2YjIxY2VlMjBhYmQgMTAwNzU1 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0KQEAgLTEzOTAsNyArMTM5MCwxMiBAQCBzdWIgaXNDcm9zc0NvbXBpbGF0aW9u KCkKICAgICAgICAgbXkgJGNvbXBpbGVyT3B0aW9ucyA9IGAkY29tcGlsZXIgLXYgMj4mMWA7CiAg ICAgICAgIG15IEBob3N0ID0gJGNvbXBpbGVyT3B0aW9ucyA9fiBtLy0taG9zdD0oLio/KVxzLzsK ICAgICAgICAgbXkgQHRhcmdldCA9ICRjb21waWxlck9wdGlvbnMgPX4gbS8tLXRhcmdldD0oLio/ KVxzLzsKLSAgICAgICAgaWYgKCR0YXJnZXRbMF0gbmUgIiIgJiYgJGhvc3RbMF0gbmUgIiIpIHsK KyAgICAgICAgaWYgKCFAdGFyZ2V0IHx8ICFAaG9zdCkgeworICAgICAgICAgICAgIyBTb21ldGlt ZXMgYSBjb21waWxlciBkb2VzIG5vdCByZXBvcnQgdGhlIGhvc3Qgb2YgdGFyZ2V0IGl0IHdhcyBj b21waWxlZCBmb3IsCisgICAgICAgICAgICAjIGluIHdoaWNoIGNhc2UsIGxhY2tpbmcgYmV0dGVy IGluZm9ybWF0aW9uIHdlIGFzc3VtZSB3ZSBhcmUgbm90IGNyb3NzLWNvbXBpbGluZy4KKyAgICAg ICAgICAgIHJldHVybiAwOworICAgICAgICB9CisgICAgICAgIGVsc2lmICgkdGFyZ2V0WzBdIG5l ICIiICYmICRob3N0WzBdIG5lICIiKSB7CiAgICAgICAgICAgICAgICAgcmV0dXJuICgkaG9zdFsw XSBuZSAkdGFyZ2V0WzBdKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICAjICR0 ZW1wRGlyIGdldHMgYXV0b21hdGljYWxseSBkZWxldGVkIHdoZW4gZ29lcyBvdXQgb2Ygc2NvcGUK