202325 2019-09-27 11:26:03 -0700 [Win] Crash under FontCache::lastResortFallbackFont 2019-09-27 14:05:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue ews-watchlist mmaxfield webkit-bug-importer oldest_to_newest 1574898 0 pvollan 2019-09-27 11:26:03 -0700 Backtrace: WebKit.dll!WebCore::FontCache::lastResortFallbackFont(const WebCore::FontDescription & fontDescription) Line 393 C++ Symbols loaded. WebKit.dll!WebCore::FontCascadeFonts::realizeFallbackRangesAt(const WebCore::FontCascadeDescription & description, unsigned int index) Line 188 C++ Symbols loaded. [Inline Frame] WebKit.dll!WebCore::FontCascadeFonts::primaryFont(const WebCore::FontCascadeDescription & description) Line 128 C++ Symbols loaded. [Inline Frame] WebKit.dll!WebCore::FontCascade::primaryFont() Line 337 C++ Symbols loaded. WebKit.dll!WebCore::StyleResolver::StyleResolver(WebCore::Document & document) Line 227 C++ Symbols loaded. [Inline Frame] WebKit.dll!std::make_unique(WebCore::Document & <_Args_0>) Line 2539 C++ Symbols loaded. WebKit.dll!WebCore::Style::Scope::resolver() Line 100 C++ Symbols loaded. [Inline Frame] WebKit.dll!WebCore::Style::TreeResolver::Scope::{ctor}(WebCore::Document & document) Line 67 C++ Symbols loaded. WebKit.dll!WebCore::Style::TreeResolver::resolve() Line 544 C++ Symbols loaded. WebKit.dll!WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType type) Line 1938 C++ Symbols loaded. WebKit.dll!WebCore::Document::updateStyleIfNeeded() Line 2082 C++ Symbols loaded. WebKit.dll!WebCore::Document::finishedParsing() Line 5756 C++ Symbols loaded. [Inline Frame] WebKit.dll!WebCore::HTMLDocumentParser::end() Line 427 C++ Symbols loaded. [Inline Frame] WebKit.dll!WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() Line 436 C++ Symbols loaded. WebKit.dll!WebCore::HTMLDocumentParser::prepareToStopParsing() Line 142 C++ Symbols loaded. [Inline Frame] WebKit.dll!WebCore::HTMLDocumentParser::attemptToEnd() Line 448 C++ Symbols loaded. WebKit.dll!WebCore::HTMLDocumentParser::finish() Line 476 C++ Symbols loaded. WebKit.dll!WebCore::DocumentWriter::end() Line 289 C++ Symbols loaded. WebKit.dll!WebCore::DocumentLoader::finishedLoading() Line 446 C++ Symbols loaded. WebKit.dll!WebCore::DocumentLoader::maybeLoadEmpty() Line 1715 C++ Symbols loaded. WebKit.dll!WebCore::DocumentLoader::startLoadingMainResource() Line 1728 C++ Symbols loaded. WebKit.dll!WebCore::FrameLoader::init() Line 315 C++ Symbols loaded. WebKit.dll!WebView::initWithFrame(tagRECT frame, wchar_t * frameName, wchar_t * groupName) Line 3160 C++ Symbols loaded. 1574905 1 379746 pvollan 2019-09-27 11:34:25 -0700 Created attachment 379746 Patch 1574908 2 pvollan 2019-09-27 11:40:49 -0700 <rdar://problem/47856730> 1574910 3 379748 pvollan 2019-09-27 11:42:51 -0700 Created attachment 379748 Patch 1574938 4 379748 bfulgham 2019-09-27 13:18:27 -0700 Comment on attachment 379748 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379748&action=review Thank's for tracking this down. > Source/WebCore/platform/graphics/win/FontCacheWin.cpp:-398 > - return *simpleFont; Oh no! 1574939 5 pvollan 2019-09-27 13:21:31 -0700 (In reply to Brent Fulgham from comment #4) > Comment on attachment 379748 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=379748&action=review > > Thank's for tracking this down. > > > Source/WebCore/platform/graphics/win/FontCacheWin.cpp:-398 > > - return *simpleFont; > > Oh no! Thanks for reviewing, Brent! 1574968 6 379748 commit-queue 2019-09-27 14:05:11 -0700 Comment on attachment 379748 Patch Clearing flags on attachment: 379748 Committed r250459: <https://trac.webkit.org/changeset/250459> 1574969 7 commit-queue 2019-09-27 14:05:13 -0700 All reviewed patches have been landed. Closing bug. 379746 2019-09-27 11:34:25 -0700 2019-09-27 11:42:49 -0700 Patch bug-202325-20190927203426.patch text/plain 1691 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MDQzNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA5LTI3ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBDcmFzaCB1bmRl ciBGb250Q2FjaGU6Omxhc3RSZXNvcnRGYWxsYmFja0ZvbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjMyNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGRlbW9uc3RyYXRlZCBieSBjcmFzaCByZXBv cnRzLCB0aGVyZSBzZWVtcyB0byBiZSBjYXNlcyB3aGVyZSB3ZSBhcmUgbm90IGFibGUgdG8gY3Jl YXRlIGEgbGFzdCByZXNvcnQgZmFsbGJhY2sgZm9udCAgCisgICAgICAgIG9uIFdpbmRvd3MuIElm IGFsbCBhdHRlbXB0cyB0byBjcmVhdGUgYSBmYWxsYmFjayBmb250IGZhaWwsIGNyZWF0ZSBhIGZv bnQgZnJvbSB0aGUgZGVmYXVsdCBVSSBmb250LgorIAorICAgICAgICBObyBuZXcgdGVzdHMuIEkg aGF2ZSBub3QgYmVlbiBhYmxlIHRvIHJlcHJvZHVjZSB0aGlzIGlzc3VlLiAKKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q2FjaGVXaW4uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Rm9udENhY2hlOjpsYXN0UmVzb3J0RmFsbGJhY2tGb250KToKKwogMjAxOS0wOS0yNyAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgRmxha3kgVGVzdDogaW5z cGVjdG9yL2NhbnZhcy91cGRhdGVTaGFkZXIuaHRtbApJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvd2luL0ZvbnRDYWNoZVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ZvbnRDYWNoZVdpbi5jcHAJKHJldmlzaW9u IDI1MDAwMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q2Fj aGVXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOTQsOCArMzk0LDkgQEAgUmVmPEZvbnQ+IEZv bnRDYWNoZTo6bGFzdFJlc29ydEZhbGxiYWNrRgogICAgICAgICAgICAgcmV0dXJuICpzaW1wbGVG b250OwogICAgIH0KICAgICAKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICByZXR1cm4g KnNpbXBsZUZvbnQ7CisgICAgYXV0byBoRm9udCA9IGFkb3B0R0RJT2JqZWN0KHN0YXRpY19jYXN0 PEhGT05UPihHZXRTdG9ja09iamVjdChERUZBVUxUX0dVSV9GT05UKSkpOworICAgIEZvbnRQbGF0 Zm9ybURhdGEgcGxhdGZvcm1EYXRhKFdURk1vdmUoaEZvbnQpLCBmb250RGVzY3JpcHRpb24uY29t cHV0ZWRQaXhlbFNpemUoKSwgZmFsc2UsIGZhbHNlLCBmYWxzZSk7CisgICAgcmV0dXJuIGZvbnRG b3JQbGF0Zm9ybURhdGEocGxhdGZvcm1EYXRhKTsKIH0KIAogc3RhdGljIExPTkcgdG9HRElGb250 V2VpZ2h0KEZvbnRTZWxlY3Rpb25WYWx1ZSBmb250V2VpZ2h0KQo= 379748 2019-09-27 11:42:51 -0700 2019-09-27 14:05:11 -0700 Patch bug-202325-20190927204251.patch text/plain 1726 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MDQzNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA5LTI3ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBDcmFzaCB1bmRl ciBGb250Q2FjaGU6Omxhc3RSZXNvcnRGYWxsYmFja0ZvbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjMyNQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNDc4NTY3MzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXMgZGVtb25zdHJhdGVkIGJ5IGNyYXNoIHJlcG9ydHMsIHRoZXJlIHNlZW1zIHRvIGJl IGNhc2VzIHdoZXJlIHdlIGFyZSBub3QgYWJsZSB0byBjcmVhdGUgYSBsYXN0IHJlc29ydCBmYWxs YmFjayBmb250ICAKKyAgICAgICAgb24gV2luZG93cy4gSWYgYWxsIGF0dGVtcHRzIHRvIGNyZWF0 ZSBhIGZhbGxiYWNrIGZvbnQgZmFpbCwgY3JlYXRlIGEgZm9udCBmcm9tIHRoZSBkZWZhdWx0IFVJ IGZvbnQuCisgCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gSSBoYXZlIG5vdCBiZWVuIGFibGUgdG8g cmVwcm9kdWNlIHRoaXMgaXNzdWUuIAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2lu L0ZvbnRDYWNoZVdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250Q2FjaGU6Omxhc3RSZXNv cnRGYWxsYmFja0ZvbnQpOgorCiAyMDE5LTA5LTI3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFw cGxlLmNvbT4KIAogICAgICAgICBGbGFreSBUZXN0OiBpbnNwZWN0b3IvY2FudmFzL3VwZGF0ZVNo YWRlci5odG1sCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9u dENhY2hlV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy93aW4vRm9udENhY2hlV2luLmNwcAkocmV2aXNpb24gMjUwMDAwKQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ZvbnRDYWNoZVdpbi5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM5NCw4ICszOTQsOSBAQCBSZWY8Rm9udD4gRm9udENhY2hlOjpsYXN0UmVzb3J0RmFs bGJhY2tGCiAgICAgICAgICAgICByZXR1cm4gKnNpbXBsZUZvbnQ7CiAgICAgfQogICAgIAotICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgIHJldHVybiAqc2ltcGxlRm9udDsKKyAgICBhdXRv IGhGb250ID0gYWRvcHRHRElPYmplY3Qoc3RhdGljX2Nhc3Q8SEZPTlQ+KEdldFN0b2NrT2JqZWN0 KERFRkFVTFRfR1VJX0ZPTlQpKSk7CisgICAgRm9udFBsYXRmb3JtRGF0YSBwbGF0Zm9ybURhdGEo V1RGTW92ZShoRm9udCksIGZvbnREZXNjcmlwdGlvbi5jb21wdXRlZFBpeGVsU2l6ZSgpLCBmYWxz ZSwgZmFsc2UsIGZhbHNlKTsKKyAgICByZXR1cm4gZm9udEZvclBsYXRmb3JtRGF0YShwbGF0Zm9y bURhdGEpOwogfQogCiBzdGF0aWMgTE9ORyB0b0dESUZvbnRXZWlnaHQoRm9udFNlbGVjdGlvblZh bHVlIGZvbnRXZWlnaHQpCg==