202323 2019-09-27 10:42:04 -0700 Layout Test http/tests/cache-storage/cache-records-persistency.https.html is failing 2019-09-27 13:50:04 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell achristensen achristensen thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1574876 0 tsavell 2019-09-27 10:42:04 -0700 The following layout tests are failing on Mac and iOS WK2 http/tests/cache-storage/cache-clearing-origin.https.html http/tests/cache-storage/cache-origins.https.html http/tests/cache-storage/cache-persistency.https.html http/tests/cache-storage/cache-records-persistency.https.html Probable cause: These tests are failing in tandem together sense around r250350 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcache-storage%2Fcache-clearing-origin.https.html%20http%2Ftests%2Fcache-storage%2Fcache-origins.https.html%20http%2Ftests%2Fcache-storage%2Fcache-persistency.https.html%20http%2Ftests%2Fcache-storage%2Fcache-records-persistency.https.html I was able to reproduce these failures together using a test list and bisection. I found that if you run http/tests/IndexedDB/storage-limit-2.https.html before these 4 tests they all fail. Reproduction: run-webkit-tests --root testbuild-250425 http/tests/IndexedDB/storage-limit-2.https.html http/tests/cache-storage/cache-clearing-origin.https.html http/tests/cache-storage/cache-origins.https.html http/tests/cache-storage/cache-persistency.https.html http/tests/cache-storage/cache-records-persistency.https.html --child-processes 1 1574877 1 webkit-bug-importer 2019-09-27 10:42:52 -0700 <rdar://problem/55787004> 1574878 2 tsavell 2019-09-27 10:45:49 -0700 Bisecting the revisions of this failure found that r250351 is to blame. 250350 passes 250351 fails 1574879 3 webkit-bug-importer 2019-09-27 10:46:02 -0700 <rdar://problem/55787137> 1574880 4 webkit-bug-importer 2019-09-27 10:47:17 -0700 <rdar://problem/55787181> 1574891 5 achristensen 2019-09-27 11:00:04 -0700 I can reproduce this and am looking into it. 1574914 6 379751 achristensen 2019-09-27 11:49:39 -0700 Created attachment 379751 Patch 1574936 7 379751 thorton 2019-09-27 13:12:05 -0700 Comment on attachment 379751 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379751&action=review > Source/WebKit/ChangeLog:16 > + This needs more words 1574957 8 achristensen 2019-09-27 13:50:04 -0700 http://trac.webkit.org/r250456 379751 2019-09-27 11:49:39 -0700 2019-09-27 13:12:05 -0700 Patch bug-202323-20190927114938.patch text/plain 5247 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTA0MzYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA5LTI3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTGF5b3V0IFRlc3Qg aHR0cC90ZXN0cy9jYWNoZS1zdG9yYWdlL2NhY2hlLXJlY29yZHMtcGVyc2lzdGVuY3kuaHR0cHMu aHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDIzMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdl YktpdDo6TmV0d29ya1Byb2Nlc3M6OmluaXRpYWxpemVOZXR3b3JrUHJvY2Vzcyk6CisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3BwOgor ICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6ZW5jb2Rl IGNvbnN0KToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3NDcmVhdGlvblBhcmFtZXRl cnM6OmRlY29kZSk6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3NDcmVh dGlvblBhcmFtZXRlcnMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6ZW5zdXJlTmV0d29ya1Byb2Nlc3Mp OgorCiAyMDE5LTA5LTI3ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5j b20+CiAKICAgICAgICAgW2lPU106IFdoZW4gaW5zZXJ0aW5nIGEgcGhvdG8gYW5kIHRoZW4gaW5z ZXJ0aW5nIGF1dG8tY29ycmVjdGVkIHRleHQsIHRoZSBwaG90byBpcyByZW1vdmVkCkluZGV4OiBT b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcAkocmV2 aXNpb24gMjUwNDI2KQorKysgU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJv Y2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyMiw4ICszMjIsNiBAQCB2b2lkIE5ldHdvcmtQ cm9jZXNzOjppbml0aWFsaXplTmV0d29ya1ByCiAKICAgICBhdXRvIHNlc3Npb25JRCA9IHBhcmFt ZXRlcnMuZGVmYXVsdERhdGFTdG9yZVBhcmFtZXRlcnMubmV0d29ya1Nlc3Npb25QYXJhbWV0ZXJz LnNlc3Npb25JRDsKICAgICBzZXRTZXNzaW9uKHNlc3Npb25JRCwgTmV0d29ya1Nlc3Npb246OmNy ZWF0ZSgqdGhpcywgV1RGTW92ZShwYXJhbWV0ZXJzLmRlZmF1bHREYXRhU3RvcmVQYXJhbWV0ZXJz Lm5ldHdvcmtTZXNzaW9uUGFyYW1ldGVycykpKTsKLSAgICBmb3IgKGF1dG8mJiBwYXJhbWV0ZXJz IDogV1RGTW92ZShwYXJhbWV0ZXJzLm5vbkRlZmF1bHREYXRhU3RvcmVQYXJhbWV0ZXJzKSkKLSAg ICAgICAgYWRkV2Vic2l0ZURhdGFTdG9yZShXVEZNb3ZlKHBhcmFtZXRlcnMpKTsKIAogI2lmIEVO QUJMRShJTkRFWEVEX0RBVEFCQVNFKQogICAgIGFkZEluZGV4ZWREYXRhYmFzZVNlc3Npb24oc2Vz c2lvbklELCBwYXJhbWV0ZXJzLmRlZmF1bHREYXRhU3RvcmVQYXJhbWV0ZXJzLmluZGV4ZWREYXRh YmFzZURpcmVjdG9yeSwgcGFyYW1ldGVycy5kZWZhdWx0RGF0YVN0b3JlUGFyYW1ldGVycy5pbmRl eGVkRGF0YWJhc2VEaXJlY3RvcnlFeHRlbnNpb25IYW5kbGUpOwpJbmRleDogU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzc0Ny ZWF0aW9uUGFyYW1ldGVycy5jcHAJKHJldmlzaW9uIDI1MDQyMikKKysrIFNvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02Miw3ICs2Miw2IEBAIHZvaWQgTmV0d29ya1Byb2Nlc3NDcmVhdGlvblBh cmFtZXRlcnM6OmUKICAgICBlbmNvZGVyIDw8IHN1cHByZXNzZXNDb25uZWN0aW9uVGVybWluYXRp b25PblN5c3RlbUNoYW5nZTsKICNlbmRpZgogICAgIGVuY29kZXIgPDwgZGVmYXVsdERhdGFTdG9y ZVBhcmFtZXRlcnM7Ci0gICAgZW5jb2RlciA8PCBub25EZWZhdWx0RGF0YVN0b3JlUGFyYW1ldGVy czsKICNpZiBVU0UoU09VUCkKICAgICBlbmNvZGVyLmVuY29kZUVudW0oY29va2llQWNjZXB0UG9s aWN5KTsKICAgICBlbmNvZGVyIDw8IGlnbm9yZVRMU0Vycm9yczsKQEAgLTE0NiwxMiArMTQ1LDYg QEAgYm9vbCBOZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6ZAogICAgICAgICByZXR1 cm4gZmFsc2U7CiAgICAgcmVzdWx0LmRlZmF1bHREYXRhU3RvcmVQYXJhbWV0ZXJzID0gV1RGTW92 ZSgqZGVmYXVsdERhdGFTdG9yZVBhcmFtZXRlcnMpOwogCi0gICAgT3B0aW9uYWw8VmVjdG9yPFdl YnNpdGVEYXRhU3RvcmVQYXJhbWV0ZXJzPj4gbm9uRGVmYXVsdERhdGFTdG9yZVBhcmFtZXRlcnM7 Ci0gICAgZGVjb2RlciA+PiBub25EZWZhdWx0RGF0YVN0b3JlUGFyYW1ldGVyczsKLSAgICBpZiAo IW5vbkRlZmF1bHREYXRhU3RvcmVQYXJhbWV0ZXJzKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0g ICAgcmVzdWx0Lm5vbkRlZmF1bHREYXRhU3RvcmVQYXJhbWV0ZXJzID0gV1RGTW92ZSgqbm9uRGVm YXVsdERhdGFTdG9yZVBhcmFtZXRlcnMpOwotICAgIAogI2lmIFVTRShTT1VQKQogICAgIGlmICgh ZGVjb2Rlci5kZWNvZGVFbnVtKHJlc3VsdC5jb29raWVBY2NlcHRQb2xpY3kpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CkluZGV4OiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQ cm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5oCShyZXZpc2lv biAyNTA0MjIpCisrKyBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNz Q3JlYXRpb25QYXJhbWV0ZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTc4LDcgKzc4LDYgQEAgc3Ry dWN0IE5ldHdvcmtQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzIAogI2VuZGlmCiAKICAgICBXZWJz aXRlRGF0YVN0b3JlUGFyYW1ldGVycyBkZWZhdWx0RGF0YVN0b3JlUGFyYW1ldGVyczsKLSAgICBW ZWN0b3I8V2Vic2l0ZURhdGFTdG9yZVBhcmFtZXRlcnM+IG5vbkRlZmF1bHREYXRhU3RvcmVQYXJh bWV0ZXJzOwogICAgIAogI2lmIFVTRShTT1VQKQogICAgIEhUVFBDb29raWVBY2NlcHRQb2xpY3kg Y29va2llQWNjZXB0UG9saWN5IHsgSFRUUENvb2tpZUFjY2VwdFBvbGljeTo6QWx3YXlzQWNjZXB0 IH07CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCShy ZXZpc2lvbiAyNTA0MjYpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9v bC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYyOSwxMiArNjI5LDYgQEAgTmV0d29ya1Byb2Nlc3NQ cm94eSYgV2ViUHJvY2Vzc1Bvb2w6OmVucwogICAgIC8vIEFkZCBhbnkgcGxhdGZvcm0gc3BlY2lm aWMgcGFyYW1ldGVycwogICAgIHBsYXRmb3JtSW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKHBhcmFt ZXRlcnMpOwogCi0gICAgLy8gTWFrZSBzdXJlIHRoZSBuZXR3b3JrIHByb2Nlc3Mga25vd3MgYWJv dXQgYWxsIHRoZSBzZXNzaW9ucyB0aGF0IGhhdmUgYmVlbiByZWdpc3RlcmVkIGJlZm9yZSBpdCBz dGFydGVkLgotICAgIGZvciAoYXV0byYgc2Vzc2lvbklEIDogbV9zZXNzaW9uVG9QYWdlSURzTWFw LmtleXMoKSkgewotICAgICAgICBpZiAoYXV0byogd2Vic2l0ZURhdGFTdG9yZSA9IFdlYnNpdGVE YXRhU3RvcmU6OmV4aXN0aW5nTm9uRGVmYXVsdERhdGFTdG9yZUZvclNlc3Npb25JRChzZXNzaW9u SUQpKQotICAgICAgICAgICAgcGFyYW1ldGVycy5ub25EZWZhdWx0RGF0YVN0b3JlUGFyYW1ldGVy cy5hcHBlbmQod2Vic2l0ZURhdGFTdG9yZS0+cGFyYW1ldGVycygpKTsKLSAgICB9Ci0KICAgICAv LyBJbml0aWFsaXplIHRoZSBuZXR3b3JrIHByb2Nlc3MuCiAgICAgbmV0d29ya1Byb2Nlc3MtPnNl bmQoTWVzc2FnZXM6Ok5ldHdvcmtQcm9jZXNzOjpJbml0aWFsaXplTmV0d29ya1Byb2Nlc3MocGFy YW1ldGVycyksIDApOwogCkBAIC02NTIsNiArNjQ2LDEyIEBAIE5ldHdvcmtQcm9jZXNzUHJveHkm IFdlYlByb2Nlc3NQb29sOjplbnMKICAgICAgICAgd2l0aFdlYnNpdGVEYXRhU3RvcmUtPmNsZWFy UGVuZGluZ0Nvb2tpZXMoKTsKICAgICB9CiAKKyAgICAvLyBNYWtlIHN1cmUgdGhlIG5ldHdvcmsg cHJvY2VzcyBrbm93cyBhYm91dCBhbGwgdGhlIHNlc3Npb25zIHRoYXQgaGF2ZSBiZWVuIHJlZ2lz dGVyZWQgYmVmb3JlIGl0IHN0YXJ0ZWQuCisgICAgZm9yIChhdXRvJiBzZXNzaW9uSUQgOiBtX3Nl c3Npb25Ub1BhZ2VJRHNNYXAua2V5cygpKSB7CisgICAgICAgIGlmIChhdXRvKiB3ZWJzaXRlRGF0 YVN0b3JlID0gV2Vic2l0ZURhdGFTdG9yZTo6ZXhpc3RpbmdOb25EZWZhdWx0RGF0YVN0b3JlRm9y U2Vzc2lvbklEKHNlc3Npb25JRCkpCisgICAgICAgICAgICBuZXR3b3JrUHJvY2Vzcy0+YWRkU2Vz c2lvbigqd2Vic2l0ZURhdGFTdG9yZSk7CisgICAgfQorCiAgICAgbV9uZXR3b3JrUHJvY2VzcyA9 IFdURk1vdmUobmV0d29ya1Byb2Nlc3MpOwogICAgIHJldHVybiAqbV9uZXR3b3JrUHJvY2VzczsK IH0K