20231 2008-07-30 10:51:45 -0700 accNavigate: no screen element found in the specified direction should return S_FALSE 2008-08-21 19:20:42 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P3 Normal --- 1 klinktech webkit-unassigned jhoneycutt oldest_to_newest 87401 0 klinktech 2008-07-30 10:51:45 -0700 In AccessibleBase::accNavigate, if childObj is null, we should return S_FALSE, not E_FAIL (see MSDN spec: http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx). 87402 1 klinktech 2008-07-30 10:52:02 -0700 jklink: have a patch for this ready 87446 2 22567 klinktech 2008-07-30 16:02:51 -0700 Created attachment 22567 Fixes the issue described in this bug. 87639 3 22567 eric 2008-08-01 15:47:50 -0700 Comment on attachment 22567 Fixes the issue described in this bug. I assume Jon is the best person to review this. 88093 4 22567 jhoneycutt 2008-08-08 00:24:31 -0700 Comment on attachment 22567 Fixes the issue described in this bug. The ChangeLog should include the URL of the bug and of the MSDN page. r=me, thanks, Jonas! 89051 5 mrowe 2008-08-21 19:19:18 -0700 Jonas, every patch of yours that I've tried to apply has given me "Malformed patch" errors in the ChangeLog hunk. Can you please create patches using svn-create-patch in the future so that we don't have to jump through hoops and hand-edit your patches to apply them? Thanks! 89053 6 mrowe 2008-08-21 19:20:42 -0700 Landed in r35887. 22567 2008-07-30 16:02:51 -0700 2008-08-08 00:24:31 -0700 Fixes the issue described in this bug. accNavigate_patch.txt text/plain 927 klinktech SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L3dpbi9D aGFuZ2VMb2cJKHJldmlzaW9uIDM1NDYzKQ0KKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpDQpAQCAtMSwzICsxLDIxIEBADQorMjAwOC0wNy0zMCAgSm9uYXMgS2xpbmsgPGts aW5rdGVjaEBnbWFpbC5jb20+DQorDQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4NCisNCisgICAgICAgICogQWNjZXNzaWJsZUJhc2UuY3BwOg0KKyAgICAgICAgKEFjY2Vzc2li bGVCYXNlOjphY2NOYXZpZ2F0ZSk6DQorICAgICAgICAqIENoYW5nZUxvZzoNCisNCisNCiAyMDA4 LTA3LTMwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+DQogDQogICAgICAg ICBSZXZpZXdlZCBieSBTYW0uDQpJbmRleDogV2ViS2l0L3dpbi9BY2Nlc3NpYmxlQmFzZS5jcHAN Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0NCi0tLSBXZWJLaXQvd2luL0FjY2Vzc2libGVCYXNlLmNwcAkocmV2aXNpb24g MzU0NjMpDQorKysgV2ViS2l0L3dpbi9BY2Nlc3NpYmxlQmFzZS5jcHAJKHdvcmtpbmcgY29weSkN CkBAIC00NDksNyArNDUxLDcgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBBY2Nlc3NpYmxl QmFzZQ0KICAgICB9DQogDQogICAgIGlmICghY2hpbGRPYmopDQotICAgICAgICByZXR1cm4gRV9G QUlMOw0KKyAgICAgICAgcmV0dXJuIFNfRkFMU0U7DQogDQogICAgIFZfVlQocHZOYXZpZ2F0ZWRU bykgPSBWVF9ESVNQQVRDSDsNCiAgICAgVl9ESVNQQVRDSChwdk5hdmlnYXRlZFRvKSA9IHdyYXBw ZXIoY2hpbGRPYmopOw0K