20230 2008-07-30 10:31:17 -0700 get_accState should be testing state on childObj 2008-08-21 19:20:30 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 klinktech webkit-unassigned jhoneycutt oldest_to_newest 87397 0 klinktech 2008-07-30 10:31:17 -0700 In AccessibleBase::get_accState, the large conditional should be testing childObj, and not m_object . 87398 1 klinktech 2008-07-30 10:31:53 -0700 (jklink): I am working on a patch for this. 87403 2 22556 klinktech 2008-07-30 11:17:49 -0700 Created attachment 22556 Fixes the issue described in this bug. 87439 3 22556 jhoneycutt 2008-07-30 15:28:27 -0700 Comment on attachment 22556 Fixes the issue described in this bug. +2008-07-30 klinktech@gmail.com Did you mean to leave out your name? + Changes get_accState to test state on childObj, instead of m_object (BUG: http://bugs.webkit.org/show_bug.cgi?id=20230). Also adds null init of output in get_accDefaultAction. Reviewed by NOBODY (OOPS!). Could you add some line breaks? r=me! 87443 4 22565 klinktech 2008-07-30 16:00:03 -0700 Created attachment 22565 Fixes the newlines and my name =) 87444 5 22565 jhoneycutt 2008-07-30 16:01:19 -0700 Comment on attachment 22565 Fixes the newlines and my name =) Thanks! 89052 6 mrowe 2008-08-21 19:20:30 -0700 Landed in r35886. 22556 2008-07-30 11:17:49 -0700 2008-07-30 16:00:03 -0700 Fixes the issue described in this bug. get_accState_patch.txt text/plain 2826 klinktech SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiAzNTQ1NCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMDctMzAga2xpbmt0ZWNoQGdtYWlsLmNvbSAg CisKKyAgICAgICAgQ2hhbmdlcyBnZXRfYWNjU3RhdGUgdG8gdGVzdCBzdGF0ZSBvbiBjaGlsZE9i aiwgaW5zdGVhZCBvZiBtX29iamVjdCAoQlVHOiBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDIzMCkuIEFsc28gYWRkcyBudWxsIGluaXQgb2Ygb3V0cHV0IGluIGdldF9h Y2NEZWZhdWx0QWN0aW9uLiBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEFjY2Vzc2libGVCYXNlLmNwcDoKKyAgICAgICAgKEFjY2Vzc2libGVCYXNlOjpnZXRfYWNjU3Rh dGUpOgorICAgICAgICAoQWNjZXNzaWJsZUJhc2U6OmdldF9hY2NEZWZhdWx0QWN0aW9uKToKKwog MjAwOC0wNy0yOSAgQWxpY2UgTGl1ICA8YWxpY2UubGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBHZW9mZiBHYXJlbi4KSW5kZXg6IFdlYktpdC93aW4vQWNjZXNzaWJsZUJhc2Uu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQWNjZXNzaWJsZUJhc2UuY3BwCShyZXZpc2lv biAzNTQzNCkKKysrIFdlYktpdC93aW4vQWNjZXNzaWJsZUJhc2UuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yMjUsNDMgKzIyNSw0MyBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIEFjY2Vzc2li bGVCYXNlCiAgICAgcHZTdGF0ZS0+dnQgPSBWVF9JNDsKICAgICBwdlN0YXRlLT5sVmFsID0gMDsK IAotICAgIGlmIChtX29iamVjdC0+aXNBbmNob3IoKSkKKyAgICBpZiAoY2hpbGRPYmotPmlzQW5j aG9yKCkpCiAgICAgICAgIHB2U3RhdGUtPmxWYWwgfD0gU1RBVEVfU1lTVEVNX0xJTktFRDsKIAot ICAgIGlmIChtX29iamVjdC0+aXNIb3ZlcmVkKCkpCisgICAgaWYgKGNoaWxkT2JqLT5pc0hvdmVy ZWQoKSkKICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNURU1fSE9UVFJBQ0tFRDsK IAotICAgIGlmICghbV9vYmplY3QtPmlzRW5hYmxlZCgpKQorICAgIGlmICghY2hpbGRPYmotPmlz RW5hYmxlZCgpKQogICAgICAgICBwdlN0YXRlLT5sVmFsIHw9IFNUQVRFX1NZU1RFTV9VTkFWQUlM QUJMRTsKIAotICAgIGlmIChtX29iamVjdC0+aXNSZWFkT25seSgpKQorICAgIGlmIChjaGlsZE9i ai0+aXNSZWFkT25seSgpKQogICAgICAgICBwdlN0YXRlLT5sVmFsIHw9IFNUQVRFX1NZU1RFTV9S RUFET05MWTsKIAotICAgIGlmIChtX29iamVjdC0+aXNPZmZTY3JlZW4oKSkKKyAgICBpZiAoY2hp bGRPYmotPmlzT2ZmU2NyZWVuKCkpCiAgICAgICAgIHB2U3RhdGUtPmxWYWwgfD0gU1RBVEVfU1lT VEVNX09GRlNDUkVFTjsKIAotICAgIGlmIChtX29iamVjdC0+aXNNdWx0aVNlbGVjdCgpKQorICAg IGlmIChjaGlsZE9iai0+aXNNdWx0aVNlbGVjdCgpKQogICAgICAgICBwdlN0YXRlLT5sVmFsIHw9 IFNUQVRFX1NZU1RFTV9NVUxUSVNFTEVDVEFCTEU7CiAKLSAgICBpZiAobV9vYmplY3QtPmlzUGFz c3dvcmRGaWVsZCgpKQorICAgIGlmIChjaGlsZE9iai0+aXNQYXNzd29yZEZpZWxkKCkpCiAgICAg ICAgIHB2U3RhdGUtPmxWYWwgfD0gU1RBVEVfU1lTVEVNX1BST1RFQ1RFRDsKIAotICAgIGlmICht X29iamVjdC0+aXNJbmRldGVybWluYXRlKCkpCisgICAgaWYgKGNoaWxkT2JqLT5pc0luZGV0ZXJt aW5hdGUoKSkKICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNURU1fSU5ERVRFUk1J TkFURTsKIAotICAgIGlmIChtX29iamVjdC0+aXNDaGVja2VkKCkpCisgICAgaWYgKGNoaWxkT2Jq LT5pc0NoZWNrZWQoKSkKICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNURU1fQ0hF Q0tFRDsKIAotICAgIGlmIChtX29iamVjdC0+aXNQcmVzc2VkKCkpCisgICAgaWYgKGNoaWxkT2Jq LT5pc1ByZXNzZWQoKSkKICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNURU1fUFJF U1NFRDsKIAotICAgIGlmIChtX29iamVjdC0+aXNGb2N1c2VkKCkpCisgICAgaWYgKGNoaWxkT2Jq LT5pc0ZvY3VzZWQoKSkKICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNURU1fRk9D VVNFRDsKIAotICAgIGlmIChtX29iamVjdC0+aXNWaXNpdGVkKCkpCisgICAgaWYgKGNoaWxkT2Jq LT5pc1Zpc2l0ZWQoKSkKICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNURU1fVFJB VkVSU0VEOwogCi0gICAgaWYgKG1fb2JqZWN0LT5jYW5TZXRGb2N1c0F0dHJpYnV0ZSgpKQorICAg IGlmIChjaGlsZE9iai0+Y2FuU2V0Rm9jdXNBdHRyaWJ1dGUoKSkKICAgICAgICAgcHZTdGF0ZS0+ bFZhbCB8PSBTVEFURV9TWVNURU1fRk9DVVNBQkxFOwogCiAgICAgLy8gVE9ETzogQWRkIHNlbGVj dGVkIGFuZCBzZWxlY3RhYmxlIHN0YXRlcy4KQEAgLTM2Niw2ICszNjYsOCBAQCBIUkVTVUxUIFNU RE1FVEhPRENBTExUWVBFIEFjY2Vzc2libGVCYXNlCiAgICAgaWYgKCFhY3Rpb24pCiAgICAgICAg IHJldHVybiBFX1BPSU5URVI7CiAKKyAgICAqYWN0aW9uID0gMDsKKwogICAgIEFjY2Vzc2liaWxp dHlPYmplY3QqIGNoaWxkT2JqOwogICAgIEhSRVNVTFQgaHIgPSBnZXRBY2Nlc3NpYmlsaXR5T2Jq ZWN0Rm9yQ2hpbGQodkNoaWxkLCBjaGlsZE9iaik7CiAK 22565 2008-07-30 16:00:03 -0700 2008-07-30 16:01:19 -0700 Fixes the newlines and my name =) get_accState_patch2.txt text/plain 2945 klinktech SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L3dpbi9D aGFuZ2VMb2cJKHJldmlzaW9uIDM1NDU0KQ0KKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpDQpAQCAtMSwzICsxLDExIEBADQorMjAwOC0wNy0zMCBKb25hcyBLbGluayA8a2xp bmt0ZWNoQGdtYWlsLmNvbT4NCisNCisgICAgICAgIEZpeGVzIGdldF9hY2NTdGF0ZSB0byBnZXQg c3RhdGUgb24gY2hpbGRPYmosIG5vdCBtX29iamVjdCANCisgICAgICAgIChCVUc6IGh0dHA6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjMwKS4NCisgICAgICAgIEFsc28gYWRk cyBudWxsIGluaXQgb2Ygb3V0cHV0IGluIGdldF9hY2NEZWZhdWx0QWN0aW9uLg0KKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAgICAqIEFjY2Vzc2libGVCYXNl LmNwcDoNCisgICAgICAgIChBY2Nlc3NpYmxlQmFzZTo6Z2V0X2FjY1N0YXRlKToNCisgICAgICAg IChBY2Nlc3NpYmxlQmFzZTo6Z2V0X2FjY0RlZmF1bHRBY3Rpb24pOg0KKw0KIDIwMDgtMDctMjkg IEFsaWNlIExpdSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+DQogDQogICAgICAgICBSZXZpZXdlZCBi eSBHZW9mZiBHYXJlbi4NCkluZGV4OiBXZWJLaXQvd2luL0FjY2Vzc2libGVCYXNlLmNwcA0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQ0KLS0tIFdlYktpdC93aW4vQWNjZXNzaWJsZUJhc2UuY3BwCShyZXZpc2lvbiAzNTQz NCkNCisrKyBXZWJLaXQvd2luL0FjY2Vzc2libGVCYXNlLmNwcAkod29ya2luZyBjb3B5KQ0KQEAg LTIyNSw0MyArMjI1LDQzIEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgQWNjZXNzaWJsZUJh c2UNCiAgICAgcHZTdGF0ZS0+dnQgPSBWVF9JNDsNCiAgICAgcHZTdGF0ZS0+bFZhbCA9IDA7DQog DQotICAgIGlmIChtX29iamVjdC0+aXNBbmNob3IoKSkNCisgICAgaWYgKGNoaWxkT2JqLT5pc0Fu Y2hvcigpKQ0KICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNURU1fTElOS0VEOw0K IA0KLSAgICBpZiAobV9vYmplY3QtPmlzSG92ZXJlZCgpKQ0KKyAgICBpZiAoY2hpbGRPYmotPmlz SG92ZXJlZCgpKQ0KICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNURU1fSE9UVFJB Q0tFRDsNCiANCi0gICAgaWYgKCFtX29iamVjdC0+aXNFbmFibGVkKCkpDQorICAgIGlmICghY2hp bGRPYmotPmlzRW5hYmxlZCgpKQ0KICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNU RU1fVU5BVkFJTEFCTEU7DQogDQotICAgIGlmIChtX29iamVjdC0+aXNSZWFkT25seSgpKQ0KKyAg ICBpZiAoY2hpbGRPYmotPmlzUmVhZE9ubHkoKSkNCiAgICAgICAgIHB2U3RhdGUtPmxWYWwgfD0g U1RBVEVfU1lTVEVNX1JFQURPTkxZOw0KIA0KLSAgICBpZiAobV9vYmplY3QtPmlzT2ZmU2NyZWVu KCkpDQorICAgIGlmIChjaGlsZE9iai0+aXNPZmZTY3JlZW4oKSkNCiAgICAgICAgIHB2U3RhdGUt PmxWYWwgfD0gU1RBVEVfU1lTVEVNX09GRlNDUkVFTjsNCiANCi0gICAgaWYgKG1fb2JqZWN0LT5p c011bHRpU2VsZWN0KCkpDQorICAgIGlmIChjaGlsZE9iai0+aXNNdWx0aVNlbGVjdCgpKQ0KICAg ICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNURU1fTVVMVElTRUxFQ1RBQkxFOw0KIA0K LSAgICBpZiAobV9vYmplY3QtPmlzUGFzc3dvcmRGaWVsZCgpKQ0KKyAgICBpZiAoY2hpbGRPYmot PmlzUGFzc3dvcmRGaWVsZCgpKQ0KICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNU RU1fUFJPVEVDVEVEOw0KIA0KLSAgICBpZiAobV9vYmplY3QtPmlzSW5kZXRlcm1pbmF0ZSgpKQ0K KyAgICBpZiAoY2hpbGRPYmotPmlzSW5kZXRlcm1pbmF0ZSgpKQ0KICAgICAgICAgcHZTdGF0ZS0+ bFZhbCB8PSBTVEFURV9TWVNURU1fSU5ERVRFUk1JTkFURTsNCiANCi0gICAgaWYgKG1fb2JqZWN0 LT5pc0NoZWNrZWQoKSkNCisgICAgaWYgKGNoaWxkT2JqLT5pc0NoZWNrZWQoKSkNCiAgICAgICAg IHB2U3RhdGUtPmxWYWwgfD0gU1RBVEVfU1lTVEVNX0NIRUNLRUQ7DQogDQotICAgIGlmIChtX29i amVjdC0+aXNQcmVzc2VkKCkpDQorICAgIGlmIChjaGlsZE9iai0+aXNQcmVzc2VkKCkpDQogICAg ICAgICBwdlN0YXRlLT5sVmFsIHw9IFNUQVRFX1NZU1RFTV9QUkVTU0VEOw0KIA0KLSAgICBpZiAo bV9vYmplY3QtPmlzRm9jdXNlZCgpKQ0KKyAgICBpZiAoY2hpbGRPYmotPmlzRm9jdXNlZCgpKQ0K ICAgICAgICAgcHZTdGF0ZS0+bFZhbCB8PSBTVEFURV9TWVNURU1fRk9DVVNFRDsNCiANCi0gICAg aWYgKG1fb2JqZWN0LT5pc1Zpc2l0ZWQoKSkNCisgICAgaWYgKGNoaWxkT2JqLT5pc1Zpc2l0ZWQo KSkNCiAgICAgICAgIHB2U3RhdGUtPmxWYWwgfD0gU1RBVEVfU1lTVEVNX1RSQVZFUlNFRDsNCiAN Ci0gICAgaWYgKG1fb2JqZWN0LT5jYW5TZXRGb2N1c0F0dHJpYnV0ZSgpKQ0KKyAgICBpZiAoY2hp bGRPYmotPmNhblNldEZvY3VzQXR0cmlidXRlKCkpDQogICAgICAgICBwdlN0YXRlLT5sVmFsIHw9 IFNUQVRFX1NZU1RFTV9GT0NVU0FCTEU7DQogDQogICAgIC8vIFRPRE86IEFkZCBzZWxlY3RlZCBh bmQgc2VsZWN0YWJsZSBzdGF0ZXMuDQpAQCAtMzY2LDYgKzM2Niw4IEBAIEhSRVNVTFQgU1RETUVU SE9EQ0FMTFRZUEUgQWNjZXNzaWJsZUJhc2UNCiAgICAgaWYgKCFhY3Rpb24pDQogICAgICAgICBy ZXR1cm4gRV9QT0lOVEVSOw0KIA0KKyAgICAqYWN0aW9uID0gMDsNCisNCiAgICAgQWNjZXNzaWJp bGl0eU9iamVjdCogY2hpbGRPYmo7DQogICAgIEhSRVNVTFQgaHIgPSBnZXRBY2Nlc3NpYmlsaXR5 T2JqZWN0Rm9yQ2hpbGQodkNoaWxkLCBjaGlsZE9iaik7DQogDQo=