202257 2019-09-25 23:14:58 -0700 We need to initialize the Gigacage first in setJITEnabled() when disabling the JIT. 2019-09-26 08:07:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1574367 0 mark.lam 2019-09-25 23:14:58 -0700 Details to follow in the ChangeLog. 1574372 1 379621 mark.lam 2019-09-26 00:27:44 -0700 Created attachment 379621 proposed patch. 1574373 2 mark.lam 2019-09-26 00:28:36 -0700 <rdar://problem/55673084> 1574374 3 379622 mark.lam 2019-09-26 00:30:29 -0700 Created attachment 379622 proposed patch. 1574433 4 379622 saam 2019-09-26 07:00:25 -0700 Comment on attachment 379622 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=379622&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:132 > if (!enabled) { Why do we do the JIT allocation when !enabled? Seems backwards, right? 1574447 5 379622 commit-queue 2019-09-26 08:07:23 -0700 Comment on attachment 379622 proposed patch. Clearing flags on attachment: 379622 Committed r250383: <https://trac.webkit.org/changeset/250383> 1574448 6 commit-queue 2019-09-26 08:07:25 -0700 All reviewed patches have been landed. Closing bug. 379621 2019-09-26 00:27:44 -0700 2019-09-26 00:30:29 -0700 proposed patch. bug-202257.patch text/plain 2586 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUwMzc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE5LTA5LTI1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBX ZSBuZWVkIHRvIGluaXRpYWxpemUgdGhlIEdpZ2FjYWdlIGZpcnN0IGluIHNldEpJVEVuYWJsZWQo KSB3aGVuIGRpc2FibGluZyB0aGUgSklULgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAyMjU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQmVjYXVzZSBvZiBhbiBPUyBxdWlyaywgZXZlbiBhZnRlciB0aGUg SklUIHJlZ2lvbiBoYXMgYmVlbiB1bm1hcHBlZCwgdGhlIE9TIHRoaW5rcworICAgICAgICB0aGF0 IHJlZ2lvbiBpcyByZXNlcnZlZCwgYW5kIGFzIHN1Y2gsIGNhbiBjYXVzZSBHaWdhY2FnZSBhbGxv Y2F0aW9uIHRvIGZhaWwuICBXZQorICAgICAgICB3b3JrYXJvdW5kIHRoaXMgYnkgaW5pdGlhbGl6 aW5nIHRoZSBHaWdhY2FnZSBmaXJzdC4KKworICAgICAgICBOb3RlOiB3aGVuIGNhbGxlZCwgc2V0 SklURW5hYmxlZCgpIGlzIGFsd2F5cyBjYWxsZWQgZXh0cmEgZWFybHkgaW4gdGhlIHByb2Nlc3MK KyAgICAgICAgYm9vdHN0cmFwLiAgVW5kZXIgbm9ybWFsIG9wZXJhdGlvbiAod2hlbiBzZXRKSVRF bmFibGVkKCkgaXNuJ3QgY2FsbGVkIGF0IGFsbCksIHdlCisgICAgICAgIHdpbGwgbmF0dXJhbGx5 IGluaXRpYWxpemUgdGhlIEdpZ2FjYWdlIGJlZm9yZSB3ZSBhbGxvY2F0ZSB0aGUgSklUIHJlZ2lv bi4gCisgICAgICAgIEhlbmNlLCB0aGlzIHdvcmthcm91bmQgaXMgbWVyZWx5IGVuc3VyaW5nIHRo ZSBzYW1lIGJlaGF2aW9yIG9mIGFsbG9jYXRpb24gb3JkZXJpbmcuCisKKyAgICAgICAgVGhpcyBw YXRjaCBvbmx5IGFwcGxpZXMgdG8gaU9TLgorCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxv Y2F0b3IuY3BwOgorICAgICAgICAoSlNDOjpFeGVjdXRhYmxlQWxsb2NhdG9yOjpzZXRKSVRFbmFi bGVkKToKKwogMjAxOS0wOS0yNSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxpYS5j b20+CiAKICAgICAgICAgdGVzdGFwaTogc2xvdyBkZXZpY2VzIG5lZWQgbW9yZSB0aW1lIGJlZm9y ZSB3YXRjaGRvZyBmaXJlcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRh YmxlQWxsb2NhdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwCShyZXZpc2lvbiAyNTAzMDApCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xMzAsNiArMTMwLDE3IEBAIHZvaWQgRXhlY3V0YWJsZUFsbG9jYXRvcjo6c2V0SklURW5hYmxl ZCgKIAogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpICYmIChDUFUoQVJNNjQpIHx8IENQVShBUk0p KQogICAgIGlmICghZW5hYmxlZCkgeworICAgICAgICAvLyBCZWNhdXNlIG9mIGFuIE9TIHF1aXJr LCBldmVuIGFmdGVyIHRoZSBKSVQgcmVnaW9uIGhhcyBiZWVuIHVubWFwcGVkLAorICAgICAgICAv LyB0aGUgT1MgdGhpbmtzIHRoYXQgcmVnaW9uIGlzIHJlc2VydmVkLCBhbmQgYXMgc3VjaCwgY2Fu IGNhdXNlIEdpZ2FjYWdlCisgICAgICAgIC8vIGFsbG9jYXRpb24gdG8gZmFpbC4gV2Ugd29ya2Fy b3VuZCB0aGlzIGJ5IGluaXRpYWxpemluZyB0aGUgR2lnYWNhZ2UKKyAgICAgICAgLy8gZmlyc3Qu CisgICAgICAgIC8vIE5vdGU6IHdoZW4gY2FsbGVkLCBzZXRKSVRFbmFibGVkKCkgaXMgYWx3YXlz IGNhbGxlZCBleHRyYSBlYXJseSBpbiB0aGUKKyAgICAgICAgLy8gcHJvY2VzcyBib290c3RyYXAu IFVuZGVyIG5vcm1hbCBvcGVyYXRpb24gKHdoZW4gc2V0SklURW5hYmxlZCgpIGlzbid0CisgICAg ICAgIC8vIGNhbGxlZCBhdCBhbGwpLCB3ZSB3aWxsIG5hdHVyYWxseSBpbml0aWFsaXplIHRoZSBH aWdhY2FnZSBiZWZvcmUgd2UKKyAgICAgICAgLy8gYWxsb2NhdGUgdGhlIEpJVCByZWdpb24uIEhl bmNlLCB0aGlzIHdvcmthcm91bmQgaXMgbWVyZWx5IGVuc3VyaW5nIHRoZQorICAgICAgICAvLyBz YW1lIGJlaGF2aW9yIG9mIGFsbG9jYXRpb24gb3JkZXJpbmcuCisgICAgICAgIEdpZ2FjYWdlOjpl bnN1cmVHaWdhY2FnZSgpOworCiAgICAgICAgIGNvbnN0ZXhwciBzaXplX3Qgc2l6ZSA9IDE7CiAg ICAgICAgIGNvbnN0ZXhwciBpbnQgcHJvdGVjdGlvbiA9IFBST1RfUkVBRCB8IFBST1RfV1JJVEUg fCBQUk9UX0VYRUM7CiAgICAgICAgIGNvbnN0ZXhwciBpbnQgZmxhZ3MgPSBNQVBfUFJJVkFURSB8 IE1BUF9BTk9OIHwgTUFQX0pJVDsK 379622 2019-09-26 00:30:29 -0700 2019-09-26 08:07:23 -0700 proposed patch. bug-202257.patch text/plain 2588 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUwMzc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE5LTA5LTI1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBX ZSBuZWVkIHRvIGluaXRpYWxpemUgdGhlIEdpZ2FjYWdlIGZpcnN0IGluIHNldEpJVEVuYWJsZWQo KSB3aGVuIGRpc2FibGluZyB0aGUgSklULgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAyMjU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQmVjYXVzZSBvZiBhbiBPUyBxdWlyaywgZXZlbiBhZnRlciB0aGUg SklUIHJlZ2lvbiBoYXMgYmVlbiB1bm1hcHBlZCwgdGhlIE9TIHRoaW5rcworICAgICAgICB0aGF0 IHJlZ2lvbiBpcyByZXNlcnZlZCwgYW5kIGFzIHN1Y2gsIGNhbiBjYXVzZSBHaWdhY2FnZSBhbGxv Y2F0aW9uIHRvIGZhaWwuICBXZQorICAgICAgICB3b3JrIGFyb3VuZCB0aGlzIGJ5IGluaXRpYWxp emluZyB0aGUgR2lnYWNhZ2UgZmlyc3QuCisKKyAgICAgICAgTm90ZTogd2hlbiBjYWxsZWQsIHNl dEpJVEVuYWJsZWQoKSBpcyBhbHdheXMgY2FsbGVkIGV4dHJhIGVhcmx5IGluIHRoZSBwcm9jZXNz CisgICAgICAgIGJvb3RzdHJhcC4gIFVuZGVyIG5vcm1hbCBvcGVyYXRpb24gKHdoZW4gc2V0SklU RW5hYmxlZCgpIGlzbid0IGNhbGxlZCBhdCBhbGwpLCB3ZQorICAgICAgICB3aWxsIG5hdHVyYWxs eSBpbml0aWFsaXplIHRoZSBHaWdhY2FnZSBiZWZvcmUgd2UgYWxsb2NhdGUgdGhlIEpJVCByZWdp b24uIAorICAgICAgICBIZW5jZSwgdGhpcyB3b3JrYXJvdW5kIGlzIG1lcmVseSBlbnN1cmluZyB0 aGUgc2FtZSBiZWhhdmlvciBvZiBhbGxvY2F0aW9uIG9yZGVyaW5nLgorCisgICAgICAgIFRoaXMg cGF0Y2ggb25seSBhcHBsaWVzIHRvIGlPUy4KKworICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxs b2NhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6RXhlY3V0YWJsZUFsbG9jYXRvcjo6c2V0SklURW5h YmxlZCk6CisKIDIwMTktMDktMjUgIEd1aWxsYXVtZSBFbW9udCAgPGd1aWplbW9udEBpZ2FsaWEu Y29tPgogCiAgICAgICAgIHRlc3RhcGk6IHNsb3cgZGV2aWNlcyBuZWVkIG1vcmUgdGltZSBiZWZv cmUgd2F0Y2hkb2cgZmlyZXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0 YWJsZUFsbG9jYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcAkocmV2aXNpb24gMjUwMzAwKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTMwLDYgKzEzMCwxNyBAQCB2b2lkIEV4ZWN1dGFibGVBbGxvY2F0b3I6OnNldEpJVEVuYWJs ZWQoCiAKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKSAmJiAoQ1BVKEFSTTY0KSB8fCBDUFUoQVJN KSkKICAgICBpZiAoIWVuYWJsZWQpIHsKKyAgICAgICAgLy8gQmVjYXVzZSBvZiBhbiBPUyBxdWly aywgZXZlbiBhZnRlciB0aGUgSklUIHJlZ2lvbiBoYXMgYmVlbiB1bm1hcHBlZCwKKyAgICAgICAg Ly8gdGhlIE9TIHRoaW5rcyB0aGF0IHJlZ2lvbiBpcyByZXNlcnZlZCwgYW5kIGFzIHN1Y2gsIGNh biBjYXVzZSBHaWdhY2FnZQorICAgICAgICAvLyBhbGxvY2F0aW9uIHRvIGZhaWwuIFdlIHdvcmsg YXJvdW5kIHRoaXMgYnkgaW5pdGlhbGl6aW5nIHRoZSBHaWdhY2FnZQorICAgICAgICAvLyBmaXJz dC4KKyAgICAgICAgLy8gTm90ZTogd2hlbiBjYWxsZWQsIHNldEpJVEVuYWJsZWQoKSBpcyBhbHdh eXMgY2FsbGVkIGV4dHJhIGVhcmx5IGluIHRoZQorICAgICAgICAvLyBwcm9jZXNzIGJvb3RzdHJh cC4gVW5kZXIgbm9ybWFsIG9wZXJhdGlvbiAod2hlbiBzZXRKSVRFbmFibGVkKCkgaXNuJ3QKKyAg ICAgICAgLy8gY2FsbGVkIGF0IGFsbCksIHdlIHdpbGwgbmF0dXJhbGx5IGluaXRpYWxpemUgdGhl IEdpZ2FjYWdlIGJlZm9yZSB3ZQorICAgICAgICAvLyBhbGxvY2F0ZSB0aGUgSklUIHJlZ2lvbi4g SGVuY2UsIHRoaXMgd29ya2Fyb3VuZCBpcyBtZXJlbHkgZW5zdXJpbmcgdGhlCisgICAgICAgIC8v IHNhbWUgYmVoYXZpb3Igb2YgYWxsb2NhdGlvbiBvcmRlcmluZy4KKyAgICAgICAgR2lnYWNhZ2U6 OmVuc3VyZUdpZ2FjYWdlKCk7CisKICAgICAgICAgY29uc3RleHByIHNpemVfdCBzaXplID0gMTsK ICAgICAgICAgY29uc3RleHByIGludCBwcm90ZWN0aW9uID0gUFJPVF9SRUFEIHwgUFJPVF9XUklU RSB8IFBST1RfRVhFQzsKICAgICAgICAgY29uc3RleHByIGludCBmbGFncyA9IE1BUF9QUklWQVRF IHwgTUFQX0FOT04gfCBNQVBfSklUOwo=