202255 2019-09-25 22:08:39 -0700 [LFC][IFC] Decouple Display::Run and Display::Box initializations. 2019-09-26 08:44:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1574360 0 zalan 2019-09-25 22:08:39 -0700 This is in preparation for moving Display::Run initialization to Line. 1574361 1 webkit-bug-importer 2019-09-25 22:09:03 -0700 <rdar://problem/55731445> 1574362 2 379619 zalan 2019-09-25 22:11:18 -0700 Created attachment 379619 Patch 1574462 3 379619 commit-queue 2019-09-26 08:44:40 -0700 Comment on attachment 379619 Patch Clearing flags on attachment: 379619 Committed r250384: <https://trac.webkit.org/changeset/250384> 1574463 4 commit-queue 2019-09-26 08:44:41 -0700 All reviewed patches have been landed. Closing bug. 379619 2019-09-25 22:11:18 -0700 2019-09-26 08:44:40 -0700 Patch bug-202255-20190925221113.patch text/plain 7637 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M0MDY0MGI4Yzk1MWI1 NTdkYzY1ODczNGQ3NTM4MTA1M2Q2MTRkZC4uMzAwMzdiOTg1MTRjZDMyMjgzYWRkMmQxZDI4YmUx NmEzMzZmZTBhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA5LTI1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBEZWNvdXBs ZSBEaXNwbGF5OjpSdW4gYW5kIERpc3BsYXk6OkJveCBpbml0aWFsaXphdGlvbnMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDIyNTUKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzU1NzMxNDQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgaW4gcHJlcGFyYXRpb24gZm9yIG1vdmluZyBEaXNw bGF5OjpSdW4gaW5pdGlhbGl6YXRpb24gdG8gTGluZSBjbGFzcy4KKworICAgICAgICAqIGxheW91 dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0TGluZUxheW91dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdDb250ZXh0OjpJbmxp bmVMYXlvdXQ6OmNyZWF0ZURpc3BsYXlSdW5zKToKKwogMjAxOS0wOS0yNSAgV2Vuc29uIEhzaWVo ICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBQYWdlIHRlbXBvcmFyaWx5IGp1 bXBzIHRvIGFuIGV4Y2Vzc2l2ZWx5IHNtYWxsIHZpZXdwb3J0IHNjYWxlIHdoaWxlIGxvYWRpbmcg dXNhdG9kYXkuY29tCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9y bWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dExpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dl YkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRMaW5l TGF5b3V0LmNwcAppbmRleCBkNjk0MWIyZWM2NmY3Y2VjOGM5MzFjZTE4Mzg4OWZjMTE2MWFkODUy Li5hM2YxNzk2N2NkNjE5MDY3YTk5ZWJkMTcxMjM4YzQ2MzUxYzkzNTE3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29u dGV4dExpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3Jt YXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0TGluZUxheW91dC5jcHAKQEAgLTM3OSw4ICsz NzksNDEgQEAgdm9pZCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6SW5saW5lTGF5b3V0OjpjcmVh dGVEaXNwbGF5UnVucyhjb25zdCBMaW5lOjpDb250ZW4KICAgICBhdXRvIHByZXZpb3VzTGluZUxh c3RSdW5JbmRleCA9IE9wdGlvbmFsPHVuc2lnbmVkPiB7IGlubGluZURpc3BsYXlSdW5zLmlzRW1w dHkoKSA/IE9wdGlvbmFsPHVuc2lnbmVkPigpIDogaW5saW5lRGlzcGxheVJ1bnMuc2l6ZSgpIC0g MSB9OwogICAgIC8vIDkuNC4yIElubGluZSBmb3JtYXR0aW5nIGNvbnRleHRzCiAgICAgLy8gQSBs aW5lIGJveCBpcyBhbHdheXMgdGFsbCBlbm91Z2ggZm9yIGFsbCBvZiB0aGUgYm94ZXMgaXQgY29u dGFpbnMuCisKICAgICAvLyBDcmVhdGUgZmluYWwgZGlzcGxheSBydW5zLgogICAgIGF1dG8mIGxp bmVSdW5zID0gbGluZUNvbnRlbnQucnVucygpOworICAgIGZvciAodW5zaWduZWQgaW5kZXggPSAw OyBpbmRleCA8IGxpbmVSdW5zLnNpemUoKTsgKytpbmRleCkgeworICAgICAgICBhdXRvJiBydW4g PSBsaW5lUnVucy5hdChpbmRleCk7CisgICAgICAgIC8vIElubGluZSBsZXZlbCBjb250YWluZXJz ICg8c3Bhbj4pIGRvbid0IGdlbmVyYXRlIGlubGluZSBydW5zLgorICAgICAgICBpZiAocnVuLT5p c0NvbnRhaW5lclN0YXJ0KCkgfHwgcnVuLT5pc0NvbnRhaW5lckVuZCgpKQorICAgICAgICAgICAg Y29udGludWU7CisgICAgICAgIGF1dG8mIGxvZ2ljYWxSZWN0ID0gcnVuLT5sb2dpY2FsUmVjdCgp OworICAgICAgICAvLyBJbmxpbmUgbGV2ZWwgYm94IChyZXBsYWNlZCBvciBpbmxpbmUtYmxvY2sp IG9yIDxicj4vPHdicj4KKyAgICAgICAgaWYgKHJ1bi0+aXNMaW5lQnJlYWsoKSB8fCBydW4tPmlz Qm94KCkpIHsKKyAgICAgICAgICAgIGZvcm1hdHRpbmdTdGF0ZS5hZGRJbmxpbmVSdW4obWFrZVVu aXF1ZTxEaXNwbGF5OjpSdW4+KGxvZ2ljYWxSZWN0KSk7CisgICAgICAgICAgICBjb250aW51ZTsK KyAgICAgICAgfQorICAgICAgICBpZiAocnVuLT5pc1RleHQoKSkgeworICAgICAgICAgICAgLy8g Q29sbGFwc2VkIGxpbmUgcnVucyBkb24ndCBnZW5lcmF0ZSBkaXNwbGF5IHJ1bnMuCisgICAgICAg ICAgICBhdXRvIHRleHRDb250ZXh0ID0gcnVuLT50ZXh0Q29udGV4dCgpOworICAgICAgICAgICAg aWYgKHRleHRDb250ZXh0LT5pc0NvbGxhcHNlZCkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsK KyAgICAgICAgICAgIC8vIFRyeSB0byBqb2luIG11bHRpcGxlIHRleHQgcnVucyB3aGVuIHBvc3Np YmxlLgorICAgICAgICAgICAgY29uc3QgTGluZTo6Q29udGVudDo6UnVuKiBwcmV2aW91c1J1biA9 ICFpbmRleCA/IG51bGxwdHIgOiBsaW5lUnVuc1tpbmRleCAtIDFdLmdldCgpOworICAgICAgICAg ICAgYXV0byBwcmV2aW91c1J1bkNhbkJlRXh0ZW5kZWQgPSBwcmV2aW91c1J1biAmJiBwcmV2aW91 c1J1bi0+dGV4dENvbnRleHQoKSA/IHByZXZpb3VzUnVuLT50ZXh0Q29udGV4dCgpLT5jYW5CZUV4 dGVuZGVkIDogZmFsc2U7CisgICAgICAgICAgICBhdXRvIGN1cnJlbnRSdW5DYW5CZU1lcmdlZFdp dGhQcmV2aW91cyA9ICFwcmV2aW91c1J1biB8fCAmcnVuLT5sYXlvdXRCb3goKSA9PSAmcHJldmlv dXNSdW4tPmxheW91dEJveCgpOworCisgICAgICAgICAgICBpZiAocHJldmlvdXNSdW5DYW5CZUV4 dGVuZGVkICYmIGN1cnJlbnRSdW5DYW5CZU1lcmdlZFdpdGhQcmV2aW91cykgeworICAgICAgICAg ICAgICAgIGF1dG8mIHByZXZpb3VzRGlzcGxheVJ1biA9IGZvcm1hdHRpbmdTdGF0ZS5pbmxpbmVS dW5zKCkubGFzdCgpOworICAgICAgICAgICAgICAgIHByZXZpb3VzRGlzcGxheVJ1bi0+ZXhwYW5k SG9yaXpvbnRhbGx5KGxvZ2ljYWxSZWN0LndpZHRoKCkpOworICAgICAgICAgICAgICAgIHByZXZp b3VzRGlzcGxheVJ1bi0+dGV4dENvbnRleHQoKS0+ZXhwYW5kKHRleHRDb250ZXh0LT5sZW5ndGgp OworICAgICAgICAgICAgfSBlbHNlCisgICAgICAgICAgICAgICAgZm9ybWF0dGluZ1N0YXRlLmFk ZElubGluZVJ1bihtYWtlVW5pcXVlPERpc3BsYXk6OlJ1bj4obG9naWNhbFJlY3QsIERpc3BsYXk6 OlJ1bjo6VGV4dENvbnRleHQgeyB0ZXh0Q29udGV4dC0+c3RhcnQsIHRleHRDb250ZXh0LT5sZW5n dGggfSkpOworICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIH0KKyAgICAgICAgQVNTRVJU X05PVF9SRUFDSEVEKCk7CisgICAgfQorCiAgICAgYXV0byBnZW9tZXRyeSA9IGZvcm1hdHRpbmdD b250ZXh0Lmdlb21ldHJ5KCk7CiAgICAgZm9yICh1bnNpZ25lZCBpbmRleCA9IDA7IGluZGV4IDwg bGluZVJ1bnMuc2l6ZSgpOyArK2luZGV4KSB7CiAgICAgICAgIGF1dG8mIGxpbmVSdW4gPSBsaW5l UnVucy5hdChpbmRleCk7CkBAIC0zOTIsNyArNDI1LDYgQEAgdm9pZCBJbmxpbmVGb3JtYXR0aW5n Q29udGV4dDo6SW5saW5lTGF5b3V0OjpjcmVhdGVEaXNwbGF5UnVucyhjb25zdCBMaW5lOjpDb250 ZW4KICAgICAgICAgICAgIGRpc3BsYXlCb3guc2V0VG9wTGVmdChsb2dpY2FsUmVjdC50b3BMZWZ0 KCkpOwogICAgICAgICAgICAgZGlzcGxheUJveC5zZXRDb250ZW50Qm94V2lkdGgobG9naWNhbFJl Y3Qud2lkdGgoKSk7CiAgICAgICAgICAgICBkaXNwbGF5Qm94LnNldENvbnRlbnRCb3hIZWlnaHQo bG9naWNhbFJlY3QuaGVpZ2h0KCkpOwotICAgICAgICAgICAgZm9ybWF0dGluZ1N0YXRlLmFkZElu bGluZVJ1bihtYWtlVW5pcXVlPERpc3BsYXk6OlJ1bj4obG9naWNhbFJlY3QpKTsKICAgICAgICAg ICAgIGNvbnRpbnVlOwogICAgICAgICB9CiAKQEAgLTQwMiw3ICs0MzQsNiBAQCB2b2lkIElubGlu ZUZvcm1hdHRpbmdDb250ZXh0OjpJbmxpbmVMYXlvdXQ6OmNyZWF0ZURpc3BsYXlSdW5zKGNvbnN0 IExpbmU6OkNvbnRlbgogICAgICAgICAgICAgaWYgKGxheW91dEJveC5pc0luRmxvd1Bvc2l0aW9u ZWQoKSkKICAgICAgICAgICAgICAgICB0b3BMZWZ0ICs9IGdlb21ldHJ5LmluRmxvd1Bvc2l0aW9u ZWRQb3NpdGlvbk9mZnNldChsYXlvdXRCb3gsIG1fdXNlZEhvcml6b250YWxWYWx1ZXMpOwogICAg ICAgICAgICAgZGlzcGxheUJveC5zZXRUb3BMZWZ0KHRvcExlZnQpOwotICAgICAgICAgICAgZm9y bWF0dGluZ1N0YXRlLmFkZElubGluZVJ1bihtYWtlVW5pcXVlPERpc3BsYXk6OlJ1bj4obG9naWNh bFJlY3QpKTsKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9CiAKQEAgLTQyOCwzMSAr NDU5LDIzIEBAIHZvaWQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OklubGluZUxheW91dDo6Y3Jl YXRlRGlzcGxheVJ1bnMoY29uc3QgTGluZTo6Q29udGVuCiAgICAgICAgIH0KIAogICAgICAgICAv LyBUZXh0IGNvbnRlbnQuIFRyeSB0byBqb2luIG11bHRpcGxlIHRleHQgcnVucyB3aGVuIHBvc3Np YmxlLgotICAgICAgICBBU1NFUlQobGluZVJ1bi0+aXNUZXh0KCkpOwotICAgICAgICBhdXRvIHRl eHRDb250ZXh0ID0gbGluZVJ1bi0+dGV4dENvbnRleHQoKTsgICAKLSAgICAgICAgY29uc3QgTGlu ZTo6Q29udGVudDo6UnVuKiBwcmV2aW91c0xpbmVSdW4gPSAhaW5kZXggPyBudWxscHRyIDogbGlu ZVJ1bnNbaW5kZXggLSAxXS5nZXQoKTsKLSAgICAgICAgaWYgKCF0ZXh0Q29udGV4dC0+aXNDb2xs YXBzZWQpIHsKLSAgICAgICAgICAgIGF1dG8gcHJldmlvdXNSdW5DYW5CZUV4dGVuZGVkID0gcHJl dmlvdXNMaW5lUnVuICYmIHByZXZpb3VzTGluZVJ1bi0+dGV4dENvbnRleHQoKSA/IHByZXZpb3Vz TGluZVJ1bi0+dGV4dENvbnRleHQoKS0+Y2FuQmVFeHRlbmRlZCA6IGZhbHNlOwotICAgICAgICAg ICAgYXV0byByZXF1aXJlc05ld1J1biA9ICFpbmRleCB8fCAhcHJldmlvdXNSdW5DYW5CZUV4dGVu ZGVkIHx8ICZsYXlvdXRCb3ggIT0gJnByZXZpb3VzTGluZVJ1bi0+bGF5b3V0Qm94KCk7Ci0gICAg ICAgICAgICBpZiAocmVxdWlyZXNOZXdSdW4pCi0gICAgICAgICAgICAgICAgZm9ybWF0dGluZ1N0 YXRlLmFkZElubGluZVJ1bihtYWtlVW5pcXVlPERpc3BsYXk6OlJ1bj4obG9naWNhbFJlY3QsIERp c3BsYXk6OlJ1bjo6VGV4dENvbnRleHQgeyB0ZXh0Q29udGV4dC0+c3RhcnQsIHRleHRDb250ZXh0 LT5sZW5ndGggfSkpOwotICAgICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICAgICAgYXV0byYg bGFzdERpc3BsYXlSdW4gPSBmb3JtYXR0aW5nU3RhdGUuaW5saW5lUnVucygpLmxhc3QoKTsKLSAg ICAgICAgICAgICAgICBsYXN0RGlzcGxheVJ1bi0+ZXhwYW5kSG9yaXpvbnRhbGx5KGxvZ2ljYWxS ZWN0LndpZHRoKCkpOwotICAgICAgICAgICAgICAgIGxhc3REaXNwbGF5UnVuLT50ZXh0Q29udGV4 dCgpLT5leHBhbmQodGV4dENvbnRleHQtPmxlbmd0aCk7CisgICAgICAgIGlmIChsaW5lUnVuLT5p c1RleHQoKSkgeworICAgICAgICAgICAgYXV0byB0ZXh0Q29udGV4dCA9IGxpbmVSdW4tPnRleHRD b250ZXh0KCk7CisgICAgICAgICAgICBjb25zdCBMaW5lOjpDb250ZW50OjpSdW4qIHByZXZpb3Vz TGluZVJ1biA9ICFpbmRleCA/IG51bGxwdHIgOiBsaW5lUnVuc1tpbmRleCAtIDFdLmdldCgpOwor ICAgICAgICAgICAgLy8gRklYTUUgdGFrZSBjb250ZW50IGJyZWFraW5nIGludG8gYWNjb3VudCB3 aGVuIHBhcnQgb2YgdGhlIGxheW91dCBib3ggaXMgb24gdGhlIHByZXZpb3VzIGxpbmUuCisgICAg ICAgICAgICBhdXRvIGZpcnN0SW5saW5lUnVuRm9yTGF5b3V0Qm94ID0gIXByZXZpb3VzTGluZVJ1 biB8fCAmcHJldmlvdXNMaW5lUnVuLT5sYXlvdXRCb3goKSAhPSAmbGF5b3V0Qm94OworICAgICAg ICAgICAgaWYgKGZpcnN0SW5saW5lUnVuRm9yTGF5b3V0Qm94KSB7CisgICAgICAgICAgICAgICAg Ly8gU2V0dXAgZGlzcGxheSBib3ggZm9yIHRoZSBhc3NvY2lhdGVkIGxheW91dCBib3guCisgICAg ICAgICAgICAgICAgZGlzcGxheUJveC5zZXRUb3BMZWZ0KGxvZ2ljYWxSZWN0LnRvcExlZnQoKSk7 CisgICAgICAgICAgICAgICAgZGlzcGxheUJveC5zZXRDb250ZW50Qm94V2lkdGgodGV4dENvbnRl eHQtPmlzQ29sbGFwc2VkID8gTGF5b3V0VW5pdCgpIDogbG9naWNhbFJlY3Qud2lkdGgoKSk7Cisg ICAgICAgICAgICAgICAgZGlzcGxheUJveC5zZXRDb250ZW50Qm94SGVpZ2h0KGxvZ2ljYWxSZWN0 LmhlaWdodCgpKTsKKyAgICAgICAgICAgIH0gZWxzZSBpZiAoIXRleHRDb250ZXh0LT5pc0NvbGxh cHNlZCkgeworICAgICAgICAgICAgICAgIC8vIEZJWE1FIGZpeCBpdCBmb3IgbXVsdGlydW4vbXVs dGlsaW5lLgorICAgICAgICAgICAgICAgIGRpc3BsYXlCb3guc2V0Q29udGVudEJveFdpZHRoKGRp c3BsYXlCb3guY29udGVudEJveFdpZHRoKCkgKyBsb2dpY2FsUmVjdC53aWR0aCgpKTsKICAgICAg ICAgICAgIH0KKyAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9Ci0gICAgICAgIC8vIEZJ WE1FIHRha2UgY29udGVudCBicmVha2luZyBpbnRvIGFjY291bnQgd2hlbiBwYXJ0IG9mIHRoZSBs YXlvdXQgYm94IGlzIG9uIHRoZSBwcmV2aW91cyBsaW5lLgotICAgICAgICBhdXRvIGZpcnN0SW5s aW5lUnVuRm9yTGF5b3V0Qm94ID0gIXByZXZpb3VzTGluZVJ1biB8fCAmcHJldmlvdXNMaW5lUnVu LT5sYXlvdXRCb3goKSAhPSAmbGF5b3V0Qm94OwotICAgICAgICBpZiAoZmlyc3RJbmxpbmVSdW5G b3JMYXlvdXRCb3gpIHsKLSAgICAgICAgICAgIC8vIFNldHVwIGRpc3BsYXkgYm94IGZvciB0aGUg YXNzb2NpYXRlZCBsYXlvdXQgYm94LgotICAgICAgICAgICAgZGlzcGxheUJveC5zZXRUb3BMZWZ0 KGxvZ2ljYWxSZWN0LnRvcExlZnQoKSk7Ci0gICAgICAgICAgICBkaXNwbGF5Qm94LnNldENvbnRl bnRCb3hXaWR0aCh0ZXh0Q29udGV4dC0+aXNDb2xsYXBzZWQgPyBMYXlvdXRVbml0KCkgOiBsb2dp Y2FsUmVjdC53aWR0aCgpKTsKLSAgICAgICAgICAgIGRpc3BsYXlCb3guc2V0Q29udGVudEJveEhl aWdodChsb2dpY2FsUmVjdC5oZWlnaHQoKSk7Ci0gICAgICAgIH0gZWxzZSBpZiAoIXRleHRDb250 ZXh0LT5pc0NvbGxhcHNlZCkgewotICAgICAgICAgICAgLy8gRklYTUUgZml4IGl0IGZvciBtdWx0 aXJ1bi9tdWx0aWxpbmUuCi0gICAgICAgICAgICBkaXNwbGF5Qm94LnNldENvbnRlbnRCb3hXaWR0 aChkaXNwbGF5Qm94LmNvbnRlbnRCb3hXaWR0aCgpICsgbG9naWNhbFJlY3Qud2lkdGgoKSk7Ci0g ICAgICAgIH0KKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQogICAgIC8vIEZJ WE1FIGxpbmVib3ggbmVlZHMgdG8gYmUgYWp1c3RlZCBhZnRlciBjb250ZW50IGFsaWdubWVudC4K ICAgICBmb3JtYXR0aW5nU3RhdGUuYWRkTGluZUJveChsaW5lQ29udGVudC5saW5lQm94KCkpOwo=