202223 2019-09-25 12:44:58 -0700 [ews] JSC queues should run or skip tests based on runTests key from config.json 2019-09-25 13:57:23 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain aperez ap commit-queue guijemont jbedard webkit-bug-importer oldest_to_newest 1574172 0 aakash_jain 2019-09-25 12:44:58 -0700 Few JSC queues should be running tests and few shouldn't be. We should add 'runTests' key in config.json and JSCTestsFactory should skip or add tests based on that key. 1574174 1 379574 aakash_jain 2019-09-25 12:50:06 -0700 Created attachment 379574 Patch 1574175 2 aakash_jain 2019-09-25 12:53:36 -0700 Tested on UAT instance by manually modifying 'runTests' key in config.json "runTests": "true" => https://ews-build.webkit-uat.org/#/builders/17/builds/4147 "runTests": "false" => https://ews-build.webkit-uat.org/#/builders/17/builds/4148 1574177 3 379574 jbedard 2019-09-25 13:02:43 -0700 Comment on attachment 379574 Patch Code looks good: A higher level question. What are we using this for? Do we have a circumstance where we would like to compile, but not test, JavaScriptCore? 1574180 4 aakash_jain 2019-09-25 13:09:33 -0700 (In reply to Jonathan Bedard from comment #3) > What are we using this for? Do we have a circumstance where we would like to compile, but not test, JavaScriptCore? Yes, this is for 'JSC i386 EWS' which I will be moving from old to new EWS soon. https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/config/ews.json#L55 1574199 5 379574 commit-queue 2019-09-25 13:56:22 -0700 Comment on attachment 379574 Patch Clearing flags on attachment: 379574 Committed r250356: <https://trac.webkit.org/changeset/250356> 1574200 6 commit-queue 2019-09-25 13:56:24 -0700 All reviewed patches have been landed. Closing bug. 1574202 7 webkit-bug-importer 2019-09-25 13:57:23 -0700 <rdar://problem/55717576> 379574 2019-09-25 12:50:06 -0700 2019-09-25 13:56:22 -0700 Patch bug-202223-20190925155005.patch text/plain 4433 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MDM1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE5LTA5LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBKU0MgcXVldWVzIHNob3VsZCBydW4gb3Igc2tpcCB0ZXN0cyBi YXNlZCBvbiBydW5UZXN0cyBrZXkgZnJvbSBjb25maWcuanNvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyMjIzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvY29uZmlnLmpzb246IEFkZGVkIHRoZSBydW5UZXN0cyBrZXkuCisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weToKKyAgICAgICAgKEpTQ1Rlc3RzRmFj dG9yeS5fX2luaXRfXyk6IEFkZCBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzIHN0ZXAgYmFzZWQgb24g cnVuVGVzdHMga2V5LgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2Fk Q29uZmlnLnB5OgorICAgICAgICAobG9hZEJ1aWxkZXJDb25maWcpOiBQYXNzIHRoZSBydW5UZXN0 cyBrZXkgdG8gdGhlIGZhY3RvcnkuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL2xvYWRDb25maWdfdW5pdHRlc3QucHk6CisgICAgICAgIChDb25maWdEb3RKU09OVGVzdC50 ZXN0X2J1aWxkZXJfa2V5cyk6IEFkZGVkIHRoZSBydW5UZXN0cyBrZXkuCisKIDIwMTktMDktMjUg IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW1vdmUgZHVwbGljYXRlIFdlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uIGNvcHlpbmcgY29k ZQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2NvbmZpZy5qc29uCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9jb25maWcuanNv bgkocmV2aXNpb24gMjUwMzU0KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L2NvbmZpZy5qc29uCSh3b3JraW5nIGNvcHkpCkBAIC00MjQsNiArNDI0LDcgQEAKICAgICAgICJm YWN0b3J5IjogIkpTQ1Rlc3RzRmFjdG9yeSIsCiAgICAgICAicGxhdGZvcm0iOiAibWFjLWhpZ2hz aWVycmEiLAogICAgICAgImNvbmZpZ3VyYXRpb24iOiAicmVsZWFzZSIsCisgICAgICAicnVuVGVz dHMiOiAidHJ1ZSIsCiAgICAgICAid29ya2VybmFtZXMiOiBbImV3czEyNyIsICJld3MxMjgiXQog ICAgIH0sCiAgICAgewpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2Zh Y3Rvcmllcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvZmFjdG9yaWVzLnB5CShyZXZpc2lvbiAyNTAzNTQpCisrKyBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsMTAgKzEx NiwxMSBAQCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToKIAogCiBjbGFzcyBKU0NUZXN0c0Zh Y3RvcnkoRmFjdG9yeSk6Ci0gICAgZGVmIF9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1 cmF0aW9uPSdyZWxlYXNlJywgYXJjaGl0ZWN0dXJlcz1Ob25lLCBhZGRpdGlvbmFsQXJndW1lbnRz PU5vbmUsICoqa3dhcmdzKToKKyAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZp Z3VyYXRpb249J3JlbGVhc2UnLCBhcmNoaXRlY3R1cmVzPU5vbmUsIGFkZGl0aW9uYWxBcmd1bWVu dHM9Tm9uZSwgcnVuVGVzdHM9J3RydWUnLCAqKmt3YXJncyk6CiAgICAgICAgIEZhY3RvcnkuX19p bml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNl LCBhZGRpdGlvbmFsQXJndW1lbnRzLCBjaGVja1JlbGV2YW5jZT1UcnVlKQogICAgICAgICBzZWxm LmFkZFN0ZXAoQ29tcGlsZUpTQyhza2lwVXBsb2FkPVRydWUpKQotICAgICAgICBzZWxmLmFkZFN0 ZXAoUnVuSmF2YVNjcmlwdENvcmVUZXN0cygpKQorICAgICAgICBpZiBydW5UZXN0cy5sb3dlcigp ID09ICd0cnVlJzoKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5KYXZhU2NyaXB0Q29yZVRl c3RzKCkpCiAKIAogY2xhc3MgQVBJVGVzdHNGYWN0b3J5KFRlc3RGYWN0b3J5KToKSW5kZXg6IFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5CShyZXZp c2lvbiAyNTAzNTQpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENv bmZpZy5weQkod29ya2luZyBjb3B5KQpAQCAtNjIsNyArNjIsNyBAQCBkZWYgbG9hZEJ1aWxkZXJD b25maWcoYywgaXNfdGVzdF9tb2RlX2VuCiAgICAgICAgIGlmICdpY29uJyBpbiBidWlsZGVyOgog ICAgICAgICAgICAgZGVsIGJ1aWxkZXJbJ2ljb24nXQogICAgICAgICBmYWN0b3J5a3dhcmdzID0g e30KLSAgICAgICAgZm9yIGtleSBpbiBbJ3BsYXRmb3JtJywgJ2NvbmZpZ3VyYXRpb24nLCAnYXJj aGl0ZWN0dXJlcycsICd0cmlnZ2VycycsICdhZGRpdGlvbmFsQXJndW1lbnRzJ106CisgICAgICAg IGZvciBrZXkgaW4gWydwbGF0Zm9ybScsICdjb25maWd1cmF0aW9uJywgJ2FyY2hpdGVjdHVyZXMn LCAndHJpZ2dlcnMnLCAnYWRkaXRpb25hbEFyZ3VtZW50cycsICdydW5UZXN0cyddOgogICAgICAg ICAgICAgdmFsdWUgPSBidWlsZGVyLnBvcChrZXksIE5vbmUpCiAgICAgICAgICAgICBpZiB2YWx1 ZToKICAgICAgICAgICAgICAgICBmYWN0b3J5a3dhcmdzW2tleV0gPSB2YWx1ZQpJbmRleDogVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWdfdW5pdHRlc3QucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWdf dW5pdHRlc3QucHkJKHJldmlzaW9uIDI1MDM1NCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9sb2FkQ29uZmlnX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zOSw4 ICszOSw4IEBAIGNsYXNzIENvbmZpZ0RvdEpTT05UZXN0KHVuaXR0ZXN0LlRlc3RDYXMKICAgICAg ICAgY3dkID0gb3MucGF0aC5kaXJuYW1lKG9zLnBhdGguYWJzcGF0aChfX2ZpbGVfXykpCiAgICAg ICAgIGNvbmZpZyA9IGpzb24ubG9hZChvcGVuKG9zLnBhdGguam9pbihjd2QsICdjb25maWcuanNv bicpKSkKICAgICAgICAgdmFsaWRfYnVpbGRlcl9rZXlzID0gWydhZGRpdGlvbmFsQXJndW1lbnRz JywgJ2FyY2hpdGVjdHVyZXMnLCAnYnVpbGRkaXInLCAnY29uZmlndXJhdGlvbicsICdkZXNjcmlw dGlvbicsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnZGVmYXVsdFByb3BlcnRpZXMn LCAnZW52JywgJ2ZhY3RvcnknLCAnaWNvbicsICdsb2NrcycsICduYW1lJywgJ3BsYXRmb3JtJywg J3Byb3BlcnRpZXMnLCAnc2hvcnRuYW1lJywgJ3RhZ3MnLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJ3RyaWdnZXJzJywgJ3dvcmtlcm5hbWVzJywgJ3dvcmtlcmJ1aWxkZGlyJ10KKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICdkZWZhdWx0UHJvcGVydGllcycsICdlbnYnLCAn ZmFjdG9yeScsICdpY29uJywgJ2xvY2tzJywgJ25hbWUnLCAncGxhdGZvcm0nLCAncHJvcGVydGll cycsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAncnVuVGVzdHMnLCAnc2hvcnRuYW1l JywgJ3RhZ3MnLCAndHJpZ2dlcnMnLCAnd29ya2VybmFtZXMnLCAnd29ya2VyYnVpbGRkaXInXQog ICAgICAgICBmb3IgYnVpbGRlciBpbiBjb25maWcuZ2V0KCdidWlsZGVycycsIFtdKToKICAgICAg ICAgICAgIGZvciBrZXkgaW4gYnVpbGRlcjoKICAgICAgICAgICAgICAgICBzZWxmLmFzc2VydFRy dWUoa2V5IGluIHZhbGlkX2J1aWxkZXJfa2V5cywgJ1VuZXhwZWN0ZWQga2V5ICJ7fSIgZm9yIGJ1 aWxkZXIge30nLmZvcm1hdChrZXksIGJ1aWxkZXIuZ2V0KCduYW1lJykpKQo=