202218 2019-09-25 11:55:37 -0700 Web Inspector: "Toggle Visibility" does not work for element inside Shadow DOM 2019-11-04 16:18:27 -0800 1 1 1 Unclassified WebKit Web Inspector Other Mac macOS 10.13 RESOLVED FIXED InRadar P2 Normal --- 1 timdream hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1574148 0 timdream 2019-09-25 11:55:37 -0700 STR: 1. Load this URL which insert an open shadow root under <body> data:text/html,<script>window.onload%20=%20()%20=>%20{%20sr%20=%20document.body.attachShadow({mode:%20"open"});%20sr.innerHTML%20=%20"<div>Hello</div>";%20}</script> 2. Inspect the element containing the word "Hello" 3. Right click and select "Toggle Visibility Expected: 1. The element is hidden Actual: 1. The element is not hidden. Note: Happens to me on Safari 13 (Version 13.0.1 (14608.2.11.1.11)) You will not be able to repro this bug on STP 92 because of bug 202217. 1574149 1 webkit-bug-importer 2019-09-25 11:55:57 -0700 <rdar://problem/55713078> 1587058 2 382750 hi 2019-11-04 10:58:38 -0800 Created attachment 382750 Patch 1587182 3 382750 bburg 2019-11-04 15:15:13 -0800 Comment on attachment 382750 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382750&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:354 > + else Please add '// Inside Shadow DOM.' to the else branch. 1587189 4 382779 hi 2019-11-04 15:20:40 -0800 Created attachment 382779 Patch 1587221 5 382779 commit-queue 2019-11-04 16:18:25 -0800 Comment on attachment 382779 Patch Clearing flags on attachment: 382779 Committed r252026: <https://trac.webkit.org/changeset/252026> 1587222 6 commit-queue 2019-11-04 16:18:27 -0800 All reviewed patches have been landed. Closing bug. 382750 2019-11-04 10:58:38 -0800 2019-11-04 15:20:40 -0800 Patch bug-202218-20191104105837.patch text/plain 2315 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcxMzJjOTUxZmMzODA1MmZjN2U3NGM0M2NjNGQx NTE5NjVhNDg3ODEuLjQzYWI0ZTc4NTZlZGNhNjM5ZmFlM2U0ODliMDMzN2NlNzYzYTE5NGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTA0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiAi VG9nZ2xlIFZpc2liaWxpdHkiIGRvZXMgbm90IHdvcmsgZm9yIGVsZW1lbnQgaW5zaWRlIFNoYWRv dyBET00KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MjIxOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTU3MTMwNzg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RP TVRyZWVFbGVtZW50LmpzOgorICAgICAgICAoV0kuRE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLnRv Z2dsZUVsZW1lbnRWaXNpYmlsaXR5Lmluc3BlY3RlZFBhZ2Vfbm9kZV9pbmplY3RTdHlsZUFuZFRv Z2dsZUNsYXNzKToKKyAgICAgICAgSWYgdGhlIG5vZGUgaXMgaW5zaWRlIGEgc2hhZG93IHRyZWUs IHN0b3JlIHRoZSBgPHN0eWxlPmAgaW5zaWRlIHRoZSBzaGFkb3cgcm9vdCBpbnN0ZWFkIG9mCisg ICAgICAgIGFsd2F5cyB1c2luZyBgZG9jdW1lbnQuaGVhZGAuCisKIDIwMTktMTEtMDIgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFk ZCBkaWFnbm9zdGljIGxvZ2dpbmcgZm9yIGZyb250ZW5kIGZlYXR1cmUgdXNhZ2UKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVt ZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJl ZUVsZW1lbnQuanMKaW5kZXggMGIzMmE2ZTQyMmZjOWU0YzUxOGQ5ODUxYWE5MzUyM2M2NjA3MTAy OS4uYTRmZmI1MjdhNjg5YjczOTg5ODk5MjYwZThhYzgxMjljZjc2ODYzYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJl ZUVsZW1lbnQuanMKQEAgLTM0MSwxMiArMzQxLDE4IEBAIFdJLkRPTVRyZWVFbGVtZW50ID0gY2xh c3MgRE9NVHJlZUVsZW1lbnQgZXh0ZW5kcyBXSS5UcmVlRWxlbWVudAogICAgICAgICAgICAgcmV0 dXJuOwogCiAgICAgICAgIGZ1bmN0aW9uIGluc3BlY3RlZFBhZ2Vfbm9kZV9pbmplY3RTdHlsZUFu ZFRvZ2dsZUNsYXNzKGhpZGRlbkNsYXNzTmFtZSwgZm9yY2UpIHsKLSAgICAgICAgICAgIGxldCBz dHlsZUVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZChoaWRkZW5DbGFzc05hbWUpOwor ICAgICAgICAgICAgbGV0IHJvb3QgPSB0aGlzLmdldFJvb3ROb2RlKCkgfHwgZG9jdW1lbnQ7CisK KyAgICAgICAgICAgIGxldCBzdHlsZUVsZW1lbnQgPSByb290LmdldEVsZW1lbnRCeUlkKGhpZGRl bkNsYXNzTmFtZSk7CiAgICAgICAgICAgICBpZiAoIXN0eWxlRWxlbWVudCkgewogICAgICAgICAg ICAgICAgIHN0eWxlRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInN0eWxlIik7CiAg ICAgICAgICAgICAgICAgc3R5bGVFbGVtZW50LmlkID0gaGlkZGVuQ2xhc3NOYW1lOwogICAgICAg ICAgICAgICAgIHN0eWxlRWxlbWVudC50ZXh0Q29udGVudCA9IGAuJHtoaWRkZW5DbGFzc05hbWV9 IHsgdmlzaWJpbGl0eTogaGlkZGVuICFpbXBvcnRhbnQ7IH1gOwotICAgICAgICAgICAgICAgIGRv Y3VtZW50LmhlYWQuYXBwZW5kQ2hpbGQoc3R5bGVFbGVtZW50KTsKKworICAgICAgICAgICAgICAg IGlmIChyb290IGluc3RhbmNlb2YgSFRNTERvY3VtZW50KQorICAgICAgICAgICAgICAgICAgICBy b290LmhlYWQuYXBwZW5kQ2hpbGQoc3R5bGVFbGVtZW50KTsKKyAgICAgICAgICAgICAgICBlbHNl CisgICAgICAgICAgICAgICAgICAgIHJvb3QuaW5zZXJ0QmVmb3JlKHN0eWxlRWxlbWVudCwgcm9v dC5maXJzdENoaWxkKTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgdGhpcy5jbGFzc0xp c3QudG9nZ2xlKGhpZGRlbkNsYXNzTmFtZSwgZm9yY2UpOwo= 382779 2019-11-04 15:20:40 -0800 2019-11-04 16:18:25 -0800 Patch bug-202218.patch text/plain 2333 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcxMzJjOTUxZmMzODA1MmZjN2U3NGM0M2NjNGQx NTE5NjVhNDg3ODEuLjQzYWI0ZTc4NTZlZGNhNjM5ZmFlM2U0ODliMDMzN2NlNzYzYTE5NGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTA0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiAi VG9nZ2xlIFZpc2liaWxpdHkiIGRvZXMgbm90IHdvcmsgZm9yIGVsZW1lbnQgaW5zaWRlIFNoYWRv dyBET00KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MjIxOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTU3MTMwNzg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgQnJpYW4gQnVyZy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJl ZUVsZW1lbnQuanM6CisgICAgICAgIChXSS5ET01UcmVlRWxlbWVudC5wcm90b3R5cGUudG9nZ2xl RWxlbWVudFZpc2liaWxpdHkuaW5zcGVjdGVkUGFnZV9ub2RlX2luamVjdFN0eWxlQW5kVG9nZ2xl Q2xhc3MpOgorICAgICAgICBJZiB0aGUgbm9kZSBpcyBpbnNpZGUgYSBzaGFkb3cgdHJlZSwgc3Rv cmUgdGhlIGA8c3R5bGU+YCBpbnNpZGUgdGhlIHNoYWRvdyByb290IGluc3RlYWQgb2YKKyAgICAg ICAgYWx3YXlzIHVzaW5nIGBkb2N1bWVudC5oZWFkYC4KKwogMjAxOS0xMS0wMiAgRGV2aW4gUm91 c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIGRp YWdub3N0aWMgbG9nZ2luZyBmb3IgZnJvbnRlbmQgZmVhdHVyZSB1c2FnZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxl bWVudC5qcwppbmRleCAwYjMyYTZlNDIyZmM5ZTRjNTE4ZDk4NTFhYTkzNTIzYzY2MDcxMDI5Li5h NGZmYjUyN2E2ODliNzM5ODk4OTkyNjBlOGFjODEyOWNmNzY4NjNjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxl bWVudC5qcwpAQCAtMzQxLDEyICszNDEsMTggQEAgV0kuRE9NVHJlZUVsZW1lbnQgPSBjbGFzcyBE T01UcmVlRWxlbWVudCBleHRlbmRzIFdJLlRyZWVFbGVtZW50CiAgICAgICAgICAgICByZXR1cm47 CiAKICAgICAgICAgZnVuY3Rpb24gaW5zcGVjdGVkUGFnZV9ub2RlX2luamVjdFN0eWxlQW5kVG9n Z2xlQ2xhc3MoaGlkZGVuQ2xhc3NOYW1lLCBmb3JjZSkgewotICAgICAgICAgICAgbGV0IHN0eWxl RWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKGhpZGRlbkNsYXNzTmFtZSk7CisgICAg ICAgICAgICBsZXQgcm9vdCA9IHRoaXMuZ2V0Um9vdE5vZGUoKSB8fCBkb2N1bWVudDsKKworICAg ICAgICAgICAgbGV0IHN0eWxlRWxlbWVudCA9IHJvb3QuZ2V0RWxlbWVudEJ5SWQoaGlkZGVuQ2xh c3NOYW1lKTsKICAgICAgICAgICAgIGlmICghc3R5bGVFbGVtZW50KSB7CiAgICAgICAgICAgICAg ICAgc3R5bGVFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3R5bGUiKTsKICAgICAg ICAgICAgICAgICBzdHlsZUVsZW1lbnQuaWQgPSBoaWRkZW5DbGFzc05hbWU7CiAgICAgICAgICAg ICAgICAgc3R5bGVFbGVtZW50LnRleHRDb250ZW50ID0gYC4ke2hpZGRlbkNsYXNzTmFtZX0geyB2 aXNpYmlsaXR5OiBoaWRkZW4gIWltcG9ydGFudDsgfWA7Ci0gICAgICAgICAgICAgICAgZG9jdW1l bnQuaGVhZC5hcHBlbmRDaGlsZChzdHlsZUVsZW1lbnQpOworCisgICAgICAgICAgICAgICAgaWYg KHJvb3QgaW5zdGFuY2VvZiBIVE1MRG9jdW1lbnQpCisgICAgICAgICAgICAgICAgICAgIHJvb3Qu aGVhZC5hcHBlbmRDaGlsZChzdHlsZUVsZW1lbnQpOworICAgICAgICAgICAgICAgIGVsc2UgLy8g SW5zaWRlIFNoYWRvdyBET00uCisgICAgICAgICAgICAgICAgICAgIHJvb3QuaW5zZXJ0QmVmb3Jl KHN0eWxlRWxlbWVudCwgcm9vdC5maXJzdENoaWxkKTsKICAgICAgICAgICAgIH0KIAogICAgICAg ICAgICAgdGhpcy5jbGFzc0xpc3QudG9nZ2xlKGhpZGRlbkNsYXNzTmFtZSwgZm9yY2UpOwo=