202216 2019-09-25 11:42:03 -0700 [EWS] RunJavaScriptCoreTestsToT should use the same command as RunJavaScriptCoreTests 2019-09-25 14:13:17 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1574140 0 aakash_jain 2019-09-25 11:42:03 -0700 RunJavaScriptCoreTestsToT should use the same command as base class RunJavaScriptCoreTests. Currently the difference between the command in both classes is that RunJavaScriptCoreTestsToT doesn't add '--no-build'. This was correct prior to Bug 202170 when there wasn't an explicit CompileJSC step before RunJavaScriptCoreTestsToT. In Bug 202170, we added an explicit build step CompileJSCToT() which is run before RunJavaScriptCoreTestsToT(). Therefore we can add the '--no-build' flag here and make it same as the base class (RunJavaScriptCoreTests). 1574143 1 379569 aakash_jain 2019-09-25 11:46:45 -0700 Created attachment 379569 Patch 1574207 2 379569 commit-queue 2019-09-25 14:12:10 -0700 Comment on attachment 379569 Patch Clearing flags on attachment: 379569 Committed r250357: <https://trac.webkit.org/changeset/250357> 1574208 3 commit-queue 2019-09-25 14:12:12 -0700 All reviewed patches have been landed. Closing bug. 1574209 4 webkit-bug-importer 2019-09-25 14:13:17 -0700 <rdar://problem/55718281> 379569 2019-09-25 11:46:45 -0700 2019-09-25 14:12:10 -0700 Patch bug-202216-20190925144644.patch text/plain 3093 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MDM1MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA5LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbRVdTXSBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzVG9UIHNob3VsZCB1c2Ug dGhlIHNhbWUgY29tbWFuZCBhcyBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDIyMTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3 cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKFJ1bkphdmFTY3JpcHRDb3JlVGVzdHNUb1QpOiBS ZW1vdmVkIHRoZSBjb21tYW5kIHNvIGFzIHRvIHVzZSB0aGUgY29tbWFuZCBmcm9tIGJhc2UgY2xh c3MuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0 LnB5OiBVcGRhdGQgdW5pdC10ZXN0cy4KKwogMjAxOS0wOS0yNSAgQWFrYXNoIEphaW4gIDxhYWth c2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0VXU10gSlNDIHF1ZXVlcyBzaG91bGQgZHlu YW1pY2FsbHkgYWRkIHJlcXVpcmVkIGJ1aWxkIHN0ZXBzIGZvciByZS10ZXN0aW5nIHRoZSBwYXRj aApJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2 aXNpb24gMjUwMzUwKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz LnB5CSh3b3JraW5nIGNvcHkpCkBAIC04NzMsNyArODczLDYgQEAgY2xhc3MgUmVSdW5KYXZhU2Ny aXB0Q29yZVRlc3RzKFJ1bkphdmFTYwogY2xhc3MgUnVuSmF2YVNjcmlwdENvcmVUZXN0c1RvVChS dW5KYXZhU2NyaXB0Q29yZVRlc3RzKToKICAgICBuYW1lID0gJ2pzY29yZS10ZXN0LXRvdCcKICAg ICBqc29uRmlsZU5hbWUgPSAnanNjX3Jlc3VsdHMuanNvbicKLSAgICBjb21tYW5kID0gWydwZXJs JywgJ1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzJywgJy0tbm8tZmFpbC1m YXN0JywgJy0tanNvbi1vdXRwdXQ9ezB9Jy5mb3JtYXQoanNvbkZpbGVOYW1lKSwgV2l0aFByb3Bl cnRpZXMoJy0tJShjb25maWd1cmF0aW9uKXMnKV0KIAogICAgIGRlZiBldmFsdWF0ZUNvbW1hbmQo c2VsZiwgY21kKToKICAgICAgICAgcmV0dXJuIHNoZWxsLlRlc3QuZXZhbHVhdGVDb21tYW5kKHNl bGYsIGNtZCkKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191 bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI1MDM1MCkKKysrIFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAt MTAxNiw3ICsxMDE2LDcgQEAgY2xhc3MgVGVzdFJ1bkphdmFTY3JpcHRDb3JlVGVzdHNUb1QoQnVp bAogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2UnKQog ICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAogICAgICAgICAgICAgRXhwZWN0U2hl bGwod29ya2Rpcj0nd2tkaXInLAotICAgICAgICAgICAgICAgICAgICAgICAgY29tbWFuZD1bJ3Bl cmwnLCAnVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMnLCAnLS1uby1mYWls LWZhc3QnLCAnLS1qc29uLW91dHB1dD17MH0nLmZvcm1hdChzZWxmLmpzb25GaWxlTmFtZSksICct LXJlbGVhc2UnXSwKKyAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9WydwZXJsJywgJ1Rv b2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzJywgJy0tbm8tYnVpbGQnLCAnLS1u by1mYWlsLWZhc3QnLCAnLS1qc29uLW91dHB1dD17MH0nLmZvcm1hdChzZWxmLmpzb25GaWxlTmFt ZSksICctLXJlbGVhc2UnXSwKICAgICAgICAgICAgICAgICAgICAgICAgIGxvZ2ZpbGVzPXsnanNv bic6IHNlbGYuanNvbkZpbGVOYW1lfSwKICAgICAgICAgICAgICAgICAgICAgICAgICkKICAgICAg ICAgICAgICsgMCwKQEAgLTEwMzAsNyArMTAzMCw3IEBAIGNsYXNzIFRlc3RSdW5KYXZhU2NyaXB0 Q29yZVRlc3RzVG9UKEJ1aWwKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlv bicsICdkZWJ1ZycpCiAgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCiAgICAgICAg ICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCi0gICAgICAgICAgICAgICAgICAgICAg ICBjb21tYW5kPVsncGVybCcsICdUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0 cycsICctLW5vLWZhaWwtZmFzdCcsICctLWpzb24tb3V0cHV0PXswfScuZm9ybWF0KHNlbGYuanNv bkZpbGVOYW1lKSwgJy0tZGVidWcnXSwKKyAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9 WydwZXJsJywgJ1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzJywgJy0tbm8t YnVpbGQnLCAnLS1uby1mYWlsLWZhc3QnLCAnLS1qc29uLW91dHB1dD17MH0nLmZvcm1hdChzZWxm Lmpzb25GaWxlTmFtZSksICctLWRlYnVnJ10sCiAgICAgICAgICAgICAgICAgICAgICAgICBsb2dm aWxlcz17J2pzb24nOiBzZWxmLmpzb25GaWxlTmFtZX0sCiAgICAgICAgICAgICAgICAgICAgICAg ICApCiAgICAgICAgICAgICArIEV4cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRvdXQ9JzkgZmFp bHVyZXMgZm91bmQuJykK