202154 2019-09-24 12:15:57 -0700 Address static analysis warning in ParkingLot.cpp: Access to field 'size' results in a dereference of a null pointer 2019-09-29 19:21:56 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin benjamin bfulgham cdumez cmarcelo commit-queue dbates ews-watchlist fpizlo mark.lam webkit-bug-importer oldest_to_newest 1573739 0 krollin 2019-09-24 12:15:57 -0700 Static analysis reports the following: .../OpenSource/Source/WTF/wtf/ParkingLot.cpp:376:30: warning: Access to field 'size' results in a dereference of a null pointer (loaded from variable 'oldHashtable') RELEASE_ASSERT(newSize > oldHashtable->size); ^~~~~~~~~~~~~~~~~~ This warning arises because earlier code checks to see if oldHashtable is NULL, leading the static analyzer to think that it *could* be NULL. However, earlier code actually ensures that oldhashtable will not be NULL. Address this by removing the NULL check, and back it up with an ASSERT to ensure that it's not NULL. 1573740 1 webkit-bug-importer 2019-09-24 12:16:14 -0700 <rdar://problem/55672103> 1573741 2 379465 krollin 2019-09-24 12:18:09 -0700 Created attachment 379465 Patch 1575181 3 379465 bfulgham 2019-09-29 15:51:25 -0700 Comment on attachment 379465 Patch This seems like a reasonable change. 1575191 4 379465 commit-queue 2019-09-29 19:21:55 -0700 Comment on attachment 379465 Patch Clearing flags on attachment: 379465 Committed r250497: <https://trac.webkit.org/changeset/250497> 1575192 5 commit-queue 2019-09-29 19:21:56 -0700 All reviewed patches have been landed. Closing bug. 379465 2019-09-24 12:18:09 -0700 2019-09-29 19:21:55 -0700 Patch bug-202154-20190924121808.patch text/plain 2468 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZiMzhlMjY5ZmQxNDU3YjgwZGRiNjkw YmJmNmEzNDIyMzFiZjAyYzQuLjIwZmNlNWExNjY3N2UwZWE3MjAyNzQ2NDVkYWMyNjNmNmZkMTYx MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMDktMjQgIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZHJlc3Mgc3RhdGljIGFuYWx5c2lzIHdhcm5pbmcg aW4gUGFya2luZ0xvdC5jcHA6IEFjY2VzcyB0byBmaWVsZCAnc2l6ZScgcmVzdWx0cyBpbiBhIGRl cmVmZXJlbmNlIG9mIGEgbnVsbCBwb2ludGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDIxNTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1Njcy MTAzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0 YXRpYyBhbmFseXNpcyByZXBvcnRzIHRoZSBmb2xsb3dpbmc6CisKKyAgICAgICAgICAgIC4uLi9P cGVuU291cmNlL1NvdXJjZS9XVEYvd3RmL1BhcmtpbmdMb3QuY3BwOjM3NjozMDogd2FybmluZzog QWNjZXNzIHRvIGZpZWxkICdzaXplJyByZXN1bHRzIGluIGEgZGVyZWZlcmVuY2Ugb2YgYSBudWxs IHBvaW50ZXIgKGxvYWRlZCBmcm9tIHZhcmlhYmxlICdvbGRIYXNodGFibGUnKQorICAgICAgICAg ICAgICAgIFJFTEVBU0VfQVNTRVJUKG5ld1NpemUgPiBvbGRIYXNodGFibGUtPnNpemUpOworICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn4K KworICAgICAgICBUaGlzIHdhcm5pbmcgYXJpc2VzIGJlY2F1c2UgZWFybGllciBjb2RlIGNoZWNr cyB0byBzZWUgaWYgb2xkSGFzaHRhYmxlCisgICAgICAgIGlzIE5VTEwsIGxlYWRpbmcgdGhlIHN0 YXRpYyBhbmFseXplciB0byB0aGluayB0aGF0IGl0ICpjb3VsZCogYmUgTlVMTC4KKyAgICAgICAg SG93ZXZlciwgZXZlbiBlYXJsaWVyIGNvZGUgYWN0dWFsbHkgZW5zdXJlcyB0aGF0IG9sZEhhc2h0 YWJsZSB3aWxsIG5vdAorICAgICAgICBiZSBOVUxMLiBBZGRyZXNzIHRoaXMgYnkgcmVtb3Zpbmcg dGhlIE5VTEwgY2hlY2ssIGFuZCBiYWNrIGl0IHVwIHdpdGgKKyAgICAgICAgYW4gQVNTRVJUIHRv IGVuc3VyZSB0aGF0IGl0J3Mgbm90IE5VTEwuCisKKyAgICAgICAgKiB3dGYvUGFya2luZ0xvdC5j cHA6CisKIDIwMTktMDktMjQgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZHJlc3Mgc3RhdGljIGFuYWx5c2lzIHdhcm5pbmcgaW4gRGF0YUxvZy5jcHA6IFZh bHVlIHN0b3JlZCB0byAncGF0aENoYXJhY3RlcnNBdmFpbGFibGUnIGlzIG5ldmVyIHJlYWQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BhcmtpbmdMb3QuY3BwIGIvU291cmNlL1dURi93dGYv UGFya2luZ0xvdC5jcHAKaW5kZXggYjM5NWYzMzA0MDA5ZTMzYjI4NTE5MzE0MjVlNzAyZWNmNDRi YWZkZS4uZjQyMmNiMjc0YWMxZTUwMGMwNTVlNTdhZWVlYmNjOWY0Y2ZhNGNmZiAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvUGFya2luZ0xvdC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvUGFy a2luZ0xvdC5jcHAKQEAgLTM1NSw3ICszNTUsOCBAQCB2b2lkIGVuc3VyZUhhc2h0YWJsZVNpemUo dW5zaWduZWQgbnVtVGhyZWFkcykKICAgICAvLyBDaGVjayBhZ2Fpbiwgc2luY2UgdGhlIGhhc2h0 YWJsZSBjb3VsZCBoYXZlIHJlaGFzaGVkIHdoaWxlIHdlIHdlcmUgbG9ja2luZyBpdC4gQWxzbywK ICAgICAvLyBsb2NrSGFzaHRhYmxlKCkgY3JlYXRlcyBhbiBpbml0aWFsIGhhc2h0YWJsZSBmb3Ig dXMuCiAgICAgb2xkSGFzaHRhYmxlID0gaGFzaHRhYmxlLmxvYWQoKTsKLSAgICBpZiAob2xkSGFz aHRhYmxlICYmIHN0YXRpY19jYXN0PGRvdWJsZT4ob2xkSGFzaHRhYmxlLT5zaXplKSAvIHN0YXRp Y19jYXN0PGRvdWJsZT4obnVtVGhyZWFkcykgPj0gbWF4TG9hZEZhY3RvcikgeworICAgIFJFTEVB U0VfQVNTRVJUKG9sZEhhc2h0YWJsZSk7CisgICAgaWYgKHN0YXRpY19jYXN0PGRvdWJsZT4ob2xk SGFzaHRhYmxlLT5zaXplKSAvIHN0YXRpY19jYXN0PGRvdWJsZT4obnVtVGhyZWFkcykgPj0gbWF4 TG9hZEZhY3RvcikgewogICAgICAgICBpZiAodmVyYm9zZSkKICAgICAgICAgICAgIGRhdGFMb2co dG9TdHJpbmcoVGhyZWFkOjpjdXJyZW50KCksICI6IGFmdGVyIGxvY2tpbmcsIG5vIG5lZWQgdG8g cmVoYXNoIGJlY2F1c2UgIiwgb2xkSGFzaHRhYmxlLT5zaXplLCAiIC8gIiwgbnVtVGhyZWFkcywg IiA+PSAiLCBtYXhMb2FkRmFjdG9yLCAiXG4iKSk7CiAgICAgICAgIHVubG9ja0hhc2h0YWJsZShi dWNrZXRzVG9VbmxvY2spOwo=