202153 2019-09-24 12:08:17 -0700 Address static analysis warning in DataLog.cpp: Value stored to 'pathCharactersAvailable' is never read 2020-04-02 11:45:05 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin benjamin bfulgham cdumez cmarcelo dbates ddkilzer ews-watchlist fpizlo msaboff webkit-bug-importer oldest_to_newest 1573732 0 krollin 2019-09-24 12:08:17 -0700 Bug 168914 introduce some code that will initialize a variable to zero, but then never use that variable afterwards. Address this by removing the assignment. 1573733 1 webkit-bug-importer 2019-09-24 12:08:32 -0700 <rdar://problem/55671845> 1573737 2 379464 krollin 2019-09-24 12:11:04 -0700 Created attachment 379464 Patch 1636958 3 ddkilzer 2020-04-02 11:21:46 -0700 Hah! I was just about to fix this, and found this bug. Thanks Keith! Feel free to cq+. 1636971 4 ddkilzer 2020-04-02 11:39:01 -0700 This is also the _last_ static analyzer warning in WTF for the version of the clang static analyzer we're running! 1636973 5 ews-feeder 2020-04-02 11:45:03 -0700 Committed r259400: <https://trac.webkit.org/changeset/259400> All reviewed patches have been landed. Closing bug and clearing flags on attachment 379464. 379464 2019-09-24 12:11:04 -0700 2020-04-02 11:45:04 -0700 Patch bug-202153-20190924121104.patch text/plain 1880 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVkODA3MzRjMTQxMmMxOWVkYTQzNTZm ZDQxNDE4NWNlNGQxMmY1NGIuLjZiMzhlMjY5ZmQxNDU3YjgwZGRiNjkwYmJmNmEzNDIyMzFiZjAy YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDktMjQgIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZHJlc3Mgc3RhdGljIGFuYWx5c2lzIHdhcm5pbmcg aW4gRGF0YUxvZy5jcHA6IFZhbHVlIHN0b3JlZCB0byAncGF0aENoYXJhY3RlcnNBdmFpbGFibGUn IGlzIG5ldmVyIHJlYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwMjE1MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTU2NzE4NDU+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE2ODkxNCBpbnRy b2R1Y2VkIHNvbWUgY29kZSB0aGF0IHdpbGwgaW5pdGlhbGl6ZSBhIHZhcmlhYmxlIHRvCisgICAg ICAgIHplcm8sIGJ1dCB0aGVuIG5ldmVyIHVzZSB0aGF0IHZhcmlhYmxlIGFmdGVyd2FyZHMuIEFk ZHJlc3MgdGhpcyBieQorICAgICAgICByZW1vdmluZyB0aGUgYXNzaWdubWVudC4KKworICAgICAg ICAqIHd0Zi9EYXRhTG9nLmNwcDoKKyAgICAgICAgKFdURjo6c2V0RGF0YUZpbGUpOgorCiAyMDE5 LTA5LTIxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgY2xh bmctdGlkeTogRml4IHVubmVjZXNzYXJ5IGNvcHkvcmVmIGNodXJuIG9mIGZvciBsb29wIHZhcmlh YmxlcyBpbiBXVEYvSmF2YVNjcmlwdENvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Rh dGFMb2cuY3BwIGIvU291cmNlL1dURi93dGYvRGF0YUxvZy5jcHAKaW5kZXggMDJkMzI0YjU3MTMy YTAwYjE4ZjY3Mzk3MjhiZDFmNTM2NjgzZTdmMi4uZjkyYTBiZjgyZjkwMmUxN2FlY2M1ZjY3YmRl MzhjOTUwMWViYzBkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRGF0YUxvZy5jcHAKKysr IGIvU291cmNlL1dURi93dGYvRGF0YUxvZy5jcHAKQEAgLTEzMyw5ICsxMzMsNyBAQCB2b2lkIHNl dERhdGFGaWxlKGNvbnN0IGNoYXIqIHBhdGgpCiAgICAgICAgICAgICBpZiAocGF0aENoYXJhY3Rl cnNBdmFpbGFibGUpIHsKICAgICAgICAgICAgICAgICBpbnQgcGlkVGV4dExlbmd0aCA9IHNucHJp bnRmKG5leHREZXN0LCBwYXRoQ2hhcmFjdGVyc0F2YWlsYWJsZSwgIiVkIiwgZ2V0Q3VycmVudFBy b2Nlc3NJRCgpKTsKIAotICAgICAgICAgICAgICAgIGlmIChwaWRUZXh0TGVuZ3RoIDwgMCB8fCBz dGF0aWNfY2FzdDxzaXplX3Q+KHBpZFRleHRMZW5ndGgpID49IHBhdGhDaGFyYWN0ZXJzQXZhaWxh YmxlKQotICAgICAgICAgICAgICAgICAgICBwYXRoQ2hhcmFjdGVyc0F2YWlsYWJsZSA9IDA7Ci0g ICAgICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICAgaWYgKHBpZFRleHRMZW5ndGgg Pj0gMCAmJiBzdGF0aWNfY2FzdDxzaXplX3Q+KHBpZFRleHRMZW5ndGgpIDwgcGF0aENoYXJhY3Rl cnNBdmFpbGFibGUpIHsKICAgICAgICAgICAgICAgICAgICAgcGF0aENoYXJhY3RlcnNBdmFpbGFi bGUgLT0gc3RhdGljX2Nhc3Q8c2l6ZV90PihwaWRUZXh0TGVuZ3RoKTsKICAgICAgICAgICAgICAg ICAgICAgbmV4dERlc3QgKz0gcGlkVGV4dExlbmd0aDsKICAgICAgICAgICAgICAgICAgICAgc3Ry bmNweShuZXh0RGVzdCwgcGlkRm9ybWF0ICsgNCwgcGF0aENoYXJhY3RlcnNBdmFpbGFibGUpOwo=