202149 2019-09-24 10:05:46 -0700 testapi: slow devices need more time before watchdog fires 2019-09-25 03:12:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 guijemont guijemont commit-queue ews-watchlist keith_miller mark.lam msaboff saam ticaiolima tzagallo webkit-bug-importer oldest_to_newest 1573689 0 guijemont 2019-09-24 10:05:46 -0700 In testExecutionTimeLimit(), the time that we leave for the watchdog to fire is often not enough on (slower) arm and mips devices, creating a testapi failure. 1573690 1 379459 guijemont 2019-09-24 10:10:53 -0700 Created attachment 379459 Patch Patch fixing this, and also skipping FTL-specific cases when FTL is disabled. 1573694 2 379459 ticaiolima 2019-09-24 10:35:05 -0700 Comment on attachment 379459 Patch Informal r+ here. LGTM if bots are green. 1573707 3 guijemont 2019-09-24 11:02:23 -0700 (In reply to Caio Lima from comment #2) > Comment on attachment 379459 [details] > Patch > > Informal r+ here. LGTM if bots are green. Note that arm and mips bots currently don't run testapi & friends. I will do more checks, but I think this was the last hurdle to enabling them (patch enabling them already exists in Bug 195404). 1573992 4 379459 guijemont 2019-09-25 02:27:06 -0700 Comment on attachment 379459 Patch Landing, as the ios-wk2 bot failures are clearly unrelated, as this change cannot affect layout tests. 1574006 5 379459 commit-queue 2019-09-25 03:11:12 -0700 Comment on attachment 379459 Patch Clearing flags on attachment: 379459 Committed r250340: <https://trac.webkit.org/changeset/250340> 1574007 6 commit-queue 2019-09-25 03:11:13 -0700 All reviewed patches have been landed. Closing bug. 1574008 7 webkit-bug-importer 2019-09-25 03:12:15 -0700 <rdar://problem/55698076> 379459 2019-09-24 10:10:53 -0700 2019-09-25 03:11:12 -0700 Patch bug-202149-20190924191052.patch text/plain 2498 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw MzYyZmU5MDMxNDgzMjUxMmE0M2E2MTY0OGMxOTg2MTkxNjRmMzljLi5mN2M4NzhkMGIxOWJlYzMz MjI0MjlhZjFiNzM1NGQ2ZmVlOTA0Yzc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0wOS0yNCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgdGVzdGFwaTogc2xvdyBkZXZpY2VzIG5lZWQgbW9yZSB0aW1lIGJl Zm9yZSB3YXRjaGRvZyBmaXJlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAyMTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW4gdGVzdEV4ZWN1dGlvblRpbWVMaW1pdCgpLCB0aGUgdGltZSB0aGF0IHdl IGxlYXZlIGZvciB0aGUgd2F0Y2hkb2cKKyAgICAgICAgdG8gZmlyZSBpcyBvZnRlbiBub3QgZW5v dWdoIG9uIChzbG93ZXIpIGFybSBhbmQgbWlwcyBkZXZpY2VzLCBjcmVhdGluZworICAgICAgICBh IHRlc3RhcGkgZmFpbHVyZS4KKyAgICAgICAgVGhpcyBjaGFuZ2UgYWxzbyBza2lwcyBGVEwtc3Bl Y2lmaWMgdGVzdGluZyB3aGVuIEZUTCBpcyBkaXNhYmxlZC4KKworICAgICAgICAqIEFQSS90ZXN0 cy9FeGVjdXRpb25UaW1lTGltaXRUZXN0LmNwcDoKKyAgICAgICAgKHRlc3RFeGVjdXRpb25UaW1l TGltaXQpOgorCiAyMDE5LTA5LTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZWZhY3RvciBjZWxsU2l6ZSgpIG91dCBvZiBWTUluc3BlY3Rvcjo6dmVyaWZ5Q2Vs bFNpemUoKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvRXhl Y3V0aW9uVGltZUxpbWl0VGVzdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3Rz L0V4ZWN1dGlvblRpbWVMaW1pdFRlc3QuY3BwCmluZGV4IDljODY3MDA3ZTcwNzU3ZTY0OTMyM2Rh ODE1ZmM1ZDMwY2Y1NmRmODMuLjMxZjRlNTI3MTY1MThiMGQxNGY0MmMwNDA3ZjBlMmRiZDEzZDM2 ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvRXhlY3V0aW9u VGltZUxpbWl0VGVzdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy9F eGVjdXRpb25UaW1lTGltaXRUZXN0LmNwcApAQCAtMTIyLDcgKzEyMiw5IEBAIGludCB0ZXN0RXhl Y3V0aW9uVGltZUxpbWl0KCkKICAgICAgICAgeyAiTExJTlQiLCAgICAwX21zLCAgICItLXVzZUNv bmN1cnJlbnRKSVQ9ZmFsc2UgLS11c2VMTEludD10cnVlIC0tdXNlSklUPWZhbHNlIiB9LAogICAg ICAgICB7ICJCYXNlbGluZSIsIDBfbXMsICAgIi0tdXNlQ29uY3VycmVudEpJVD1mYWxzZSAtLXVz ZUxMSW50PXRydWUgLS11c2VKSVQ9dHJ1ZSAtLXVzZURGR0pJVD1mYWxzZSIgfSwKICAgICAgICAg eyAiREZHIiwgICAgICAyMDBfbXMsICAgIi0tdXNlQ29uY3VycmVudEpJVD1mYWxzZSAtLXVzZUxM SW50PXRydWUgLS11c2VKSVQ9dHJ1ZSAtLXVzZURGR0pJVD10cnVlIC0tdXNlRlRMSklUPWZhbHNl IiB9LAorI2lmIEVOQUJMRShGVExfSklUKQogICAgICAgICB7ICJGVEwiLCAgICAgIDUwMF9tcywg Ii0tdXNlQ29uY3VycmVudEpJVD1mYWxzZSAtLXVzZUxMSW50PXRydWUgLS11c2VKSVQ9dHJ1ZSAt LXVzZURGR0pJVD10cnVlIC0tdXNlRlRMSklUPXRydWUiIH0sCisjZW5kaWYKICAgICB9OwogICAg IAogICAgIGJvb2wgZmFpbGVkID0gZmFsc2U7CkBAIC0xNTYsNyArMTU4LDExIEBAIGludCB0ZXN0 RXhlY3V0aW9uVGltZUxpbWl0KCkKICAgICAgICAgdGltZUxpbWl0ID0gMTAwX21zICsgdGllckFk anVzdG1lbnQ7CiAgICAgICAgIEpTQ29udGV4dEdyb3VwU2V0RXhlY3V0aW9uVGltZUxpbWl0KGNv bnRleHRHcm91cCwgdGltZUxpbWl0LnNlY29uZHMoKSwgc2hvdWxkVGVybWluYXRlQ2FsbGJhY2ss IDApOwogICAgICAgICB7CisjaWYgT1MoTElOVVgpICYmIChDUFUoTUlQUykgfHwgQ1BVKEFSTV9U SFVNQjIpKQorICAgICAgICAgICAgU2Vjb25kcyB0aW1lQWZ0ZXJXYXRjaGRvZ1Nob3VsZEhhdmVG aXJlZCA9IDUwMF9tcyArIHRpZXJBZGp1c3RtZW50OworI2Vsc2UKICAgICAgICAgICAgIFNlY29u ZHMgdGltZUFmdGVyV2F0Y2hkb2dTaG91bGRIYXZlRmlyZWQgPSAzMDBfbXMgKyB0aWVyQWRqdXN0 bWVudDsKKyNlbmRpZgogCiAgICAgICAgICAgICBKU1N0cmluZ1JlZiBzY3JpcHQgPSBKU1N0cmlu Z0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygiZnVuY3Rpb24gZm9vKCkgeyB3aGlsZSAodHJ1ZSkgeyB9 IH0gZm9vKCk7Iik7CiAgICAgICAgICAgICBleGNlcHRpb24gPSBudWxscHRyOwo=