202146 2019-09-24 08:49:24 -0700 We should initialize WebProcessPool::m_hiddenPageThrottlingTimer before using it. 2019-09-24 09:22:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 mark.lam mark.lam cdumez ggaren rmorisset thorton oldest_to_newest 1573667 0 mark.lam 2019-09-24 08:49:24 -0700 ... 1573670 1 379455 mark.lam 2019-09-24 08:54:48 -0700 Created attachment 379455 proposed patch. 1573672 2 379455 rmorisset 2019-09-24 09:17:04 -0700 Comment on attachment 379455 proposed patch. r=me 1573673 3 379455 cdumez 2019-09-24 09:18:13 -0700 Comment on attachment 379455 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=379455&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:232 > + , m_hiddenPageThrottlingAutoIncreasesCounter([this](RefCounterEvent) { m_hiddenPageThrottlingTimer.startOneShot(0_s); }) The RefCounter constructor does not run the lambda it is being given so I don't understand the problem. 1573675 4 379455 mark.lam 2019-09-24 09:22:03 -0700 Comment on attachment 379455 proposed patch. I think Chris meant to r- this patch. This is not an issue after all. I just didn't look carefully enough at the code. Sorry for the noise. 379455 2019-09-24 08:54:48 -0700 2019-09-24 09:22:03 -0700 proposed patch. bug-202146.patch text/plain 3225 mark.lam SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTAzMDApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA5LTI0ICBNYXJrIExhbSAg PG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBXZSBzaG91bGQgaW5pdGlhbGl6ZSBXZWJQ cm9jZXNzUG9vbDo6bV9oaWRkZW5QYWdlVGhyb3R0bGluZ1RpbWVyIGJlZm9yZSB1c2luZyBpdC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjE0Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBXZWJQ cm9jZXNzUG9vbCBjb25zdHJ1Y3RvciB3YXMgaW52b2tpbmcgc3RhcnRPbmVTaG90KCkgb24KKyAg ICAgICAgbV9oaWRkZW5QYWdlVGhyb3R0bGluZ1RpbWVyIGJlZm9yZSBpdCB3YXMgY29uc3RydWN0 ZWQuICBUaGlzIHBhdGNoIGZpeGVzIHRoaXMgYnkKKyAgICAgICAgcmV2ZXJzaW5nIHRoZSBvcmRl ciBvZiB0aGVzZSAyLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcDoK KyAgICAgICAgKFdlYktpdDo6bV9wcm9jZXNzU3VwcHJlc3Npb25EaXNhYmxlZEZvclBhZ2VDb3Vu dGVyKToKKyAgICAgICAgKFdlYktpdDo6bV9oaWRkZW5QYWdlVGhyb3R0bGluZ0F1dG9JbmNyZWFz ZXNDb3VudGVyKToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuaDoKKwogMjAx OS0wOS0yNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJlcXVpcmUgYSBXZWJzaXRlRGF0YVN0b3JlIHdoZW4gY3JlYXRpbmcgb3IgcmVzdW1p bmcgZG93bmxvYWRzCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9v bC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bv b2wuY3BwCShyZXZpc2lvbiAyNTAzMDApCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ cm9jZXNzUG9vbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29w eXJpZ2h0IChDKSAyMDEwLTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICog Q29weXJpZ2h0IChDKSAyMDEwLTIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgog ICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMs IHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVk IHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0yMjgsOCArMjI4LDggQEAgV2ViUHJv Y2Vzc1Bvb2w6OldlYlByb2Nlc3NQb29sKEFQSTo6UHJvYwogICAgICwgbV9zaG91bGRUYWtlVUlC YWNrZ3JvdW5kQXNzZXJ0aW9uKG1fY29uZmlndXJhdGlvbi0+c2hvdWxkVGFrZVVJQmFja2dyb3Vu ZEFzc2VydGlvbigpKQogICAgICwgbV91c2VyT2JzZXJ2YWJsZVBhZ2VDb3VudGVyKFt0aGlzXShS ZWZDb3VudGVyRXZlbnQpIHsgdXBkYXRlUHJvY2Vzc1N1cHByZXNzaW9uU3RhdGUoKTsgfSkKICAg ICAsIG1fcHJvY2Vzc1N1cHByZXNzaW9uRGlzYWJsZWRGb3JQYWdlQ291bnRlcihbdGhpc10oUmVm Q291bnRlckV2ZW50KSB7IHVwZGF0ZVByb2Nlc3NTdXBwcmVzc2lvblN0YXRlKCk7IH0pCi0gICAg LCBtX2hpZGRlblBhZ2VUaHJvdHRsaW5nQXV0b0luY3JlYXNlc0NvdW50ZXIoW3RoaXNdKFJlZkNv dW50ZXJFdmVudCkgeyBtX2hpZGRlblBhZ2VUaHJvdHRsaW5nVGltZXIuc3RhcnRPbmVTaG90KDBf cyk7IH0pCiAgICAgLCBtX2hpZGRlblBhZ2VUaHJvdHRsaW5nVGltZXIoUnVuTG9vcDo6bWFpbigp LCB0aGlzLCAmV2ViUHJvY2Vzc1Bvb2w6OnVwZGF0ZUhpZGRlblBhZ2VUaHJvdHRsaW5nQXV0b0lu Y3JlYXNlTGltaXQpCisgICAgLCBtX2hpZGRlblBhZ2VUaHJvdHRsaW5nQXV0b0luY3JlYXNlc0Nv dW50ZXIoW3RoaXNdKFJlZkNvdW50ZXJFdmVudCkgeyBtX2hpZGRlblBhZ2VUaHJvdHRsaW5nVGlt ZXIuc3RhcnRPbmVTaG90KDBfcyk7IH0pCiAgICAgLCBtX3NlcnZpY2VXb3JrZXJQcm9jZXNzZXNU ZXJtaW5hdGlvblRpbWVyKFJ1bkxvb3A6Om1haW4oKSwgdGhpcywgJldlYlByb2Nlc3NQb29sOjp0 ZXJtaW5hdGVTZXJ2aWNlV29ya2VyUHJvY2Vzc2VzKQogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkp CiAgICAgLCBtX2ZvcmVncm91bmRXZWJQcm9jZXNzQ291bnRlcihbdGhpc10oUmVmQ291bnRlckV2 ZW50KSB7IHVwZGF0ZVByb2Nlc3NBc3NlcnRpb25zKCk7IH0pCkluZGV4OiBTb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmgJKHJldmlzaW9uIDI1MDMwMCkKKysrIFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmgJKHdvcmtpbmcgY29weSkKQEAgLTczMyw4 ICs3MzMsOCBAQCBwcml2YXRlOgogCiAgICAgVXNlck9ic2VydmFibGVQYWdlQ291bnRlciBtX3Vz ZXJPYnNlcnZhYmxlUGFnZUNvdW50ZXI7CiAgICAgUHJvY2Vzc1N1cHByZXNzaW9uRGlzYWJsZWRD b3VudGVyIG1fcHJvY2Vzc1N1cHByZXNzaW9uRGlzYWJsZWRGb3JQYWdlQ291bnRlcjsKLSAgICBI aWRkZW5QYWdlVGhyb3R0bGluZ0F1dG9JbmNyZWFzZXNDb3VudGVyIG1faGlkZGVuUGFnZVRocm90 dGxpbmdBdXRvSW5jcmVhc2VzQ291bnRlcjsKICAgICBSdW5Mb29wOjpUaW1lcjxXZWJQcm9jZXNz UG9vbD4gbV9oaWRkZW5QYWdlVGhyb3R0bGluZ1RpbWVyOworICAgIEhpZGRlblBhZ2VUaHJvdHRs aW5nQXV0b0luY3JlYXNlc0NvdW50ZXIgbV9oaWRkZW5QYWdlVGhyb3R0bGluZ0F1dG9JbmNyZWFz ZXNDb3VudGVyOwogCiAjaWYgUExBVEZPUk0oQ09DT0EpCiAgICAgUmV0YWluUHRyPE5TTXV0YWJs ZURpY3Rpb25hcnk+IG1fYnVuZGxlUGFyYW1ldGVyczsK