202143 2019-09-24 07:40:48 -0700 [iOS] iOS 13 does not send proper events in Safari, such as double tap and long touch, possibly​ influencing Leaflet JS apps​ 2019-10-01 00:43:03 -0700 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build iPhone / iPad Other CLOSED INVALID InRadar P2 Normal --- 1 tomas.slavkovsky webkit-unassigned graouts webkit-bug-importer oldest_to_newest 1573653 0 tomas.slavkovsky 2019-09-24 07:40:48 -0700 Long tap in iOS 13 Safari does not send any event to the Leaflet library and is handled by iOS itself. Double click emits following events: mouseover, mousemove, mousedown, mouseup, click, which results in leaflet's event click. Might be tested on test map on https://leafletjs.com, if you use long-press it will trigger the copy-paste. Double click does not trigger anything. https://github.com/Leaflet/Leaflet/issues/6817#issue-497034089 1574251 1 webkit-bug-importer 2019-09-25 15:37:20 -0700 <rdar://problem/55721808> 1575246 2 graouts 2019-09-30 06:18:28 -0700 The change in behavior seems tied to the availability of Pointer Events in iOS 13. With Pointer Events enabled (the default setting): - double-tap: nothing happens - long press: plus icon gets selected With Pointer Events disabled (Settings > Safari > Advanced > Experimental Features > Pointer Events set to off): - double-tap: map zooms to tapped location - long press: nothing happens Both of those behaviors match those of iOS 12.4.1 so Pointer Events introduced a regression for LeafletJS. 1575250 3 379833 graouts 2019-09-30 06:43:43 -0700 Created attachment 379833 Leaflet test Attached a simple test case for LeafletJS which includes the full JS source which may make it easier to diagnose issues. 1575254 4 graouts 2019-09-30 07:13:19 -0700 So, first, the "contextmenu" Leaflet event is not triggered because the Leaflet code uses "pointerdown" and "touchstart" events interchangeably and the availability of the former excludes the other. In Map.Tap.js the `_onDown` method has this check `if (!e.touches) { return; }` which will always lead to an early return since a PointerEvent event is not the same as a TouchEvent and does not have a `touches` property. So the lack of a Leaflet "contextmenu" event being triggered is a Leaflet issue specifically. 1575255 5 graouts 2019-09-30 07:31:24 -0700 Actually, the "contextmenu"-related code is never initialized because Leaflet only enables it if touch events are supported but pointer events aren't: if (Browser.touch && !Browser.pointer) { Map.addInitHook('addHandler', 'tap', Tap); } This makes sense since the code up there is specific to touch events. This code is simply not designed to work with Pointer Events at all. Now to diagnose why double-tap-to-zoom the map doesn't work… 1575256 6 graouts 2019-09-30 07:43:12 -0700 OK, the double-tap issue is also a Leaflet issue. Consider this code in DomEvent.DoubleTap.js: function onTouchStart(e) { var count; if (Browser.pointer) { if ((!Browser.edge) || e.pointerType === 'mouse') { return; } count = _pointersCount; } else { count = e.touches.length; } if (count > 1) { return; } var now = Date.now(), delta = now - (last || now); touch = e.touches ? e.touches[0] : e; doubleTap = (delta > 0 && delta <= delay); last = now; } The function branches early between user agents that support Pointer Events and those that don't (based on `Browser.pointer`), but if `Browser.edge` is false it returns early. That property is false in iOS 13 and thus this function returns early and a "dblclick" event is never dispatched on the Leaflet Map object. So all reported issues are Leaflet issues, there is nothing for us to do here. 1575457 7 tomas.slavkovsky 2019-10-01 00:43:03 -0700 Thanks for looking into this. Confirming that it is a bug on Leaflet JS side. Will follow the track on Leaflet's Github. 379833 2019-09-30 06:43:43 -0700 2019-09-30 06:43:43 -0700 Leaflet test leaflet.html text/html 1132 graouts PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KCQoJPHRpdGxlPlF1aWNrIFN0YXJ0IC0gTGVh ZmxldDwvdGl0bGU+CgoJPG1ldGEgY2hhcnNldD0idXRmLTgiIC8+Cgk8bWV0YSBuYW1lPSJ2aWV3 cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNlLXdpZHRoLCBpbml0aWFsLXNjYWxlPTEuMCI+CgkK CTxsaW5rIHJlbD0ic2hvcnRjdXQgaWNvbiIgdHlwZT0iaW1hZ2UveC1pY29uIiBocmVmPSJkb2Nz L2ltYWdlcy9mYXZpY29uLmljbyIgLz4KCiAgICA8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9 Imh0dHBzOi8vdW5wa2cuY29tL2xlYWZsZXRAMS41LjEvZGlzdC9sZWFmbGV0LmNzcyIvPgogICAg PHNjcmlwdCBzcmM9Imh0dHBzOi8vdW5wa2cuY29tL2xlYWZsZXRAMS41LjEvZGlzdC9sZWFmbGV0 LXNyYy5qcyI+PC9zY3JpcHQ+CgoKCQo8L2hlYWQ+Cjxib2R5PgoKCgo8ZGl2IGlkPSJtYXBpZCIg c3R5bGU9IndpZHRoOiA2MDBweDsgaGVpZ2h0OiA0MDBweDsiPjwvZGl2Pgo8c2NyaXB0PgoKCXZh ciBteW1hcCA9IEwubWFwKCdtYXBpZCcpLnNldFZpZXcoWzUxLjUwNSwgLTAuMDldLCAxMyk7CgoJ TC50aWxlTGF5ZXIoJ2h0dHBzOi8vYXBpLnRpbGVzLm1hcGJveC5jb20vdjQve2lkfS97en0ve3h9 L3t5fS5wbmc/YWNjZXNzX3Rva2VuPXBrLmV5SjFJam9pYldGd1ltOTRJaXdpWVNJNkltTnBlalk0 TlhWeWNUQTJlbVl5Y1hCbmRIUnFjbVozTjNnaWZRLnJKY0ZJRzIxNEFyaUlTTGJCNkI1YXcnLCB7 CgkJbWF4Wm9vbTogMTgsCgkJYXR0cmlidXRpb246ICdNYXAgZGF0YSAmY29weTsgPGEgaHJlZj0i aHR0cHM6Ly93d3cub3BlbnN0cmVldG1hcC5vcmcvIj5PcGVuU3RyZWV0TWFwPC9hPiBjb250cmli dXRvcnMsICcgKwoJCQknPGEgaHJlZj0iaHR0cHM6Ly9jcmVhdGl2ZWNvbW1vbnMub3JnL2xpY2Vu c2VzL2J5LXNhLzIuMC8iPkNDLUJZLVNBPC9hPiwgJyArCgkJCSdJbWFnZXJ5IMKpIDxhIGhyZWY9 Imh0dHBzOi8vd3d3Lm1hcGJveC5jb20vIj5NYXBib3g8L2E+JywKCQlpZDogJ21hcGJveC5zdHJl ZXRzJwoJfSkuYWRkVG8obXltYXApOwoKICAgIG15bWFwLm9uKCJjb250ZXh0bWVudSIsIGV2ZW50 ID0+IGFsZXJ0KCJmb28iKSkKCjwvc2NyaXB0PgoKCgo8L2JvZHk+CjwvaHRtbD4KCg==