202123 2019-09-23 16:43:13 -0700 JavaScriptCore (still) doesn't unlock the engineering keychain 2019-09-24 12:23:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 200733 1 ap ap commit-queue ews-watchlist keith_miller krollin mark.lam mitz msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1573477 0 ap 2019-09-23 16:43:13 -0700 Unlike WebKit, JavaScriptCore only defines CODE_SIGN_IDENTITY in ToolExecutable, not in DebugRelease. As a result, it's not defined when running the script for Unlock Keychain phase. 1573480 1 379408 ap 2019-09-23 16:48:43 -0700 Created attachment 379408 proposed patch 1573481 2 379408 keith_miller 2019-09-23 16:52:05 -0700 Comment on attachment 379408 proposed patch r=me. 1573483 3 ap 2019-09-23 17:02:27 -0700 On the other hand, maybe we should start signing everything in the same way. Does anyone remember why only tool targets get CODE_SIGN_IDENTITY defined? 1573507 4 tzagallo 2019-09-23 18:03:17 -0700 (In reply to Alexey Proskuryakov from comment #3) > On the other hand, maybe we should start signing everything in the same way. > Does anyone remember why only tool targets get CODE_SIGN_IDENTITY defined? The only executable that actually needs signing is testapi, in order to test the bytecode cache, so I only added it to ToolExecutable... maybe it wasn't the best call. 1573674 5 379456 ap 2019-09-24 09:21:13 -0700 Created attachment 379456 alternative fix Alternative fix - just sign everything in JavaScriptCore, the same way it's done in WebKit. 1573742 6 379456 commit-queue 2019-09-24 12:22:29 -0700 Comment on attachment 379456 alternative fix Clearing flags on attachment: 379456 Committed r250314: <https://trac.webkit.org/changeset/250314> 1573743 7 commit-queue 2019-09-24 12:22:30 -0700 All reviewed patches have been landed. Closing bug. 1573744 8 webkit-bug-importer 2019-09-24 12:23:16 -0700 <rdar://problem/55672336> 379408 2019-09-23 16:48:43 -0700 2019-09-24 11:31:40 -0700 proposed patch UnlockKeychain.txt text/plain 2357 ap SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUwMjY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE5LTA5LTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAg ICAgIEphdmFTY3JpcHRDb3JlIChzdGlsbCkgZG9lc24ndCB1bmxvY2sgdGhlIGVuZ2luZWVyaW5n IGtleWNoYWluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDIxMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVbmxpa2UgV2ViS2l0LCBKYXZhU2NyaXB0Q29yZSBvbmx5IGRlZmluZXMgQ09ERV9TSUdOX0lE RU5USVRZIGluIFRvb2xFeGVjdXRhYmxlLAorICAgICAgICBub3QgaW4gRGVidWdSZWxlYXNlLiBB cyBhIHJlc3VsdCwgaXQncyBub3QgZGVmaW5lZCB3aGVuIHJ1bm5pbmcgdGhlIHNjcmlwdCBmb3IK KyAgICAgICAgVW5sb2NrIEtleWNoYWluIHBoYXNlLgorCisgICAgICAgIEZpeCB0aGlzIGJ5IG1h a2luZyBVbmxvY2sgS2V5Y2hhaW4gdXNlIFRvb2xFeGVjdXRhYmxlIGNvbmZpZ3VyYXRpb24gdG9v LgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajoK KwogMjAxOS0wOS0yMyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAg TGF6eSBKU0dsb2JhbE9iamVjdCBwcm9wZXJ0eSBtYXRlcmlhbGl6YXRpb24gc2hvdWxkIG5vdCB1 c2UgcHV0RGlyZWN0V2l0aG91dFRyYW5zaXRpb24uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvago9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvagkocmV2aXNpb24gMjUwMjYyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFT Y3JpcHRDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHdvcmtpbmcgY29weSkKQEAgLTEx NzA1LDYgKzExNzAzLDcgQEAKIAkJfTsKIAkJMTRDRkIxMDEyMzAzNUVGMzAwRjAwNDhDIC8qIERl YnVnICovID0gewogCQkJaXNhID0gWENCdWlsZENvbmZpZ3VyYXRpb247CisJCQliYXNlQ29uZmln dXJhdGlvblJlZmVyZW5jZSA9IEJDMDIxQkYyMTM2OTAwQzMwMEZDNTQ2NyAvKiBUb29sRXhlY3V0 YWJsZS54Y2NvbmZpZyAqLzsKIAkJCWJ1aWxkU2V0dGluZ3MgPSB7CiAJCQkJQ09QWV9QSEFTRV9T VFJJUCA9IE5POwogCQkJCUdDQ19EWU5BTUlDX05PX1BJQyA9IE5POwpAQCAtMTE3MTUsNiArMTE3 MTQsNyBAQAogCQl9OwogCQkxNENGQjEwMjIzMDM1RUYzMDBGMDA0OEMgLyogUmVsZWFzZSAqLyA9 IHsKIAkJCWlzYSA9IFhDQnVpbGRDb25maWd1cmF0aW9uOworCQkJYmFzZUNvbmZpZ3VyYXRpb25S ZWZlcmVuY2UgPSBCQzAyMUJGMjEzNjkwMEMzMDBGQzU0NjcgLyogVG9vbEV4ZWN1dGFibGUueGNj b25maWcgKi87CiAJCQlidWlsZFNldHRpbmdzID0gewogCQkJCUNPUFlfUEhBU0VfU1RSSVAgPSBZ RVM7CiAJCQkJREVCVUdfSU5GT1JNQVRJT05fRk9STUFUID0gImR3YXJmLXdpdGgtZHN5bSI7CkBA IC0xMTcyNCw2ICsxMTcyNCw3IEBACiAJCX07CiAJCTE0Q0ZCMTAzMjMwMzVFRjMwMEYwMDQ4QyAv KiBQcm9maWxpbmcgKi8gPSB7CiAJCQlpc2EgPSBYQ0J1aWxkQ29uZmlndXJhdGlvbjsKKwkJCWJh c2VDb25maWd1cmF0aW9uUmVmZXJlbmNlID0gQkMwMjFCRjIxMzY5MDBDMzAwRkM1NDY3IC8qIFRv b2xFeGVjdXRhYmxlLnhjY29uZmlnICovOwogCQkJYnVpbGRTZXR0aW5ncyA9IHsKIAkJCQlQUk9E VUNUX05BTUUgPSAiVW5sb2NrIGtleWNoYWluIjsKIAkJCX07CkBAIC0xMTczMSw2ICsxMTczMiw3 IEBACiAJCX07CiAJCTE0Q0ZCMTA0MjMwMzVFRjMwMEYwMDQ4QyAvKiBQcm9kdWN0aW9uICovID0g ewogCQkJaXNhID0gWENCdWlsZENvbmZpZ3VyYXRpb247CisJCQliYXNlQ29uZmlndXJhdGlvblJl ZmVyZW5jZSA9IEJDMDIxQkYyMTM2OTAwQzMwMEZDNTQ2NyAvKiBUb29sRXhlY3V0YWJsZS54Y2Nv bmZpZyAqLzsKIAkJCWJ1aWxkU2V0dGluZ3MgPSB7CiAJCQkJUFJPRFVDVF9OQU1FID0gIlVubG9j ayBrZXljaGFpbiI7CiAJCQl9Owo= 379456 2019-09-24 09:21:13 -0700 2019-09-24 12:22:29 -0700 alternative fix UnlockKeychain2.txt text/plain 3023 ap SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUwMzAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE5LTA5LTI0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAg ICAgIEphdmFTY3JpcHRDb3JlIChzdGlsbCkgZG9lc24ndCB1bmxvY2sgdGhlIGVuZ2luZWVyaW5n IGtleWNoYWluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDIxMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVbmxpa2UgV2ViS2l0LCBKYXZhU2NyaXB0Q29yZSBvbmx5IGRlZmluZXMgQ09ERV9TSUdOX0lE RU5USVRZIGluIFRvb2xFeGVjdXRhYmxlCisgICAgICAgIGNvbmZpZ3VyYXRpb24sIG5vdCBpbiBE ZWJ1Z1JlbGVhc2UuIEFzIGEgcmVzdWx0LCBpdCdzIG5vdCBkZWZpbmVkIHdoZW4gcnVubmluZwor ICAgICAgICB0aGUgc2NyaXB0IGZvciBVbmxvY2sgS2V5Y2hhaW4gcGhhc2UuCisKKyAgICAgICAg Rml4IHRoaXMgYnkgbW92aW5nIENPREVfU0lHTl9JREVOVElUWSB0byBEZWJ1Z1JlbGVhc2UgY29u ZmlndXJhdGlvbiwgbWF0Y2hpbmcKKyAgICAgICAgV2ViS2l0LiBBcyBhIHJlc3VsdCwgd2UgYXJl IG5vdyB1c2luZyBjb25zaXN0ZW50IHNpZ25pbmcgb3B0aW9ucyBpbiBhbGwgdGFyZ2V0cy4KKwor ICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54Y2NvbmZpZzoKKyAgICAgICAg KiBDb25maWd1cmF0aW9ucy9Ub29sRXhlY3V0YWJsZS54Y2NvbmZpZzoKKyAgICAgICAgV2hlbiBt b3ZpbmcsIHJlbW92ZWQgYSBzcGVjaWFsIGNhc2UgZm9yIFByb2R1Y3Rpb24sIGFzIHRoYXQncyBu ZXZlciB1c2VkIHdpdGgKKyAgICAgICAgRGVidWdSZWxlYXNlIChhbHNvLCB0aGUgUHJvZmlsZSBj YXNlIHdhcyBpbmNvcnJlY3QpLgorCiAyMDE5LTA5LTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBSZWZhY3RvciBjZWxsU2l6ZSgpIG91dCBvZiBWTUluc3BlY3Rv cjo6dmVyaWZ5Q2VsbFNpemUoKS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1 cmF0aW9ucy9EZWJ1Z1JlbGVhc2UueGNjb25maWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54Y2NvbmZpZwkocmV2aXNpb24g MjUwMjYyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0RlYnVnUmVs ZWFzZS54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMzksNiArMzksMTEgQEAgTUFDT1NYX0RF UExPWU1FTlRfVEFSR0VUX21hY29zeF8xMDE2MDAgPQogR0NDX1dBUk5fQUJPVVRfREVQUkVDQVRF RF9GVU5DVElPTlMgPSBZRVM7CiBERUJVR19JTkZPUk1BVElPTl9GT1JNQVQgPSBkd2FyZjsKIAor Q09ERV9TSUdOX0lERU5USVRZW3Nkaz1tYWNvc3gqXSA9ICQoQ09ERV9TSUdOX0lERU5USVRZXyQo VVNFX0lOVEVSTkFMX1NESykpOworQ09ERV9TSUdOX0lERU5USVRZXyA9ICQoQ09ERV9TSUdOX0lE RU5USVRZX05PKTsKK0NPREVfU0lHTl9JREVOVElUWV9OTyA9IC07CitDT0RFX1NJR05fSURFTlRJ VFlfWUVTID0gJChXS19FTkdJTkVFUklOR19DT0RFX1NJR05fSURFTlRJVFkpOworCiBTREtST09U ID0gJChTREtST09UXyQoVVNFX0lOVEVSTkFMX1NESykpOwogU0RLUk9PVF8gPSBtYWNvc3g7CiBT REtST09UX1lFUyA9IG1hY29zeC5pbnRlcm5hbDsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9Db25maWd1cmF0aW9ucy9Ub29sRXhlY3V0YWJsZS54Y2NvbmZpZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVG9vbEV4ZWN1dGFibGUueGNjb25m aWcJKHJldmlzaW9uIDI1MDI2MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0 aW9ucy9Ub29sRXhlY3V0YWJsZS54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMzMsMTYgKzMz LDYgQEAgVVNFX0lOVEVSTkFMX1NES19Qcm9kdWN0aW9uID0gWUVTOwogVVNFX0lOVEVSTkFMX1NE S19EZWJ1ZyA9ICQoSEFWRV9JTlRFUk5BTF9TREspOwogVVNFX0lOVEVSTkFMX1NES19SZWxlYXNl ID0gJChIQVZFX0lOVEVSTkFMX1NESyk7CiAKLUNPREVfU0lHTl9JREVOVElUWVtzZGs9bWFjb3N4 Kl0gPSAkKENPREVfU0lHTl9JREVOVElUWV8kKENPTkZJR1VSQVRJT04pKTsKLQotQ09ERV9TSUdO X0lERU5USVRZX1Byb2R1Y3Rpb24gPSAkKENPREVfU0lHTl9JREVOVElUWV9OTyk7Ci1DT0RFX1NJ R05fSURFTlRJVFlfRGVidWcgPSAkKENPREVfU0lHTl9JREVOVElUWV8kKFVTRV9JTlRFUk5BTF9T REspKTsKLUNPREVfU0lHTl9JREVOVElUWV9SZWxlYXNlID0gJChDT0RFX1NJR05fSURFTlRJVFlf JChVU0VfSU5URVJOQUxfU0RLKSk7Ci0KLUNPREVfU0lHTl9JREVOVElUWV8gPSAkKENPREVfU0lH Tl9JREVOVElUWV9OTyk7Ci1DT0RFX1NJR05fSURFTlRJVFlfTk8gPSAtOwotQ09ERV9TSUdOX0lE RU5USVRZX1lFUyA9ICQoV0tfRU5HSU5FRVJJTkdfQ09ERV9TSUdOX0lERU5USVRZKTsKLQogQ09E RV9TSUdOX0VOVElUTEVNRU5UU1tzZGs9bWFjb3N4Kl0gPSAkKENPREVfU0lHTl9FTlRJVExFTUVO VFNfbWFjb3N4XyQoVEFSR0VUX05BTUUpXyQoVVNFX0lOVEVSTkFMX1NESykpOwogQ09ERV9TSUdO X0VOVElUTEVNRU5UU19tYWNvc3hfdGVzdGFwaV9ZRVMgPSB0ZXN0YXBpLmVudGl0bGVtZW50czsK IAo=