202112 2019-09-23 11:01:09 -0700 [iOS] REGRESSION(r250151): Occasional assertion failures in ShareableBitmap::~ShareableBitmap() 2019-09-23 13:15:27 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 david_quesada webkit-unassigned cdumez commit-queue thorton webkit-bug-importer oldest_to_newest 1573357 0 david_quesada 2019-09-23 11:01:09 -0700 CGImageRef's created from a ShareableBitmap can legitimately be deallocated on a background thread. When this happens, the data provider's release callback will be called. This derefs the ShareableBitmap, which might cause it to deallocate, isn't allowed on the background thread. releaseDataProviderData() should dispatch to the main runloop if it is called from a background thread. This is similar to what r250151 added for releaseBitmapContextData(). 1573358 1 david_quesada 2019-09-23 11:01:33 -0700 rdar://problem/55624598 1573363 2 379379 david_quesada 2019-09-23 11:14:21 -0700 Created attachment 379379 Patch 1573378 3 379379 cdumez 2019-09-23 12:30:16 -0700 Comment on attachment 379379 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379379&action=review > Source/WebKit/Shared/cg/ShareableBitmapCG.cpp:159 > + if (!RunLoop::isMain()) { This looks a lot like https://trac.webkit.org/changeset/250151 ? 1573379 4 379379 cdumez 2019-09-23 12:31:12 -0700 Comment on attachment 379379 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379379&action=review >> Source/WebKit/Shared/cg/ShareableBitmapCG.cpp:159 >> + if (!RunLoop::isMain()) { > > This looks a lot like https://trac.webkit.org/changeset/250151 ? Oh, it is a different release function :) 1573384 5 379379 commit-queue 2019-09-23 13:15:25 -0700 Comment on attachment 379379 Patch Clearing flags on attachment: 379379 Committed r250248: <https://trac.webkit.org/changeset/250248> 1573385 6 commit-queue 2019-09-23 13:15:27 -0700 All reviewed patches have been landed. Closing bug. 379379 2019-09-23 11:14:21 -0700 2019-09-23 13:15:25 -0700 Patch file_202112.txt text/plain 2887 david_quesada Y29tbWl0IGE2N2NlMDI4OTJkZTMyODVhOTk0ZWIwZjZlM2Q3ZTNiNzM2MzBiMDYNCkF1dGhvcjog RGF2aWQgUXVlc2FkYSA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQpEYXRlOiAgIE1vbiBTZXAg MjMgMTE6MTI6MjMgMjAxOSAtMDcwMA0KDQogICAgW2lPU10gUkVHUkVTU0lPTihyMjUwMTUxKTog T2NjYXNpb25hbCBhc3NlcnRpb24gZmFpbHVyZXMgaW4gU2hhcmVhYmxlQml0bWFwOjp+U2hhcmVh YmxlQml0bWFwKCkNCiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAyMTEyDQogICAgcmRhcjovL3Byb2JsZW0vNTU2MjQ1OTgNCiAgICANCiAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4NCiAgICANCiAgICAqIFNoYXJlZC9jZy9TaGFyZWFibGVCaXRtYXBD Ry5jcHA6DQogICAgKFdlYktpdDo6U2hhcmVhYmxlQml0bWFwOjpyZWxlYXNlRGF0YVByb3ZpZGVy RGF0YSk6DQogICAgSXQgaXMgcG9zc2libGUgYW5kIHZhbGlkIGZvciBhIFVJSW1hZ2UgY3JlYXRl ZCBmcm9tIGEgU2hhcmVhYmxlQml0bWFwJ3MgQ0dJbWFnZSByZXByZXNlbnRhdGlvbg0KICAgIHRv IGJlIGRlYWxsb2NhdGVkIG9uIGEgYmFja2dyb3VuZCB0aHJlYWQuIFdoZW4gdGhpcyBoYXBwZW5z LCByZWxlYXNlRGF0YVByb3ZpZGVyRGF0YSgpIHNob3VsZA0KICAgIGVuc3VyZSBpdCdzIHJ1bm5p bmcgb24gdGhlIG1haW4gdGhyZWFkIGJlZm9yZSBkZXJlZidpbmcgdGhlIFNoYXJlYWJsZUJpdG1h cC4gT3RoZXJ3aXNlIHRoZQ0KICAgIGJpdG1hcCBjYW4gYmUgZGVhbGxvY2F0ZWQgb24gdGhlIGJh Y2tncm91bmQgdGhyZWFkLCB2aW9sYXRpbmcgYW4gYXNzZXJ0aW9uIGFkZGVkIGluIHIyNTAxNTEu DQoNCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nDQppbmRleCA4MjJhMzU4ZTc5MC4uZjAwZWYxMTQ1ZDkgMTAwNjQ0DQotLS0gYS9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZw0KKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cNCkBA IC0xLDMgKzEsMTggQEANCisyMDE5LTA5LTIzICBEYXZpZCBRdWVzYWRhICA8ZGF2aWRfcXVlc2Fk YUBhcHBsZS5jb20+DQorDQorICAgICAgICBbaU9TXSBSRUdSRVNTSU9OKHIyNTAxNTEpOiBPY2Nh c2lvbmFsIGFzc2VydGlvbiBmYWlsdXJlcyBpbiBTaGFyZWFibGVCaXRtYXA6On5TaGFyZWFibGVC aXRtYXAoKQ0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwMjExMg0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNTU2MjQ1OTgNCisNCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAgKiBTaGFyZWQvY2cvU2hhcmVh YmxlQml0bWFwQ0cuY3BwOg0KKyAgICAgICAgKFdlYktpdDo6U2hhcmVhYmxlQml0bWFwOjpyZWxl YXNlRGF0YVByb3ZpZGVyRGF0YSk6DQorICAgICAgICBJdCBpcyBwb3NzaWJsZSBhbmQgdmFsaWQg Zm9yIGEgVUlJbWFnZSBjcmVhdGVkIGZyb20gYSBTaGFyZWFibGVCaXRtYXAncyBDR0ltYWdlIHJl cHJlc2VudGF0aW9uDQorICAgICAgICB0byBiZSBkZWFsbG9jYXRlZCBvbiBhIGJhY2tncm91bmQg dGhyZWFkLiBXaGVuIHRoaXMgaGFwcGVucywgcmVsZWFzZURhdGFQcm92aWRlckRhdGEoKSBzaG91 bGQNCisgICAgICAgIGVuc3VyZSBpdCdzIHJ1bm5pbmcgb24gdGhlIG1haW4gdGhyZWFkIGJlZm9y ZSBkZXJlZidpbmcgdGhlIFNoYXJlYWJsZUJpdG1hcC4gT3RoZXJ3aXNlIHRoZQ0KKyAgICAgICAg Yml0bWFwIGNhbiBiZSBkZWFsbG9jYXRlZCBvbiB0aGUgYmFja2dyb3VuZCB0aHJlYWQsIHZpb2xh dGluZyBhbiBhc3NlcnRpb24gYWRkZWQgaW4gcjI1MDE1MS4NCisNCiAyMDE5LTA5LTIzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4NCiANCiAgICAgICAgIFNpbXBsaWZ5IFVzZXJN ZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlciBtYW5hZ2VtZW50IG9mIFVzZXJNZWRpYVJlcXVl c3QNCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9jZy9TaGFyZWFibGVCaXRtYXBD Ry5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9jZy9TaGFyZWFibGVCaXRtYXBDRy5jcHANCmlu ZGV4IDNlMzFjZGVjMDc0Li41YzRjMzYyMDBkYyAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJLaXQv U2hhcmVkL2NnL1NoYXJlYWJsZUJpdG1hcENHLmNwcA0KKysrIGIvU291cmNlL1dlYktpdC9TaGFy ZWQvY2cvU2hhcmVhYmxlQml0bWFwQ0cuY3BwDQpAQCAtMTU2LDYgKzE1NiwxMyBAQCB2b2lkIFNo YXJlYWJsZUJpdG1hcDo6cmVsZWFzZUJpdG1hcENvbnRleHREYXRhKHZvaWQqIHR5cGVsZXNzQml0 bWFwLCB2b2lkKiB0eXBlbA0KIA0KIHZvaWQgU2hhcmVhYmxlQml0bWFwOjpyZWxlYXNlRGF0YVBy b3ZpZGVyRGF0YSh2b2lkKiB0eXBlbGVzc0JpdG1hcCwgY29uc3Qgdm9pZCogdHlwZWxlc3NEYXRh LCBzaXplX3QpDQogew0KKyAgICBpZiAoIVJ1bkxvb3A6OmlzTWFpbigpKSB7DQorICAgICAgICBS dW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3R5cGVsZXNzQml0bWFwLCB0eXBlbGVzc0RhdGFdIHsN CisgICAgICAgICAgICByZWxlYXNlRGF0YVByb3ZpZGVyRGF0YSh0eXBlbGVzc0JpdG1hcCwgdHlw ZWxlc3NEYXRhLCAwKTsNCisgICAgICAgIH0pOw0KKyAgICAgICAgcmV0dXJuOw0KKyAgICB9DQor DQogICAgIFNoYXJlYWJsZUJpdG1hcCogYml0bWFwID0gc3RhdGljX2Nhc3Q8U2hhcmVhYmxlQml0 bWFwKj4odHlwZWxlc3NCaXRtYXApOw0KICAgICBBU1NFUlRfVU5VU0VEKHR5cGVsZXNzRGF0YSwg Yml0bWFwLT5kYXRhKCkgPT0gdHlwZWxlc3NEYXRhKTsNCiAgICAgYml0bWFwLT5kZXJlZigpOyAv LyBCYWxhbmNlZCBieSByZWYgaW4gY3JlYXRlQ0dJbWFnZS4NCg==