202099 2019-09-23 01:15:52 -0700 testmasm: integer operands loaded as unsigned values 2019-09-23 07:09:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199891 InRadar P2 Normal --- 1 zan zan ews-watchlist justin_michaud keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1573250 0 zan 2019-09-23 01:15:52 -0700 testmasm: integer operands loaded as unsigned values 1573251 1 zan 2019-09-23 01:20:05 -0700 ../../Source/JavaScriptCore/assembler/testmasm.cpp: In function ‘void {anonymous}::testBranchTestBit32RegReg()’: ../../Source/JavaScriptCore/assembler/testmasm.cpp:105:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare] if ((_actual) == (_expected)) \ ~~~~~~~~~~^~~~~~~~~~~~~~ ../../Source/JavaScriptCore/assembler/testmasm.cpp:105:23: note: in definition of macro ‘CHECK_EQ’ if ((_actual) == (_expected)) \ ^~ 1573252 2 379360 zan 2019-09-23 01:21:49 -0700 Created attachment 379360 Patch 1573290 3 379360 mark.lam 2019-09-23 07:01:32 -0700 Comment on attachment 379360 Patch r=me 1573291 4 379360 zan 2019-09-23 07:08:10 -0700 Comment on attachment 379360 Patch Clearing flags on attachment: 379360 Committed r250232: <https://trac.webkit.org/changeset/250232> 1573292 5 zan 2019-09-23 07:08:14 -0700 All reviewed patches have been landed. Closing bug. 1573293 6 webkit-bug-importer 2019-09-23 07:09:20 -0700 <rdar://problem/55621894> 379360 2019-09-23 01:21:49 -0700 2019-09-23 07:08:10 -0700 Patch bug-202099-20190923102148.patch text/plain 4533 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj M2Q5ZDM2YjI4N2IwYzE4YTFhMzBiOTc5ODhiMjBiYmVlYjJhODdkLi45NjQxZDI4NTIyY2QzODIy OGY4ODVkNWFlMjliMzVlNTcwOThhMDIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOS0wOS0yMyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j b20+CisKKyAgICAgICAgdGVzdG1hc206IGludGVnZXIgb3BlcmFuZHMgbG9hZGVkIGFzIHVuc2ln bmVkIHZhbHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjAyMDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU3VwcHJlc3MgR0NDIHdhcm5pbmdzIGFib3V0IGNvbXBhcmluZyBzaWduZWQgYW5kIHVuc2ln bmVkIHZhbHVlcyBpbgorICAgICAgICB0ZXN0IGNhc2VzIGludHJvZHVjZWQgaW4gcjI0NzkxMyBi eSB1c2luZyBzaWduZWQgaW50ZWdlciB0eXBlcyBmb3IKKyAgICAgICAgbG9hZGluZyAzMi1iaXQg YW5kIDY0LWJpdCBpbnRlZ2VyIG9wZXJhbmQgdmFsdWVzLgorCisgICAgICAgICogYXNzZW1ibGVy L3Rlc3RtYXNtLmNwcDoKKyAgICAgICAgKEpTQzo6dGVzdEJyYW5jaFRlc3RCaXQzMlJlZ1JlZyk6 CisgICAgICAgIChKU0M6OnRlc3RCcmFuY2hUZXN0Qml0MzJSZWdJbW0pOgorICAgICAgICAoSlND Ojp0ZXN0QnJhbmNoVGVzdEJpdDMyQWRkckltbSk6CisgICAgICAgIChKU0M6OnRlc3RCcmFuY2hU ZXN0Qml0NjRSZWdSZWcpOgorICAgICAgICAoSlNDOjp0ZXN0QnJhbmNoVGVzdEJpdDY0UmVnSW1t KToKKyAgICAgICAgKEpTQzo6dGVzdEJyYW5jaFRlc3RCaXQ2NEFkZHJJbW0pOgorCiAyMDE5LTA5 LTIyICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10g SW50NTJSZXAoRG91YmxlUmVwQW55SW50VXNlKSBzaG91bGQgbm90IGNhbGwgb3BlcmF0aW9uIGZ1 bmN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL3Rlc3Rt YXNtLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvdGVzdG1hc20uY3BwCmlu ZGV4IDgyYjQ0NmY2MzU3ODJmYWU0OGQ3OGUyYWNiOGU2NzE1MmE0NGUzNmUuLjQyY2Y4ZjI3ZjQw YWIwODIwMTQ4YjI1ZTk2OTVhMzQzYzU0YWNhNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvdGVzdG1hc20uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvdGVzdG1hc20uY3BwCkBAIC0zMzYsNyArMzM2LDcgQEAgc3RhdGljIFZlY3Rv cjxpbnQ2NF90PiBpbnQ2NE9wZXJhbmRzKCkKICNpZiBDUFUoWDg2XzY0KQogdm9pZCB0ZXN0QnJh bmNoVGVzdEJpdDMyUmVnUmVnKCkKIHsKLSAgICBmb3IgKHVpbnQzMl90IHZhbHVlIDogaW50MzJP cGVyYW5kcygpKSB7CisgICAgZm9yIChhdXRvIHZhbHVlIDogaW50MzJPcGVyYW5kcygpKSB7CiAg ICAgICAgIGF1dG8gdGVzdCA9IGNvbXBpbGUoWz1dIChDQ2FsbEhlbHBlcnMmIGppdCkgewogICAg ICAgICAgICAgZW1pdEZ1bmN0aW9uUHJvbG9ndWUoaml0KTsKIApAQCAtMzUxLDE0ICszNTEsMTQg QEAgdm9pZCB0ZXN0QnJhbmNoVGVzdEJpdDMyUmVnUmVnKCkKICAgICAgICAgICAgIGppdC5yZXQo KTsKICAgICAgICAgfSk7CiAKLSAgICAgICAgZm9yICh1aW50MzJfdCB2YWx1ZTIgOiBpbnQzMk9w ZXJhbmRzKCkpCisgICAgICAgIGZvciAoYXV0byB2YWx1ZTIgOiBpbnQzMk9wZXJhbmRzKCkpCiAg ICAgICAgICAgICBDSEVDS19FUShpbnZva2U8aW50Pih0ZXN0LCB2YWx1ZSwgdmFsdWUyKSwgKHZh bHVlPj4odmFsdWUyJTMyKSkmMSk7CiAgICAgfQogfQogCiB2b2lkIHRlc3RCcmFuY2hUZXN0Qml0 MzJSZWdJbW0oKQogewotICAgIGZvciAodWludDMyX3QgdmFsdWUgOiBpbnQzMk9wZXJhbmRzKCkp IHsKKyAgICBmb3IgKGF1dG8gdmFsdWUgOiBpbnQzMk9wZXJhbmRzKCkpIHsKICAgICAgICAgYXV0 byB0ZXN0ID0gY29tcGlsZShbPV0gKENDYWxsSGVscGVycyYgaml0KSB7CiAgICAgICAgICAgICBl bWl0RnVuY3Rpb25Qcm9sb2d1ZShqaXQpOwogCkBAIC0zNzMsMTQgKzM3MywxNCBAQCB2b2lkIHRl c3RCcmFuY2hUZXN0Qml0MzJSZWdJbW0oKQogICAgICAgICAgICAgaml0LnJldCgpOwogICAgICAg ICB9KTsKIAotICAgICAgICBmb3IgKHVpbnQzMl90IHZhbHVlMiA6IGludDMyT3BlcmFuZHMoKSkK KyAgICAgICAgZm9yIChhdXRvIHZhbHVlMiA6IGludDMyT3BlcmFuZHMoKSkKICAgICAgICAgICAg IENIRUNLX0VRKGludm9rZTxpbnQ+KHRlc3QsIHZhbHVlMiksICh2YWx1ZTI+Pih2YWx1ZSUzMikp JjEpOwogICAgIH0KIH0KIAogdm9pZCB0ZXN0QnJhbmNoVGVzdEJpdDMyQWRkckltbSgpCiB7Ci0g ICAgZm9yICh1aW50MzJfdCB2YWx1ZSA6IGludDMyT3BlcmFuZHMoKSkgeworICAgIGZvciAoYXV0 byB2YWx1ZSA6IGludDMyT3BlcmFuZHMoKSkgewogICAgICAgICBhdXRvIHRlc3QgPSBjb21waWxl KFs9XSAoQ0NhbGxIZWxwZXJzJiBqaXQpIHsKICAgICAgICAgICAgIGVtaXRGdW5jdGlvblByb2xv Z3VlKGppdCk7CiAKQEAgLTM5NSwxNCArMzk1LDE0IEBAIHZvaWQgdGVzdEJyYW5jaFRlc3RCaXQz MkFkZHJJbW0oKQogICAgICAgICAgICAgaml0LnJldCgpOwogICAgICAgICB9KTsKIAotICAgICAg ICBmb3IgKHVpbnQzMl90IHZhbHVlMiA6IGludDMyT3BlcmFuZHMoKSkKKyAgICAgICAgZm9yIChh dXRvIHZhbHVlMiA6IGludDMyT3BlcmFuZHMoKSkKICAgICAgICAgICAgIENIRUNLX0VRKGludm9r ZTxpbnQ+KHRlc3QsICZ2YWx1ZTIpLCAodmFsdWUyPj4odmFsdWUlMzIpKSYxKTsKICAgICB9CiB9 CiAKIHZvaWQgdGVzdEJyYW5jaFRlc3RCaXQ2NFJlZ1JlZygpCiB7Ci0gICAgZm9yICh1aW50NjRf dCB2YWx1ZSA6IGludDY0T3BlcmFuZHMoKSkgeworICAgIGZvciAoYXV0byB2YWx1ZSA6IGludDY0 T3BlcmFuZHMoKSkgewogICAgICAgICBhdXRvIHRlc3QgPSBjb21waWxlKFs9XSAoQ0NhbGxIZWxw ZXJzJiBqaXQpIHsKICAgICAgICAgICAgIGVtaXRGdW5jdGlvblByb2xvZ3VlKGppdCk7CiAKQEAg LTQxNywxNCArNDE3LDE0IEBAIHZvaWQgdGVzdEJyYW5jaFRlc3RCaXQ2NFJlZ1JlZygpCiAgICAg ICAgICAgICBqaXQucmV0KCk7CiAgICAgICAgIH0pOwogCi0gICAgICAgIGZvciAodWludDY0X3Qg dmFsdWUyIDogaW50NjRPcGVyYW5kcygpKQorICAgICAgICBmb3IgKGF1dG8gdmFsdWUyIDogaW50 NjRPcGVyYW5kcygpKQogICAgICAgICAgICAgQ0hFQ0tfRVEoaW52b2tlPGxvbmcgaW50Pih0ZXN0 LCB2YWx1ZSwgdmFsdWUyKSwgKHZhbHVlPj4odmFsdWUyJTY0KSkmMSk7CiAgICAgfQogfQogCiB2 b2lkIHRlc3RCcmFuY2hUZXN0Qml0NjRSZWdJbW0oKQogewotICAgIGZvciAodWludDY0X3QgdmFs dWUgOiBpbnQ2NE9wZXJhbmRzKCkpIHsKKyAgICBmb3IgKGF1dG8gdmFsdWUgOiBpbnQ2NE9wZXJh bmRzKCkpIHsKICAgICAgICAgYXV0byB0ZXN0ID0gY29tcGlsZShbPV0gKENDYWxsSGVscGVycyYg aml0KSB7CiAgICAgICAgICAgICBlbWl0RnVuY3Rpb25Qcm9sb2d1ZShqaXQpOwogCkBAIC00Mzks MTQgKzQzOSwxNCBAQCB2b2lkIHRlc3RCcmFuY2hUZXN0Qml0NjRSZWdJbW0oKQogICAgICAgICAg ICAgaml0LnJldCgpOwogICAgICAgICB9KTsKIAotICAgICAgICBmb3IgKHVpbnQ2NF90IHZhbHVl MiA6IGludDY0T3BlcmFuZHMoKSkKKyAgICAgICAgZm9yIChhdXRvIHZhbHVlMiA6IGludDY0T3Bl cmFuZHMoKSkKICAgICAgICAgICAgIENIRUNLX0VRKGludm9rZTxsb25nIGludD4odGVzdCwgdmFs dWUyKSwgKHZhbHVlMj4+KHZhbHVlJTY0KSkmMSk7CiAgICAgfQogfQogCiB2b2lkIHRlc3RCcmFu Y2hUZXN0Qml0NjRBZGRySW1tKCkKIHsKLSAgICBmb3IgKHVpbnQ2NF90IHZhbHVlIDogaW50NjRP cGVyYW5kcygpKSB7CisgICAgZm9yIChhdXRvIHZhbHVlIDogaW50NjRPcGVyYW5kcygpKSB7CiAg ICAgICAgIGF1dG8gdGVzdCA9IGNvbXBpbGUoWz1dIChDQ2FsbEhlbHBlcnMmIGppdCkgewogICAg ICAgICAgICAgZW1pdEZ1bmN0aW9uUHJvbG9ndWUoaml0KTsKIApAQCAtNDYxLDcgKzQ2MSw3IEBA IHZvaWQgdGVzdEJyYW5jaFRlc3RCaXQ2NEFkZHJJbW0oKQogICAgICAgICAgICAgaml0LnJldCgp OwogICAgICAgICB9KTsKIAotICAgICAgICBmb3IgKHVpbnQ2NF90IHZhbHVlMiA6IGludDY0T3Bl cmFuZHMoKSkKKyAgICAgICAgZm9yIChhdXRvIHZhbHVlMiA6IGludDY0T3BlcmFuZHMoKSkKICAg ICAgICAgICAgIENIRUNLX0VRKGludm9rZTxsb25nIGludD4odGVzdCwgJnZhbHVlMiksICh2YWx1 ZTI+Pih2YWx1ZSU2NCkpJjEpOwogICAgIH0KIH0K