202094 2019-09-22 19:06:08 -0700 WebPage::sessionID() does not need to get the sessionID from there WebCore Page 2019-09-23 09:32:27 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren rniwa webkit-bug-importer youennf oldest_to_newest 1573219 0 cdumez 2019-09-22 19:06:08 -0700 WebPage::sessionID() does not need to get the sessionID from there WebCore Page. 1573220 1 379351 cdumez 2019-09-22 19:07:48 -0700 Created attachment 379351 Patch 1573235 2 379351 youennf 2019-09-22 22:48:50 -0700 Comment on attachment 379351 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379351&action=review > Source/WebKit/WebProcess/WebPage/WebPage.h:297 > bool usesEphemeralSession() const { return m_page->usesEphemeralSession(); } Can we fix usesEphemeralSession() as well? 1573302 3 379370 cdumez 2019-09-23 08:22:16 -0700 Created attachment 379370 Patch 1573306 4 cdumez 2019-09-23 08:38:37 -0700 (In reply to youenn fablet from comment #2) > Comment on attachment 379351 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=379351&action=review > > > Source/WebKit/WebProcess/WebPage/WebPage.h:297 > > bool usesEphemeralSession() const { return m_page->usesEphemeralSession(); } > > Can we fix usesEphemeralSession() as well? Good catch, fixed. 1573325 5 379370 commit-queue 2019-09-23 09:31:22 -0700 Comment on attachment 379370 Patch Clearing flags on attachment: 379370 Committed r250236: <https://trac.webkit.org/changeset/250236> 1573327 6 commit-queue 2019-09-23 09:31:23 -0700 All reviewed patches have been landed. Closing bug. 1573328 7 webkit-bug-importer 2019-09-23 09:32:27 -0700 <rdar://problem/55625642> 379351 2019-09-22 19:07:48 -0700 2019-09-23 08:22:14 -0700 Patch bug-202094-20190922190746.patch text/plain 2801 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM3OTI0MDljMTBhZDVhZGIx OTM4NmIyMTFhOGE1ZjQ1ZTQxNzNlOWYuLjM2MDU4OTcyNDI5Mzk1MjM2ZDFkN2YxMDliYmVlNTI0 ZGY5MjFlYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDktMjIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXZWJQYWdlOjpzZXNzaW9uSUQoKSBk b2VzIG5vdCBuZWVkIHRvIGdldCB0aGUgc2Vzc2lvbklEIGZyb20gdGhlcmUgV2ViQ29yZSBQYWdl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDIwOTQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJQYWdl OjpzZXNzaW9uSUQoKSBkb2VzIG5vdCBuZWVkIHRvIGdldCB0aGUgc2Vzc2lvbklEIGZyb20gdGhl cmUgV2ViQ29yZSBQYWdlLCBpdCBjYW4KKyAgICAgICAgc2ltcGx5IGdldCB0aGUgc2Vzc2lvbklE IGZyb20gdGhlIFdlYlByb2Nlc3Mgc2luZ2xldG9uLCBub3cgdGhhdCB3ZSBoYXZlIGEgc2luZ2xl IHNlc3Npb24KKyAgICAgICAgcGVyIFdlYlByb2Nlc3MuIFRoaXMgd2lsbCBhdm9pZCBwb3RlbnRp YWwgY3Jhc2hlcyB0cnlpbmcgdG8gZGVyZWZlcmVuY2UgbV9wYWdlIHRvIGdldCB0aGUKKyAgICAg ICAgc2Vzc2lvbklELCBzaW5jZSBtX3BhZ2UgY2FuIGJlIG51bGwuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnNl c3Npb25JRCBjb25zdCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaDoK KyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2Vzc2lvbklEIGNvbnN0KTogRGVsZXRlZC4KKwog MjAxOS0wOS0yMSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIEZp eCBhbiBhc3NlcnRpb24gZmFpbHVyZSBpbnRyb2R1Y2VkIGluIHIyNTAxODYuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDNmYmFmYTUzOTRhNzlm ZjRkMzU2ODM2Y2I1MjQ1YjgxZjc4YWFhYzIuLjgwYThkMmM3MGZhZjY2MWRmNmUxOWUyNmVlYTg4 ODU3ODg0NDc3ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCkBAIC02ODA3LDYgKzY4MDcsMTEgQEAgRWxlbWVudCogV2ViUGFnZTo6ZWxlbWVudEZv clRleHRJbnB1dENvbnRleHQoY29uc3QgVGV4dElucHV0Q29udGV4dCYgdGV4dElucHV0Q28KICAg ICByZXR1cm4gZG9jdW1lbnQtPnNlYXJjaEZvckVsZW1lbnRCeUlkZW50aWZpZXIodGV4dElucHV0 Q29udGV4dC5lbGVtZW50SWRlbnRpZmllcik7CiB9CiAKK1BBTDo6U2Vzc2lvbklEIFdlYlBhZ2U6 OnNlc3Npb25JRCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigp LnNlc3Npb25JRCgpOworfQorCiB2b2lkIFdlYlBhZ2U6OmNvbmZpZ3VyZUxvZ2dpbmdDaGFubmVs KGNvbnN0IFN0cmluZyYgY2hhbm5lbE5hbWUsIFdURkxvZ0NoYW5uZWxTdGF0ZSBzdGF0ZSwgV1RG TG9nTGV2ZWwgbGV2ZWwpCiB7CiAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpDb25m aWd1cmVMb2dnaW5nQ2hhbm5lbChjaGFubmVsTmFtZSwgc3RhdGUsIGxldmVsKSk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmggYi9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKaW5kZXggYTRlMmZlZTA3ZjQ3ZTIy MTFkMTI0MzQwYzE4NTgzY2NkYTRkNTEwYi4uNjY0NjRmMmMxODIzNjI1NDQ0OTQ2NmFmZGNiZDU0 YzgzZWU3YjUyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu aApAQCAtMjkzLDcgKzI5Myw3IEBAIHB1YmxpYzoKICAgICBXZWJDb3JlOjpQYWdlKiBjb3JlUGFn ZSgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZS5nZXQoKTsgfQogICAgIFdlYkNvcmU6OlBhZ2VJZGVu dGlmaWVyIGlkZW50aWZpZXIoKSBjb25zdCB7IHJldHVybiBtX2lkZW50aWZpZXI7IH0KICAgICBT dG9yYWdlTmFtZXNwYWNlSWRlbnRpZmllciBzZXNzaW9uU3RvcmFnZU5hbWVzcGFjZUlkZW50aWZp ZXIoKSBjb25zdCB7IHJldHVybiBtYWtlT2JqZWN0SWRlbnRpZmllcjxTdG9yYWdlTmFtZXNwYWNl SWRlbnRpZmllclR5cGU+KG1fd2ViUGFnZVByb3h5SWRlbnRpZmllci50b1VJbnQ2NCgpKTsgfQot ICAgIFBBTDo6U2Vzc2lvbklEIHNlc3Npb25JRCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZS0+c2Vz c2lvbklEKCk7IH0KKyAgICBQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQoKSBjb25zdDsKICAgICBi b29sIHVzZXNFcGhlbWVyYWxTZXNzaW9uKCkgY29uc3QgeyByZXR1cm4gbV9wYWdlLT51c2VzRXBo ZW1lcmFsU2Vzc2lvbigpOyB9CiAKICAgICB2b2lkIHNldFNpemUoY29uc3QgV2ViQ29yZTo6SW50 U2l6ZSYpOwo= 379370 2019-09-23 08:22:16 -0700 2019-09-23 09:31:22 -0700 Patch bug-202094-20190923082214.patch text/plain 3024 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDgyMmEzNThlNzkwY2NiMGQ2 Mjc5ZWJkMjkxZGFjMGYwYzgxNDBjNmQuLjZjZDJhNmMwOTBiMjNmNDQ4MTU3NWM3YjUzYmRlMmVi MmRmMjcwMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDktMjMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXZWJQYWdlOjpzZXNzaW9uSUQoKSBk b2VzIG5vdCBuZWVkIHRvIGdldCB0aGUgc2Vzc2lvbklEIGZyb20gdGhlcmUgV2ViQ29yZSBQYWdl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDIwOTQK KworICAgICAgICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgIFdlYlBhZ2U6 OnNlc3Npb25JRCgpIGRvZXMgbm90IG5lZWQgdG8gZ2V0IHRoZSBzZXNzaW9uSUQgZnJvbSB0aGVy ZSBXZWJDb3JlIFBhZ2UsIGl0IGNhbgorICAgICAgICBzaW1wbHkgZ2V0IHRoZSBzZXNzaW9uSUQg ZnJvbSB0aGUgV2ViUHJvY2VzcyBzaW5nbGV0b24sIG5vdyB0aGF0IHdlIGhhdmUgYSBzaW5nbGUg c2Vzc2lvbgorICAgICAgICBwZXIgV2ViUHJvY2Vzcy4gVGhpcyB3aWxsIGF2b2lkIHBvdGVudGlh bCBjcmFzaGVzIHRyeWluZyB0byBkZXJlZmVyZW5jZSBtX3BhZ2UgdG8gZ2V0IHRoZQorICAgICAg ICBzZXNzaW9uSUQsIHNpbmNlIG1fcGFnZSBjYW4gYmUgbnVsbC4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2Vz c2lvbklEIGNvbnN0KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzZXNzaW9uSUQgY29uc3QpOiBEZWxldGVkLgorCiAy MDE5LTA5LTIzICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBT aW1wbGlmeSBVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIgbWFuYWdlbWVudCBvZiBV c2VyTWVkaWFSZXF1ZXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCmluZGV4IDNmYmFmYTUzOTRhNzlmZjRkMzU2ODM2Y2I1MjQ1YjgxZjc4YWFhYzIuLmFh OTE0OTJhYTI1MzUzNzkwMzEzYWYxYTg3ZTFlNjIwNzhkZjU3NjIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC02ODA3LDYgKzY4MDcsMTYgQEAg RWxlbWVudCogV2ViUGFnZTo6ZWxlbWVudEZvclRleHRJbnB1dENvbnRleHQoY29uc3QgVGV4dElu cHV0Q29udGV4dCYgdGV4dElucHV0Q28KICAgICByZXR1cm4gZG9jdW1lbnQtPnNlYXJjaEZvckVs ZW1lbnRCeUlkZW50aWZpZXIodGV4dElucHV0Q29udGV4dC5lbGVtZW50SWRlbnRpZmllcik7CiB9 CiAKK1BBTDo6U2Vzc2lvbklEIFdlYlBhZ2U6OnNlc3Npb25JRCgpIGNvbnN0Cit7CisgICAgcmV0 dXJuIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnNlc3Npb25JRCgpOworfQorCitib29sIFdlYlBh Z2U6OnVzZXNFcGhlbWVyYWxTZXNzaW9uKCkgY29uc3QKK3sKKyAgICByZXR1cm4gc2Vzc2lvbklE KCkuaXNFcGhlbWVyYWwoKTsKK30KKwogdm9pZCBXZWJQYWdlOjpjb25maWd1cmVMb2dnaW5nQ2hh bm5lbChjb25zdCBTdHJpbmcmIGNoYW5uZWxOYW1lLCBXVEZMb2dDaGFubmVsU3RhdGUgc3RhdGUs IFdURkxvZ0xldmVsIGxldmVsKQogewogICAgIHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6 Q29uZmlndXJlTG9nZ2luZ0NoYW5uZWwoY2hhbm5lbE5hbWUsIHN0YXRlLCBsZXZlbCkpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCmluZGV4IGE0ZTJmZWUwN2Y0 N2UyMjExZDEyNDM0MGMxODU4M2NjZGE0ZDUxMGIuLjczN2YzMTlkNDM4ZjQ1MmExODkxYjkyYjcx Nzk2YWI4ZTZhZjVmMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmgKQEAgLTI5Myw4ICsyOTMsOCBAQCBwdWJsaWM6CiAgICAgV2ViQ29yZTo6UGFnZSogY29y ZVBhZ2UoKSBjb25zdCB7IHJldHVybiBtX3BhZ2UuZ2V0KCk7IH0KICAgICBXZWJDb3JlOjpQYWdl SWRlbnRpZmllciBpZGVudGlmaWVyKCkgY29uc3QgeyByZXR1cm4gbV9pZGVudGlmaWVyOyB9CiAg ICAgU3RvcmFnZU5hbWVzcGFjZUlkZW50aWZpZXIgc2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2VJZGVu dGlmaWVyKCkgY29uc3QgeyByZXR1cm4gbWFrZU9iamVjdElkZW50aWZpZXI8U3RvcmFnZU5hbWVz cGFjZUlkZW50aWZpZXJUeXBlPihtX3dlYlBhZ2VQcm94eUlkZW50aWZpZXIudG9VSW50NjQoKSk7 IH0KLSAgICBQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQoKSBjb25zdCB7IHJldHVybiBtX3BhZ2Ut PnNlc3Npb25JRCgpOyB9Ci0gICAgYm9vbCB1c2VzRXBoZW1lcmFsU2Vzc2lvbigpIGNvbnN0IHsg cmV0dXJuIG1fcGFnZS0+dXNlc0VwaGVtZXJhbFNlc3Npb24oKTsgfQorICAgIFBBTDo6U2Vzc2lv bklEIHNlc3Npb25JRCgpIGNvbnN0OworICAgIGJvb2wgdXNlc0VwaGVtZXJhbFNlc3Npb24oKSBj b25zdDsKIAogICAgIHZvaWQgc2V0U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJik7CiAgICAg Y29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgc2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fdmlld1NpemU7 IH0K