202082 2019-09-21 18:26:52 -0700 Move JSLexicalEnvironment, DirectArguments, and ScopedArguments cells out of the Gigacage. 2019-09-21 21:02:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 202085 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1573114 0 mark.lam 2019-09-21 18:26:52 -0700 They aren't being caged. 1573115 1 379330 mark.lam 2019-09-21 18:47:00 -0700 Created attachment 379330 proposed patch. 1573128 2 379330 mark.lam 2019-09-21 19:53:14 -0700 Comment on attachment 379330 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=379330&action=review > Source/JavaScriptCore/runtime/VM.cpp:272 > + , variableSizedCellSpace("Variable Sized JSCell", heap, cellHeapCellType.get(), fastMallocAllocator.get()) // Hash:0x2f5b102b I will also update the hash value in the comment before landing because it is computed based on the subspace name. It is now 0xbcd769cc. 1573136 3 mark.lam 2019-09-21 21:01:56 -0700 Thanks for the review. Landed in r250189: <http://trac.webkit.org/r250189>. 1573137 4 webkit-bug-importer 2019-09-21 21:02:18 -0700 <rdar://problem/55596065> 379330 2019-09-21 18:47:00 -0700 2019-09-21 19:59:17 -0700 proposed patch. bug-202082.patch text/plain 5397 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUwMTg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE5LTA5LTIxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBN b3ZlIEpTTGV4aWNhbEVudmlyb25tZW50LCBEaXJlY3RBcmd1bWVudHMsIGFuZCBTY29wZWRBcmd1 bWVudHMgY2VsbHMgb3V0IG9mIHRoZSBHaWdhY2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjA4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXkgYXJlIG5vdCBiZWluZyBjYWdlZCBhbnl3YXku CisKKyAgICAgICAgKiBydW50aW1lL0RpcmVjdEFyZ3VtZW50cy5oOgorICAgICAgICAqIHJ1bnRp bWUvSlNMZXhpY2FsRW52aXJvbm1lbnQuaDoKKyAgICAgICAgKEpTQzo6SlNMZXhpY2FsRW52aXJv bm1lbnQ6OnN1YnNwYWNlRm9yKToKKyAgICAgICAgKiBydW50aW1lL1Njb3BlZEFyZ3VtZW50cy5o OgorICAgICAgICAqIHJ1bnRpbWUvVk0uY3BwOgorICAgICAgICAoSlNDOjpWTTo6Vk0pOgorICAg ICAgICAqIHJ1bnRpbWUvVk0uaDoKKwogMjAxOS0wOS0yMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdh bGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBBY2Nlc3NDYXNlIHNob3VsZCBzdHJvbmdseSB2aXNp dCBpdHMgZGVwZW5kZW5jaWVzIHdoaWxlIG9uIHN0YWNrCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9EaXJlY3RBcmd1bWVudHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9EaXJlY3RBcmd1bWVudHMuaAkocmV2aXNpb24gMjUwMTg3KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGlyZWN0QXJndW1lbnRzLmgJKHdvcmtp bmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE1LTIwMTgg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE1LTIw MTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9u IGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICog bW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBj b25kaXRpb25zCkBAIC01MCw3ICs1MCw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgQ29tcGxldGVT dWJzcGFjZSogc3Vic3BhY2VGb3IoVk0mIHZtKQogICAgIHsKICAgICAgICAgc3RhdGljX2Fzc2Vy dCghQ2VsbFR5cGU6Om5lZWRzRGVzdHJ1Y3Rpb24sICIiKTsKLSAgICAgICAgcmV0dXJuICZ2bS5q c1ZhbHVlR2lnYWNhZ2VDZWxsU3BhY2U7CisgICAgICAgIHJldHVybiAmdm0udmFyaWFibGVTaXpl ZENlbGxTcGFjZTsKICAgICB9CiAKICAgICAvLyBDcmVhdGVzIGFuIGFyZ3VtZW50cyBvYmplY3Qg YnV0IGxlYXZlcyBpdCB1bmluaXRpYWxpemVkLiBUaGlzIGlzIGRhbmdlcm91cyBpZiB3ZSBHQyBy aWdodApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNMZXhpY2FsRW52aXJv bm1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0xl eGljYWxFbnZpcm9ubWVudC5oCShyZXZpc2lvbiAyNTAxODcpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU0xleGljYWxFbnZpcm9ubWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00 NCw3ICs0NCw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgQ29tcGxldGVTdWJzcGFjZSogc3Vic3Bh Y2VGb3IoVk0mIHZtKQogICAgIHsKICAgICAgICAgc3RhdGljX2Fzc2VydCghQ2VsbFR5cGU6Om5l ZWRzRGVzdHJ1Y3Rpb24sICIiKTsKLSAgICAgICAgcmV0dXJuICZ2bS5qc1ZhbHVlR2lnYWNhZ2VD ZWxsU3BhY2U7CisgICAgICAgIHJldHVybiAmdm0udmFyaWFibGVTaXplZENlbGxTcGFjZTsKICAg ICB9CiAKICAgICB1c2luZyBCYXNlID0gSlNTeW1ib2xUYWJsZU9iamVjdDsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Njb3BlZEFyZ3VtZW50cy5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Njb3BlZEFyZ3VtZW50cy5oCShyZXZpc2lv biAyNTAxODcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TY29wZWRBcmd1bWVu dHMuaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNyArNDcsNyBAQCBwdWJsaWM6CiAgICAgc3RhdGlj IENvbXBsZXRlU3Vic3BhY2UqIHN1YnNwYWNlRm9yKFZNJiB2bSkKICAgICB7CiAgICAgICAgIHN0 YXRpY19hc3NlcnQoIUNlbGxUeXBlOjpuZWVkc0Rlc3RydWN0aW9uLCAiIik7Ci0gICAgICAgIHJl dHVybiAmdm0uanNWYWx1ZUdpZ2FjYWdlQ2VsbFNwYWNlOworICAgICAgICByZXR1cm4gJnZtLnZh cmlhYmxlU2l6ZWRDZWxsU3BhY2U7CiAgICAgfQogCiAgICAgLy8gQ3JlYXRlcyBhbiBhcmd1bWVu dHMgb2JqZWN0IGJ1dCBsZWF2ZXMgaXQgdW5pbml0aWFsaXplZC4gVGhpcyBpcyBkYW5nZXJvdXMg aWYgd2UgR0MgcmlnaHQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAJKHJl dmlzaW9uIDI1MDE4NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjY5LDcgKzI2OSw3IEBAIFZNOjpWTShWTVR5cGUgdm1UeXBlLCBI ZWFwVHlwZSBoZWFwVHlwZSkKICAgICAsIGpzVmFsdWVHaWdhY2FnZUF1eGlsaWFyeVNwYWNlKCJK U1ZhbHVlIEdpZ2FjYWdlIEF1eGlsaWFyeSIsIGhlYXAsIGF1eGlsaWFyeUhlYXBDZWxsVHlwZS5n ZXQoKSwganNWYWx1ZUdpZ2FjYWdlQWxsb2NhdG9yLmdldCgpKSAvLyBIYXNoOjB4MjQxZTk0Ngog ICAgICwgaW1tdXRhYmxlQnV0dGVyZmx5SlNWYWx1ZUdpZ2FjYWdlQXV4aWxpYXJ5U3BhY2UoIklt bXV0YWJsZUJ1dHRlcmZseSBHaWdhY2FnZSBKU0NlbGxXaXRoSW50ZXJpb3JQb2ludGVycyIsIGhl YXAsIGltbXV0YWJsZUJ1dHRlcmZseUhlYXBDZWxsVHlwZS5nZXQoKSwganNWYWx1ZUdpZ2FjYWdl QWxsb2NhdG9yLmdldCgpKSAvLyBIYXNoOjB4N2E5NDUzMDAKICAgICAsIGNlbGxTcGFjZSgiSlND ZWxsIiwgaGVhcCwgY2VsbEhlYXBDZWxsVHlwZS5nZXQoKSwgZmFzdE1hbGxvY0FsbG9jYXRvci5n ZXQoKSkgLy8gSGFzaDoweGFkZmI1YTc5Ci0gICAgLCBqc1ZhbHVlR2lnYWNhZ2VDZWxsU3BhY2Uo IkpTVmFsdWUgR2lnYWNhZ2UgSlNDZWxsIiwgaGVhcCwgY2VsbEhlYXBDZWxsVHlwZS5nZXQoKSwg anNWYWx1ZUdpZ2FjYWdlQWxsb2NhdG9yLmdldCgpKSAvLyBIYXNoOjB4MmY1YjEwMmIKKyAgICAs IHZhcmlhYmxlU2l6ZWRDZWxsU3BhY2UoIlZhcmlhYmxlIFNpemVkIEpTQ2VsbCIsIGhlYXAsIGNl bGxIZWFwQ2VsbFR5cGUuZ2V0KCksIGZhc3RNYWxsb2NBbGxvY2F0b3IuZ2V0KCkpIC8vIEhhc2g6 MHgyZjViMTAyYgogICAgICwgZGVzdHJ1Y3RpYmxlQ2VsbFNwYWNlKCJEZXN0cnVjdGlibGUgSlND ZWxsIiwgaGVhcCwgZGVzdHJ1Y3RpYmxlQ2VsbEhlYXBDZWxsVHlwZS5nZXQoKSwgZmFzdE1hbGxv Y0FsbG9jYXRvci5nZXQoKSkgLy8gSGFzaDoweGJmZmYzZDczCiAgICAgLCBzdHJpbmdTcGFjZSgi SlNTdHJpbmciLCBoZWFwLCBzdHJpbmdIZWFwQ2VsbFR5cGUuZ2V0KCksIGZhc3RNYWxsb2NBbGxv Y2F0b3IuZ2V0KCkpIC8vIEhhc2g6MHg5MGNmNzU4ZgogICAgICwgZGVzdHJ1Y3RpYmxlT2JqZWN0 U3BhY2UoIkpTRGVzdHJ1Y3RpYmxlT2JqZWN0IiwgaGVhcCwgZGVzdHJ1Y3RpYmxlT2JqZWN0SGVh cENlbGxUeXBlLmdldCgpLCBmYXN0TWFsbG9jQWxsb2NhdG9yLmdldCgpKSAvLyBIYXNoOjB4NGY1 ZWQ3YTkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uaAkocmV2aXNpb24gMjUwMTg3 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uaAkod29ya2luZyBjb3B5KQpA QCAtMzY2LDcgKzM2Niw3IEBAIHB1YmxpYzoKICAgICAKICAgICAvLyBXaGVuZXZlciBwb3NzaWJs ZSwgdXNlIHN1YnNwYWNlRm9yPENlbGxUeXBlPih2bSkgdG8gZ2V0IG9uZSBvZiB0aGVzZSBzdWJz cGFjZXMuCiAgICAgQ29tcGxldGVTdWJzcGFjZSBjZWxsU3BhY2U7Ci0gICAgQ29tcGxldGVTdWJz cGFjZSBqc1ZhbHVlR2lnYWNhZ2VDZWxsU3BhY2U7IC8vIEZJWE1FOiBUaGlzIHNwYWNlIGlzIHBy b2JsZW1hdGljIGJlY2F1c2Ugd2UgaGF2ZSB0aGluZ3MgaW4gaGVyZSBsaWtlIERpcmVjdEFyZ3Vt ZW50cyBhbmQgU2NvcGVkQXJndW1lbnRzOyB0aG9zZSBzaG91bGQgYmUgc3BsaXQgaW50byBKU1Zh bHVlT09CIGNlbGxzIGFuZCBKU1ZhbHVlU3RyaWN0IGF1eGlsaWFyaWVzLiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyODU4CisgICAgQ29tcGxldGVTdWJzcGFjZSB2 YXJpYWJsZVNpemVkQ2VsbFNwYWNlOyAvLyBGSVhNRTogVGhpcyBzcGFjZSBpcyBwcm9ibGVtYXRp YyBiZWNhdXNlIHdlIGhhdmUgdGhpbmdzIGluIGhlcmUgbGlrZSBEaXJlY3RBcmd1bWVudHMgYW5k IFNjb3BlZEFyZ3VtZW50czsgdGhvc2Ugc2hvdWxkIGJlIHNwbGl0IGludG8gSlNWYWx1ZU9PQiBj ZWxscyBhbmQgSlNWYWx1ZVN0cmljdCBhdXhpbGlhcmllcy4gaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4Mjg1OAogICAgIENvbXBsZXRlU3Vic3BhY2UgZGVzdHJ1Y3Rp YmxlQ2VsbFNwYWNlOwogICAgIENvbXBsZXRlU3Vic3BhY2Ugc3RyaW5nU3BhY2U7CiAgICAgQ29t cGxldGVTdWJzcGFjZSBkZXN0cnVjdGlibGVPYmplY3RTcGFjZTsK