202070 2019-09-20 19:41:14 -0700 Regression(iOS 13) web views do not deal properly with their window's UIScene changing 2019-09-21 16:13:55 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue ggaren simon.fraser thorton webkit-bug-importer oldest_to_newest 1573026 0 cdumez 2019-09-20 19:41:14 -0700 Web views do not deal properly with their window's UIScene changing. If a Safari window is in the background for 1 minute, its UIScene will be detached and the window will get a new UIScene if the user later switches to this window. Our web views listen to UIScene notifications to determine their visibility and currently stop receiving visibility updates once the window’s UIScene has changed. This causes view freezes because our WebContent process does not know its view is visible and keeps its layer tree frozen. 1573027 1 cdumez 2019-09-20 19:41:31 -0700 <rdar://problem/55580699> 1573030 2 379304 cdumez 2019-09-20 19:46:03 -0700 Created attachment 379304 Patch 1573100 3 379304 commit-queue 2019-09-21 16:13:53 -0700 Comment on attachment 379304 Patch Clearing flags on attachment: 379304 Committed r250187: <https://trac.webkit.org/changeset/250187> 1573101 4 commit-queue 2019-09-21 16:13:55 -0700 All reviewed patches have been landed. Closing bug. 379304 2019-09-20 19:46:03 -0700 2019-09-21 16:13:53 -0700 Patch bug-202070-20190920194601.patch text/plain 4640 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVhMTZkZTI3ZTJjYTI4ZmRm MDFhN2Q2ZDQ4MTU5YjhhNDUzMjc5NjkuLmI0NzA5M2QxZjIwYzQ0NzNlNTg3ZDdlZTYxMTkwNTg2 NTQ5NDJjZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTktMDktMjAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKGlPUyAxMykgd2Vi IHZpZXdzIGRvIG5vdCBkZWFsIHByb3Blcmx5IHdpdGggdGhlaXIgd2luZG93J3MgVUlTY2VuZSBj aGFuZ2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAyMDcwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTU4MDY5OT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgdmlld3MgZG8gbm90IGRlYWwg cHJvcGVybHkgd2l0aCB0aGVpciB3aW5kb3cncyBVSVNjZW5lIGNoYW5naW5nLiBJZiBhIFNhZmFy aSB3aW5kb3cgaXMgaW4gdGhlCisgICAgICAgIGJhY2tncm91bmQgZm9yIDEgbWludXRlLCBpdHMg VUlTY2VuZSB3aWxsIGJlIGRldGFjaGVkIGFuZCB0aGUgd2luZG93IHdpbGwgZ2V0IGEgbmV3IFVJ U2NlbmUgaWYKKyAgICAgICAgdGhlIHVzZXIgbGF0ZXIgc3dpdGNoZXMgdG8gdGhpcyB3aW5kb3cu IE91ciB3ZWIgdmlld3MgbGlzdGVuIHRvIFVJU2NlbmUgbm90aWZpY2F0aW9ucyB0byBkZXRlcm1p bmUKKyAgICAgICAgdGhlaXIgdmlzaWJpbGl0eSBhbmQgY3VycmVudGx5IHN0b3AgcmVjZWl2aW5n IHZpc2liaWxpdHkgdXBkYXRlcyBvbmNlIHRoZSB3aW5kb3figJlzIFVJU2NlbmUgaGFzCisgICAg ICAgIGNoYW5nZWQuIFRoaXMgY2F1c2VzIHZpZXcgZnJlZXplcyBiZWNhdXNlIG91ciBXZWJDb250 ZW50IHByb2Nlc3MgZG9lcyBub3Qga25vdyBpdHMgdmlldyBpcyB2aXNpYmxlCisgICAgICAgIGFu ZCBrZWVwcyBpdHMgbGF5ZXIgdHJlZSBmcm96ZW4uCisKKyAgICAgICAgUHJldmlvdXNseSwgd2hl biBvdXIgdmlldyB3b3VsZCBiZSBhZGRlZCB0byBhIHdpbmRvdywgd2Ugd291bGQgZ2V0IHRoaXMg d2luZG93J3MgVUlTY2VuZSBhbmQgbGlzdGVuCisgICAgICAgIGZvciBVSVNjZW5lRGlkRW50ZXJC YWNrZ3JvdW5kTm90aWZpY2F0aW9uIC8gVUlTY2VuZVdpbGxFbnRlckZvcmVncm91bmROb3RpZmlj YXRpb24gZm9yIHRoaXMgVUlTY2VuZQorICAgICAgICBvYmplY3QuIEluc3RlYWQsIHdlIG5vdyBs aXN0ZW4gdG8gdGhlc2Ugbm90aWZpY2F0aW9ucyBmb3IgQUxMIHRoZSBhcHBsaWNhdGlvbidzIFVJ U2NlbmVzLiBPdXIgaGFuZGxlcgorICAgICAgICB0aGVuIGNoZWNrcyBpZiB0aGUgbm90aWZpY2F0 aW9uJ3MgVUlTY2VuZSBvYmplY3QgbWF0Y2hlcyB0aGUgY3VycmVudCB3aW5kb3cncyBVSVNjZW5l IGJlZm9yZQorICAgICAgICBmb3J3YXJkaW5nIHRoZSBub3RpZmljYXRpb24gdG8gdGhlIHJlc3Qg b2YgV2ViS2l0LgorCisgICAgICAgICogVUlQcm9jZXNzL0FwcGxpY2F0aW9uU3RhdGVUcmFja2Vy Lm1tOgorICAgICAgICAoV2ViS2l0OjpBcHBsaWNhdGlvblN0YXRlVHJhY2tlcjo6QXBwbGljYXRp b25TdGF0ZVRyYWNrZXIpOgorICAgICAgICAoV2ViS2l0OjpBcHBsaWNhdGlvblN0YXRlVHJhY2tl cjo6fkFwcGxpY2F0aW9uU3RhdGVUcmFja2VyKToKKwogMjAxOS0wOS0yMCAgS2VpdGggUm9sbGlu ICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgc3VwcG9ydCBmb3Ig PCBpT1MgMTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FwcGxpY2F0aW9u U3RhdGVUcmFja2VyLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXBwbGljYXRpb25TdGF0 ZVRyYWNrZXIubW0KaW5kZXggNGE1MTEwOGJhNTlmMzI5YjczNTk2YWIxN2E2MDQyNTNlNDRhN2Rh Ny4uZDU3MjU3N2ExMjU0YWY2YWFjYTYxODZiNmY1NTdjM2I3ZmQ3ZTRkOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXBwbGljYXRpb25TdGF0ZVRyYWNrZXIubW0KKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXBwbGljYXRpb25TdGF0ZVRyYWNrZXIubW0KQEAgLTEw OCwxNCArMTA4LDE4IEBAIEFwcGxpY2F0aW9uU3RhdGVUcmFja2VyOjpBcHBsaWNhdGlvblN0YXRl VHJhY2tlcihVSVZpZXcgKnZpZXcsIFNFTCBkaWRFbnRlckJhY2tnCiAgICAgICAgIG1faXNJbkJh Y2tncm91bmQgPSB3aW5kb3cud2luZG93U2NlbmUuYWN0aXZhdGlvblN0YXRlID09IFVJU2NlbmVB Y3RpdmF0aW9uU3RhdGVCYWNrZ3JvdW5kIHx8IHdpbmRvdy53aW5kb3dTY2VuZS5hY3RpdmF0aW9u U3RhdGUgPT0gVUlTY2VuZUFjdGl2YXRpb25TdGF0ZVVuYXR0YWNoZWQ7CiAgICAgICAgIFJFTEVB U0VfTE9HKFZpZXdTdGF0ZSwgIiVwIC0gQXBwbGljYXRpb25TdGF0ZVRyYWNrZXI6OkFwcGxpY2F0 aW9uU3RhdGVUcmFja2VyKCk6IG1faXNJbkJhY2tncm91bmQ6ICVkIiwgdGhpcywgbV9pc0luQmFj a2dyb3VuZCk7CiAKLSAgICAgICAgbV9kaWRFbnRlckJhY2tncm91bmRPYnNlcnZlciA9IFtub3Rp ZmljYXRpb25DZW50ZXIgYWRkT2JzZXJ2ZXJGb3JOYW1lOlVJU2NlbmVEaWRFbnRlckJhY2tncm91 bmROb3RpZmljYXRpb24gb2JqZWN0OndpbmRvdy53aW5kb3dTY2VuZSBxdWV1ZTpuaWwgdXNpbmdC bG9jazpbdGhpc10oTlNOb3RpZmljYXRpb24gKikgewotICAgICAgICAgICAgUkVMRUFTRV9MT0co Vmlld1N0YXRlLCAiJXAgLSBBcHBsaWNhdGlvblN0YXRlVHJhY2tlcjogVUlTY2VuZURpZEVudGVy QmFja2dyb3VuZCIsIHRoaXMpOwotICAgICAgICAgICAgYXBwbGljYXRpb25EaWRFbnRlckJhY2tn cm91bmQoKTsKKyAgICAgICAgbV9kaWRFbnRlckJhY2tncm91bmRPYnNlcnZlciA9IFtub3RpZmlj YXRpb25DZW50ZXIgYWRkT2JzZXJ2ZXJGb3JOYW1lOlVJU2NlbmVEaWRFbnRlckJhY2tncm91bmRO b3RpZmljYXRpb24gb2JqZWN0Om5pbCBxdWV1ZTpuaWwgdXNpbmdCbG9jazpbdGhpc10oTlNOb3Rp ZmljYXRpb24gKm5vdGlmaWNhdGlvbikgeworICAgICAgICAgICAgaWYgKG5vdGlmaWNhdGlvbi5v YmplY3QgPT0gW1ttX3ZpZXcgd2luZG93XSB3aW5kb3dTY2VuZV0pIHsKKyAgICAgICAgICAgICAg ICBSRUxFQVNFX0xPRyhWaWV3U3RhdGUsICIlcCAtIEFwcGxpY2F0aW9uU3RhdGVUcmFja2VyOiBV SVNjZW5lRGlkRW50ZXJCYWNrZ3JvdW5kIiwgdGhpcyk7CisgICAgICAgICAgICAgICAgYXBwbGlj YXRpb25EaWRFbnRlckJhY2tncm91bmQoKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfV07CiAK LSAgICAgICAgbV93aWxsRW50ZXJGb3JlZ3JvdW5kT2JzZXJ2ZXIgPSBbbm90aWZpY2F0aW9uQ2Vu dGVyIGFkZE9ic2VydmVyRm9yTmFtZTpVSVNjZW5lV2lsbEVudGVyRm9yZWdyb3VuZE5vdGlmaWNh dGlvbiBvYmplY3Q6d2luZG93LndpbmRvd1NjZW5lIHF1ZXVlOm5pbCB1c2luZ0Jsb2NrOlt0aGlz XShOU05vdGlmaWNhdGlvbiAqKSB7Ci0gICAgICAgICAgICBSRUxFQVNFX0xPRyhWaWV3U3RhdGUs ICIlcCAtIEFwcGxpY2F0aW9uU3RhdGVUcmFja2VyOiBVSVNjZW5lV2lsbEVudGVyRm9yZWdyb3Vu ZCIsIHRoaXMpOwotICAgICAgICAgICAgYXBwbGljYXRpb25XaWxsRW50ZXJGb3JlZ3JvdW5kKCk7 CisgICAgICAgIG1fd2lsbEVudGVyRm9yZWdyb3VuZE9ic2VydmVyID0gW25vdGlmaWNhdGlvbkNl bnRlciBhZGRPYnNlcnZlckZvck5hbWU6VUlTY2VuZVdpbGxFbnRlckZvcmVncm91bmROb3RpZmlj YXRpb24gb2JqZWN0Om5pbCBxdWV1ZTpuaWwgdXNpbmdCbG9jazpbdGhpc10oTlNOb3RpZmljYXRp b24gKm5vdGlmaWNhdGlvbikgeworICAgICAgICAgICAgaWYgKG5vdGlmaWNhdGlvbi5vYmplY3Qg PT0gW1ttX3ZpZXcgd2luZG93XSB3aW5kb3dTY2VuZV0pIHsKKyAgICAgICAgICAgICAgICBSRUxF QVNFX0xPRyhWaWV3U3RhdGUsICIlcCAtIEFwcGxpY2F0aW9uU3RhdGVUcmFja2VyOiBVSVNjZW5l V2lsbEVudGVyRm9yZWdyb3VuZCIsIHRoaXMpOworICAgICAgICAgICAgICAgIGFwcGxpY2F0aW9u V2lsbEVudGVyRm9yZWdyb3VuZCgpOworICAgICAgICAgICAgfQogICAgICAgICB9XTsKICNlbHNl CiAgICAgICAgIG1faXNJbkJhY2tncm91bmQgPSBhcHBsaWNhdGlvbi5hcHBsaWNhdGlvblN0YXRl ID09IFVJQXBwbGljYXRpb25TdGF0ZUJhY2tncm91bmQ7CkBAIC0xODAsNiArMTg0LDcgQEAgQXBw bGljYXRpb25TdGF0ZVRyYWNrZXI6OkFwcGxpY2F0aW9uU3RhdGVUcmFja2VyKFVJVmlldyAqdmll dywgU0VMIGRpZEVudGVyQmFja2cKIAogQXBwbGljYXRpb25TdGF0ZVRyYWNrZXI6On5BcHBsaWNh dGlvblN0YXRlVHJhY2tlcigpCiB7CisgICAgUkVMRUFTRV9MT0coVmlld1N0YXRlLCAiJXAgLSB+ QXBwbGljYXRpb25TdGF0ZVRyYWNrZXIiLCB0aGlzKTsKICAgICBpZiAobV9hcHBsaWNhdGlvblN0 YXRlTW9uaXRvcikgewogICAgICAgICBbbV9hcHBsaWNhdGlvblN0YXRlTW9uaXRvciBpbnZhbGlk YXRlXTsKICAgICAgICAgcmV0dXJuOwo=