<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>202068</bug_id>
          
          <creation_ts>2019-09-20 18:14:28 -0700</creation_ts>
          <short_desc>[LFC] LayoutContext::m_formattingContextRootListForLayout should be a WeakHashSet</short_desc>
          <delta_ts>2019-09-21 06:51:25 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="alan">zalan</reporter>
          <assigned_to name="alan">zalan</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>koivisto</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1573004</commentid>
    <comment_count>0</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2019-09-20 18:14:28 -0700</bug_when>
    <thetext>and not a HashSet</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1573005</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-09-20 18:14:58 -0700</bug_when>
    <thetext>&lt;rdar://problem/55579352&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1573007</commentid>
    <comment_count>2</comment_count>
      <attachid>379299</attachid>
    <who name="alan">zalan</who>
    <bug_when>2019-09-20 18:21:59 -0700</bug_when>
    <thetext>Created attachment 379299
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1573069</commentid>
    <comment_count>3</comment_count>
      <attachid>379299</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-21 06:51:24 -0700</bug_when>
    <thetext>Comment on attachment 379299
Patch

Clearing flags on attachment: 379299

Committed r250181: &lt;https://trac.webkit.org/changeset/250181&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1573070</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-21 06:51:25 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>379299</attachid>
            <date>2019-09-20 18:21:59 -0700</date>
            <delta_ts>2019-09-21 06:51:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-202068-20190920182152.patch</filename>
            <type>text/plain</type>
            <size>3520</size>
            <attacher name="alan">zalan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjBkMTc0ZDBlMmYyNjRh
NjViM2RmNGI1M2M1NmUwNGZjY2M2OWViYy4uNjE0NjBiMThhODhmZGM4NmM4YjM4YzRiODE4ZGFh
M2M0YTQ1NTNlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA5LTIwICBaYWxh
biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gTGF5b3V0Q29udGV4
dDo6bV9mb3JtYXR0aW5nQ29udGV4dFJvb3RMaXN0Rm9yTGF5b3V0IHNob3VsZCBiZSBhIFdlYWtI
YXNoU2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y
MDIwNjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1NTc5MzUyPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbGF5b3V0L0xheW91dENvbnRleHQu
Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMYXlvdXRDb250ZXh0OjpsYXlvdXQpOgor
ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMYXlvdXRDb250ZXh0OjpzdHlsZUNoYW5nZWQpOgor
ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMYXlvdXRDb250ZXh0OjptYXJrTmVlZHNVcGRhdGUp
OgorICAgICAgICAqIGxheW91dC9MYXlvdXRDb250ZXh0Lmg6CisgICAgICAgICogcGFnZS9GcmFt
ZVZpZXdMYXlvdXRDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmxheW91dFVzaW5nRm9y
bWF0dGluZ0NvbnRleHQpOgorCiAyMDE5LTA5LTIwICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs
ZS5jb20+CiAKICAgICAgICAgW0xGQ10gSW50cm9kdWNlIExheW91dENvbnRleHQgY2xhc3MKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRDb250ZXh0LmNwcCBiL1NvdXJj
ZS9XZWJDb3JlL2xheW91dC9MYXlvdXRDb250ZXh0LmNwcAppbmRleCAzNTQ5ZDA5MTE3OTg4Mzk0
YzgyMDgyMzQyMzAyNmVkZTJiZjgwYWRhLi4wOGU4ZWQwMWIzOTNiZTAzZGNlODM4N2Q1OTYzMmFl
OGY3YTFjNmUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0Q29udGV4
dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0xheW91dENvbnRleHQuY3BwCkBAIC01
OSw5ICs1OSw5IEBAIHZvaWQgTGF5b3V0Q29udGV4dDo6bGF5b3V0KCkKIHsKICAgICBQaGFzZVNj
b3BlIHNjb3BlKFBoYXNlOjpUeXBlOjpMYXlvdXQpOwogCi0gICAgQVNTRVJUKCFtX2Zvcm1hdHRp
bmdDb250ZXh0Um9vdExpc3RGb3JMYXlvdXQuaXNFbXB0eSgpKTsKLSAgICBmb3IgKGF1dG8qIGxh
eW91dFJvb3QgOiBtX2Zvcm1hdHRpbmdDb250ZXh0Um9vdExpc3RGb3JMYXlvdXQpCi0gICAgICAg
IGxheW91dEZvcm1hdHRpbmdDb250ZXh0U3VidHJlZSgqbGF5b3V0Um9vdCk7CisgICAgQVNTRVJU
KCFtX2Zvcm1hdHRpbmdDb250ZXh0Um9vdExpc3RGb3JMYXlvdXQuY29tcHV0ZXNFbXB0eSgpKTsK
KyAgICBmb3IgKGF1dG8mIGxheW91dFJvb3QgOiBtX2Zvcm1hdHRpbmdDb250ZXh0Um9vdExpc3RG
b3JMYXlvdXQpCisgICAgICAgIGxheW91dEZvcm1hdHRpbmdDb250ZXh0U3VidHJlZShsYXlvdXRS
b290KTsKICAgICBtX2Zvcm1hdHRpbmdDb250ZXh0Um9vdExpc3RGb3JMYXlvdXQuY2xlYXIoKTsK
IH0KIApAQCAtODYsMTMgKzg2LDEzIEBAIHZvaWQgTGF5b3V0Q29udGV4dDo6c3R5bGVDaGFuZ2Vk
KGNvbnN0IEJveCYgbGF5b3V0Qm94LCBTdHlsZURpZmYgc3R5bGVEaWZmKQogICAgIGVsc2UKICAg
ICAgICAgQVNTRVJUX05PVF9JTVBMRU1FTlRFRF9ZRVQoKTsKICAgICBBU1NFUlQoaW52YWxpZGF0
aW9uUm9vdCk7Ci0gICAgbV9mb3JtYXR0aW5nQ29udGV4dFJvb3RMaXN0Rm9yTGF5b3V0LmFkZFZv
aWQoaW52YWxpZGF0aW9uUm9vdCk7CisgICAgbV9mb3JtYXR0aW5nQ29udGV4dFJvb3RMaXN0Rm9y
TGF5b3V0LmFkZChpbnZhbGlkYXRpb25Sb290KTsKIH0KIAogdm9pZCBMYXlvdXRDb250ZXh0Ojpt
YXJrTmVlZHNVcGRhdGUoY29uc3QgQm94JiBsYXlvdXRCb3gsIE9wdGlvblNldDxVcGRhdGVUeXBl
PikKIHsKICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgdHJpZ2dlciBwcm9wZXIgaW52YWxpZGF0
aW9uIGluc3RlYWQgb2YganVzdCBhZGRpbmcgdGhlIGZvcm1hdHRpbmcgY29udGV4dCByb290IHRv
IHRoZSBkaXJ0eSBsaXN0LiAKLSAgICBtX2Zvcm1hdHRpbmdDb250ZXh0Um9vdExpc3RGb3JMYXlv
dXQuYWRkVm9pZCgmKGxheW91dEJveC5pc0luaXRpYWxDb250YWluaW5nQmxvY2soKSA/IGRvd25j
YXN0PENvbnRhaW5lcj4obGF5b3V0Qm94KSA6IGxheW91dEJveC5mb3JtYXR0aW5nQ29udGV4dFJv
b3QoKSkpOworICAgIG1fZm9ybWF0dGluZ0NvbnRleHRSb290TGlzdEZvckxheW91dC5hZGQoJihs
YXlvdXRCb3guaXNJbml0aWFsQ29udGFpbmluZ0Jsb2NrKCkgPyBkb3duY2FzdDxDb250YWluZXI+
KGxheW91dEJveCkgOiBsYXlvdXRCb3guZm9ybWF0dGluZ0NvbnRleHRSb290KCkpKTsKIH0KIAog
c3RkOjp1bmlxdWVfcHRyPEZvcm1hdHRpbmdDb250ZXh0PiBMYXlvdXRDb250ZXh0OjpjcmVhdGVG
b3JtYXR0aW5nQ29udGV4dChjb25zdCBDb250YWluZXImIGZvcm1hdHRpbmdDb250ZXh0Um9vdCwg
TGF5b3V0U3RhdGUmIGxheW91dFN0YXRlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5
b3V0L0xheW91dENvbnRleHQuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRDb250ZXh0
LmgKaW5kZXggODFlZThhNmQ0NDEwMGJhNGQ4MTQ1ZGZhYjg2YTQ0MDZjM2YxZjA5Zi4uYzkxZDZl
YzE2OTY5ZGY1ZWQxZWE1MTZjYjNkZmNlM2UwNjY2YjYzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvbGF5b3V0L0xheW91dENvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv
TGF5b3V0Q29udGV4dC5oCkBAIC0yOSw5ICsyOSw5IEBACiAKICNpbmNsdWRlICJMYXlvdXRDb250
YWluZXIuaCIKICNpbmNsdWRlICJMYXlvdXRTdGF0ZS5oIgotI2luY2x1ZGUgPHd0Zi9IYXNoU2V0
Lmg+CiAjaW5jbHVkZSA8d3RmL0lzb01hbGxvYy5oPgogI2luY2x1ZGUgPHd0Zi9PcHRpb25TZXQu
aD4KKyNpbmNsdWRlIDx3dGYvV2Vha0hhc2hTZXQuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewog
CkBAIC03OSw3ICs3OSw3IEBAIHByaXZhdGU6CiAgICAgTGF5b3V0U3RhdGUmIGxheW91dFN0YXRl
KCkgeyByZXR1cm4gbV9sYXlvdXRTdGF0ZTsgfQogCiAgICAgTGF5b3V0U3RhdGUmIG1fbGF5b3V0
U3RhdGU7Ci0gICAgSGFzaFNldDxjb25zdCBDb250YWluZXIqPiBtX2Zvcm1hdHRpbmdDb250ZXh0
Um9vdExpc3RGb3JMYXlvdXQ7CisgICAgV2Vha0hhc2hTZXQ8Y29uc3QgQ29udGFpbmVyPiBtX2Zv
cm1hdHRpbmdDb250ZXh0Um9vdExpc3RGb3JMYXlvdXQ7CiB9OwogCiB9Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>