202057 2019-09-20 14:30:15 -0700 Web Inspector: REGRESSION: Elements detail sidebar sometimes starts collapsed 2019-09-25 21:19:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned bburg commit-queue hi inspector-bugzilla-changes joepeck nvasilyev webkit-bug-importer oldest_to_newest 1572890 0 joepeck 2019-09-20 14:30:15 -0700 Elements detail sidebar sometimes starts collapsed For some reason when I switch to the Elements tab the sidebar is collapsed quite often. It should absolutely not be collapsed on first show most of the time. I'm of the opinion this probably shouldn't even be collapsable. 1572891 1 webkit-bug-importer 2019-09-20 14:30:37 -0700 <rdar://problem/55572345> 1572918 2 joepeck 2019-09-20 15:16:08 -0700 We can initialize the default value for this specific sidebar to be true, which certainly seems to help! 1572921 3 379275 joepeck 2019-09-20 15:22:25 -0700 Created attachment 379275 [PATCH] Proposed Fix 1572922 4 379275 nvasilyev 2019-09-20 15:25:33 -0700 Comment on attachment 379275 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=379275&action=review > I'm of the opinion this probably shouldn't even be collapsable. I agree!! > Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js:70 > + get detailsSidebarExpandedByDefault() > + { > + return true; > + } Nice! 1573798 5 379275 hi 2019-09-24 13:33:56 -0700 Comment on attachment 379275 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=379275&action=review r=me as is, but I'm also r=me for the below suggestion too :) > Source/WebInspectorUI/UserInterface/Views/TabContentView.js:55 > + this._detailsSidebarCollapsedSetting = new WI.Setting(identifier + "-details-sidebar-collapsed", !this.detailsSidebarExpandedByDefault); Frankly, is there ever a situation where we don't want the sidebar to be expanded by default? I think the default collapsed state should just be `false`. I do think there's value in allowing the sidebar to be collapsed in certain situations (e.g. resource introspection), but I think most of them provide a lot of super useful utility (especially when the Sources tab becomes default) that we may just want to expand them all by default. I'm also 100% on board with not allowing the details sidebar from being collapsed in the Elements Tab, if we wanted to go that "far". 1573847 6 bburg 2019-09-24 14:41:56 -0700 I think a default of not collapsed is best. Still, a user may want to collapse it for narrow widths / split view. 1574340 7 joepeck 2019-09-25 20:33:30 -0700 (In reply to Devin Rousso from comment #5) > Comment on attachment 379275 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=379275&action=review > > r=me as is, but I'm also r=me for the below suggestion too :) > > > Source/WebInspectorUI/UserInterface/Views/TabContentView.js:55 > > + this._detailsSidebarCollapsedSetting = new WI.Setting(identifier + "-details-sidebar-collapsed", !this.detailsSidebarExpandedByDefault); > > Frankly, is there ever a situation where we don't want the sidebar to be > expanded by default? I think the default collapsed state should just be > `false`. Yeah, I think the "Resource" sidebar in the Sources tab would rather not be expanded. The Scope sidebar will auto expand when paused for the first time. > I do think there's value in allowing the sidebar to be collapsed in certain > situations (e.g. resource introspection), but I think most of them provide a > lot of super useful utility (especially when the Sources tab becomes > default) that we may just want to expand them all by default. > > I'm also 100% on board with not allowing the details sidebar from being > collapsed in the Elements Tab, if we wanted to go that "far". I think we do, but not just yet. We should get better in narrow configurations. 1574352 8 379275 commit-queue 2019-09-25 21:19:17 -0700 Comment on attachment 379275 [PATCH] Proposed Fix Clearing flags on attachment: 379275 Committed r250376: <https://trac.webkit.org/changeset/250376> 1574353 9 commit-queue 2019-09-25 21:19:19 -0700 All reviewed patches have been landed. Closing bug. 379275 2019-09-20 15:22:25 -0700 2019-09-25 21:19:17 -0700 [PATCH] Proposed Fix elements-detail-sidebar.patch text/plain 3224 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVlYjZmMDIwMWNhLi41NDA3ODNlYmI1OSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDktMjAgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSRUdSRVNTSU9OOiBFbGVtZW50cyBkZXRhaWwgc2lkZWJhciBzb21ldGltZXMgc3RhcnRzIGNv bGxhcHNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAyMDU3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTU3MjM0NT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv RWxlbWVudHNUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkVsZW1lbnRzVGFiQ29udGVu dFZpZXcucHJvdG90eXBlLmdldCBkZXRhaWxzU2lkZWJhckV4cGFuZGVkQnlEZWZhdWx0KToKKyAg ICAgICAgRGVmYXVsdCB0aGUgRWxlbWVudHMgdGFiIGRldGFpbCBzaWRlYmFyIHRvIGJlIHNob3du LCBub3QgY29sbGFwc2VkLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJDb250 ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLlRhYkNvbnRlbnRWaWV3KToKKyAgICAgICAgKFdJLlRh YkNvbnRlbnRWaWV3LnByb3RvdHlwZS5nZXQgZGV0YWlsc1NpZGViYXJFeHBhbmRlZEJ5RGVmYXVs dCk6CisgICAgICAgIEFsbG93IGNsYXNzZXMgdG8gc3BlY2lmeSB3aGV0aGVyIG9yIG5vdCB0aGVp ciBkZXRhaWwgc2lkZWJhciBzaG91bGQKKyAgICAgICAgYmUgZXhwYW5kZWQgYnkgZGVmYXVsdC4K KwogMjAxOS0wOS0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbW92ZSBCcmFuY2hNYW5hZ2VyIGluIGZhdm9yIG9mIGp1 c3QgdXNpbmcgY3VycmVudFJldmlzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9FbGVtZW50c1RhYkNvbnRlbnRWaWV3LmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRWxlbWVudHNUYWJDb250ZW50Vmll dy5qcwppbmRleCBiOWNmZWYxMjVjNS4uZGQyMTM0YTBiOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0VsZW1lbnRzVGFiQ29udGVudFZpZXcu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRWxlbWVu dHNUYWJDb250ZW50Vmlldy5qcwpAQCAtNjQsNiArNjQsMTEgQEAgV0kuRWxlbWVudHNUYWJDb250 ZW50VmlldyA9IGNsYXNzIEVsZW1lbnRzVGFiQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50 QnJvd3MKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCisgICAgZ2V0IGRldGFpbHNTaWRl YmFyRXhwYW5kZWRCeURlZmF1bHQoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAg fQorCiAgICAgY2FuU2hvd1JlcHJlc2VudGVkT2JqZWN0KHJlcHJlc2VudGVkT2JqZWN0KQogICAg IHsKICAgICAgICAgcmV0dXJuIHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV0kuRE9NVHJl ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RhYkNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGFiQ29udGVudFZpZXcuanMKaW5kZXggOTM3NzQ1MGVlMmMuLmFlOTA2NWY5MjE2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJD b250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UYWJDb250ZW50Vmlldy5qcwpAQCAtNTIsNyArNTIsNyBAQCBXSS5UYWJDb250ZW50Vmll dyA9IGNsYXNzIFRhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICAgICAg dGhpcy5fbmF2aWdhdGlvblNpZGViYXJDb2xsYXBzZWRTZXR0aW5nID0gbmV3IFdJLlNldHRpbmco aWRlbnRpZmllciArICItbmF2aWdhdGlvbi1zaWRlYmFyLWNvbGxhcHNlZCIsIGZhbHNlKTsKICAg ICAgICAgdGhpcy5fbmF2aWdhdGlvblNpZGViYXJXaWR0aFNldHRpbmcgPSBuZXcgV0kuU2V0dGlu ZyhpZGVudGlmaWVyICsgIi1uYXZpZ2F0aW9uLXNpZGViYXItd2lkdGgiLCBkZWZhdWx0U2lkZWJh cldpZHRoKTsKIAotICAgICAgICB0aGlzLl9kZXRhaWxzU2lkZWJhckNvbGxhcHNlZFNldHRpbmcg PSBuZXcgV0kuU2V0dGluZyhpZGVudGlmaWVyICsgIi1kZXRhaWxzLXNpZGViYXItY29sbGFwc2Vk IiwgdHJ1ZSk7CisgICAgICAgIHRoaXMuX2RldGFpbHNTaWRlYmFyQ29sbGFwc2VkU2V0dGluZyA9 IG5ldyBXSS5TZXR0aW5nKGlkZW50aWZpZXIgKyAiLWRldGFpbHMtc2lkZWJhci1jb2xsYXBzZWQi LCAhdGhpcy5kZXRhaWxzU2lkZWJhckV4cGFuZGVkQnlEZWZhdWx0KTsKICAgICAgICAgdGhpcy5f ZGV0YWlsc1NpZGViYXJTZWxlY3RlZFBhbmVsU2V0dGluZyA9IG5ldyBXSS5TZXR0aW5nKGlkZW50 aWZpZXIgKyAiLWRldGFpbHMtc2lkZWJhci1zZWxlY3RlZC1wYW5lbCIsIG51bGwpOwogICAgICAg ICB0aGlzLl9kZXRhaWxzU2lkZWJhcldpZHRoU2V0dGluZyA9IG5ldyBXSS5TZXR0aW5nKGlkZW50 aWZpZXIgKyAiLWRldGFpbHMtc2lkZWJhci13aWR0aCIsIGRlZmF1bHRTaWRlYmFyV2lkdGgpOwog CkBAIC0xMDEsNiArMTAxLDEyIEBAIFdJLlRhYkNvbnRlbnRWaWV3ID0gY2xhc3MgVGFiQ29udGVu dFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAg fQogCisgICAgZ2V0IGRldGFpbHNTaWRlYmFyRXhwYW5kZWRCeURlZmF1bHQoKQorICAgIHsKKyAg ICAgICAgLy8gSW1wbGVtZW50ZWQgYnkgc3ViY2xhc3Nlcy4KKyAgICAgICAgcmV0dXJuIGZhbHNl OworICAgIH0KKwogICAgIHNob3dEZXRhaWxzU2lkZWJhclBhbmVscygpCiAgICAgewogICAgICAg ICAvLyBJbXBsZW1lbnRlZCBieSBzdWJjbGFzc2VzLgo=