20205 2008-07-28 18:51:54 -0700 Typo in comment for bracer ending block 2008-07-30 08:26:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Trivial --- 0 gustavo webkit-unassigned oldest_to_newest 87238 0 gustavo 2008-07-28 18:51:54 -0700 I believe the comment in webkitprivate.h is incorrect. I assure you this is not a way to have a patch of mine committed quickly for its simplicity =). } /** end namespace WebCore */ should be } /** end namespace WebKit */ 87239 1 22532 gustavo 2008-07-28 18:52:36 -0700 Created attachment 22532 typo fix patch to fix the issue 87242 2 22532 sam 2008-07-28 22:16:11 -0700 Comment on attachment 22532 typo fix r=me except you need to remove the tabs in the ChangeLog 87263 3 22536 gustavo 2008-07-29 06:37:32 -0700 Created attachment 22536 tabs corrected So, tabs fixed in the ChangeLog, should be OK to commit. 87264 4 22536 gustavo 2008-07-29 06:38:31 -0700 Comment on attachment 22536 tabs corrected I am adding the + flag, since it was already r=me'd =) 87267 5 22536 sam 2008-07-29 07:28:06 -0700 Comment on attachment 22536 tabs corrected Even though you already go this reviewed, if you post a second patch like this, you should still set the review flag to ?, as setting it to + will be confusing when committing the patch. 87387 6 22536 christian 2008-07-30 08:26:23 -0700 Comment on attachment 22536 tabs corrected Committed in r35447. 22532 2008-07-28 18:52:36 -0700 2008-07-29 06:37:32 -0700 typo fix typofix.diff text/plain 920 gustavo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggODA4MGZmNi4uZDYzOGI0ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOC0wNy0yOCAg R3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCVR5cG8gZml4IGluIGNvbW1lbnQgZm9yIHRoZSBicmFj ZSB0aGF0IGVuZHMgdGhlIFdlYktpdCBuYW1lc3BhY2U7CisJV2ViQ29yZSAtPiBXZWJLaXQKKwkK KyAgICAgICAgKiB3ZWJraXQvd2Via2l0cHJpdmF0ZS5jcHA6CisKIDIwMDgtMDctMjYgIE1hcmsg Um93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguICBDaGFuZ2VzIHRv IGFjY29tbW9kYXRlIG5ld2x5IG5hbWVkL3NpZ25hdHVyZWQgbG9hZGluZyBtZXRob2RzIGluIFdl YkNvcmUuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRwcml2YXRlLmNwcCBi L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuY3BwCmluZGV4IGJlYTFhZDYuLjMxM2Jk NWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuY3BwCisrKyBi L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuY3BwCkBAIC04Myw3ICs4Myw3IEBAIFdl YktpdFdlYlZpZXcqIGtpdChXZWJDb3JlOjpQYWdlKiBjb3JlUGFnZSkKICAgICByZXR1cm4gY2xp ZW50ID8gY2xpZW50LT53ZWJWaWV3KCkgOiAwOwogfQogCi19IC8qKiBlbmQgbmFtZXNwYWNlIFdl YkNvcmUgKi8KK30gLyoqIGVuZCBuYW1lc3BhY2UgV2ViS2l0ICovCiAKIHZvaWQgd2Via2l0X2lu aXQoKQogewo= 22536 2008-07-29 06:37:32 -0700 2008-07-30 08:26:23 -0700 tabs corrected typofix.diff text/plain 941 gustavo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggODA4MGZmNi4uYzA5NjNiOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOC0wNy0yOSAg R3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUeXBvIGZpeCBpbiBjb21tZW50IGZvciB0 aGUgYnJhY2UgdGhhdCBlbmRzIHRoZSBXZWJLaXQgbmFtZXNwYWNlOworICAgICAgICBXZWJDb3Jl IC0+IFdlYktpdAorICAgICAgICAKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0cHJpdmF0ZS5jcHA6 CisKIDIwMDgtMDctMjYgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBC dWlsZCBmaXguICBDaGFuZ2VzIHRvIGFjY29tbW9kYXRlIG5ld2x5IG5hbWVkL3NpZ25hdHVyZWQg bG9hZGluZyBtZXRob2RzIGluIFdlYkNvcmUuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXRwcml2YXRlLmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuY3Bw CmluZGV4IGJlYTFhZDYuLjMxM2JkNWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHByaXZhdGUuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuY3Bw CkBAIC04Myw3ICs4Myw3IEBAIFdlYktpdFdlYlZpZXcqIGtpdChXZWJDb3JlOjpQYWdlKiBjb3Jl UGFnZSkKICAgICByZXR1cm4gY2xpZW50ID8gY2xpZW50LT53ZWJWaWV3KCkgOiAwOwogfQogCi19 IC8qKiBlbmQgbmFtZXNwYWNlIFdlYkNvcmUgKi8KK30gLyoqIGVuZCBuYW1lc3BhY2UgV2ViS2l0 ICovCiAKIHZvaWQgd2Via2l0X2luaXQoKQogewo=