202021 2019-09-19 19:40:52 -0700 [FTW, WinCairo] Support running tests in Release mode 2019-09-19 21:11:55 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201597 https://bugs.webkit.org/show_bug.cgi?id=201996 InRadar P2 Normal --- 161817 1 bfulgham bfulgham achristensen annulen bfulgham commit-queue don.olmstead ews-watchlist fujii gyuyoung.kim mark.lam pvollan rakuco ryuan.choi sergio webkit-bug-importer oldest_to_newest 1572603 0 bfulgham 2019-09-19 19:40:52 -0700 In Bug 201597, we added new features to better lock down JSC features in the potentially untrusted WebContent process. Unfortunately, this change included XPC Dictionary items used at startup to lock down JSC features before entering the main execution of the process. These changes were not done for the WinCairo or FTW ports. We need to pass the state of the JIT and whether to enable certain JSC features at process launch. Since the XPC mechanisms we use on macOS and iOS do not exist on Windows, I am implementing them as command-line flags. 1572606 1 379196 bfulgham 2019-09-19 19:47:28 -0700 Created attachment 379196 Patch 1572630 2 379196 commit-queue 2019-09-19 20:51:44 -0700 Comment on attachment 379196 Patch Clearing flags on attachment: 379196 Committed r250119: <https://trac.webkit.org/changeset/250119> 1572631 3 commit-queue 2019-09-19 20:51:46 -0700 All reviewed patches have been landed. Closing bug. 1572632 4 webkit-bug-importer 2019-09-19 20:52:19 -0700 <rdar://problem/55546547> 379196 2019-09-19 19:47:28 -0700 2019-09-19 20:51:44 -0700 Patch bug-202021-20190919194726.patch text/plain 4969 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTAxMTYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDE5LTA5LTE5ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtGVFcsIFdpbkNhaXJvXSBTdXBw b3J0IHJ1bm5pbmcgdGVzdHMgaW4gUmVsZWFzZSBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDIwMjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBCdWcgMjAxNTk3LCB3ZSBhZGRlZCBuZXcgZmVh dHVyZXMgdG8gYmV0dGVyIGxvY2sgZG93biBKU0MgZmVhdHVyZXMgaW4gdGhlCisgICAgICAgIHBv dGVudGlhbGx5IHVudHJ1c3RlZCBXZWJDb250ZW50IHByb2Nlc3MuCisKKyAgICAgICAgVW5mb3J0 dW5hdGVseSwgdGhpcyBjaGFuZ2UgaW5jbHVkZWQgWFBDIERpY3Rpb25hcnkgaXRlbXMgdXNlZCBh dCBzdGFydHVwIHRvCisgICAgICAgIGxvY2sgZG93biBKU0MgZmVhdHVyZXMgYmVmb3JlIGVudGVy aW5nIHRoZSBtYWluIGV4ZWN1dGlvbiBvZiB0aGUgcHJvY2Vzcy4gVGhlc2UKKyAgICAgICAgY2hh bmdlcyB3ZXJlIG5vdCBkb25lIGZvciB0aGUgV2luQ2Fpcm8gb3IgRlRXIHBvcnRzLgorCisgICAg ICAgIFdlIG5lZWQgdG8gcGFzcyB0aGUgc3RhdGUgb2YgdGhlIEpJVCBhbmQgd2hldGhlciB0byBl bmFibGUgY2VydGFpbiBKU0MgZmVhdHVyZXMKKyAgICAgICAgYXQgcHJvY2VzcyBsYXVuY2guIFNp bmNlIHRoZSBYUEMgbWVjaGFuaXNtcyB3ZSB1c2Ugb24gbWFjT1MgYW5kIGlPUyBkbyBub3QgZXhp c3QKKyAgICAgICAgb24gV2luZG93cywgSSBhbSBpbXBsZW1lbnRpbmcgdGhlbSBhcyBjb21tYW5k LWxpbmUgZmxhZ3MuCisKKyAgICAgICAgICAgIC1jb25maWd1cmUtanNjLWZvci10ZXN0aW5nOiBT ZXRzIHRoZSBKU0MgaW4gdGVzdGluZyBtb2RlLgorICAgICAgICAgICAgLWRpc2FibGUtaml0OiBE aXNhYmxlcyB0aGUgSklULgorCisgICAgICAgIFNlZSByMjQ5ODA4IGZvciB0aGUgZXF1aXZhbGVu dCBjaGFuZ2VzIG9uIG1hY09TIGFuZCBpT1MuCisKKyAgICAgICAgKiBQbGF0Zm9ybUZUVy5jbWFr ZTogQWRkIHNvbWUgbWlzc2luZyBoZWFkZXIgZmlsZXMgbmVlZGVkIHdoZW4gYnVpbGRpbmcgdGVz dHMuCisgICAgICAgICogU2hhcmVkL3dpbi9BdXhpbGlhcnlQcm9jZXNzTWFpbldpbi5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OkF1eGlsaWFyeVByb2Nlc3NNYWluQmFzZTo6cGFyc2VDb21tYW5kTGlu ZSk6CisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL3dpbi9Qcm9jZXNzTGF1bmNoZXJXaW4u Y3BwOgorICAgICAgICAoV2ViS2l0OjpQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MpOgor CiAyMDE5LTA5LTE5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg QWRkIGJldHRlciBsb2dnaW5nIGZvciB3aGVuIHRoZSB2aWV3IHZpc2liaWxpdHkgc3RhdGUgY2hh bmdlcwpJbmRleDogU291cmNlL1dlYktpdC9QbGF0Zm9ybUZUVy5jbWFrZQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L1BsYXRmb3JtRlRXLmNtYWtlCShyZXZpc2lvbiAyNTAxMDMpCisrKyBT b3VyY2UvV2ViS2l0L1BsYXRmb3JtRlRXLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC0yNjIsNiAr MjYyLDcgQEAgc2V0KFdlYktpdF9QVUJMSUNfRlJBTUVXT1JLX0hFQURFUlMKICAgICBVSVByb2Nl c3MvQVBJL0MvV0tHZW9sb2NhdGlvbk1hbmFnZXIuaAogICAgIFVJUHJvY2Vzcy9BUEkvQy9XS0dl b2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3QuaAogICAgIFVJUHJvY2Vzcy9BUEkvQy9XS0dlb2xv Y2F0aW9uUG9zaXRpb24uaAorICAgIFVJUHJvY2Vzcy9BUEkvQy9XS0hUVFBDb29raWVTdG9yZVJl Zi5oCiAgICAgVUlQcm9jZXNzL0FQSS9DL1dLSGl0VGVzdFJlc3VsdC5oCiAgICAgVUlQcm9jZXNz L0FQSS9DL1dLSWNvbkRhdGFiYXNlLmgKICAgICBVSVByb2Nlc3MvQVBJL0MvV0tJbnNwZWN0b3Iu aApAQCAtMjkzLDggKzI5NCw4IEBAIHNldChXZWJLaXRfUFVCTElDX0ZSQU1FV09SS19IRUFERVJT CiAgICAgVUlQcm9jZXNzL0FQSS9DL1dLUGFnZU5hdmlnYXRpb25DbGllbnQuaAogICAgIFVJUHJv Y2Vzcy9BUEkvQy9XS1BhZ2VQb2xpY3lDbGllbnQuaAogICAgIFVJUHJvY2Vzcy9BUEkvQy9XS1Bh Z2VQcml2YXRlLmgKLSAgICBVSVByb2Nlc3MvQVBJL0MvV0tQYWdlU3RhdGVDbGllbnQuaAogICAg IFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2VSZW5kZXJpbmdQcm9ncmVzc0V2ZW50cy5oCisgICAgVUlQ cm9jZXNzL0FQSS9DL1dLUGFnZVN0YXRlQ2xpZW50LmgKICAgICBVSVByb2Nlc3MvQVBJL0MvV0tQ YWdlVUlDbGllbnQuaAogICAgIFVJUHJvY2Vzcy9BUEkvQy9XS1BsdWdpbkxvYWRQb2xpY3kuaAog ICAgIFVJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzUmVmLmgKQEAgLTMxMiw2ICszMTMsNyBA QCBzZXQoV2ViS2l0X1BVQkxJQ19GUkFNRVdPUktfSEVBREVSUwogICAgIFVJUHJvY2Vzcy9BUEkv Qy9XS1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0LmgKICAgICBVSVByb2Nlc3MvQVBJL0MvV0tV c2VyU2NyaXB0UmVmLmgKICAgICBVSVByb2Nlc3MvQVBJL0MvV0tWaWV3cG9ydEF0dHJpYnV0ZXMu aAorICAgIFVJUHJvY2Vzcy9BUEkvQy9XS1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uUmVm LmgKICAgICBVSVByb2Nlc3MvQVBJL0MvV0tXZWJzaXRlRGF0YVN0b3JlUmVmLmgKICAgICBVSVBy b2Nlc3MvQVBJL0MvV0tXZWJzaXRlUG9saWNpZXMuaAogICAgIFVJUHJvY2Vzcy9BUEkvQy9XS1dp bmRvd0ZlYXR1cmVzUmVmLmgKSW5kZXg6IFNvdXJjZS9XZWJLaXQvU2hhcmVkL3dpbi9BdXhpbGlh cnlQcm9jZXNzTWFpbldpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9TaGFyZWQv d2luL0F1eGlsaWFyeVByb2Nlc3NNYWluV2luLmNwcAkocmV2aXNpb24gMjUwMTAzKQorKysgU291 cmNlL1dlYktpdC9TaGFyZWQvd2luL0F1eGlsaWFyeVByb2Nlc3NNYWluV2luLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUg IkF1eGlsaWFyeVByb2Nlc3NNYWluLmgiCiAKKyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9FeGVj dXRhYmxlQWxsb2NhdG9yLmg+CiAjaW5jbHVkZSA8Y3N0cmluZz4KICNpbmNsdWRlIDx3dGYvdGV4 dC9XVEZTdHJpbmcuaD4KIApAQCAtNDAsNyArNDEsMTAgQEAgYm9vbCBBdXhpbGlhcnlQcm9jZXNz TWFpbkJhc2U6OnBhcnNlQ29tbQogICAgICAgICB9IGVsc2UgaWYgKCFzdHJjbXAoYXJndltpXSwg Ii1wcm9jZXNzSWRlbnRpZmllciIpICYmIGkgKyAxIDwgYXJnYykgewogICAgICAgICAgICAgU3Ry aW5nIHN0cihhcmd2WysraV0pOwogICAgICAgICAgICAgbV9wYXJhbWV0ZXJzLnByb2Nlc3NJZGVu dGlmaWVyID0gbWFrZU9iamVjdElkZW50aWZpZXI8V2ViQ29yZTo6UHJvY2Vzc0lkZW50aWZpZXJU eXBlPihzdHIudG9VSW50NjQoKSk7Ci0gICAgICAgIH0KKyAgICAgICAgfSBlbHNlIGlmICghc3Ry Y21wKGFyZ3ZbaV0sICItY29uZmlndXJlLWpzYy1mb3ItdGVzdGluZyIpKQorICAgICAgICAgICAg SlNDOjpDb25maWc6OmNvbmZpZ3VyZUZvclRlc3RpbmcoKTsKKyAgICAgICAgZWxzZSBpZiAoIXN0 cmNtcChhcmd2W2ldLCAiLWRpc2FibGUtaml0IikpCisgICAgICAgICAgICBKU0M6OkV4ZWN1dGFi bGVBbGxvY2F0b3I6OnNldEpJVEVuYWJsZWQoZmFsc2UpOwogICAgIH0KICAgICByZXR1cm4gdHJ1 ZTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL3dpbi9Qcm9jZXNz TGF1bmNoZXJXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xh dW5jaGVyL3dpbi9Qcm9jZXNzTGF1bmNoZXJXaW4uY3BwCShyZXZpc2lvbiAyNTAxMDMpCisrKyBT b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci93aW4vUHJvY2Vzc0xhdW5jaGVyV2luLmNw cAkod29ya2luZyBjb3B5KQpAQCAtODIsNiArODIsMTAgQEAgdm9pZCBQcm9jZXNzTGF1bmNoZXI6 OmxhdW5jaFByb2Nlc3MoKQogICAgIGNvbW1hbmRMaW5lQnVpbGRlci5hcHBlbmQoU3RyaW5nOjpu dW1iZXIobV9sYXVuY2hPcHRpb25zLnByb2Nlc3NJZGVudGlmaWVyLnRvVUludDY0KCkpKTsKICAg ICBjb21tYW5kTGluZUJ1aWxkZXIuYXBwZW5kKCIgLWNsaWVudElkZW50aWZpZXIgIik7CiAgICAg Y29tbWFuZExpbmVCdWlsZGVyLmFwcGVuZChTdHJpbmc6Om51bWJlcihyZWludGVycHJldF9jYXN0 PHVpbnRwdHJfdD4oY2xpZW50SWRlbnRpZmllcikpKTsKKyAgICBpZiAobV9jbGllbnQtPnNob3Vs ZENvbmZpZ3VyZUpTQ0ZvclRlc3RpbmcoKSkKKyAgICAgICAgY29tbWFuZExpbmVCdWlsZGVyLmFw cGVuZCgiIC1jb25maWd1cmUtanNjLWZvci10ZXN0aW5nIik7CisgICAgaWYgKCFtX2NsaWVudC0+ aXNKSVRFbmFibGVkKCkpCisgICAgICAgIGNvbW1hbmRMaW5lQnVpbGRlci5hcHBlbmQoIiAtZGlz YWJsZS1qaXQiKTsKICAgICBjb21tYW5kTGluZUJ1aWxkZXIuYXBwZW5kKCdcMCcpOwogCiAgICAg YXV0byBjb21tYW5kTGluZSA9IGNvbW1hbmRMaW5lQnVpbGRlci50b1N0cmluZygpLndpZGVDaGFy YWN0ZXJzKCk7Cg==