202008 2019-09-19 15:06:19 -0700 Add better logging for when the view visibility state changes 2019-09-19 17:13:18 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue ggaren thorton webkit-bug-importer oldest_to_newest 1572496 0 cdumez 2019-09-19 15:06:19 -0700 Add better logging for when the view visibility state changes. 1572498 1 379166 cdumez 2019-09-19 15:09:05 -0700 Created attachment 379166 Patch 1572501 2 379166 ggaren 2019-09-19 15:14:11 -0700 Comment on attachment 379166 Patch r=me 1572547 3 379166 commit-queue 2019-09-19 17:12:03 -0700 Comment on attachment 379166 Patch Clearing flags on attachment: 379166 Committed r250111: <https://trac.webkit.org/changeset/250111> 1572548 4 commit-queue 2019-09-19 17:12:05 -0700 All reviewed patches have been landed. Closing bug. 1572549 5 webkit-bug-importer 2019-09-19 17:13:18 -0700 <rdar://problem/55541227> 379166 2019-09-19 15:09:05 -0700 2019-09-19 17:12:03 -0700 Patch bug-202008-20190919150904.patch text/plain 6614 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFjZWIxZDM1ZGNkMzNlZjEw OWY4Y2YyZDgyM2YxYWQ5OTYxMDg1MzEuLjRmZDUwYzIxMzE0MjJkZTFhMGE4NDFlMjZhYWZhZDJl NzdiZGU0NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDktMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYmV0dGVyIGxvZ2dpbmcgZm9y IHdoZW4gdGhlIHZpZXcgdmlzaWJpbGl0eSBzdGF0ZSBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDIwMDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BcHBsaWNhdGlvblN0 YXRlVHJhY2tlci5tbToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojp1cGRhdGVBY3Rpdml0eVN0YXRlKToKKyAgICAg ICAgKiBVSVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94eUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6 V2ViUGFnZVByb3h5OjphcHBsaWNhdGlvbkRpZEVudGVyQmFja2dyb3VuZCk6CisgICAgICAgIChX ZWJLaXQ6OldlYlBhZ2VQcm94eTo6YXBwbGljYXRpb25XaWxsRW50ZXJGb3JlZ3JvdW5kKToKKwog MjAxOS0wOS0xOSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBDcmVhdGUgSW5qZWN0ZWRCdW5kbGUgU1BJIHRvIGJldHRlciBzdXBwb3J0IE5TU2VjdXJlQ29k aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BcHBsaWNhdGlvblN0YXRl VHJhY2tlci5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FwcGxpY2F0aW9uU3RhdGVUcmFj a2VyLm1tCmluZGV4IDUwNzkyMmZhYWY4ODBiNWJhMmFlY2FhZDgyN2ZlOTExMjA4ZDI5ZjQuLmFk YWIxYTM3ZTVlNWM0ODU1YzlhMmVhNzcwZWQ5ZWU3ZDQ2MzNlODUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FwcGxpY2F0aW9uU3RhdGVUcmFja2VyLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FwcGxpY2F0aW9uU3RhdGVUcmFja2VyLm1tCkBAIC0xMDUsMTkg KzEwNSwyNCBAQCBBcHBsaWNhdGlvblN0YXRlVHJhY2tlcjo6QXBwbGljYXRpb25TdGF0ZVRyYWNr ZXIoVUlWaWV3ICp2aWV3LCBTRUwgZGlkRW50ZXJCYWNrZwogICAgIHN3aXRjaCAoYXBwbGljYXRp b25UeXBlKHdpbmRvdykpIHsKICAgICBjYXNlIEFwcGxpY2F0aW9uVHlwZTo6QXBwbGljYXRpb246 IHsKICAgICAgICAgbV9pc0luQmFja2dyb3VuZCA9IGFwcGxpY2F0aW9uLmFwcGxpY2F0aW9uU3Rh dGUgPT0gVUlBcHBsaWNhdGlvblN0YXRlQmFja2dyb3VuZDsKKyAgICAgICAgUkVMRUFTRV9MT0co UHJvY2Vzc1N1c3BlbnNpb24sICIlcCAtIEFwcGxpY2F0aW9uU3RhdGVUcmFja2VyOjpBcHBsaWNh dGlvblN0YXRlVHJhY2tlcigpOiBtX2lzSW5CYWNrZ3JvdW5kOiAlZCIsIHRoaXMsIG1faXNJbkJh Y2tncm91bmQpOwogCiAjaWYgSEFWRShVSVNDRU5FKQogICAgICAgICBtX2RpZEVudGVyQmFja2dy b3VuZE9ic2VydmVyID0gW25vdGlmaWNhdGlvbkNlbnRlciBhZGRPYnNlcnZlckZvck5hbWU6VUlT Y2VuZURpZEVudGVyQmFja2dyb3VuZE5vdGlmaWNhdGlvbiBvYmplY3Q6d2luZG93LndpbmRvd1Nj ZW5lIHF1ZXVlOm5pbCB1c2luZ0Jsb2NrOlt0aGlzXShOU05vdGlmaWNhdGlvbiAqKSB7CisgICAg ICAgICAgICBSRUxFQVNFX0xPRyhQcm9jZXNzU3VzcGVuc2lvbiwgIiVwIC0gQXBwbGljYXRpb25T dGF0ZVRyYWNrZXI6IFVJU2NlbmVEaWRFbnRlckJhY2tncm91bmQiLCB0aGlzKTsKICNlbHNlCiAg ICAgICAgIG1fZGlkRW50ZXJCYWNrZ3JvdW5kT2JzZXJ2ZXIgPSBbbm90aWZpY2F0aW9uQ2VudGVy IGFkZE9ic2VydmVyRm9yTmFtZTpVSUFwcGxpY2F0aW9uRGlkRW50ZXJCYWNrZ3JvdW5kTm90aWZp Y2F0aW9uIG9iamVjdDphcHBsaWNhdGlvbiBxdWV1ZTpuaWwgdXNpbmdCbG9jazpbdGhpc10oTlNO b3RpZmljYXRpb24gKikgeworICAgICAgICAgICAgUkVMRUFTRV9MT0coUHJvY2Vzc1N1c3BlbnNp b24sICIlcCAtIEFwcGxpY2F0aW9uU3RhdGVUcmFja2VyOiBVSUFwcGxpY2F0aW9uRGlkRW50ZXJC YWNrZ3JvdW5kIiwgdGhpcyk7CiAjZW5kaWYKICAgICAgICAgICAgIGFwcGxpY2F0aW9uRGlkRW50 ZXJCYWNrZ3JvdW5kKCk7CiAgICAgICAgIH1dOwogCiAjaWYgSEFWRShVSVNDRU5FKQogICAgICAg ICBtX3dpbGxFbnRlckZvcmVncm91bmRPYnNlcnZlciA9IFtub3RpZmljYXRpb25DZW50ZXIgYWRk T2JzZXJ2ZXJGb3JOYW1lOlVJU2NlbmVXaWxsRW50ZXJGb3JlZ3JvdW5kTm90aWZpY2F0aW9uIG9i amVjdDp3aW5kb3cud2luZG93U2NlbmUgcXVldWU6bmlsIHVzaW5nQmxvY2s6W3RoaXNdKE5TTm90 aWZpY2F0aW9uICopIHsKKyAgICAgICAgICAgIFJFTEVBU0VfTE9HKFByb2Nlc3NTdXNwZW5zaW9u LCAiJXAgLSBBcHBsaWNhdGlvblN0YXRlVHJhY2tlcjogVUlTY2VuZVdpbGxFbnRlckZvcmVncm91 bmQiLCB0aGlzKTsKICNlbHNlCiAgICAgICAgIG1fd2lsbEVudGVyRm9yZWdyb3VuZE9ic2VydmVy ID0gW25vdGlmaWNhdGlvbkNlbnRlciBhZGRPYnNlcnZlckZvck5hbWU6VUlBcHBsaWNhdGlvbldp bGxFbnRlckZvcmVncm91bmROb3RpZmljYXRpb24gb2JqZWN0OmFwcGxpY2F0aW9uIHF1ZXVlOm5p bCB1c2luZ0Jsb2NrOlt0aGlzXShOU05vdGlmaWNhdGlvbiAqKSB7CisgICAgICAgICAgICBSRUxF QVNFX0xPRyhQcm9jZXNzU3VzcGVuc2lvbiwgIiVwIC0gQXBwbGljYXRpb25TdGF0ZVRyYWNrZXI6 IFVJQXBwbGljYXRpb25XaWxsRW50ZXJGb3JlZ3JvdW5kIiwgdGhpcyk7CiAjZW5kaWYKICAgICAg ICAgICAgIGFwcGxpY2F0aW9uV2lsbEVudGVyRm9yZWdyb3VuZCgpOwogICAgICAgICB9XTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDlkY2E4Zjc3ZjljYTdk NjVhNjU0OGYzMmRjM2FhYWExYTE4OGFjZjQuLmNmODQxZWQxMDA0NDZkYzNjOTlmNWRkZWYyOTE2 YjMyNGQ2MzIwZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApA QCAtMTczNCwxMyArMTczNCwxOSBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6c2V0U3VwcHJlc3NWaXNp YmlsaXR5VXBkYXRlcyhib29sIGZsYWcpCiAKIHZvaWQgV2ViUGFnZVByb3h5Ojp1cGRhdGVBY3Rp dml0eVN0YXRlKE9wdGlvblNldDxBY3Rpdml0eVN0YXRlOjpGbGFnPiBmbGFnc1RvVXBkYXRlKQog eworICAgIGJvb2wgd2FzVmlzaWJsZSA9IGlzVmlld1Zpc2libGUoKTsKICAgICBtX2FjdGl2aXR5 U3RhdGUucmVtb3ZlKGZsYWdzVG9VcGRhdGUpOwogICAgIGlmIChmbGFnc1RvVXBkYXRlICYgQWN0 aXZpdHlTdGF0ZTo6SXNGb2N1c2VkICYmIHBhZ2VDbGllbnQoKS5pc1ZpZXdGb2N1c2VkKCkpCiAg ICAgICAgIG1fYWN0aXZpdHlTdGF0ZS5hZGQoQWN0aXZpdHlTdGF0ZTo6SXNGb2N1c2VkKTsKICAg ICBpZiAoZmxhZ3NUb1VwZGF0ZSAmIEFjdGl2aXR5U3RhdGU6OldpbmRvd0lzQWN0aXZlICYmIHBh Z2VDbGllbnQoKS5pc1ZpZXdXaW5kb3dBY3RpdmUoKSkKICAgICAgICAgbV9hY3Rpdml0eVN0YXRl LmFkZChBY3Rpdml0eVN0YXRlOjpXaW5kb3dJc0FjdGl2ZSk7Ci0gICAgaWYgKGZsYWdzVG9VcGRh dGUgJiBBY3Rpdml0eVN0YXRlOjpJc1Zpc2libGUgJiYgcGFnZUNsaWVudCgpLmlzVmlld1Zpc2li bGUoKSkKLSAgICAgICAgbV9hY3Rpdml0eVN0YXRlLmFkZChBY3Rpdml0eVN0YXRlOjpJc1Zpc2li bGUpOworICAgIGlmIChmbGFnc1RvVXBkYXRlICYgQWN0aXZpdHlTdGF0ZTo6SXNWaXNpYmxlKSB7 CisgICAgICAgIGJvb2wgaXNOb3dWaXNpYmxlID0gcGFnZUNsaWVudCgpLmlzVmlld1Zpc2libGUo KTsKKyAgICAgICAgaWYgKGlzTm93VmlzaWJsZSkKKyAgICAgICAgICAgIG1fYWN0aXZpdHlTdGF0 ZS5hZGQoQWN0aXZpdHlTdGF0ZTo6SXNWaXNpYmxlKTsKKyAgICAgICAgaWYgKHdhc1Zpc2libGUg IT0gaXNOb3dWaXNpYmxlKQorICAgICAgICAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRChWaWV3 U3RhdGUsICJ1cGRhdGVBY3Rpdml0eVN0YXRlOiB2aWV3IHZpc2liaWxpdHkgc3RhdGUgY2hhbmdl ZCAlZCAtPiAlZCIsIHdhc1Zpc2libGUsIGlzTm93VmlzaWJsZSk7CisgICAgfQogICAgIGlmIChm bGFnc1RvVXBkYXRlICYgQWN0aXZpdHlTdGF0ZTo6SXNWaXNpYmxlT3JPY2NsdWRlZCAmJiBwYWdl Q2xpZW50KCkuaXNWaWV3VmlzaWJsZU9yT2NjbHVkZWQoKSkKICAgICAgICAgbV9hY3Rpdml0eVN0 YXRlLmFkZChBY3Rpdml0eVN0YXRlOjpJc1Zpc2libGVPck9jY2x1ZGVkKTsKICAgICBpZiAoZmxh Z3NUb1VwZGF0ZSAmIEFjdGl2aXR5U3RhdGU6OklzSW5XaW5kb3cgJiYgcGFnZUNsaWVudCgpLmlz Vmlld0luV2luZG93KCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V2ViUGFnZVByb3h5SU9TLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dlYlBhZ2VQ cm94eUlPUy5tbQppbmRleCA0MDdkOTZhNjY3MmRmYmY4YTMyYmYxODNmMTdiYzVlMzU1NjE5MjBj Li5lOTcwYWM0MTVkYjQyNmUyZjc5MGI0OWJmODM1MjY4MTRmM2EzNTE1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0KQEAgLTc0LDYgKzc0LDgg QEAKICNpbXBvcnQgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogI2VuZGlmCiAKKyNkZWZpbmUgUkVM RUFTRV9MT0dfSUZfQUxMT1dFRChjaGFubmVsLCBmbXQsIC4uLikgUkVMRUFTRV9MT0dfSUYoaXNB bHdheXNPbkxvZ2dpbmdBbGxvd2VkKCksIGNoYW5uZWwsICIlcCAtIFtwYWdlUHJveHlJRD0lbGx1 LCB3ZWJQYWdlSUQ9JWxsdSwgUElEPSVpXSBXZWJQYWdlUHJveHk6OiIgZm10LCB0aGlzLCBtX2lk ZW50aWZpZXIudG9VSW50NjQoKSwgbV93ZWJQYWdlSUQudG9VSW50NjQoKSwgbV9wcm9jZXNzLT5w cm9jZXNzSWRlbnRpZmllcigpLCAjI19fVkFfQVJHU19fKQorCiBuYW1lc3BhY2UgV2ViS2l0IHsK IHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC02NDcsNiArNjQ5LDggQEAgdm9pZCBXZWJQ YWdlUHJveHk6OnNhdmVJbWFnZVRvTGlicmFyeShjb25zdCBTaGFyZWRNZW1vcnk6OkhhbmRsZSYg aW1hZ2VIYW5kbGUsIHUKIHZvaWQgV2ViUGFnZVByb3h5OjphcHBsaWNhdGlvbkRpZEVudGVyQmFj a2dyb3VuZCgpCiB7CiAgICAgYm9vbCBpc1N1c3BlbmRlZFVuZGVyTG9jayA9IFtVSUFwcCBpc1N1 c3BlbmRlZFVuZGVyTG9ja107CisgICAgCisgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRChWaWV3 U3RhdGUsICJhcHBsaWNhdGlvbkRpZEVudGVyQmFja2dyb3VuZDogaXNTdXNwZW5kZWRVbmRlckxv Y2s/ICVkIiwgaXNTdXNwZW5kZWRVbmRlckxvY2spOwogCiAjaWYgIVBMQVRGT1JNKFdBVENIT1Mp CiAgICAgLy8gV2Ugbm9ybWFsbHkgZGVsYXkgcHJvY2VzcyBzdXNwZW5zaW9uIHdoZW4gdGhlIGFw cCBpcyBiYWNrZ3JvdW5kZWQgdW50aWwgdGhlIGN1cnJlbnQgcGFnZSBsb2FkIGNvbXBsZXRlcy4g SG93ZXZlciwKQEAgLTY3NCw2ICs2NzgsOCBAQCBib29sIFdlYlBhZ2VQcm94eTo6aXNJbkhhcmR3 YXJlS2V5Ym9hcmRNb2RlKCkKIHZvaWQgV2ViUGFnZVByb3h5OjphcHBsaWNhdGlvbldpbGxFbnRl ckZvcmVncm91bmQoKQogewogICAgIGJvb2wgaXNTdXNwZW5kZWRVbmRlckxvY2sgPSBbVUlBcHAg aXNTdXNwZW5kZWRVbmRlckxvY2tdOworICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoVmlld1N0 YXRlLCAiYXBwbGljYXRpb25XaWxsRW50ZXJGb3JlZ3JvdW5kOiBpc1N1c3BlbmRlZFVuZGVyTG9j az8gJWQiLCBpc1N1c3BlbmRlZFVuZGVyTG9jayk7CisKICAgICBtX3Byb2Nlc3MtPnNlbmQoTWVz c2FnZXM6OldlYlBhZ2U6OkFwcGxpY2F0aW9uV2lsbEVudGVyRm9yZWdyb3VuZChpc1N1c3BlbmRl ZFVuZGVyTG9jayksIG1fd2ViUGFnZUlEKTsKICAgICBtX3Byb2Nlc3MtPnNlbmQoTWVzc2FnZXM6 OldlYlBhZ2U6OkhhcmR3YXJlS2V5Ym9hcmRBdmFpbGFiaWxpdHlDaGFuZ2VkKGlzSW5IYXJkd2Fy ZUtleWJvYXJkTW9kZSgpKSwgbV93ZWJQYWdlSUQpOwogfQpAQCAtMTQ2Nyw0ICsxNDczLDYgQEAg V2ViQ29udGVudE1vZGUgV2ViUGFnZVByb3h5OjplZmZlY3RpdmVDb250ZW50TW9kZUFmdGVyQWRq dXN0aW5nUG9saWNpZXMoQVBJOjpXZWIKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKKyN1bmRl ZiBSRUxFQVNFX0xPR19JRl9BTExPV0VECisKICNlbmRpZiAvLyBQTEFURk9STShJT1NfRkFNSUxZ KQo=