201999 2019-09-19 13:18:36 -0700 [EWS] JSC queues should re-build ToT and compare results on build failure 2019-09-24 14:24:51 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=202170 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain aperez ap clopez commit-queue jbedard webkit-bug-importer oldest_to_newest 1572450 0 aakash_jain 2019-09-19 13:18:36 -0700 When JSC queue fails to build-jsc with the patch, it should re-build ToT and compare results to check if the failure is new or pre-existing. 1572456 1 379159 aakash_jain 2019-09-19 13:38:41 -0700 Created attachment 379159 Patch 1572457 2 aakash_jain 2019-09-19 13:41:23 -0700 Sample runs: - Failure introduced by patch: https://ews-build.webkit-uat.org/#/builders/17/builds/3989 - Failure on ToT: https://ews-build.webkit-uat.org/#/builders/17/builds/3985 - Success: https://ews-build.webkit-uat.org/#/builders/17/builds/3993, https://ews-build.webkit-uat.org/#/builders/17/builds/3935 1572469 3 aakash_jain 2019-09-19 13:52:43 -0700 Another sample run for 'success': https://ews-build.webkit-uat.org/#/builders/17/builds/3994 1572472 4 aakash_jain 2019-09-19 13:53:55 -0700 Note that this patch is only for building JSC, jsc-testing logic will be added/fixed in subsequent patches. 1572529 5 379159 jbedard 2019-09-19 16:29:33 -0700 Comment on attachment 379159 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379159&action=review > Tools/BuildSlaveSupport/ews-build/factories.py:124 > self.addStep(UnApplyPatchIfRequired()) Is this not dynamically added as well? 1572559 6 379159 aakash_jain 2019-09-19 17:37:32 -0700 Comment on attachment 379159 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379159&action=review >> Tools/BuildSlaveSupport/ews-build/factories.py:124 >> self.addStep(UnApplyPatchIfRequired()) > > Is this not dynamically added as well? These would be removed in subsequent patches. I haven’t started working on these tests yet. 1572998 7 379159 commit-queue 2019-09-20 18:07:56 -0700 Comment on attachment 379159 Patch Clearing flags on attachment: 379159 Committed r250174: <https://trac.webkit.org/changeset/250174> 1572999 8 commit-queue 2019-09-20 18:07:57 -0700 All reviewed patches have been landed. Closing bug. 1573000 9 webkit-bug-importer 2019-09-20 18:08:15 -0700 <rdar://problem/55579180> 379159 2019-09-19 13:38:41 -0700 2019-09-20 18:07:56 -0700 Patch bug-201999-20190919163840.patch text/plain 4514 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MDEwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE5LTA5LTE5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbRVdTXSBKU0MgcXVldWVzIHNob3VsZCByZS1idWlsZCBUb1QgYW5kIGNv bXBhcmUgcmVzdWx0cyBvbiBidWlsZCBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE5OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0 b3JpZXMucHk6CisgICAgICAgIChKU0NUZXN0c0ZhY3RvcnkuX19pbml0X18pOiBEbyBub3QgYWRk IHRoZSBVbkFwcGx5UGF0Y2hJZlJlcXVpcmVkIGFuZCBDb21waWxlSlNDT25seVRvVCBzdGVwIGhl cmUsIGFzCisgICAgICAgIHRoZXNlIGFyZSBkeW5hbWljYWxseSBhZGRlZCAoaWYgcmVxdWlyZWQp IGluIHN0ZXBzLnB5IGluIENvbXBpbGVXZWJLaXQuZXZhbHVhdGVDb21tYW5kKCkgdXNpbmcgYWRk U3RlcHNBZnRlckN1cnJlbnRTdGVwKCkuCisgICAgICAgIEFsc28gc2V0dGluZyBza2lwVXBsb2Fk PUZhbHNlIHNpbmNlIHdlIGRvbid0IG5lZWQgdG8gdXBsb2FkIHRoZSBhcmNoaXZlIGZvciB0aGlz IHF1ZXVlLiBCdWlsZGluZyBhbmQgdGVzdGluZyBpcyBkb25lIGluIHNhbWUgYnVpbGQuCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQ29t cGlsZVdlYktpdC5ldmFsdWF0ZUNvbW1hbmQpOiBBZGQgQ29tcGlsZUpTQ09ubHlUb1Qgb3IgQ29t cGlsZVdlYktpdFRvVCBidWlsZC1zdGVwIGJhc2VkIG9uICdncm91cCcgcHJvcGVydHkuCisgICAg ICAgIChBbmFseXplQ29tcGlsZVdlYktpdFJlc3VsdHMuc3RhcnQpOiBEaXR0by4KKyAgICAgICAg KENvbXBpbGVKU0NPbmx5LnN0YXJ0KTogU2V0IHRoZSAnZ3JvdXAnIHByb3BlcnR5IHRvICdqc2Mn LgorICAgICAgICAoQ29tcGlsZUpTQ09ubHlUb1QuZXZhbHVhdGVDb21tYW5kKTogT3Zlci1yaWRl IGV2YWx1YXRlQ29tbWFuZCwgc28gdGhhdCBiYXNlLWNsYXNzJyAoQ29tcGlsZVdlYktpdCkgZXZh bHVhdGVDb21tYW5kIGlzIAorICAgICAgICBub3QgdXNlZCwgYmFzZSBjbGFzcyBldmFsdWF0ZUNv bW1hbmQgYWRkcyBidWlsZC1zdGVwcyBkeW5hbWljYWxseS4KKwogMjAxOS0wOS0xOSAgQWFrYXNo IEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3c10gRml4IHBsYXRm b3JtIGZvciBKU0MgRVdTCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv ZmFjdG9yaWVzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9mYWN0b3JpZXMucHkJKHJldmlzaW9uIDI1MDEwMikKKysrIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTExOCw5ICsx MTgsNyBAQCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToKIGNsYXNzIEpTQ1Rlc3RzRmFjdG9y eShGYWN0b3J5KToKICAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRp b249J3JlbGVhc2UnLCBhcmNoaXRlY3R1cmVzPU5vbmUsIGFkZGl0aW9uYWxBcmd1bWVudHM9Tm9u ZSwgKiprd2FyZ3MpOgogICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBj b25maWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgYWRkaXRpb25hbEFyZ3VtZW50cywg Y2hlY2tSZWxldmFuY2U9VHJ1ZSkKLSAgICAgICAgc2VsZi5hZGRTdGVwKENvbXBpbGVKU0NPbmx5 KCkpCi0gICAgICAgIHNlbGYuYWRkU3RlcChVbkFwcGx5UGF0Y2hJZlJlcXVpcmVkKCkpCi0gICAg ICAgIHNlbGYuYWRkU3RlcChDb21waWxlSlNDT25seVRvVCgpKQorICAgICAgICBzZWxmLmFkZFN0 ZXAoQ29tcGlsZUpTQ09ubHkoc2tpcFVwbG9hZD1UcnVlKSkKICAgICAgICAgc2VsZi5hZGRTdGVw KFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKFJlUnVuSmF2 YVNjcmlwdENvcmVUZXN0cygpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoVW5BcHBseVBhdGNoSWZS ZXF1aXJlZCgpKQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw cy5weQkocmV2aXNpb24gMjUwMTAyKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03NDQsNyArNzQ0LDEwIEBAIGNsYXNzIENv bXBpbGVXZWJLaXQoc2hlbGwuQ29tcGlsZSk6CiAgICAgICAgICAgICAgICAgc3RlcHNfdG9fYWRk LmFwcGVuZChJbnN0YWxsV3BlRGVwZW5kZW5jaWVzKCkpCiAgICAgICAgICAgICBlbGlmIHBsYXRm b3JtID09ICdndGsnOgogICAgICAgICAgICAgICAgIHN0ZXBzX3RvX2FkZC5hcHBlbmQoSW5zdGFs bEd0a0RlcGVuZGVuY2llcygpKQotICAgICAgICAgICAgc3RlcHNfdG9fYWRkLmFwcGVuZChDb21w aWxlV2ViS2l0VG9UKCkpCisgICAgICAgICAgICBpZiBzZWxmLmdldFByb3BlcnR5KCdncm91cCcp ID09ICdqc2MnOgorICAgICAgICAgICAgICAgIHN0ZXBzX3RvX2FkZC5hcHBlbmQoQ29tcGlsZUpT Q09ubHlUb1QoKSkKKyAgICAgICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgc3RlcHNfdG9f YWRkLmFwcGVuZChDb21waWxlV2ViS2l0VG9UKCkpCiAgICAgICAgICAgICBzdGVwc190b19hZGQu YXBwZW5kKEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0cygpKQogICAgICAgICAgICAgIyBVc2lu ZyBhIHNpbmdsZSBhZGRTdGVwc0FmdGVyQ3VycmVudFN0ZXAgYmVjYXVzZSBvZiBodHRwczovL2dp dGh1Yi5jb20vYnVpbGRib3QvYnVpbGRib3QvaXNzdWVzLzQ4NzQKICAgICAgICAgICAgIHNlbGYu YnVpbGQuYWRkU3RlcHNBZnRlckN1cnJlbnRTdGVwKHN0ZXBzX3RvX2FkZCkKQEAgLTc3Niw3ICs3 NzksMTAgQEAgY2xhc3MgQW5hbHl6ZUNvbXBpbGVXZWJLaXRSZXN1bHRzKGJ1aWxkcwogICAgIGRl c2NyaXB0aW9uRG9uZSA9IFsnYW5hbHl6ZS1jb21waWxlLXdlYmtpdC1yZXN1bHRzJ10KIAogICAg IGRlZiBzdGFydChzZWxmKToKLSAgICAgICAgY29tcGlsZV93ZWJraXRfdG90X3Jlc3VsdCA9IHNl bGYuZ2V0U3RlcFJlc3VsdChDb21waWxlV2ViS2l0VG9ULm5hbWUpCisgICAgICAgIGNvbXBpbGVf dG90X3N0ZXAgPSBDb21waWxlV2ViS2l0VG9ULm5hbWUKKyAgICAgICAgaWYgc2VsZi5nZXRQcm9w ZXJ0eSgnZ3JvdXAnKSA9PSAnanNjJzoKKyAgICAgICAgICAgIGNvbXBpbGVfdG90X3N0ZXAgPSBD b21waWxlSlNDT25seVRvVC5uYW1lCisgICAgICAgIGNvbXBpbGVfd2Via2l0X3RvdF9yZXN1bHQg PSBzZWxmLmdldFN0ZXBSZXN1bHQoY29tcGlsZV90b3Rfc3RlcCkKIAogICAgICAgICBpZiBjb21w aWxlX3dlYmtpdF90b3RfcmVzdWx0ID09IEZBSUxVUkU6CiAgICAgICAgICAgICBzZWxmLmZpbmlz aGVkKEZBSUxVUkUpCkBAIC04MDQsNiArODEwLDEwIEBAIGNsYXNzIENvbXBpbGVKU0NPbmx5KENv bXBpbGVXZWJLaXQpOgogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsnQ29tcGlsZWQgSlNDJ10KICAg ICBjb21tYW5kID0gWydwZXJsJywgJ1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjJywgV2l0aFByb3Bl cnRpZXMoJy0tJShjb25maWd1cmF0aW9uKXMnKV0KIAorICAgIGRlZiBzdGFydChzZWxmKToKKyAg ICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZ3JvdXAnLCAnanNjJykKKyAgICAgICAgcmV0dXJuIENv bXBpbGVXZWJLaXQuc3RhcnQoc2VsZikKKwogCiBjbGFzcyBDb21waWxlSlNDT25seVRvVChDb21w aWxlSlNDT25seSk6CiAgICAgbmFtZSA9ICdidWlsZC1qc2MtdG90JwpAQCAtODE0LDYgKzgyNCw5 IEBAIGNsYXNzIENvbXBpbGVKU0NPbmx5VG9UKENvbXBpbGVKU0NPbmx5KToKICAgICBkZWYgaGlk ZVN0ZXBJZihzZWxmLCByZXN1bHRzLCBzdGVwKToKICAgICAgICAgcmV0dXJuIG5vdCBzZWxmLmRv U3RlcElmKHN0ZXApCiAKKyAgICBkZWYgZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNtZCk6CisgICAg ICAgIHJldHVybiBzaGVsbC5Db21waWxlLmV2YWx1YXRlQ29tbWFuZChzZWxmLCBjbWQpCisKIAog Y2xhc3MgUnVuSmF2YVNjcmlwdENvcmVUZXN0cyhzaGVsbC5UZXN0KToKICAgICBuYW1lID0gJ2pz Y29yZS10ZXN0Jwo=