20198 2008-07-28 11:01:57 -0700 [Qt] Copy key sequence doesn't work in non-editable areas. 2008-08-04 07:03:49 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 elbunce webkit-unassigned oldest_to_newest 87173 0 elbunce 2008-07-28 11:01:57 -0700 Can be demonstrated using QtLauncher from SVN r35408. 1) Navigate to any site. 2) Make a selection in a non-editable text area. Note that the Copy action is now enabled. 3) Use the local copy key sequence (CTRL+C, etc.) 4) Attempt to paste into your favorite text editor, note you'll get the previous clipboard contents since the copy will not have been performed. This is because it is only checked for in editorActionForKeyEvent(), the calling of which is inappropriate outside of editable areas. 87174 1 22524 elbunce 2008-07-28 11:04:23 -0700 Created attachment 22524 patch to add Copy handling for non-editable sections of a page. 87748 2 22524 hausmann 2008-08-04 02:38:14 -0700 Comment on attachment 22524 patch to add Copy handling for non-editable sections of a page. Ahh, I ran into this bug a few times and I always wondered what it was, since I did not see it in my daily use of QtWebKit in Arora. But I realize that's only because the browser there has its own Copy handling. Thanks for the patch! 87754 3 hausmann 2008-08-04 07:03:49 -0700 Landed in r35535 22524 2008-07-28 11:04:23 -0700 2008-08-04 02:38:14 -0700 patch to add Copy handling for non-editable sections of a page. copy.patch.txt text/plain 1062 elbunce SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gMzU0MDgpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDctMjggIEVyaWsgQnVuY2UgIDxlbGJ1bmNlQHRo ZWhpdmUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFsbG93IENvcHkga2V5IHNlcXVlbmNlIHRvIHdvcmsgaW4gbm9uLWVkaXRhYmxlIGFyZWFz LgorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlUHJpdmF0 ZTo6a2V5UHJlc3NFdmVudCk6CisKIDIwMDgtMDctMjcgIERhdmlkIEtpbHplciAgPGRka2lsemVy QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggUXQgYnVpbGQgZmFpbHVyZS4KSW5kZXg6IFdlYktp dC9xdC9BcGkvcXdlYnBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYnBh Z2UuY3BwCShyZXZpc2lvbiAzNTQwNikKKysrIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC01NTQsNiArNTU0LDExIEBAIHZvaWQgUVdlYlBhZ2VQcml2YXRlOjpr ZXlQcmVzc0V2ZW50KFFLZXkKICAgICAgICAgICAgIHEtPnRyaWdnZXJBY3Rpb24oYWN0aW9uKTsK ICAgICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOwogICAgICAgICB9CisgICAgfSBlbHNlIHsKKyAg ICAgICAgaWYgKGV2ID09IFFLZXlTZXF1ZW5jZTo6Q29weSkgeworICAgICAgICAgICAgcS0+dHJp Z2dlckFjdGlvbihRV2ViUGFnZTo6Q29weSk7CisgICAgICAgICAgICBoYW5kbGVkID0gdHJ1ZTsK KyAgICAgICAgfQogICAgIH0KICAgICBpZiAoIWhhbmRsZWQpCiAgICAgICAgIGhhbmRsZWQgPSBm cmFtZS0+ZXZlbnRIYW5kbGVyKCktPmtleUV2ZW50KGV2KTsK