201972 2019-09-18 21:17:00 -0700 [LFC][IFC] InlineFormattingContext::InlineLayout should not need to call LayoutState::establishedFormattingState 2019-09-19 07:58:50 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1572244 0 zalan 2019-09-18 21:17:00 -0700 when it has access to InlineFormattingContext object. 1572245 1 webkit-bug-importer 2019-09-18 21:18:17 -0700 <rdar://problem/55505869> 1572248 2 379102 zalan 2019-09-18 21:19:22 -0700 Created attachment 379102 Patch 1572357 3 zalan 2019-09-19 07:58:50 -0700 Committed r250089: <https://trac.webkit.org/changeset/250089> 379102 2019-09-18 21:19:22 -0700 2019-09-19 02:09:13 -0700 Patch bug-201972-20190918211918.patch text/plain 6556 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGY0MWZhMmZmZDRhZDRh ZDIwZjA5MzMzMTJkMGRiZTJiNzA2ODIxOS4uMjc0NmNkZjYyYmRmMmRiYmFiM2Q2ZDUxOTg1NWFh OWRlMjI2YjhhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA5LTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBJbmxpbmVG b3JtYXR0aW5nQ29udGV4dDo6SW5saW5lTGF5b3V0IHNob3VsZCBub3QgbmVlZCB0byBjYWxsIExh eW91dFN0YXRlOjplc3RhYmxpc2hlZEZvcm1hdHRpbmdTdGF0ZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxOTcyCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81NTUwNTg2OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJbmxpbmVMYXlvdXQgaGFzIGFjY2VzcyB0byBJbmxpbmVGb3JtYXR0aW5nQ29udGV4 dCwgc28gaXQgc2hvdWxkIGp1c3QgcXVlcnkgaXQgaW5zdGVhZCBvZiBjYWxsaW5nIExheW91dFN0 YXRlOjplc3RhYmxpc2hlZEZvcm1hdHRpbmdTdGF0ZS4KKworICAgICAgICAqIGxheW91dC9pbmxp bmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0Lmg6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdDb250ZXh0OjpJbmxpbmVMYXlvdXQ6OmZvcm1hdHRp bmdDb250ZXh0IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6SW5saW5lRm9ybWF0 dGluZ0NvbnRleHQ6OklubGluZUxheW91dDo6Zm9ybWF0dGluZ1N0YXRlKToKKyAgICAgICAgKiBs YXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dExpbmVMYXlvdXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6 SW5saW5lTGF5b3V0OjpJbmxpbmVMYXlvdXQpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJ bmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6SW5saW5lTGF5b3V0OjpsYXlvdXQpOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6SW5saW5lTGF5b3V0Ojpj cmVhdGVEaXNwbGF5UnVucyk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1h dHRpbmdDb250ZXh0OjpJbmxpbmVMYXlvdXQ6OmxheW91dCBjb25zdCk6IERlbGV0ZWQuCisgICAg ICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdDb250ZXh0OjpJbmxpbmVMYXlv dXQ6OmNyZWF0ZURpc3BsYXlSdW5zIGNvbnN0KTogRGVsZXRlZC4KKwogMjAxOS0wOS0xOCAgWmFs YW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdIEZsb2F0aW5nQ29u dGV4dCBzaG91bGQgdGFrZSB0aGUgcm9vdCBjb250YWluZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5o IGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGlu Z0NvbnRleHQuaAppbmRleCBjNTlmYTE2MmU5NzhjNTMxY2IyMTUzMmM0OGVkN2M5YWVlMWE1ZDZh Li44MDg3YjJiN2QxNmUxNDkyZGEzYzliNDMyMzRmMjBhYmJjN2Q3NDdiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29u dGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGlu ZUZvcm1hdHRpbmdDb250ZXh0LmgKQEAgLTUzLDIwICs1MywyMSBAQCBwcml2YXRlOgogCiAgICAg Y2xhc3MgSW5saW5lTGF5b3V0IHsKICAgICBwdWJsaWM6Ci0gICAgICAgIElubGluZUxheW91dChj b25zdCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dCYpOwotICAgICAgICB2b2lkIGxheW91dChjb25z dCBJbmxpbmVJdGVtcyYsIExheW91dFVuaXQgd2lkdGhDb25zdHJhaW50KSBjb25zdDsKKyAgICAg ICAgSW5saW5lTGF5b3V0KElubGluZUZvcm1hdHRpbmdDb250ZXh0Jik7CisgICAgICAgIHZvaWQg bGF5b3V0KGNvbnN0IElubGluZUl0ZW1zJiwgTGF5b3V0VW5pdCB3aWR0aENvbnN0cmFpbnQpOwog ICAgICAgICBMYXlvdXRVbml0IGNvbXB1dGVkSW50cmluc2ljV2lkdGgoY29uc3QgSW5saW5lSXRl bXMmLCBMYXlvdXRVbml0IHdpZHRoQ29uc3RyYWludCkgY29uc3Q7CiAKICAgICBwcml2YXRlOgog ICAgICAgICBMYXlvdXRTdGF0ZSYgbGF5b3V0U3RhdGUoKSBjb25zdCB7IHJldHVybiBtX2lubGlu ZUZvcm1hdHRpbmdDb250ZXh0LmxheW91dFN0YXRlKCk7IH0KLSAgICAgICAgY29uc3QgSW5saW5l Rm9ybWF0dGluZ0NvbnRleHQmIGZvcm1hdHRpbmdDb250ZXh0KCkgY29uc3QgeyByZXR1cm4gbV9p bmxpbmVGb3JtYXR0aW5nQ29udGV4dDsgfQorICAgICAgICBJbmxpbmVGb3JtYXR0aW5nQ29udGV4 dCYgZm9ybWF0dGluZ0NvbnRleHQoKSBjb25zdCB7IHJldHVybiBtX2lubGluZUZvcm1hdHRpbmdD b250ZXh0OyB9CiAgICAgICAgIGNvbnN0IENvbnRhaW5lciYgZm9ybWF0dGluZ1Jvb3QoKSBjb25z dCB7IHJldHVybiBtX2lubGluZUZvcm1hdHRpbmdDb250ZXh0LnJvb3QoKTsgfQorICAgICAgICBJ bmxpbmVGb3JtYXR0aW5nU3RhdGUmIGZvcm1hdHRpbmdTdGF0ZSgpIHsgcmV0dXJuIG1faW5saW5l Rm9ybWF0dGluZ0NvbnRleHQuZm9ybWF0dGluZ1N0YXRlKCk7IH0KICAgICAgICAgTGluZUNvbnRl bnQgcGxhY2VJbmxpbmVJdGVtcyhjb25zdCBMaW5lSW5wdXQmKSBjb25zdDsKLSAgICAgICAgdm9p ZCBjcmVhdGVEaXNwbGF5UnVucyhjb25zdCBMaW5lOjpDb250ZW50JiwgY29uc3QgVmVjdG9yPFdl YWtQdHI8SW5saW5lSXRlbT4+JiBmbG9hdHMsIExheW91dFVuaXQgd2lkdGhDb25zdHJhaW50KSBj b25zdDsKKyAgICAgICAgdm9pZCBjcmVhdGVEaXNwbGF5UnVucyhjb25zdCBMaW5lOjpDb250ZW50 JiwgY29uc3QgVmVjdG9yPFdlYWtQdHI8SW5saW5lSXRlbT4+JiBmbG9hdHMsIExheW91dFVuaXQg d2lkdGhDb25zdHJhaW50KTsKICAgICAgICAgdm9pZCBhbGlnblJ1bnMoVGV4dEFsaWduTW9kZSwg SW5saW5lUnVucyYsIHVuc2lnbmVkIGZpcnN0UnVuSW5kZXgsIExheW91dFVuaXQgYXZhaWxhYmxl V2lkdGgpIGNvbnN0OwogCiAgICAgcHJpdmF0ZToKLSAgICAgICAgY29uc3QgSW5saW5lRm9ybWF0 dGluZ0NvbnRleHQmIG1faW5saW5lRm9ybWF0dGluZ0NvbnRleHQ7CisgICAgICAgIElubGluZUZv cm1hdHRpbmdDb250ZXh0JiBtX2lubGluZUZvcm1hdHRpbmdDb250ZXh0OwogICAgIH07CiAKICAg ICBjbGFzcyBRdWlya3MgOiBwdWJsaWMgRm9ybWF0dGluZ0NvbnRleHQ6OlF1aXJrcyB7CkBAIC0x MTIsNiArMTEzLDcgQEAgcHJpdmF0ZToKICAgICBJbmxpbmVGb3JtYXR0aW5nU3RhdGUmIGZvcm1h dHRpbmdTdGF0ZSgpIHsgcmV0dXJuIGRvd25jYXN0PElubGluZUZvcm1hdHRpbmdTdGF0ZT4oRm9y bWF0dGluZ0NvbnRleHQ6OmZvcm1hdHRpbmdTdGF0ZSgpKTsgfQogICAgIC8vIEZJWE1FOiBDb21l IHVwIHdpdGggYSBzdHJ1Y3R1cmUgdGhhdCByZXF1aXJlcyBubyBmcmllbmRpbmcuCiAgICAgZnJp ZW5kIGNsYXNzIExpbmU7CisgICAgZnJpZW5kIGNsYXNzIElubGluZUxheW91dDsKIH07CiAKIGlu bGluZSBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6Okdlb21ldHJ5KGNvbnN0IElu bGluZUZvcm1hdHRpbmdDb250ZXh0JiBpbmxpbmVGb3JtYXR0aW5nQ29udGV4dCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRp bmdDb250ZXh0TGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9y bWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dExpbmVMYXlvdXQuY3BwCmluZGV4IDY1ODg4 NzBiNDU5YjRmYjRmYjdmM2VhMmRjNGNmODg5NjYwYWRjZTYuLjgzZWFiMmQ3YjBjNjdjYmFlMGMy ZDgxYTVlMzE5NGU1MTVkMTEwOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0TGluZUxheW91dC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGlu Z0NvbnRleHRMaW5lTGF5b3V0LmNwcApAQCAtMjY5LDE4ICsyNjksMTcgQEAgTGluZUlucHV0OjpM aW5lSW5wdXQoY29uc3QgTGluZTo6SW5pdGlhbENvbnN0cmFpbnRzJiBpbml0aWFsTGluZUNvbnN0 cmFpbnRzLCBMaW4KIHsKIH0KIAotSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OklubGluZUxheW91 dDo6SW5saW5lTGF5b3V0KGNvbnN0IElubGluZUZvcm1hdHRpbmdDb250ZXh0JiBpbmxpbmVGb3Jt YXR0aW5nQ29udGV4dCkKK0lubGluZUZvcm1hdHRpbmdDb250ZXh0OjpJbmxpbmVMYXlvdXQ6Oklu bGluZUxheW91dChJbmxpbmVGb3JtYXR0aW5nQ29udGV4dCYgaW5saW5lRm9ybWF0dGluZ0NvbnRl eHQpCiAgICAgOiBtX2lubGluZUZvcm1hdHRpbmdDb250ZXh0KGlubGluZUZvcm1hdHRpbmdDb250 ZXh0KQogewogfQogCi12b2lkIElubGluZUZvcm1hdHRpbmdDb250ZXh0OjpJbmxpbmVMYXlvdXQ6 OmxheW91dChjb25zdCBJbmxpbmVJdGVtcyYgaW5saW5lSXRlbXMsIExheW91dFVuaXQgd2lkdGhD b25zdHJhaW50KSBjb25zdAordm9pZCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6SW5saW5lTGF5 b3V0OjpsYXlvdXQoY29uc3QgSW5saW5lSXRlbXMmIGlubGluZUl0ZW1zLCBMYXlvdXRVbml0IHdp ZHRoQ29uc3RyYWludCkKIHsKLSAgICBhdXRvJiBsYXlvdXRTdGF0ZSA9IHRoaXMtPmxheW91dFN0 YXRlKCk7CiAgICAgYXV0byYgZm9ybWF0dGluZ0NvbnRleHQgPSB0aGlzLT5mb3JtYXR0aW5nQ29u dGV4dCgpOwogICAgIGF1dG8mIGZvcm1hdHRpbmdSb290ID0gdGhpcy0+Zm9ybWF0dGluZ1Jvb3Qo KTsKICAgICBhdXRvJiBmb3JtYXR0aW5nUm9vdEdlb21ldHJ5ID0gZm9ybWF0dGluZ0NvbnRleHQu Z2VvbWV0cnlGb3JCb3goZm9ybWF0dGluZ1Jvb3QpOwotICAgIGF1dG8gZmxvYXRpbmdDb250ZXh0 ID0gRmxvYXRpbmdDb250ZXh0IHsgZm9ybWF0dGluZ1Jvb3QsIGZvcm1hdHRpbmdDb250ZXh0LCBs YXlvdXRTdGF0ZS5lc3RhYmxpc2hlZEZvcm1hdHRpbmdTdGF0ZShmb3JtYXR0aW5nUm9vdCkuZmxv YXRpbmdTdGF0ZSgpIH07CisgICAgYXV0byBmbG9hdGluZ0NvbnRleHQgPSBGbG9hdGluZ0NvbnRl eHQgeyBmb3JtYXR0aW5nUm9vdCwgZm9ybWF0dGluZ0NvbnRleHQsIGZvcm1hdHRpbmdTdGF0ZSgp LmZsb2F0aW5nU3RhdGUoKSB9OwogCiAgICAgYXV0byBsaW5lTG9naWNhbFRvcCA9IGZvcm1hdHRp bmdSb290R2VvbWV0cnkuY29udGVudEJveFRvcCgpOwogICAgIGF1dG8gbGluZUxvZ2ljYWxMZWZ0 ID0gZm9ybWF0dGluZ1Jvb3RHZW9tZXRyeS5jb250ZW50Qm94TGVmdCgpOwpAQCAtMzU3LDExICsz NTYsMTAgQEAgTGF5b3V0VW5pdCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6SW5saW5lTGF5b3V0 Ojpjb21wdXRlZEludHJpbnNpY1dpZHRoKGNvbnN0IEkKICAgICByZXR1cm4gbWF4aW11bUxpbmVX aWR0aDsKIH0KIAotdm9pZCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6SW5saW5lTGF5b3V0Ojpj cmVhdGVEaXNwbGF5UnVucyhjb25zdCBMaW5lOjpDb250ZW50JiBsaW5lQ29udGVudCwgY29uc3Qg VmVjdG9yPFdlYWtQdHI8SW5saW5lSXRlbT4+JiBmbG9hdHMsIExheW91dFVuaXQgd2lkdGhDb25z dHJhaW50KSBjb25zdAordm9pZCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6SW5saW5lTGF5b3V0 OjpjcmVhdGVEaXNwbGF5UnVucyhjb25zdCBMaW5lOjpDb250ZW50JiBsaW5lQ29udGVudCwgY29u c3QgVmVjdG9yPFdlYWtQdHI8SW5saW5lSXRlbT4+JiBmbG9hdHMsIExheW91dFVuaXQgd2lkdGhD b25zdHJhaW50KQogewotICAgIGF1dG8mIGxheW91dFN0YXRlID0gdGhpcy0+bGF5b3V0U3RhdGUo KTsKICAgICBhdXRvJiBmb3JtYXR0aW5nQ29udGV4dCA9IHRoaXMtPmZvcm1hdHRpbmdDb250ZXh0 KCk7Ci0gICAgYXV0byYgZm9ybWF0dGluZ1N0YXRlID0gZG93bmNhc3Q8SW5saW5lRm9ybWF0dGlu Z1N0YXRlPihsYXlvdXRTdGF0ZS5lc3RhYmxpc2hlZEZvcm1hdHRpbmdTdGF0ZShmb3JtYXR0aW5n Um9vdCgpKSk7CisgICAgYXV0byYgZm9ybWF0dGluZ1N0YXRlID0gdGhpcy0+Zm9ybWF0dGluZ1N0 YXRlKCk7CiAgICAgYXV0byBmbG9hdGluZ0NvbnRleHQgPSBGbG9hdGluZ0NvbnRleHQgeyBmb3Jt YXR0aW5nUm9vdCgpLCBmb3JtYXR0aW5nQ29udGV4dCwgZm9ybWF0dGluZ1N0YXRlLmZsb2F0aW5n U3RhdGUoKSB9OwogCiAgICAgLy8gTW92ZSBmbG9hdHMgdG8gdGhlaXIgZmluYWwgcG9zaXRpb24u Cg==